)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7229b8e24fdff56cdec6d21c8de4217f94479112","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"304e6d67_9631641d","updated":"2023-01-31 15:57:54.000000000","message":"I think my comments are correct, haven\u0027t verified.","commit_id":"83b77543730cce4277335a88b7f55bd279998fee"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f605c6b967fccee1ef4ffccbe1018c054c4b6ce9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d52bbdd_83e514cd","updated":"2023-01-31 09:45:04.000000000","message":"It is a good idea, thanks","commit_id":"83b77543730cce4277335a88b7f55bd279998fee"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d2ccce0e037f4070cca674bef807ef83c783147b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"680ce0dc_121102d1","updated":"2023-01-31 11:17:15.000000000","message":"Please fix unit tests and then LGTM :)","commit_id":"83b77543730cce4277335a88b7f55bd279998fee"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1e04fab02758f1d776acf0980a058c15d2b6b409","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fbf4e802_91cc0a2c","updated":"2023-02-14 16:18:05.000000000","message":"Thanks it looks ok, please consider the comment from Rodolfo","commit_id":"77923ab1d0e345be6cdf1930d2f78334eb29f07d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cff5e6cf202c3f87b78c0540a0031b4e4d6ccb1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8aea1020_6c060948","updated":"2023-02-01 07:02:32.000000000","message":"recheck","commit_id":"77923ab1d0e345be6cdf1930d2f78334eb29f07d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"63cef9b0bd61fba902ef32206d7151e81dbc90d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"680e5720_27dd79af","updated":"2023-03-11 03:48:12.000000000","message":"recheck","commit_id":"02012b6813978d7b2be1b36fafdad91faa1034da"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ff247c6eb727b182e1edbec7293c7e42ead1c6d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a986439e_5c570b3c","updated":"2023-03-13 05:44:54.000000000","message":"recheck","commit_id":"02012b6813978d7b2be1b36fafdad91faa1034da"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1f9b93d5565d3c338ab074e145c33484f1e815e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7ceafde_41cb0529","updated":"2023-03-14 06:23:37.000000000","message":"recheck","commit_id":"882bdd7ba688aaf233643d2b24378a17e66755dd"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d0704fe6f249705ceda4f195c37782d65ce7c287","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"11a1f82b_b8959630","updated":"2023-05-12 06:35:26.000000000","message":"recheck","commit_id":"7573fca58c147eddddbfff6eebc3554fcdd23306"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"21036522c346fb5b6fd68f9a1ef3328f7c262e0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cd51c91e_cc9f1556","updated":"2023-05-15 01:01:35.000000000","message":"recheck","commit_id":"7573fca58c147eddddbfff6eebc3554fcdd23306"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0657b88e3e45c229c20cfc42dec806b4d124a0c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff433717_e66a5f27","updated":"2023-05-12 02:03:45.000000000","message":"recheck","commit_id":"7573fca58c147eddddbfff6eebc3554fcdd23306"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1836703d0511bbe2f34a4152bd1da0748bdd4526","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e37b0eb3_7d4a9c6b","updated":"2023-05-15 13:21:43.000000000","message":"recheck https://review.opendev.org/c/openstack/neutron/+/883081 merged","commit_id":"7573fca58c147eddddbfff6eebc3554fcdd23306"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7229b8e24fdff56cdec6d21c8de4217f94479112","unresolved":true,"context_lines":[{"line_number":2526,"context_line":"            LOG.info(\"Cleaning stale %s flows\", self.tun_br.br_name)"},{"line_number":2527,"context_line":"            self.tun_br.cleanup_flows()"},{"line_number":2528,"context_line":""},{"line_number":2529,"context_line":"    def process_port_info(self, start, polling_manager, sync, ovs_restarted,"},{"line_number":2530,"context_line":"                          ports, ancillary_ports, updated_ports_copy,"},{"line_number":2531,"context_line":"                          consecutive_resyncs, ports_not_ready_yet,"},{"line_number":2532,"context_line":"                          failed_devices, failed_ancillary_devices):"}],"source_content_type":"text/x-python","patch_set":1,"id":"13627cce_73db8205","line":2529,"range":{"start_line":2529,"start_character":62,"end_line":2529,"end_character":75},"updated":"2023-01-31 15:57:54.000000000","message":"This is no longer needed since it\u0027s declared in the object itself now.","commit_id":"83b77543730cce4277335a88b7f55bd279998fee"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"85efed445e4f504494f9e3e9a0bd1e69fec410a9","unresolved":true,"context_lines":[{"line_number":2526,"context_line":"            LOG.info(\"Cleaning stale %s flows\", self.tun_br.br_name)"},{"line_number":2527,"context_line":"            self.tun_br.cleanup_flows()"},{"line_number":2528,"context_line":""},{"line_number":2529,"context_line":"    def process_port_info(self, start, polling_manager, sync, ovs_restarted,"},{"line_number":2530,"context_line":"                          ports, ancillary_ports, updated_ports_copy,"},{"line_number":2531,"context_line":"                          consecutive_resyncs, ports_not_ready_yet,"},{"line_number":2532,"context_line":"                          failed_devices, failed_ancillary_devices):"}],"source_content_type":"text/x-python","patch_set":1,"id":"40424384_483cb666","line":2529,"range":{"start_line":2529,"start_character":62,"end_line":2529,"end_character":75},"in_reply_to":"13627cce_73db8205","updated":"2023-02-01 02:16:50.000000000","message":"Yes, I noticed this. But because this is in the middle of the params, IMO, remove this will cause many test case updating.","commit_id":"83b77543730cce4277335a88b7f55bd279998fee"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f53b9c8bbfc5ced624937a2e2832f4393a400811","unresolved":false,"context_lines":[{"line_number":2526,"context_line":"            LOG.info(\"Cleaning stale %s flows\", self.tun_br.br_name)"},{"line_number":2527,"context_line":"            self.tun_br.cleanup_flows()"},{"line_number":2528,"context_line":""},{"line_number":2529,"context_line":"    def process_port_info(self, start, polling_manager, sync, ovs_restarted,"},{"line_number":2530,"context_line":"                          ports, ancillary_ports, updated_ports_copy,"},{"line_number":2531,"context_line":"                          consecutive_resyncs, ports_not_ready_yet,"},{"line_number":2532,"context_line":"                          failed_devices, failed_ancillary_devices):"}],"source_content_type":"text/x-python","patch_set":1,"id":"40a86c30_eee46eb3","line":2529,"range":{"start_line":2529,"start_character":62,"end_line":2529,"end_character":75},"in_reply_to":"40424384_483cb666","updated":"2023-03-09 01:25:35.000000000","message":"Ack","commit_id":"83b77543730cce4277335a88b7f55bd279998fee"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7229b8e24fdff56cdec6d21c8de4217f94479112","unresolved":true,"context_lines":[{"line_number":2765,"context_line":"                    self.activated_bindings \u003d set()"},{"line_number":2766,"context_line":"                    (port_info, ancillary_port_info, consecutive_resyncs,"},{"line_number":2767,"context_line":"                     ports_not_ready_yet) \u003d (self.process_port_info("},{"line_number":2768,"context_line":"                         start, polling_manager, sync, self.ovs_restarted,"},{"line_number":2769,"context_line":"                         ports, ancillary_ports, updated_ports_copy,"},{"line_number":2770,"context_line":"                         consecutive_resyncs, ports_not_ready_yet,"},{"line_number":2771,"context_line":"                         failed_devices, failed_ancillary_devices))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9bf6c1bc_4d86f2e8","line":2768,"range":{"start_line":2768,"start_character":55,"end_line":2768,"end_character":73},"updated":"2023-01-31 15:57:54.000000000","message":"So this can go away too.","commit_id":"83b77543730cce4277335a88b7f55bd279998fee"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f53b9c8bbfc5ced624937a2e2832f4393a400811","unresolved":false,"context_lines":[{"line_number":2765,"context_line":"                    self.activated_bindings \u003d set()"},{"line_number":2766,"context_line":"                    (port_info, ancillary_port_info, consecutive_resyncs,"},{"line_number":2767,"context_line":"                     ports_not_ready_yet) \u003d (self.process_port_info("},{"line_number":2768,"context_line":"                         start, polling_manager, sync, self.ovs_restarted,"},{"line_number":2769,"context_line":"                         ports, ancillary_ports, updated_ports_copy,"},{"line_number":2770,"context_line":"                         consecutive_resyncs, ports_not_ready_yet,"},{"line_number":2771,"context_line":"                         failed_devices, failed_ancillary_devices))"}],"source_content_type":"text/x-python","patch_set":1,"id":"2ff5a4af_9e0f7f35","line":2768,"range":{"start_line":2768,"start_character":55,"end_line":2768,"end_character":73},"in_reply_to":"95293b1a_2e2206ab","updated":"2023-03-09 01:25:35.000000000","message":"Ack","commit_id":"83b77543730cce4277335a88b7f55bd279998fee"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"85efed445e4f504494f9e3e9a0bd1e69fec410a9","unresolved":true,"context_lines":[{"line_number":2765,"context_line":"                    self.activated_bindings \u003d set()"},{"line_number":2766,"context_line":"                    (port_info, ancillary_port_info, consecutive_resyncs,"},{"line_number":2767,"context_line":"                     ports_not_ready_yet) \u003d (self.process_port_info("},{"line_number":2768,"context_line":"                         start, polling_manager, sync, self.ovs_restarted,"},{"line_number":2769,"context_line":"                         ports, ancillary_ports, updated_ports_copy,"},{"line_number":2770,"context_line":"                         consecutive_resyncs, ports_not_ready_yet,"},{"line_number":2771,"context_line":"                         failed_devices, failed_ancillary_devices))"}],"source_content_type":"text/x-python","patch_set":1,"id":"95293b1a_2e2206ab","line":2768,"range":{"start_line":2768,"start_character":55,"end_line":2768,"end_character":73},"in_reply_to":"9bf6c1bc_4d86f2e8","updated":"2023-02-01 02:16:50.000000000","message":"Will try to.","commit_id":"83b77543730cce4277335a88b7f55bd279998fee"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"75bb867237bfb2897439f6f6ae71708b6f3a9aaa","unresolved":true,"context_lines":[{"line_number":2687,"context_line":"        activated_bindings_copy \u003d set()"},{"line_number":2688,"context_line":"        ancillary_ports \u003d set()"},{"line_number":2689,"context_line":"        tunnel_sync \u003d True"},{"line_number":2690,"context_line":"        self.ovs_restarted \u003d False"},{"line_number":2691,"context_line":"        consecutive_resyncs \u003d 0"},{"line_number":2692,"context_line":"        need_clean_stale_flow \u003d True"},{"line_number":2693,"context_line":"        ports_not_ready_yet \u003d set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc19db3f_34db2aae","line":2690,"range":{"start_line":2690,"start_character":0,"end_line":2690,"end_character":34},"updated":"2023-02-01 07:51:08.000000000","message":"Member variables should be initialized in the init method.","commit_id":"77923ab1d0e345be6cdf1930d2f78334eb29f07d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f8324bd32a17c9e61cc8903a0fe08db16c005a8a","unresolved":false,"context_lines":[{"line_number":2687,"context_line":"        activated_bindings_copy \u003d set()"},{"line_number":2688,"context_line":"        ancillary_ports \u003d set()"},{"line_number":2689,"context_line":"        tunnel_sync \u003d True"},{"line_number":2690,"context_line":"        self.ovs_restarted \u003d False"},{"line_number":2691,"context_line":"        consecutive_resyncs \u003d 0"},{"line_number":2692,"context_line":"        need_clean_stale_flow \u003d True"},{"line_number":2693,"context_line":"        ports_not_ready_yet \u003d set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"2febe9c2_551df45a","line":2690,"range":{"start_line":2690,"start_character":0,"end_line":2690,"end_character":34},"in_reply_to":"4e754cc4_d1de4875","updated":"2023-03-14 01:42:40.000000000","message":"Rollback to the version of patchset 2, please see the comment for the details:\nhttps://review.opendev.org/c/openstack/neutron/+/872265/4/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#2686","commit_id":"77923ab1d0e345be6cdf1930d2f78334eb29f07d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f53b9c8bbfc5ced624937a2e2832f4393a400811","unresolved":false,"context_lines":[{"line_number":2687,"context_line":"        activated_bindings_copy \u003d set()"},{"line_number":2688,"context_line":"        ancillary_ports \u003d set()"},{"line_number":2689,"context_line":"        tunnel_sync \u003d True"},{"line_number":2690,"context_line":"        self.ovs_restarted \u003d False"},{"line_number":2691,"context_line":"        consecutive_resyncs \u003d 0"},{"line_number":2692,"context_line":"        need_clean_stale_flow \u003d True"},{"line_number":2693,"context_line":"        ports_not_ready_yet \u003d set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"4e754cc4_d1de4875","line":2690,"range":{"start_line":2690,"start_character":0,"end_line":2690,"end_character":34},"in_reply_to":"95b5b5c4_c3b9092b","updated":"2023-03-09 01:25:35.000000000","message":"Done","commit_id":"77923ab1d0e345be6cdf1930d2f78334eb29f07d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1e04fab02758f1d776acf0980a058c15d2b6b409","unresolved":true,"context_lines":[{"line_number":2687,"context_line":"        activated_bindings_copy \u003d set()"},{"line_number":2688,"context_line":"        ancillary_ports \u003d set()"},{"line_number":2689,"context_line":"        tunnel_sync \u003d True"},{"line_number":2690,"context_line":"        self.ovs_restarted \u003d False"},{"line_number":2691,"context_line":"        consecutive_resyncs \u003d 0"},{"line_number":2692,"context_line":"        need_clean_stale_flow \u003d True"},{"line_number":2693,"context_line":"        ports_not_ready_yet \u003d set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"95b5b5c4_c3b9092b","line":2690,"range":{"start_line":2690,"start_character":0,"end_line":2690,"end_character":34},"in_reply_to":"dc19db3f_34db2aae","updated":"2023-02-14 16:18:05.000000000","message":"nit, but agree","commit_id":"77923ab1d0e345be6cdf1930d2f78334eb29f07d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6f0a6c58f743d3861627a5ce103dd327d1722dc0","unresolved":true,"context_lines":[{"line_number":2831,"context_line":"                        self.update_retries_map_and_remove_devs_not_to_retry("},{"line_number":2832,"context_line":"                            failed_devices, failed_ancillary_devices,"},{"line_number":2833,"context_line":"                            failed_devices_retries_map))"},{"line_number":2834,"context_line":"                    # Keep this flag in the last line of \"try\" block,"},{"line_number":2835,"context_line":"                    # so we can sure that no other Exception occurred."},{"line_number":2836,"context_line":"                    self._dispose_local_vlan_hints()"},{"line_number":2837,"context_line":"                except Exception:"},{"line_number":2838,"context_line":"                    LOG.exception(\"Error while processing VIF ports\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"63746f09_2ace775d","line":2835,"range":{"start_line":2834,"start_character":18,"end_line":2835,"end_character":70},"updated":"2023-03-14 06:37:13.000000000","message":"the comment can be dropped as no longer relevant with this change.","commit_id":"882bdd7ba688aaf233643d2b24378a17e66755dd"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b1d203a6a8fc9bddb6763ee19e9f264cc8d8288b","unresolved":true,"context_lines":[{"line_number":2831,"context_line":"                        self.update_retries_map_and_remove_devs_not_to_retry("},{"line_number":2832,"context_line":"                            failed_devices, failed_ancillary_devices,"},{"line_number":2833,"context_line":"                            failed_devices_retries_map))"},{"line_number":2834,"context_line":"                    # Keep this flag in the last line of \"try\" block,"},{"line_number":2835,"context_line":"                    # so we can sure that no other Exception occurred."},{"line_number":2836,"context_line":"                    self._dispose_local_vlan_hints()"},{"line_number":2837,"context_line":"                except Exception:"},{"line_number":2838,"context_line":"                    LOG.exception(\"Error while processing VIF ports\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"55fdfbaf_a9b5159e","line":2835,"range":{"start_line":2834,"start_character":18,"end_line":2835,"end_character":70},"in_reply_to":"63746f09_2ace775d","updated":"2023-03-14 10:02:29.000000000","message":"+1","commit_id":"882bdd7ba688aaf233643d2b24378a17e66755dd"}]}