)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"a92a2c8cd49cbb5a5254a816d11f0e6dfcade323","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"f488d33e_71c6eb52","updated":"2023-04-30 14:12:48.000000000","message":"recheck vexxhost nested virt hosts disabled","commit_id":"7e9eeaf78448d926f16c9cd0190d5f62491d2431"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"4993ca648b3265ec3f2ec1bf8bf9bb3c20dbf1eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"b81d9dcc_76c3a7eb","updated":"2023-06-22 15:35:43.000000000","message":"```\n2023-06-22 14:05:34.377094 | controller |\n\n2023-06-22 14:05:34.377115 | controller | neutron.tests.functional.plugins.ml2.drivers.ovn.mech_driver.ovsdb.test_maintenance.TestMaintenance.test_subnet_global_dhcp4_opts\n\n2023-06-22 14:05:34.377135 | controller | ---------------------------------------------------------------------------------------------------------------------------------\n\n2023-06-22 14:05:34.377154 | controller |\n\n2023-06-22 14:05:34.377172 | controller | Captured traceback:\n\n2023-06-22 14:05:34.377194 | controller | ~~~~~~~~~~~~~~~~~~~\n\n2023-06-22 14:05:34.377216 | controller |     Traceback (most recent call last):\n\n2023-06-22 14:05:34.377238 | controller |\n\n2023-06-22 14:05:34.377257 | controller |       File \"/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py\", line 178, in func\n\n2023-06-22 14:05:34.377277 | controller |     return f(self, *args, **kwargs)\n\n2023-06-22 14:05:34.377297 | controller |\n\n2023-06-22 14:05:34.377317 | controller |       File \"/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py\", line 376, in test_subnet_global_dhcp4_opts\n\n2023-06-22 14:05:34.377339 | controller |     neutron_net \u003d self._create_network(\u0027network1\u0027)\n\n2023-06-22 14:05:34.377362 | controller |\n\n2023-06-22 14:05:34.377384 | controller |       File \"/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py\", line 68, in _create_network\n\n2023-06-22 14:05:34.377428 | controller |     return self.deserialize(self.fmt, res)[\u0027network\u0027]\n\n2023-06-22 14:05:34.377451 | controller |\n\n2023-06-22 14:05:34.377470 | controller |     KeyError: \u0027network\u0027\n\n2023-06-22 14:05:34.377489 | controller |\n\n2023-06-22 14:05:34.377508 | controller |\n\n2023-06-22 14:05:34.377527 | controller |\n\n2023-06-22 14:05:34.377547 | controller | \u003d\u003d\u003d\u003d\u003d\u003d\n\n2023-06-22 14:05:34.377565 | controller | Totals\n\n2023-06-22 14:05:34.377583 | controller | \u003d\u003d\u003d\u003d\u003d\u003d\n\n2023-06-22 14:05:34.377603 | controller | Ran: 1577 tests in 2173.1808 sec.\n\n2023-06-22 14:05:34.377622 | controller |  - Passed: 1550\n\n2023-06-22 14:05:34.377641 | controller |  - Skipped: 26\n\n2023-06-22 14:05:34.377660 | controller |  - Expected Fail: 0\n\n2023-06-22 14:05:34.377681 | controller |  - Unexpected Success: 0\n\n2023-06-22 14:05:34.377703 | controller |  - Failed: 1\n\n2023-06-22 14:05:34.377725 | controller | Sum of execute time for each test: 14686.8818 sec.\n```","commit_id":"9bfb047b5d075a2c227fc24b597345b4e6f533e1"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"fcc5e4360f142efb6fa367a5a0fe45974691ded2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"a766b5b0_0db484f7","updated":"2023-06-22 15:35:58.000000000","message":"recheck no bug","commit_id":"9bfb047b5d075a2c227fc24b597345b4e6f533e1"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"79f9dc41b27735d9e0dcf449440461a89d4d1943","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"8479c7e1_ee9fca93","in_reply_to":"b81d9dcc_76c3a7eb","updated":"2023-06-22 15:37:30.000000000","message":"Yeah, I saw that, but that file is not touched by this review, and this does not happen before or after this review, so I think it\u0027s a fluke.","commit_id":"9bfb047b5d075a2c227fc24b597345b4e6f533e1"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"8978c3abf840c868ab792676a54eaeac8f7b7fac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"502f291e_d811cdf4","updated":"2023-06-23 10:10:02.000000000","message":"recheck no bug timed out","commit_id":"0ac357fa1cc54a8cfd5c58a6662462215b4a221c"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"050aa9018c57f1da0415616bb57b17c0a4dbbddc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"b20baff0_7d9e2bb8","updated":"2023-07-03 18:19:52.000000000","message":"Rebased to get out of merge conflict, would appreciate if previous code-review scores would be restored when convenient. Thanks!","commit_id":"faff25b2b70722f1d3e8e95bef1f3927168febf7"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"320e8ecfbea7395baba6ae9e0839e92651698f4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"552a695d_217a3b57","updated":"2023-08-09 06:36:21.000000000","message":"recheck timed out","commit_id":"df5379163bfed3081389347bd995c7f3a1f4cab7"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"cfd18ecf8237379d3c34ee86d50d54cc9ca23f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"36d02cf9_7a5c37e2","updated":"2023-08-29 13:33:06.000000000","message":"recheck","commit_id":"7c13f8977059d39656ca329ac227bb44dc5c04cd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f8d80437a49f4b49874b6170040706f27ca68db3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"9e1bd7f9_4382e163","updated":"2024-02-07 22:15:46.000000000","message":"Just putting back the +W as the rebase cleared it, but code has not changed. It is still blocked by the dependency in the chain.","commit_id":"ed30fe017489c2e0b22be851ff67a16937e7b3ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4b4609bec95e95d3a4ceec045fca2c7be3017d95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"4e5b9236_82b7a1c1","updated":"2024-02-16 20:18:53.000000000","message":"Just re-adding +W as looks like clean rebase.","commit_id":"c9949f88f1d82d49e7a307c667ec8e7def1c1264"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0b8452713f320b30b660f42c9dda6f4f19c1a715","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"e7467ac2_f4d8312e","updated":"2024-02-27 15:49:57.000000000","message":"I\u0027ve manually tested this method. A functional test is needed to properly test it.","commit_id":"898498ca3ba268122dd5de43f2a0dbf2eb3c4058"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"f679cc5c22a6554cf2d9e3b1cd9e5b31ed3ee8f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"6cf25948_cd224624","updated":"2024-02-27 12:28:36.000000000","message":"recheck failure in test unrelated to this change (`neutron.tests.functional.agent.l3.test_dvr_router.TestDvrRouter.test_dvr_router_fip_associations_exist_when_snat_removed`)","commit_id":"898498ca3ba268122dd5de43f2a0dbf2eb3c4058"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5b8f6a0145830d11357f4f61aebdde86f069570c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"60e52972_0283dbb2","updated":"2024-02-28 01:27:42.000000000","message":"recheck unknown gate failure","commit_id":"898498ca3ba268122dd5de43f2a0dbf2eb3c4058"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"90b85d8b94d54066078f9ef35892f61e6e69ec6c","unresolved":true,"context_lines":[{"line_number":802,"context_line":"        #         \u0027Logical_Router\u0027,"},{"line_number":803,"context_line":"        #         (\u0027ports\u0027, \u0027{\u003e}\u0027, lrp.uuid))"},{"line_number":804,"context_line":"        #"},{"line_number":805,"context_line":"        # However, ovsdbapp does not currently support the \u0027{\u003e}\u0027 operator."},{"line_number":806,"context_line":"        for lrouter in self._tables[\u0027Logical_Router\u0027].rows.values():"},{"line_number":807,"context_line":"            if lrp in lrouter.ports:"},{"line_number":808,"context_line":"                return lrouter"}],"source_content_type":"text/x-python","patch_set":2,"id":"190eb962_c60aebb5","line":805,"updated":"2023-02-17 17:43:13.000000000","message":"See my hack, waiting to see what Terry thinks of it.\n\nhttps://review.opendev.org/c/openstack/ovsdbapp/+/873748","commit_id":"8edce09a9663b87f43dc2b64e63f78724c7f15e0"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"2e1694d9745c4915ef0f376d6b22a6c7916cc5c5","unresolved":true,"context_lines":[{"line_number":802,"context_line":"        #         \u0027Logical_Router\u0027,"},{"line_number":803,"context_line":"        #         (\u0027ports\u0027, \u0027{\u003e}\u0027, lrp.uuid))"},{"line_number":804,"context_line":"        #"},{"line_number":805,"context_line":"        # However, ovsdbapp does not currently support the \u0027{\u003e}\u0027 operator."},{"line_number":806,"context_line":"        for lrouter in self._tables[\u0027Logical_Router\u0027].rows.values():"},{"line_number":807,"context_line":"            if lrp in lrouter.ports:"},{"line_number":808,"context_line":"                return lrouter"}],"source_content_type":"text/x-python","patch_set":2,"id":"297c5d48_4cdb1448","line":805,"in_reply_to":"190eb962_c60aebb5","updated":"2023-02-20 09:32:59.000000000","message":"Thanks alot! I\u0027ll try it as part of testing this series and comment with findings","commit_id":"8edce09a9663b87f43dc2b64e63f78724c7f15e0"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a83fd0b241487e43935c084f422a2b0477ca058e","unresolved":false,"context_lines":[{"line_number":802,"context_line":"        #         \u0027Logical_Router\u0027,"},{"line_number":803,"context_line":"        #         (\u0027ports\u0027, \u0027{\u003e}\u0027, lrp.uuid))"},{"line_number":804,"context_line":"        #"},{"line_number":805,"context_line":"        # However, ovsdbapp does not currently support the \u0027{\u003e}\u0027 operator."},{"line_number":806,"context_line":"        for lrouter in self._tables[\u0027Logical_Router\u0027].rows.values():"},{"line_number":807,"context_line":"            if lrp in lrouter.ports:"},{"line_number":808,"context_line":"                return lrouter"}],"source_content_type":"text/x-python","patch_set":2,"id":"4403a3b0_facc2f4c","line":805,"in_reply_to":"297c5d48_4cdb1448","updated":"2023-04-24 21:23:36.000000000","message":"That patch doesn\u0027t add set operations like {\u003e}, so I don\u0027t think it\u0027ll help with this. One thing that really bothers me about the python-ovs IDL library is that OVSDB \u0027set\u0027 types (which are real sets--unordered unique items) are represented in the IDL *as lists*. WHICH THEY SORT. EVERY TIME YOU access values via __getattr__(): https://github.com/openvswitch/ovs/blob/d70688a7291edb432fd66b9230a92842fcfd3607/python/ovs/db/data.py#L498-L504\n\nIt\u0027s something I\u0027d like to change in python-ovs, but it\u0027s definitely an api-breaking change. We could also go the opposite direction and start relying on the sorted behavior to use bisect for log(n) lookups with these kinds of operations.","commit_id":"8edce09a9663b87f43dc2b64e63f78724c7f15e0"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"30420d2dbb3b145fb5e2cbabdd6e66b28edd21cc","unresolved":false,"context_lines":[{"line_number":802,"context_line":"        #         \u0027Logical_Router\u0027,"},{"line_number":803,"context_line":"        #         (\u0027ports\u0027, \u0027{\u003e}\u0027, lrp.uuid))"},{"line_number":804,"context_line":"        #"},{"line_number":805,"context_line":"        # However, ovsdbapp does not currently support the \u0027{\u003e}\u0027 operator."},{"line_number":806,"context_line":"        for lrouter in self._tables[\u0027Logical_Router\u0027].rows.values():"},{"line_number":807,"context_line":"            if lrp in lrouter.ports:"},{"line_number":808,"context_line":"                return lrouter"}],"source_content_type":"text/x-python","patch_set":2,"id":"a62f1335_63dd8ba1","line":805,"in_reply_to":"4403a3b0_facc2f4c","updated":"2023-04-24 22:22:03.000000000","message":"I started a discussion in ovs-discuss about making these lookups cheaper in python-ovs: https://mail.openvswitch.org/pipermail/ovs-discuss/2023-April/052387.html","commit_id":"8edce09a9663b87f43dc2b64e63f78724c7f15e0"}]}