)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2967e890a1c1dade7d626bc6ba74c9d58a36981e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76a7b2b7_a72880ba","updated":"2023-02-16 22:29:49.000000000","message":"I will rebase this to master once I get some feedback on the approach. Then I can tweak the doc patch based on how things progress.","commit_id":"547701aebe9d3ede43d07956568d9eed40f63250"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bdb46b41053f12a9f8433775138653da766bebb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6ab822c2_cb46817f","updated":"2023-02-18 00:22:20.000000000","message":"Still needs a little work on the unit tests","commit_id":"7ae5228ff118bc8f5e526e9ea9b8e7f363fdebcd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"78ce332ce8d0a07cc35e8098ebcd92a7b3ca3830","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a203ed5f_32f58c66","updated":"2023-03-09 22:31:38.000000000","message":"I\u0027m not sure we need this at all with https://review.opendev.org/c/openstack/neutron/+/875809 as we shouldn\u0027t have a network with an MTU below the minimum","commit_id":"866902f714a320941dfdabdfb640541d6ab9076b"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"907607a6a6446cf87e14a4ce931a3ff7ead4a8c8","unresolved":true,"context_lines":[{"line_number":1504,"context_line":"                not subnet.enable_dhcp or"},{"line_number":1505,"context_line":"                subnet.gateway_ip is None or"},{"line_number":1506,"context_line":"                subnet.subnetpool_id \u003d\u003d constants.IPV6_PD_POOL_ID or"},{"line_number":1507,"context_line":"                (mtu and subnet.ip_version \u003d\u003d constants.IP_VERSION_6 and"},{"line_number":1508,"context_line":"                 mtu \u003c constants.IPV6_MIN_MTU))"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"            if skip_subnet:"},{"line_number":1511,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"ac515300_76b89a34","line":1508,"range":{"start_line":1507,"start_character":16,"end_line":1508,"end_character":47},"updated":"2023-02-17 16:08:50.000000000","message":"Agree with this check but for ipv4 too.\n\nIn this case, we should log a warning message in the logs.","commit_id":"547701aebe9d3ede43d07956568d9eed40f63250"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"10b8d516cb0b2aab11eea8fc9254052322eef721","unresolved":false,"context_lines":[{"line_number":1504,"context_line":"                not subnet.enable_dhcp or"},{"line_number":1505,"context_line":"                subnet.gateway_ip is None or"},{"line_number":1506,"context_line":"                subnet.subnetpool_id \u003d\u003d constants.IPV6_PD_POOL_ID or"},{"line_number":1507,"context_line":"                (mtu and subnet.ip_version \u003d\u003d constants.IP_VERSION_6 and"},{"line_number":1508,"context_line":"                 mtu \u003c constants.IPV6_MIN_MTU))"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"            if skip_subnet:"},{"line_number":1511,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"2880c951_9cff204a","line":1508,"range":{"start_line":1507,"start_character":16,"end_line":1508,"end_character":47},"in_reply_to":"ac515300_76b89a34","updated":"2023-02-24 02:21:05.000000000","message":"Done","commit_id":"547701aebe9d3ede43d07956568d9eed40f63250"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"997592e55ba42c8b9cb9daee5b02e83eaa8cc7b5","unresolved":true,"context_lines":[{"line_number":1880,"context_line":"                ip_cidrs \u003d list(set(ip_cidrs) - set(no_cidrs))"},{"line_number":1881,"context_line":""},{"line_number":1882,"context_line":"        self.driver.init_l3(interface_name, ip_cidrs,"},{"line_number":1883,"context_line":"                            namespace\u003dnetwork.namespace)"},{"line_number":1884,"context_line":""},{"line_number":1885,"context_line":"        self._set_default_route(network, interface_name, mtu\u003dmtu)"},{"line_number":1886,"context_line":"        self.cleanup_stale_devices(network, port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ce91a5bc_65fae60f","line":1883,"updated":"2023-02-23 17:52:34.000000000","message":"The l3-agent also calls init_l3() and has a similar failure, so I\u0027ll have to move some of this code there and/or duplicate some things in the interface code :(","commit_id":"9a2b8b913747eccfcebb9adb556018936186673a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"10b8d516cb0b2aab11eea8fc9254052322eef721","unresolved":false,"context_lines":[{"line_number":1880,"context_line":"                ip_cidrs \u003d list(set(ip_cidrs) - set(no_cidrs))"},{"line_number":1881,"context_line":""},{"line_number":1882,"context_line":"        self.driver.init_l3(interface_name, ip_cidrs,"},{"line_number":1883,"context_line":"                            namespace\u003dnetwork.namespace)"},{"line_number":1884,"context_line":""},{"line_number":1885,"context_line":"        self._set_default_route(network, interface_name, mtu\u003dmtu)"},{"line_number":1886,"context_line":"        self.cleanup_stale_devices(network, port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bbbddd70_8c3a4307","line":1883,"in_reply_to":"ce91a5bc_65fae60f","updated":"2023-02-24 02:21:05.000000000","message":"Done","commit_id":"9a2b8b913747eccfcebb9adb556018936186673a"}]}
