)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cc25af5843e28edd85fe931e38451aac47a9155c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-04-04 18:20:37 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add extra router attributes for ECMP and BFD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial-Bug: #2002687"},{"line_number":10,"context_line":"Change-Id: I3fcd0458d20f20ce40378f90f073f37c41400865"},{"line_number":11,"context_line":"Depends-On: I2618475636b2bb9bfd743a62f5d4859d4f68a547"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"232ca0d3_424a7bee","line":8,"updated":"2023-04-05 16:01:33.000000000","message":"You can mentioned the added options","commit_id":"bf0439aeb3ace96b5832c4ba0942f3b7c9aa9a10"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"64b551f30bbd6a97e9842e25997ddb65ddcf733c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-04-04 18:20:37 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add extra router attributes for ECMP and BFD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial-Bug: #2002687"},{"line_number":10,"context_line":"Change-Id: I3fcd0458d20f20ce40378f90f073f37c41400865"},{"line_number":11,"context_line":"Depends-On: I2618475636b2bb9bfd743a62f5d4859d4f68a547"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"2f983e37_f0ef907e","line":8,"in_reply_to":"232ca0d3_424a7bee","updated":"2023-04-27 22:12:52.000000000","message":"Ack","commit_id":"bf0439aeb3ace96b5832c4ba0942f3b7c9aa9a10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dd31954441b25b06bb00591e20e38b3f118c73","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #2002687"},{"line_number":13,"context_line":"Change-Id: I3fcd0458d20f20ce40378f90f073f37c41400865"},{"line_number":14,"context_line":"Depends-On: I2618475636b2bb9bfd743a62f5d4859d4f68a547"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"2f3a52dc_82ea1ef0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":53},"updated":"2023-07-04 12:28:02.000000000","message":"To enforce a dependency on the same project, you should push the patch on top of the dependant one. \"Depends-On\" should not be used within the same project.","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"821927a8b6308d9e90e3d4c34c0fcb3d015a15bd","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #2002687"},{"line_number":13,"context_line":"Change-Id: I3fcd0458d20f20ce40378f90f073f37c41400865"},{"line_number":14,"context_line":"Depends-On: I2618475636b2bb9bfd743a62f5d4859d4f68a547"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"3750a4e6_2674d2bf","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":53},"in_reply_to":"2f3a52dc_82ea1ef0","updated":"2023-07-05 21:41:55.000000000","message":"Since this dependency is neutron-lib and it already merged and tag is released can just remove this line now.","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"526f5678dcff1a900545b40f26e1819ebe0cc156","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #2002687"},{"line_number":13,"context_line":"Change-Id: I3fcd0458d20f20ce40378f90f073f37c41400865"},{"line_number":14,"context_line":"Depends-On: I2618475636b2bb9bfd743a62f5d4859d4f68a547"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"090bbff3_a067d834","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":53},"in_reply_to":"3750a4e6_2674d2bf","updated":"2023-07-06 06:49:30.000000000","message":"Yes, this is not pointing at the same project, and was from the days when the neutron-lib change was not yet merged. It was added in an attempt to get real CI feedback.\n\nWe can drop it now.","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cc25af5843e28edd85fe931e38451aac47a9155c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"1531d964_ef50e621","updated":"2023-04-05 16:01:33.000000000","message":"Looks good, any chance that you can articulate your change with some tests, perhaps test_l3.py, creating a router with new attributes introduced, validating default value and set.\n\nThis also avoid potential regression in future. ","commit_id":"bf0439aeb3ace96b5832c4ba0942f3b7c9aa9a10"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"64b551f30bbd6a97e9842e25997ddb65ddcf733c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"a1f03e67_6e361e63","updated":"2023-04-27 22:12:52.000000000","message":"recheck","commit_id":"d84f023a4577061cbc24a72209080ffc16d5a7ee"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"405910d4cb0a362139e571b81678ffe3ff921481","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"cae96a16_37de575b","updated":"2023-04-28 13:45:58.000000000","message":"recheck vexxhost nested virt hosts disabled","commit_id":"d84f023a4577061cbc24a72209080ffc16d5a7ee"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"180e37ef5bbcbcb8dc896ff6dbfa3c3444238447","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"f11475aa_b0dfbd53","updated":"2023-05-02 15:23:22.000000000","message":"recheck","commit_id":"912f8176f869d66dea5a8c0358bc8343726e280a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bd67dcaca64520c764c651fe9f972cdf0be0a44a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"6cec4c93_61de10ba","updated":"2023-05-03 09:22:23.000000000","message":"Dimitrii I don\u0027t think you really articulate your change with tests, Any chance you add some in test_l3.py?","commit_id":"e55a416bb215d5c282676d90023be554fcaea2a9"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"ad2b32280697572d2e6619e0b40de08b82a8c76d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"781c7812_d636edd1","in_reply_to":"6cec4c93_61de10ba","updated":"2023-05-05 23:53:50.000000000","message":"Ack, I\u0027ll look into it in the next iteration.\n\nThe one after this comment is just a rebase to resolve the merge conflict.","commit_id":"e55a416bb215d5c282676d90023be554fcaea2a9"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"0bf79cbd518f6a1ceacce1237f6e43d7691b29fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"38f4e8a6_afefd395","in_reply_to":"781c7812_d636edd1","updated":"2023-05-08 13:22:49.000000000","message":"I added some basic testing of setting/updating the new attributes.\n\nThere is more (functional) testing in further changes here:\n\nhttps://review.opendev.org/c/openstack/neutron/+/878531/16/neutron/tests/functional/services/ovn_l3/test_plugin.py\nhttps://review.opendev.org/c/openstack/neutron/+/878543/19/neutron/tests/functional/services/ovn_l3/test_plugin.py","commit_id":"e55a416bb215d5c282676d90023be554fcaea2a9"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"356c80bceddc54839dfed42de7bae0bb77ae896f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"8831a682_922a8f60","updated":"2023-05-19 17:52:36.000000000","message":"recheck","commit_id":"0eeee3fc628c67c0e4595f71f034c6aa9e93eb97"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"2edf8e5c4659cfe89d942ca53a2f424631c76cf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"8a2c680a_680b4af0","updated":"2023-05-19 14:14:00.000000000","message":"recheck","commit_id":"0eeee3fc628c67c0e4595f71f034c6aa9e93eb97"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"06496d3396c31f575a734be66b1864dda01cbeda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"9f64e6b6_296270d3","updated":"2023-06-14 15:58:06.000000000","message":"++","commit_id":"55e7e7ab6978b0736add549e4cb4b482d9d58451"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"2624bd565f333cf9a600e36aaf18aa298727041d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"48f91f67_f0d4c0e0","updated":"2023-06-12 12:45:32.000000000","message":"Looks like an infra issue:\n\nW: Download is performed unsandboxed as root as file \u0027/var/lib/apt/lists/partial/archive.ubuntu.com_ubuntu_dists_focal_InRelease\u0027 couldn\u0027t be accessed by user \u0027_apt\u0027. - pkgAcquire::Run (13: Permission denied)\nE: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/focal-updates/main/binary-amd64/Packages.xz  File has unexpected size (2626656 !\u003d 2613496). Mirror sync in progress? [IP: 2001:67c:1562::15 80]","commit_id":"55e7e7ab6978b0736add549e4cb4b482d9d58451"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"23f60ce13513ab9ad65547c708760edd0c9aabff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"cbd04734_24708e51","updated":"2023-06-12 12:45:39.000000000","message":"recheck","commit_id":"55e7e7ab6978b0736add549e4cb4b482d9d58451"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c24952efa00a56db0ffad8de3734761c40c238ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"05b60b16_18993016","updated":"2023-06-23 07:46:38.000000000","message":"Thanks for the fixes","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"8f426e64b5b70c96c1a333e546e266f8cf976d19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"a534c75d_63dc597e","updated":"2023-06-23 10:08:52.000000000","message":"recheck no bug timed out","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"8c2f17b3096eeb194b83e7674c09fa8ebe423b61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"383d47b4_9d87ea76","updated":"2023-06-27 06:02:08.000000000","message":"recheck timed out","commit_id":"64513526801227935ded4d148d93846d402e065a"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"d2f83e6cd111d1b93f3c5fa64f5e54852ad1a99d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"aa6c9c10_f46a3881","updated":"2023-06-27 08:37:59.000000000","message":"recheck timed out","commit_id":"64513526801227935ded4d148d93846d402e065a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"83aaa0878145c8c788f1225c7a830f0f2be93c77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"87feedad_39225124","updated":"2023-06-26 19:33:32.000000000","message":"recheck unrelated timeout failure","commit_id":"64513526801227935ded4d148d93846d402e065a"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ba805e9938c230d40d1b2710460b97b280cd6b03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"bed75171_b2e0501a","updated":"2023-07-03 17:04:58.000000000","message":"Rebased to get out of merge conflict, would appreciate if previous code-review scores would be restored when convenient. Thanks!","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"526f5678dcff1a900545b40f26e1819ebe0cc156","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"d5f46d8a_b26a2694","updated":"2023-07-06 06:49:30.000000000","message":"Thank you for taking the time to review, much apprechiated!\n\nI\u0027ll make an update shortly just to get the series out of merge conflict again, and we will address other comments in subsequent update shortly after that.","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dd31954441b25b06bb00591e20e38b3f118c73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"794d8412_babe0cf1","updated":"2023-07-04 12:28:02.000000000","message":"The patch is close to be ready","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"386acd141b6c10bdfb5d881c7a3804bfd87416e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"56e48929_5b077aef","updated":"2023-07-06 15:58:54.000000000","message":"recheck","commit_id":"d4d7f7d087ccc878743c94673143e6984322e33b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b2dc5fbbc420a29c638eb370e51529b8c89d50ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"7b7b057f_576501a1","updated":"2023-07-25 14:07:58.000000000","message":"Let\u0027s move this series forward","commit_id":"572d4308bde25eff5dbaf74e830b72368e9aae2a"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"80761140bf74916025779455a7fc8e37e5c86553","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"bcb5c179_10247103","updated":"2023-07-25 15:15:53.000000000","message":"Thanks a lot for the reviews and intent to merge, much appreciated!\n\nUnfortunately the patch set has gone into merge conflict due to another update to alembic migration, which will invalidate any verdicts.\n\nI\u0027ll rebase the series momentarily, hope to see review verdicts restored on the new patch set. Cheers!","commit_id":"572d4308bde25eff5dbaf74e830b72368e9aae2a"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"9de335538bbf32a6eeb8b5f4f9ffaba4e496b980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"5641fbea_a534e928","updated":"2023-08-04 16:09:20.000000000","message":"Gate failure looks like failure unrelated to the change, perhaps intermittent?:\n```\n2023-08-04 15:22:04.424674 | controller | setUpClass (tempest.api.compute.servers.test_server_actions.ServerActionsV293TestJSON)\n2023-08-04 15:22:04.424748 | controller | --------------------------------------------------------------------------------------\n2023-08-04 15:22:04.424774 | controller |\n2023-08-04 15:22:04.424793 | controller | Captured traceback:\n2023-08-04 15:22:04.424813 | controller | ~~~~~~~~~~~~~~~~~~~\n2023-08-04 15:22:04.424833 | controller |     Traceback (most recent call last):\n2023-08-04 15:22:04.424852 | controller |\n2023-08-04 15:22:04.424870 | controller |       File \"/opt/stack/tempest/tempest/test.py\", line 206, in setUpClass\n2023-08-04 15:22:04.424891 | controller |     raise value.with_traceback(trace)\n2023-08-04 15:22:04.424910 | controller |\n2023-08-04 15:22:04.424934 | controller |       File \"/opt/stack/tempest/tempest/test.py\", line 199, in setUpClass\n2023-08-04 15:22:04.424953 | controller |     cls.resource_setup()\n2023-08-04 15:22:04.424972 | controller |\n2023-08-04 15:22:04.424992 | controller |       File \"/opt/stack/tempest/tempest/api/compute/servers/test_server_actions.py\", line 841, in resource_setup\n2023-08-04 15:22:04.425012 | controller |     cls.server_id \u003d cls.recreate_server(None, volume_backed\u003dTrue,\n2023-08-04 15:22:04.425032 | controller |\n2023-08-04 15:22:04.425052 | controller |       File \"/opt/stack/tempest/tempest/api/compute/base.py\", line 442, in recreate_server\n2023-08-04 15:22:04.425071 | controller |     server \u003d cls.create_test_server(\n2023-08-04 15:22:04.425089 | controller |\n2023-08-04 15:22:04.425109 | controller |       File \"/opt/stack/tempest/tempest/api/compute/base.py\", line 272, in create_test_server\n2023-08-04 15:22:04.425128 | controller |     body, servers \u003d compute.create_test_server(\n2023-08-04 15:22:04.425146 | controller |\n2023-08-04 15:22:04.425165 | controller |       File \"/opt/stack/tempest/tempest/common/compute.py\", line 256, in create_test_server\n2023-08-04 15:22:04.425185 | controller |     volume \u003d volumes_client.create_volume(**params)\n2023-08-04 15:22:04.425203 | controller |\n2023-08-04 15:22:04.425222 | controller |       File \"/opt/stack/tempest/tempest/lib/services/volume/v3/volumes_client.py\", line 116, in create_volume\n2023-08-04 15:22:04.425241 | controller |     resp, body \u003d self.post(\u0027volumes\u0027, post_body)\n2023-08-04 15:22:04.425262 | controller |\n2023-08-04 15:22:04.425275 | controller |       File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 300, in post\n2023-08-04 15:22:04.425287 | controller |     return self.request(\u0027POST\u0027, url, extra_headers, headers, body, chunked)\n2023-08-04 15:22:04.425298 | controller |\n2023-08-04 15:22:04.425309 | controller |       File \"/opt/stack/tempest/tempest/lib/services/volume/base_client.py\", line 39, in request\n2023-08-04 15:22:04.425321 | controller |     resp, resp_body \u003d super(BaseClient, self).request(\n2023-08-04 15:22:04.425332 | controller |\n2023-08-04 15:22:04.425343 | controller |       File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 726, in request\n2023-08-04 15:22:04.425355 | controller |     resp, resp_body \u003d self._request(method, url, headers\u003dheaders,\n2023-08-04 15:22:04.425366 | controller |\n2023-08-04 15:22:04.425377 | controller |       File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 589, in _request\n2023-08-04 15:22:04.425388 | controller |     req_url, req_headers, req_body \u003d self.auth_provider.auth_request(\n2023-08-04 15:22:04.425400 | controller |\n2023-08-04 15:22:04.425411 | controller |       File \"/opt/stack/tempest/tempest/lib/auth.py\", line 185, in auth_request\n2023-08-04 15:22:04.425423 | controller |     auth_url, auth_headers, auth_body \u003d self._decorate_request(\n2023-08-04 15:22:04.425434 | controller |\n2023-08-04 15:22:04.425445 | controller |       File \"/opt/stack/tempest/tempest/lib/auth.py\", line 277, in _decorate_request\n2023-08-04 15:22:04.425908 | controller |     base_url \u003d self.base_url(filters\u003dfilters, auth_data\u003dauth_data)\n2023-08-04 15:22:04.425930 | controller |\n2023-08-04 15:22:04.425942 | controller |       File \"/opt/stack/tempest/tempest/lib/auth.py\", line 574, in base_url\n2023-08-04 15:22:04.425953 | controller |     raise exceptions.EndpointNotFound(msg % (\n2023-08-04 15:22:04.425965 | controller |\n2023-08-04 15:22:04.425976 | controller |     tempest.lib.exceptions.EndpointNotFound: Endpoint not found\n2023-08-04 15:22:04.425990 | controller | Details: No matching service found in the catalog.\n```","commit_id":"89702218db2476a17f6ff36cf51b909db563d887"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"3ba30449973cac3ab17a1a65560181ebe7e45c43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"bf7953cd_f2940d8b","updated":"2023-08-04 21:12:23.000000000","message":"Same failure again, looks like there is a gate blocking failure in the `tempest.api.compute.servers.test_server_actions.ServerActionsV293TestJSON` test atm","commit_id":"89702218db2476a17f6ff36cf51b909db563d887"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"e8b99cecb976cb5efaf3cac3749550f986cb0d5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"8fa7b257_6c1343e6","updated":"2023-08-04 16:09:28.000000000","message":"recheck no bug","commit_id":"89702218db2476a17f6ff36cf51b909db563d887"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c28c9e9e3207ad8dc02c8c5277c730171d7953e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"be26f71c_f24145d2","updated":"2023-08-08 16:31:47.000000000","message":"recheck ovn rally timeout","commit_id":"89702218db2476a17f6ff36cf51b909db563d887"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ed541d1fcf1bf2e6e0c3a10a18cff2e5d196491f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"bd668ff5_c4a61c1d","updated":"2023-08-07 01:40:21.000000000","message":"recheck tempest fix possibly merged","commit_id":"89702218db2476a17f6ff36cf51b909db563d887"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"40bd8be68cc736ab9183bdc523aefa9598483fe5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"2842861d_fa3f2563","updated":"2023-08-08 13:34:02.000000000","message":"recheck timed out","commit_id":"89702218db2476a17f6ff36cf51b909db563d887"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"aa9eccdbce9a5baffc3c34a5679c54fef9f24375","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"ecf29666_d2c554d1","updated":"2023-08-07 16:02:30.000000000","message":"recheck unrelated fullstack failure","commit_id":"89702218db2476a17f6ff36cf51b909db563d887"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"2fd47f404d8dac2c5dbc596283f67f6d772a2d5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"31d08238_854709eb","updated":"2023-08-08 10:49:35.000000000","message":"recheck unrelated intermittent neutron-ovn-tempest-ipv6-only-ovs-release failure","commit_id":"89702218db2476a17f6ff36cf51b909db563d887"}],"neutron/conf/db/l3_extra_gws_db.py":[{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"763a03ebe44400b95a8b8d29e300d55a85e83f12","unresolved":true,"context_lines":[{"line_number":29,"context_line":"                help\u003d_(\"Define the default value for\""},{"line_number":30,"context_line":"                       \" enable_default_route_bfd if not specified on the\""},{"line_number":31,"context_line":"                       \" router.\")),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def register_db_l3_extragws_opts(conf\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":35,"id":"f9846ba5_869f39fd","line":32,"updated":"2023-06-26 10:43:47.000000000","message":"\u003e And the file mode should be 100664 - I see a lot of others are wrong will fix them in another patch.\n\nI unfortunately do not know how to do that. AFAICT Git only gives you control over whether the file should have the executable bit set or not.","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d49ae484384a1e947e079df3747915e267fce0ab","unresolved":true,"context_lines":[{"line_number":29,"context_line":"                help\u003d_(\"Define the default value for\""},{"line_number":30,"context_line":"                       \" enable_default_route_bfd if not specified on the\""},{"line_number":31,"context_line":"                       \" router.\")),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def register_db_l3_extragws_opts(conf\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":35,"id":"b86d3814_bd65b584","line":32,"updated":"2023-06-23 16:30:44.000000000","message":"Could you please also add a release note for these new config options? Sorry I didn\u0027t notice that last review.\n\nAnd the file mode should be 100664 - I see a lot of others are wrong will fix them in another patch.","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"83aaa0878145c8c788f1225c7a830f0f2be93c77","unresolved":true,"context_lines":[{"line_number":29,"context_line":"                help\u003d_(\"Define the default value for\""},{"line_number":30,"context_line":"                       \" enable_default_route_bfd if not specified on the\""},{"line_number":31,"context_line":"                       \" router.\")),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def register_db_l3_extragws_opts(conf\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":35,"id":"763600f9_a43f3e33","line":32,"in_reply_to":"752b004d_4d9a8de0","updated":"2023-06-26 19:33:32.000000000","message":"No, just because it doesn\u0027t seem trivial to do so. There are too many files and directories with the wrong permission, as least in my clone.","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"8c2f17b3096eeb194b83e7674c09fa8ebe423b61","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                help\u003d_(\"Define the default value for\""},{"line_number":30,"context_line":"                       \" enable_default_route_bfd if not specified on the\""},{"line_number":31,"context_line":"                       \" router.\")),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def register_db_l3_extragws_opts(conf\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":35,"id":"5c2cd2b6_ba43b479","line":32,"in_reply_to":"763600f9_a43f3e33","updated":"2023-06-27 06:02:08.000000000","message":"Thank you for clarifying. I understand the desire to update the mode, and was also surprised by no control over it in Git.","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"763a03ebe44400b95a8b8d29e300d55a85e83f12","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                help\u003d_(\"Define the default value for\""},{"line_number":30,"context_line":"                       \" enable_default_route_bfd if not specified on the\""},{"line_number":31,"context_line":"                       \" router.\")),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def register_db_l3_extragws_opts(conf\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":35,"id":"447af8f9_500a42a2","line":32,"in_reply_to":"b86d3814_bd65b584","updated":"2023-06-26 10:43:47.000000000","message":"\u003e Could you please also add a release note for these new config options? Sorry I didn\u0027t notice that last review.\n\nAdded.","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"8e7b6f0cc61371bca5ed82846936362dd98882ae","unresolved":true,"context_lines":[{"line_number":29,"context_line":"                help\u003d_(\"Define the default value for\""},{"line_number":30,"context_line":"                       \" enable_default_route_bfd if not specified on the\""},{"line_number":31,"context_line":"                       \" router.\")),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def register_db_l3_extragws_opts(conf\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":35,"id":"752b004d_4d9a8de0","line":32,"in_reply_to":"f879cb96_7cdf47e4","updated":"2023-06-26 18:23:41.000000000","message":"Does that mean you are planning on re-adding all the files in the repository to meet this requirement, and do you still require us to re-add the file with the requested permission on this review?","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3c646f271834182e5977c20a76dff878cc389d99","unresolved":true,"context_lines":[{"line_number":29,"context_line":"                help\u003d_(\"Define the default value for\""},{"line_number":30,"context_line":"                       \" enable_default_route_bfd if not specified on the\""},{"line_number":31,"context_line":"                       \" router.\")),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def register_db_l3_extragws_opts(conf\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":35,"id":"f879cb96_7cdf47e4","line":32,"in_reply_to":"f9846ba5_869f39fd","updated":"2023-06-26 14:47:04.000000000","message":"Right, I think you would have had to \u0027git add\u0027 it originally with the correct mode, even with filemode\u003dtrue in .git/config it won\u0027t let you change it. I even tried with other files. Almost seems like a bug in git (even given the long-winded explanation I found about it :)","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dd31954441b25b06bb00591e20e38b3f118c73","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027enable_default_route_ecmp\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d_(\"Define the default value for\""},{"line_number":25,"context_line":"                       \" enable_default_route_ecmp if not specified on the\""},{"line_number":26,"context_line":"                       \" router.\")),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027enable_default_route_bfd\u0027,"},{"line_number":28,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":37,"id":"7a7ea356_356c6a79","line":25,"range":{"start_line":25,"start_character":24,"end_line":25,"end_character":25},"updated":"2023-07-04 12:28:02.000000000","message":"nit: we add the spaces at the end of the lines, not at the beginning.","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ea5dd0f1b181c33ba5818e378df674002b0d3055","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027enable_default_route_ecmp\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d_(\"Define the default value for\""},{"line_number":25,"context_line":"                       \" enable_default_route_ecmp if not specified on the\""},{"line_number":26,"context_line":"                       \" router.\")),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027enable_default_route_bfd\u0027,"},{"line_number":28,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":37,"id":"8c058e41_7b6a6b16","line":25,"range":{"start_line":25,"start_character":24,"end_line":25,"end_character":25},"in_reply_to":"7a7ea356_356c6a79","updated":"2023-07-07 09:53:09.000000000","message":"Done","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"}],"neutron/conf/policies/router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d81e80599a00cc50ed2f902fceaa36525b35aa0e","unresolved":true,"context_lines":[{"line_number":273,"context_line":"        check_str\u003dbase.ADMIN,"},{"line_number":274,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":275,"context_line":"        description\u003d(\u0027Specify ``enable_default_route_bfd`` attribute when\u0027"},{"line_number":276,"context_line":"                     \u0027 creating a router\u0027),"},{"line_number":277,"context_line":"        operations\u003dACTION_POST,"},{"line_number":278,"context_line":"    ),"},{"line_number":279,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":34,"id":"8a40d9fc_39940aa8","line":276,"range":{"start_line":276,"start_character":23,"end_line":276,"end_character":31},"updated":"2023-06-22 17:41:54.000000000","message":"s/updating","commit_id":"98ec9dae8d77b5d8b70f5d614acc46ded51391e4"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"56d1f54f560cf51a8f364cacb41af8de5914ec06","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        check_str\u003dbase.ADMIN,"},{"line_number":274,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":275,"context_line":"        description\u003d(\u0027Specify ``enable_default_route_bfd`` attribute when\u0027"},{"line_number":276,"context_line":"                     \u0027 creating a router\u0027),"},{"line_number":277,"context_line":"        operations\u003dACTION_POST,"},{"line_number":278,"context_line":"    ),"},{"line_number":279,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":34,"id":"3a5c355e_ca8c6eb3","line":276,"range":{"start_line":276,"start_character":23,"end_line":276,"end_character":31},"in_reply_to":"8a40d9fc_39940aa8","updated":"2023-06-23 06:44:08.000000000","message":"Ack","commit_id":"98ec9dae8d77b5d8b70f5d614acc46ded51391e4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d81e80599a00cc50ed2f902fceaa36525b35aa0e","unresolved":true,"context_lines":[{"line_number":281,"context_line":"        check_str\u003dbase.ADMIN,"},{"line_number":282,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":283,"context_line":"        description\u003d(\u0027Specify ``enable_default_route_ecmp`` attribute when\u0027"},{"line_number":284,"context_line":"                     \u0027 creating a router\u0027),"},{"line_number":285,"context_line":"        operations\u003dACTION_POST,"},{"line_number":286,"context_line":"    ),"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"50b89777_342a9842","line":284,"range":{"start_line":284,"start_character":23,"end_line":284,"end_character":31},"updated":"2023-06-22 17:41:54.000000000","message":"s/updating\n\nAnd I\u0027ll add a super nit since I\u0027m commenting that the other entries have the space at the end of each line and not the beginning. I notice these things...","commit_id":"98ec9dae8d77b5d8b70f5d614acc46ded51391e4"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"56d1f54f560cf51a8f364cacb41af8de5914ec06","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        check_str\u003dbase.ADMIN,"},{"line_number":282,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":283,"context_line":"        description\u003d(\u0027Specify ``enable_default_route_ecmp`` attribute when\u0027"},{"line_number":284,"context_line":"                     \u0027 creating a router\u0027),"},{"line_number":285,"context_line":"        operations\u003dACTION_POST,"},{"line_number":286,"context_line":"    ),"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"62e78bc8_461f2f63","line":284,"range":{"start_line":284,"start_character":23,"end_line":284,"end_character":31},"in_reply_to":"50b89777_342a9842","updated":"2023-06-23 06:44:08.000000000","message":"Ack","commit_id":"98ec9dae8d77b5d8b70f5d614acc46ded51391e4"}],"neutron/db/l3_extra_gws_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d81e80599a00cc50ed2f902fceaa36525b35aa0e","unresolved":true,"context_lines":[{"line_number":41,"context_line":"# from neutron_lib.api.definitions import l3_enable_default_route_bfd"},{"line_number":42,"context_line":"ENABLE_DEFAULT_ROUTE_BFD \u003d \u0027enable_default_route_bfd\u0027"},{"line_number":43,"context_line":"# from neutron_lib.api.definitions import l3_enable_default_route_ecmp"},{"line_number":44,"context_line":"ENABLE_DEFAULT_ROUTE_ECMP \u003d \u0027enable_default_route_ecmp\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def format_gateway_info(gw_port):"}],"source_content_type":"text/x-python","patch_set":34,"id":"f02d7529_5cca0127","line":44,"updated":"2023-06-22 17:41:54.000000000","message":"If these are in the version of neutron-lib this patch is using should just use them instead of re-defining here.","commit_id":"98ec9dae8d77b5d8b70f5d614acc46ded51391e4"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"56d1f54f560cf51a8f364cacb41af8de5914ec06","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# from neutron_lib.api.definitions import l3_enable_default_route_bfd"},{"line_number":42,"context_line":"ENABLE_DEFAULT_ROUTE_BFD \u003d \u0027enable_default_route_bfd\u0027"},{"line_number":43,"context_line":"# from neutron_lib.api.definitions import l3_enable_default_route_ecmp"},{"line_number":44,"context_line":"ENABLE_DEFAULT_ROUTE_ECMP \u003d \u0027enable_default_route_ecmp\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def format_gateway_info(gw_port):"}],"source_content_type":"text/x-python","patch_set":34,"id":"e30e2853_8213fc5e","line":44,"in_reply_to":"f02d7529_5cca0127","updated":"2023-06-23 06:44:08.000000000","message":"Ack","commit_id":"98ec9dae8d77b5d8b70f5d614acc46ded51391e4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dd31954441b25b06bb00591e20e38b3f118c73","unresolved":true,"context_lines":[{"line_number":38,"context_line":"from neutron_lib.plugins import constants as plugin_constants"},{"line_number":39,"context_line":"from neutron_lib.plugins import directory"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"l3_extra_gws_db.register_db_l3_extragws_opts()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def format_gateway_info(gw_port):"}],"source_content_type":"text/x-python","patch_set":37,"id":"ff5f3948_2c991e95","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":4},"updated":"2023-07-04 12:28:02.000000000","message":"You are registering these options in [1] too. That could lead to an error if both modules are loaded at the same time.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/874797/37/neutron/db/l3_attrs_db.py#25","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ea5dd0f1b181c33ba5818e378df674002b0d3055","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from neutron_lib.plugins import constants as plugin_constants"},{"line_number":39,"context_line":"from neutron_lib.plugins import directory"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"l3_extra_gws_db.register_db_l3_extragws_opts()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def format_gateway_info(gw_port):"}],"source_content_type":"text/x-python","patch_set":37,"id":"b55c603a_57b57f59","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":4},"in_reply_to":"ff5f3948_2c991e95","updated":"2023-07-07 09:53:09.000000000","message":"Done","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"}],"neutron/db/migration/alembic_migrations/versions/2023.2/expand/89c58a70ceba_ecmp_bfd_attributes.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d49ae484384a1e947e079df3747915e267fce0ab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"b4b7cd9a_9f8c9418","updated":"2023-06-23 16:30:44.000000000","message":"File mode here should be 100664 as well.","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"8c2f17b3096eeb194b83e7674c09fa8ebe423b61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"4643581f_86238c43","in_reply_to":"9c3a882e_83a05939","updated":"2023-06-27 06:02:08.000000000","message":"See other comment.","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"763a03ebe44400b95a8b8d29e300d55a85e83f12","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"9c3a882e_83a05939","in_reply_to":"b4b7cd9a_9f8c9418","updated":"2023-06-26 10:43:47.000000000","message":"\u003e File mode here should be 100664 as well.\n\nI unfortunately do not know how to do that. AFAICT Git only gives you control over whether the file should have the executable bit set or not.","commit_id":"1fba624f4c76e6c29a83af9d73bcd1c4ff12dba2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dd31954441b25b06bb00591e20e38b3f118c73","unresolved":true,"context_lines":[{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027router_extra_attributes\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027enable_default_route_ecmp\u0027, sa.Boolean(),"},{"line_number":35,"context_line":"                            server_default\u003dsa.text(\u0027false\u0027), nullable\u003dFalse))"},{"line_number":36,"context_line":"    op.add_column(\u0027router_extra_attributes\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027enable_default_route_bfd\u0027, sa.Boolean(),"},{"line_number":38,"context_line":"                            server_default\u003dsa.text(\u0027false\u0027), nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":37,"id":"3c29b2e6_81805843","line":35,"range":{"start_line":35,"start_character":43,"end_line":35,"end_character":59},"updated":"2023-07-04 12:28:02.000000000","message":"sqlalchemy provides a sql expresion for true and false:\n```\nfrom sqlalchemy import sql\n...\nserver_default\u003dsql.false(), ...\n\n```","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ea5dd0f1b181c33ba5818e378df674002b0d3055","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027router_extra_attributes\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027enable_default_route_ecmp\u0027, sa.Boolean(),"},{"line_number":35,"context_line":"                            server_default\u003dsa.text(\u0027false\u0027), nullable\u003dFalse))"},{"line_number":36,"context_line":"    op.add_column(\u0027router_extra_attributes\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027enable_default_route_bfd\u0027, sa.Boolean(),"},{"line_number":38,"context_line":"                            server_default\u003dsa.text(\u0027false\u0027), nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":37,"id":"722774fb_0868e52d","line":35,"range":{"start_line":35,"start_character":43,"end_line":35,"end_character":59},"in_reply_to":"3c29b2e6_81805843","updated":"2023-07-07 09:53:09.000000000","message":"Done","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dd31954441b25b06bb00591e20e38b3f118c73","unresolved":true,"context_lines":[{"line_number":35,"context_line":"                            server_default\u003dsa.text(\u0027false\u0027), nullable\u003dFalse))"},{"line_number":36,"context_line":"    op.add_column(\u0027router_extra_attributes\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027enable_default_route_bfd\u0027, sa.Boolean(),"},{"line_number":38,"context_line":"                            server_default\u003dsa.text(\u0027false\u0027), nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":37,"id":"645115fa_bfd4aab7","line":38,"range":{"start_line":38,"start_character":52,"end_line":38,"end_character":57},"updated":"2023-07-04 12:28:02.000000000","message":"ditto","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ea5dd0f1b181c33ba5818e378df674002b0d3055","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                            server_default\u003dsa.text(\u0027false\u0027), nullable\u003dFalse))"},{"line_number":36,"context_line":"    op.add_column(\u0027router_extra_attributes\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027enable_default_route_bfd\u0027, sa.Boolean(),"},{"line_number":38,"context_line":"                            server_default\u003dsa.text(\u0027false\u0027), nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":37,"id":"92024b04_dd06fc4f","line":38,"range":{"start_line":38,"start_character":52,"end_line":38,"end_character":57},"in_reply_to":"645115fa_bfd4aab7","updated":"2023-07-07 09:53:09.000000000","message":"Done","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"}],"neutron/objects/router.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cc25af5843e28edd85fe931e38451aac47a9155c","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        \u0027service_router\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":83,"context_line":"        \u0027ha\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":84,"context_line":"        \u0027ha_vr_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027availability_zone_hints\u0027: obj_fields.ListOfStringsField("},{"line_number":86,"context_line":"            nullable\u003dTrue),"},{"line_number":87,"context_line":"        \u0027enable_default_route_ecmp\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":88,"context_line":"        \u0027enable_default_route_bfd\u0027: obj_fields.BooleanField(default\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":19,"id":"3c685178_f613d515","line":85,"updated":"2023-04-05 16:01:33.000000000","message":"nit: unnecessary change.","commit_id":"bf0439aeb3ace96b5832c4ba0942f3b7c9aa9a10"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"64b551f30bbd6a97e9842e25997ddb65ddcf733c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \u0027service_router\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":83,"context_line":"        \u0027ha\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":84,"context_line":"        \u0027ha_vr_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027availability_zone_hints\u0027: obj_fields.ListOfStringsField("},{"line_number":86,"context_line":"            nullable\u003dTrue),"},{"line_number":87,"context_line":"        \u0027enable_default_route_ecmp\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":88,"context_line":"        \u0027enable_default_route_bfd\u0027: obj_fields.BooleanField(default\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":19,"id":"b93e1def_33cf0586","line":85,"in_reply_to":"3c685178_f613d515","updated":"2023-04-27 22:12:52.000000000","message":"It\u0027s actually to avoid the \u003e 80 characters limit:\n\n```\n./neutron/objects/router.py:85:80: E501 line too long (80 \u003e 79 characters)\n        \u0027availability_zone_hints\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue),\n```","commit_id":"bf0439aeb3ace96b5832c4ba0942f3b7c9aa9a10"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bd67dcaca64520c764c651fe9f972cdf0be0a44a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \u0027service_router\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":83,"context_line":"        \u0027ha\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":84,"context_line":"        \u0027ha_vr_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027availability_zone_hints\u0027: obj_fields.ListOfStringsField("},{"line_number":86,"context_line":"            nullable\u003dTrue),"},{"line_number":87,"context_line":"        \u0027enable_default_route_ecmp\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":88,"context_line":"        \u0027enable_default_route_bfd\u0027: obj_fields.BooleanField(default\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":19,"id":"f55fc429_3e87edb5","line":85,"in_reply_to":"b93e1def_33cf0586","updated":"2023-05-03 09:22:23.000000000","message":"I see the \u0027,\u0027 added. My mistake. Thanks.","commit_id":"bf0439aeb3ace96b5832c4ba0942f3b7c9aa9a10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dd31954441b25b06bb00591e20e38b3f118c73","unresolved":true,"context_lines":[{"line_number":133,"context_line":"            query \u003d query.filter(count \u003c less_than)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        return list(query)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"@base.NeutronObjectRegistry.register"},{"line_number":139,"context_line":"class RouterPort(base.NeutronDbObject):"}],"source_content_type":"text/x-python","patch_set":37,"id":"be25a070_4e2515c8","line":136,"updated":"2023-07-04 12:28:02.000000000","message":"You need to implement a method to downgrade the OVO from 1.1 to 1.0. This method must be called \"def obj_make_compatible(self, primitive, target_version)\". Search for it in the repo for more info.","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ea5dd0f1b181c33ba5818e378df674002b0d3055","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            query \u003d query.filter(count \u003c less_than)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        return list(query)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"@base.NeutronObjectRegistry.register"},{"line_number":139,"context_line":"class RouterPort(base.NeutronDbObject):"}],"source_content_type":"text/x-python","patch_set":37,"id":"c7f9ece7_5f5b6b8c","line":136,"in_reply_to":"be25a070_4e2515c8","updated":"2023-07-07 09:53:09.000000000","message":"Done","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"}],"neutron/tests/unit/conf/policies/test_router.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dd31954441b25b06bb00591e20e38b3f118c73","unresolved":true,"context_lines":[{"line_number":266,"context_line":"            policy.enforce,"},{"line_number":267,"context_line":"            self.context, \u0027update_router:enable_default_route_ecmp\u0027,"},{"line_number":268,"context_line":"            self.target)"},{"line_number":269,"context_line":"        self.assertRaises("},{"line_number":270,"context_line":"            base_policy.InvalidScope,"},{"line_number":271,"context_line":"            policy.enforce,"},{"line_number":272,"context_line":"            self.context, \u0027update_router:enable_default_route_ecmp\u0027,"},{"line_number":273,"context_line":"            self.alt_target)"}],"source_content_type":"text/x-python","patch_set":37,"id":"d09e2052_5fbec345","line":270,"range":{"start_line":269,"start_character":8,"end_line":270,"end_character":37},"updated":"2023-07-04 12:28:02.000000000","message":"There should be at least one test where this action is possible. Same comment applies to \"enable_default_route_bfd\"","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ea5dd0f1b181c33ba5818e378df674002b0d3055","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            policy.enforce,"},{"line_number":267,"context_line":"            self.context, \u0027update_router:enable_default_route_ecmp\u0027,"},{"line_number":268,"context_line":"            self.target)"},{"line_number":269,"context_line":"        self.assertRaises("},{"line_number":270,"context_line":"            base_policy.InvalidScope,"},{"line_number":271,"context_line":"            policy.enforce,"},{"line_number":272,"context_line":"            self.context, \u0027update_router:enable_default_route_ecmp\u0027,"},{"line_number":273,"context_line":"            self.alt_target)"}],"source_content_type":"text/x-python","patch_set":37,"id":"069072ae_21cfa5a8","line":270,"range":{"start_line":269,"start_character":8,"end_line":270,"end_character":37},"in_reply_to":"d09e2052_5fbec345","updated":"2023-07-07 09:53:09.000000000","message":"Done","commit_id":"00ce497412fa2eba61da10bc9c3b5215a1140bdf"}]}