)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a1205c15da1758e2d7ea2f16df405d87b814805c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Normalise format of OVN agent heartbeat timestamp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A recent change [1] to show the real heartbeat timestamp from OVN agents had a"},{"line_number":10,"context_line":"side effect of changing the timestamp format, which now includes a timezone:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    +-------------------+----------------------------------+"},{"line_number":13,"context_line":"    | Field             | Value                            |"},{"line_number":14,"context_line":"    +-------------------+----------------------------------+"},{"line_number":15,"context_line":"    | last_heartbeat_at | 2023-02-23 14:12:07.471000+00:00 |"},{"line_number":16,"context_line":"    +-------------------+----------------------------------+"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This unexpected format change causes some clients to fail to parse the response"},{"line_number":19,"context_line":"to GET /v2.0/agents."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Normalise the format of the timestamp to remove timezone information."},{"line_number":22,"context_line":"Also remove the microsecond part, which was not done before for OVN, but"},{"line_number":23,"context_line":"is absent from other network agents."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] https://review.opendev.org/c/openstack/neutron/+/844179"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"708a4c51_fdd6337d","line":23,"range":{"start_line":9,"start_character":0,"end_line":23,"end_character":36},"updated":"2023-02-23 14:42:11.000000000","message":"nit: please use a line break at 72 chars, that will be read better in gerrit [1]:\n  Subsequent lines should be wrapped at 72 characters. \n\n[1]https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"f6caefd6a503b34e77f126f2a5a98f99ca33cc5d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"fdc99435a98f5b276cefa4a6d3aeda36bb7b7a4d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Normalise format of OVN agent heartbeat timestamp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A recent change [1] to show the real heartbeat timestamp from OVN agents had a"},{"line_number":10,"context_line":"side effect of changing the timestamp format, which now includes a timezone:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    +-------------------+----------------------------------+"},{"line_number":13,"context_line":"    | Field             | Value                            |"},{"line_number":14,"context_line":"    +-------------------+----------------------------------+"},{"line_number":15,"context_line":"    | last_heartbeat_at | 2023-02-23 14:12:07.471000+00:00 |"},{"line_number":16,"context_line":"    +-------------------+----------------------------------+"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This unexpected format change causes some clients to fail to parse the response"},{"line_number":19,"context_line":"to GET /v2.0/agents."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Normalise the format of the timestamp to remove timezone information."},{"line_number":22,"context_line":"Also remove the microsecond part, which was not done before for OVN, but"},{"line_number":23,"context_line":"is absent from other network agents."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] https://review.opendev.org/c/openstack/neutron/+/844179"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e00ca838_0bca2ee7","line":23,"range":{"start_line":9,"start_character":0,"end_line":23,"end_character":36},"in_reply_to":"708a4c51_fdd6337d","updated":"2023-02-23 14:45:43.000000000","message":"I normally do, something broke in my Vim setup and it isn\u0027t wrapping automatically anymore.","commit_id":"f6caefd6a503b34e77f126f2a5a98f99ca33cc5d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a1205c15da1758e2d7ea2f16df405d87b814805c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8211d020_ba5c8f12","updated":"2023-02-23 14:42:11.000000000","message":"Good catch.\n\nPlease add a unit test to show this method is actually formatting the timestamp in the desired format.","commit_id":"f6caefd6a503b34e77f126f2a5a98f99ca33cc5d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b481f66cdc5d9a44d2742ebe1d03ba45cb719fb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f172dc0c_dd155680","updated":"2023-02-23 14:45:58.000000000","message":"Please check my previous comments","commit_id":"27055508f1db186f7e93c4e90b0e6ac475630de7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e0ad6a4023cd8aa97265fcd48ffd34b1aae41f27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28952496_17369522","in_reply_to":"f172dc0c_dd155680","updated":"2023-02-23 14:54:55.000000000","message":"Yes, working on it :)","commit_id":"27055508f1db186f7e93c4e90b0e6ac475630de7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"67ee4971966030589df5ad33152832aaca47ea12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4db42f82_2f3ddc69","updated":"2023-02-23 17:11:48.000000000","message":"Actually no, the FT test is failing: neutron.tests.functional.plugins.ml2.drivers.ovn.mech_driver.test_mech_driver.TestAgentApi.test_agent_show_real_heartbeat_timestamp","commit_id":"83fbb47dac97a74203430be7d45e4be5cc3df193"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"493d608b5fba902f179b6a20ecca6d0c6eb1297d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fe5690b_0e2218f2","updated":"2023-02-23 16:36:09.000000000","message":"Looks good and CI test is passing","commit_id":"83fbb47dac97a74203430be7d45e4be5cc3df193"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c00bf239b370bcbd9593a7bc5dbf8391c9eabe51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3b8aba94_26267f6e","in_reply_to":"4db42f82_2f3ddc69","updated":"2023-02-24 11:38:48.000000000","message":"The failing test is fixed now.","commit_id":"83fbb47dac97a74203430be7d45e4be5cc3df193"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c00bf239b370bcbd9593a7bc5dbf8391c9eabe51","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ef2ad82_5a549f27","updated":"2023-02-24 11:38:48.000000000","message":"@Rodolfo: What do you think of the removal of the microsecond part. Is this a good idea? AFAIK it matches the API output for other agents, but I don\u0027t know how this is used internally.\n\nThe file neutron/tests/unit/db/test_agents_db.py has a test with heartbeat_timestamp using microseconds, but is it the case anywhere else than OVN outside of tests?","commit_id":"827fbd01c306ce292e46b0d881bc3cc804202285"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8c0b0052b0983be321e4e80ae857c022be8f992","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dd39538a_98fe6f4c","updated":"2023-02-28 05:03:40.000000000","message":"recheck nova 500 error in tempest","commit_id":"827fbd01c306ce292e46b0d881bc3cc804202285"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8be33d9b2ea046429ff20e03f311d2dd57c9b75c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"12d562b4_653b20c7","updated":"2023-02-27 16:30:51.000000000","message":"recheck tempest","commit_id":"827fbd01c306ce292e46b0d881bc3cc804202285"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0421a61a1d1c889b37d434e39d9305fdea29cfb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d41137ff_db7c5952","in_reply_to":"1ef2ad82_5a549f27","updated":"2023-02-27 12:41:37.000000000","message":"The Neutron API [1] is clear on this:\n  \"heartbeat_timestamp\": \"2017-09-12 19:40:38\"\n\nWe don\u0027t provide microsecond information. The output should be the same for any agent.\n\n[1]https://docs.openstack.org/api-ref/network/v2/index.html?expanded\u003dshow-agent-details-detail","commit_id":"827fbd01c306ce292e46b0d881bc3cc804202285"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0c072c84b25abdcfd77905728aaa2196695b1876","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"11a5663e_6ec79fe6","in_reply_to":"d41137ff_db7c5952","updated":"2023-02-27 13:33:50.000000000","message":"Thank you for confirming.","commit_id":"827fbd01c306ce292e46b0d881bc3cc804202285"}]}