)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"b80b5c020ae48f4d9a76e69499a6d9617fc4dca9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0785b6d9_e095b9c5","updated":"2023-03-06 15:50:23.000000000","message":"recheck -- unrelated ping failure dsvm-functional-gate","commit_id":"75e83602247360cf10b7b9aa4e53a0135b491cae"}],"neutron/tests/functional/agent/ovn/metadata/test_metadata_agent.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"24bba3e19922199418d6516a8499e1b6191a2efd","unresolved":true,"context_lines":[{"line_number":190,"context_line":"        # new br-new value to its attribute."},{"line_number":191,"context_line":"        self.assertEqual(self.OVN_BRIDGE, self.agent.ovn_bridge)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        # NOTE: The IP address is specifically picked such that it fits the"},{"line_number":194,"context_line":"        # metadata port external_ids: { neutron:cidrs }. This is because agent"},{"line_number":195,"context_line":"        # will only trigger if the logical port is part of a neutron subnet"},{"line_number":196,"context_line":"        lswitchport_name, _ \u003d self._create_logical_switch_port("},{"line_number":197,"context_line":"            addresses\u003d\u0027AA:AA:AA:AA:AA:AB 192.168.122.125\u0027"},{"line_number":198,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"b4844413_d7fd56e5","line":195,"range":{"start_line":193,"start_character":10,"end_line":195,"end_character":75},"updated":"2023-02-28 03:38:14.000000000","message":"I did not want to complicate the code more, so I purposely created an IP which will be within the neutron metadaport cidr. Alternatevely, I could have introduced logic in _crete_logical_switch_port() function which will figure out a CIDR(using netaddr) \nand it will create a new metadaport with appropriate CIDR. This would have been cleaner solution but I feel like overengineered at this point. Maybe worth doing that if we find more tests needing this functionality.","commit_id":"75e83602247360cf10b7b9aa4e53a0135b491cae"}]}
