)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a9f5ff66965c929ca7ee2f6557ea2cdf752c43e8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change API to validate network MTU minimums"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A network\u0027s MTU is now only valid if it is the minimum value"},{"line_number":10,"context_line":"allowed based on the IP version of the associated subnets,"},{"line_number":11,"context_line":"68 for IPv4 and 1280 for IPv6."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This minimum is now enforced in the following ways:"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"6130484d_cfb26d1b","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":30},"updated":"2023-04-05 07:40:23.000000000","message":"Users mentioning on reports 70 and usage of 68 for the MTU. Even If I \u0027m totally with you and this change. Should we consider that something else is impacting our dhcp agent?","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9a98b8de0cbf860c54998fb0fac7265662210c1f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change API to validate network MTU minimums"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A network\u0027s MTU is now only valid if it is the minimum value"},{"line_number":10,"context_line":"allowed based on the IP version of the associated subnets,"},{"line_number":11,"context_line":"68 for IPv4 and 1280 for IPv6."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This minimum is now enforced in the following ways:"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"54bd8adf_9735d5ef","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":30},"in_reply_to":"1cf055e9_6a32d835","updated":"2023-04-05 15:16:48.000000000","message":"Ack","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ed30fdf198e5f42214c8f0c3162d025524761cd0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change API to validate network MTU minimums"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A network\u0027s MTU is now only valid if it is the minimum value"},{"line_number":10,"context_line":"allowed based on the IP version of the associated subnets,"},{"line_number":11,"context_line":"68 for IPv4 and 1280 for IPv6."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This minimum is now enforced in the following ways:"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1cf055e9_6a32d835","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":30},"in_reply_to":"6130484d_cfb26d1b","updated":"2023-04-05 13:56:00.000000000","message":"Hi Sahid,\n\nTake a look at my other related change that shouldn\u0027t be necessary if we restrict this at the API:\n\nhttps://review.opendev.org/c/openstack/neutron/+/874167\n\nIf there is some text from that change I can put here let me know, for example having an mtu of 1279 will trigger a failure if there is an IPv6 subnet present, so it doesn\u0027t need to be any lower.\n\nI have not seen any other issues with the dhcp agent while I was investigating this.","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1d52ae56f94897f5f355a2bc93d1f625e256364e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c461e0c0_0d8af6ab","updated":"2023-03-04 01:11:18.000000000","message":"I also need to add a release note.","commit_id":"023509592deaa6a1a140b3399baf96ca32efab25"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9a98b8de0cbf860c54998fb0fac7265662210c1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"294382ac_bb211d7b","updated":"2023-04-05 15:16:48.000000000","message":"Fair enough I think it\u0027s a good progress anyway. Thank you Brian !","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"abbcbc653bf0da8855f792046965eeeb4c33ac8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2bc53062_e8294178","updated":"2023-03-23 20:26:55.000000000","message":"Hopefully I\u0027m not missing something...","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8d3e8324a5e9b904f41005a93b2455f1d07d2503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dfdc93af_5474070b","updated":"2023-04-26 16:23:06.000000000","message":"Needs a manual rebase to fix _constants.py conflict.","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4fd9813d0d1840bc03b5e32b81962f139e184294","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b2d73582_1c131893","updated":"2023-03-27 19:10:24.000000000","message":"Nice,\nSome higher level test would be good for these , not sure if tempest of functional or fullstack is enough.","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3d7969feb5cbe35e07150ba6482075187c0aa49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e6edabaf_8763de4b","updated":"2023-04-25 19:41:56.000000000","message":"recheck gate fixed","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1f7a057b0202b69889c65f40bc357b0a0689276c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0f20b323_821160f3","updated":"2023-04-18 09:45:35.000000000","message":"recheck tempest","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d502c7ceb8e42926f0c7a8656e8666e804ca5a33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7c00a08b_9458e7b8","updated":"2023-04-26 02:39:53.000000000","message":"recheck unrelated grenade failure","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7cc58bae0f94aac6c23960239ff89f2d74df74e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2e92b35b_532840bc","updated":"2023-04-13 14:44:05.000000000","message":"recheck unrelated neutron-ovs-grenade-dvr-multinode failure","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f420acb6e19c048da1f70274393d63060193726c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7d19181c_164a6bcf","updated":"2023-04-13 17:58:52.000000000","message":"recheck unrelated neutron-ovs-grenade-multinode failure","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0ffc01f2e958935bc58726cf02c4f59e2ee07733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1a13fbad_a2b5eb6f","updated":"2023-04-29 14:40:56.000000000","message":"recheck fullstack RETRY","commit_id":"88ce859b568248a0ee2f47a5d91c1708b774d20e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"702d1836d1c0b4facba814bc400ef0f768b37658","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"28ffa2f4_6ad37d82","updated":"2023-04-28 19:40:44.000000000","message":"recheck ip6tables failure in test_securitygroup\n\nfyi, the failure in the fullstack job looks like https://bugs.gentoo.org/831626","commit_id":"88ce859b568248a0ee2f47a5d91c1708b774d20e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dbc0bb01c3ac62639ac81d2aa924cf50d44bf33c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6f6055a1_d3b15654","updated":"2023-04-26 21:05:22.000000000","message":"recheck mirror issue","commit_id":"88ce859b568248a0ee2f47a5d91c1708b774d20e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"76257f1e9f32f70a9a0e956dada930a2869c9d9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e239e6f4_348b19d5","updated":"2023-04-27 02:52:14.000000000","message":"recheck mirror issue","commit_id":"88ce859b568248a0ee2f47a5d91c1708b774d20e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"93e2434e9c3b091080808e8fdde9c857b13a9bd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"990c0b91_991ab6c9","updated":"2023-05-02 07:31:05.000000000","message":"recheck neutron CI fixed","commit_id":"88ce859b568248a0ee2f47a5d91c1708b774d20e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5946e5422e44c8f03e46445298635b802b1e74b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"221f01c6_7f48ff7a","updated":"2023-04-26 18:46:19.000000000","message":"recheck unrelated grenade failure","commit_id":"88ce859b568248a0ee2f47a5d91c1708b774d20e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e59220bf113514512d0e6b81db581f235ab0db2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7b34b36b_3eb67f57","updated":"2023-04-28 15:40:03.000000000","message":"recheck vexxhost nodes disabled","commit_id":"88ce859b568248a0ee2f47a5d91c1708b774d20e"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a9f5ff66965c929ca7ee2f6557ea2cdf752c43e8","unresolved":true,"context_lines":[{"line_number":488,"context_line":"            return"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        # at least one subnet present, if below IPv4 minimum we fail early"},{"line_number":491,"context_line":"        if mtu \u003c _constants.IPV4_MIN_MTU:"},{"line_number":492,"context_line":"            raise mtu_exc.NetworkMTUSubnetConflict("},{"line_number":493,"context_line":"                net_id\u003did, mtu\u003d_constants.IPV4_MIN_MTU)"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6844e204_cc562f34","line":491,"updated":"2023-04-05 07:40:23.000000000","message":"Based on a report in the ML It seems that we should also use \u003c\u003d 68, right?\n\n3401: tap1c220d25-b9: \u003cBROADCAST,MULTICAST,UP,LOWER_UP\u003e mtu 68 qdisc noqueue state UNKNOWN group default qlen 1000\n\n\n$tail -f /var/log/kolla/neutron/neutron-dhcp-agent.log |grep 8db375e0-28d2-4379-9330-397dc9b4f2b1\n2023-04-05 08:36:11.558 7 INFO neutron.agent.dhcp.agent [-] Starting network 8db375e0-28d2-4379-9330-397dc9b4f2b1 dhcp configuration\n2023-04-05 08:36:12.532 7 ERROR neutron.agent.dhcp.agent [-] Unable to enable dhcp for 8db375e0-28d2-4379-9330-397dc9b4f2b1.: neutron.privileged.agent.linux.ip_lib.InvalidArgument: Invalid parameter/value used on interface tap1c220d25-b9, namespace qdhcp-8db375e0-28d2-4379-9330-397dc9b4f2b1.\n2023-04-05 08:36:12.532 7 ERROR neutron.agent.dhcp.agent neutron.privileged.agent.linux.ip_lib.InvalidArgument: Invalid parameter/value used on interface tap1c220d25-b9, namespace qdhcp-8db375e0-28d2-4379-9330-397dc9b4f2b1.\n2023-04-05 08:36:12.534 7 INFO neutron.agent.dhcp.agent [-] Finished network 8db375e0-28d2-4379-9330-397dc9b4f2b1 dhcp configuration","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9a98b8de0cbf860c54998fb0fac7265662210c1f","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            return"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        # at least one subnet present, if below IPv4 minimum we fail early"},{"line_number":491,"context_line":"        if mtu \u003c _constants.IPV4_MIN_MTU:"},{"line_number":492,"context_line":"            raise mtu_exc.NetworkMTUSubnetConflict("},{"line_number":493,"context_line":"                net_id\u003did, mtu\u003d_constants.IPV4_MIN_MTU)"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"be895753_b77d9c2c","line":491,"in_reply_to":"06303137_49eae07f","updated":"2023-04-05 15:16:48.000000000","message":"Ack","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ed30fdf198e5f42214c8f0c3162d025524761cd0","unresolved":true,"context_lines":[{"line_number":488,"context_line":"            return"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        # at least one subnet present, if below IPv4 minimum we fail early"},{"line_number":491,"context_line":"        if mtu \u003c _constants.IPV4_MIN_MTU:"},{"line_number":492,"context_line":"            raise mtu_exc.NetworkMTUSubnetConflict("},{"line_number":493,"context_line":"                net_id\u003did, mtu\u003d_constants.IPV4_MIN_MTU)"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"06303137_49eae07f","line":491,"in_reply_to":"6844e204_cc562f34","updated":"2023-04-05 13:56:00.000000000","message":"68 works if just IPv4 subnet(s) are present, I can test it again. And since it\u0027s the IPv4 minimum according to the RFC we should allow it, even if it\u0027s useless.\n\nI\u0027m not sure what\u0027s up with the report on the mailing list, and if there is possibly another network involved, which might trigger a failure in this one.","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6f40290bfbaba92d31917e5bb2c8ed442763ad87","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            return"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        # at least one subnet present, if below IPv4 minimum we fail early"},{"line_number":491,"context_line":"        if mtu \u003c _constants.IPV4_MIN_MTU:"},{"line_number":492,"context_line":"            raise mtu_exc.NetworkMTUSubnetConflict("},{"line_number":493,"context_line":"                net_id\u003did, mtu\u003d_constants.IPV4_MIN_MTU)"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"cdd82bc1_78830f46","line":491,"in_reply_to":"be895753_b77d9c2c","updated":"2023-04-05 17:26:47.000000000","message":"So I just re-tested this patch, creating a network then changing it\u0027s mtu to 68:\n\n18: tapd7022a4f-17: \u003cBROADCAST,MULTICAST,UP,LOWER_UP\u003e mtu 68 qdisc noqueue state UNKNOWN group default qlen 1000\n    link/ether fa:16:3e:de:3b:a7 brd ff:ff:ff:ff:ff:ff\n    inet 10.0.0.66/26 brd 10.0.0.127 scope global tapd7022a4f-17\n       valid_lft forever preferred_lft forever\n\nI didn\u0027t see any tracebacks in the dhcp-agent log. I also tried creating one with an initial mtu of 68 and same thing.\n\nThe only thing I saw was that the qdhcp namespace was not removed when I deleted the network, will have to file a bug for that :(","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6913df2bf59e2cfc3e8f24a956c371e591221a5c","unresolved":true,"context_lines":[{"line_number":496,"context_line":"        # caught by above IPV4_MIN_MTU check"},{"line_number":497,"context_line":"        for subnet in subnets:"},{"line_number":498,"context_line":"            if (subnet.ip_version \u003d\u003d constants.IP_VERSION_6 and"},{"line_number":499,"context_line":"                    mtu \u003c constants.IPV6_MIN_MTU):"},{"line_number":500,"context_line":"                raise mtu_exc.NetworkMTUSubnetConflict("},{"line_number":501,"context_line":"                    net_id\u003did, mtu\u003dconstants.IPV6_MIN_MTU)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"c86a2237_6fb77386","line":499,"range":{"start_line":499,"start_character":19,"end_line":499,"end_character":48},"updated":"2023-03-23 15:26:31.000000000","message":"this is already always True as otherwise it would be return in L484, right?","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7cc58bae0f94aac6c23960239ff89f2d74df74e1","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        # caught by above IPV4_MIN_MTU check"},{"line_number":497,"context_line":"        for subnet in subnets:"},{"line_number":498,"context_line":"            if (subnet.ip_version \u003d\u003d constants.IP_VERSION_6 and"},{"line_number":499,"context_line":"                    mtu \u003c constants.IPV6_MIN_MTU):"},{"line_number":500,"context_line":"                raise mtu_exc.NetworkMTUSubnetConflict("},{"line_number":501,"context_line":"                    net_id\u003did, mtu\u003dconstants.IPV6_MIN_MTU)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9d9ba321_ec3d33ce","line":499,"range":{"start_line":499,"start_character":19,"end_line":499,"end_character":48},"in_reply_to":"5670086a_d26881ca","updated":"2023-04-13 14:44:05.000000000","message":"Done","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"abbcbc653bf0da8855f792046965eeeb4c33ac8d","unresolved":true,"context_lines":[{"line_number":496,"context_line":"        # caught by above IPV4_MIN_MTU check"},{"line_number":497,"context_line":"        for subnet in subnets:"},{"line_number":498,"context_line":"            if (subnet.ip_version \u003d\u003d constants.IP_VERSION_6 and"},{"line_number":499,"context_line":"                    mtu \u003c constants.IPV6_MIN_MTU):"},{"line_number":500,"context_line":"                raise mtu_exc.NetworkMTUSubnetConflict("},{"line_number":501,"context_line":"                    net_id\u003did, mtu\u003dconstants.IPV6_MIN_MTU)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"d6f9356b_99e34626","line":499,"range":{"start_line":499,"start_character":19,"end_line":499,"end_character":48},"in_reply_to":"c86a2237_6fb77386","updated":"2023-03-23 20:26:55.000000000","message":"L484 should return if the MTU is at least 1280, which is good for both v4/v6. We should only get here if it\u0027s (68 \u003c\u003d mtu \u003c 1280), right?","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0716b015e4e4e6f654ae8b7a414f5da624348439","unresolved":true,"context_lines":[{"line_number":496,"context_line":"        # caught by above IPV4_MIN_MTU check"},{"line_number":497,"context_line":"        for subnet in subnets:"},{"line_number":498,"context_line":"            if (subnet.ip_version \u003d\u003d constants.IP_VERSION_6 and"},{"line_number":499,"context_line":"                    mtu \u003c constants.IPV6_MIN_MTU):"},{"line_number":500,"context_line":"                raise mtu_exc.NetworkMTUSubnetConflict("},{"line_number":501,"context_line":"                    net_id\u003did, mtu\u003dconstants.IPV6_MIN_MTU)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5670086a_d26881ca","line":499,"range":{"start_line":499,"start_character":19,"end_line":499,"end_character":48},"in_reply_to":"d6f9356b_99e34626","updated":"2023-04-13 09:55:00.000000000","message":"yes, correct","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6913df2bf59e2cfc3e8f24a956c371e591221a5c","unresolved":true,"context_lines":[{"line_number":756,"context_line":"        # caught by above IPV4_MIN_MTU check"},{"line_number":757,"context_line":"        ip_version \u003d subnet.get(\u0027ip_version\u0027)"},{"line_number":758,"context_line":"        if (ip_version \u003d\u003d constants.IP_VERSION_6 and"},{"line_number":759,"context_line":"                mtu \u003c constants.IPV6_MIN_MTU):"},{"line_number":760,"context_line":"            raise mtu_exc.NetworkMTUSubnetConflict(net_id\u003dnetwork.id, mtu\u003dmtu)"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def _update_router_gw_ports(self, context, network, subnet):"}],"source_content_type":"text/x-python","patch_set":7,"id":"598d5627_7117f104","line":759,"range":{"start_line":759,"start_character":16,"end_line":759,"end_character":44},"updated":"2023-03-23 15:26:31.000000000","message":"nit: same as above but to have it like that You would need to split check in L748 into two separate:\n\n    if not mtu:\n        return\n         \n    if mtu \u003e\u003d constants.IPV6_MIN_MTU:\n        return","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0716b015e4e4e6f654ae8b7a414f5da624348439","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        # caught by above IPV4_MIN_MTU check"},{"line_number":757,"context_line":"        ip_version \u003d subnet.get(\u0027ip_version\u0027)"},{"line_number":758,"context_line":"        if (ip_version \u003d\u003d constants.IP_VERSION_6 and"},{"line_number":759,"context_line":"                mtu \u003c constants.IPV6_MIN_MTU):"},{"line_number":760,"context_line":"            raise mtu_exc.NetworkMTUSubnetConflict(net_id\u003dnetwork.id, mtu\u003dmtu)"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def _update_router_gw_ports(self, context, network, subnet):"}],"source_content_type":"text/x-python","patch_set":7,"id":"a3aa2816_11d91e67","line":759,"range":{"start_line":759,"start_character":16,"end_line":759,"end_character":44},"in_reply_to":"22f13526_53c5e14d","updated":"2023-04-13 09:55:00.000000000","message":"Done","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"abbcbc653bf0da8855f792046965eeeb4c33ac8d","unresolved":true,"context_lines":[{"line_number":756,"context_line":"        # caught by above IPV4_MIN_MTU check"},{"line_number":757,"context_line":"        ip_version \u003d subnet.get(\u0027ip_version\u0027)"},{"line_number":758,"context_line":"        if (ip_version \u003d\u003d constants.IP_VERSION_6 and"},{"line_number":759,"context_line":"                mtu \u003c constants.IPV6_MIN_MTU):"},{"line_number":760,"context_line":"            raise mtu_exc.NetworkMTUSubnetConflict(net_id\u003dnetwork.id, mtu\u003dmtu)"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def _update_router_gw_ports(self, context, network, subnet):"}],"source_content_type":"text/x-python","patch_set":7,"id":"22f13526_53c5e14d","line":759,"range":{"start_line":759,"start_character":16,"end_line":759,"end_character":44},"in_reply_to":"598d5627_7117f104","updated":"2023-03-23 20:26:55.000000000","message":"We shouldn\u0027t get here if \"not mtu\" based on L748, right?","commit_id":"538389f802870439961bbd8006ed5f57c26a3462"}]}