)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"c9bd2ad0eba3b66f772095d111ad7bed3dc4985d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b28d6010_0ac02a97","updated":"2023-03-02 15:28:06.000000000","message":"In our environment, we are seeing slow response times for the get_routers() RPC call when:\n- A large numbers of subnets are attached to a router\n- Lots of FIPs exist which use fixed IPs from the above subnets\n\nWe have measured the response time for the get_routers() RPC call response in one of our networks. This network has 27 subnets and around 1000 FIPs. \n\nPrior to this change, the total time for this RPC call to response was 18.35s. After this change was applied, the call responded in just 5.87s (on average).","commit_id":"87fe58494124b3d53664c33399e062356ccf77f4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5f17eff88c2a4c08d7ff6b96b2ef3d47d84fbd2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d83a98cf_2b343ea7","updated":"2023-03-02 17:22:02.000000000","message":"Patch looks ok and is a good candidate to be backported.\n\nBut you need to test this method \"get_scoped_floating_ips\" in \"FloatingIPDbObjectTestCase\", for example creating 3 routers and 3 ports+FIPs per router. The output of this method, being called with (\"router_ids\") 1, 2 or 3 routers at the same time, should be the FIPs of these routers and no duplicated registers.","commit_id":"87fe58494124b3d53664c33399e062356ccf77f4"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"9af4872881cdab1a36d3d0e214b9a443b2bf7a28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36ba3086_774f1f30","in_reply_to":"d83a98cf_2b343ea7","updated":"2023-03-06 11:53:29.000000000","message":"Original commit has been updated to include the new test.","commit_id":"87fe58494124b3d53664c33399e062356ccf77f4"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d240a77d5930a7fac2cd6fd08bb17f7696807a9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d603f7d2_d434e49e","updated":"2023-03-06 15:33:52.000000000","message":"Changing my vote based on the issues mentioned by pep8, you should just fix them, thanks","commit_id":"ddfc1b43845b6b8df1ff09ce282f14a5e3734a60"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"db65da010b35c19a03081920262aca1654a0a3bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a7c50488_a0eb4e71","updated":"2023-03-06 14:15:41.000000000","message":"Great change, could you report and attach a bug report for it, as mentioned this may be good candidate for backports","commit_id":"ddfc1b43845b6b8df1ff09ce282f14a5e3734a60"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"c9cc90a71667ee0778337912477969e889e17414","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5bd40b24_d37ad589","in_reply_to":"a7c50488_a0eb4e71","updated":"2023-03-06 16:12:52.000000000","message":"Thanks Sahid. I\u0027ve created https://bugs.launchpad.net/neutron/+bug/2009509 to track this.","commit_id":"ddfc1b43845b6b8df1ff09ce282f14a5e3734a60"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"c9cc90a71667ee0778337912477969e889e17414","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d3c1817d_0b734ced","in_reply_to":"d603f7d2_d434e49e","updated":"2023-03-06 16:12:52.000000000","message":"Apologies. The pep8 checks pass locally now and patch has been updated.","commit_id":"ddfc1b43845b6b8df1ff09ce282f14a5e3734a60"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6d09b66b6ce234184062718dd23e25e07ce66324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5961c58f_f4e5c00a","updated":"2023-03-06 16:46:50.000000000","message":"Please change the import (L18 in the testing file). The rest of the patch is OK.\n\nIf approved, please send patches for stable branches.","commit_id":"5598d84e189c23d9ec7016e8a0c9cbf27e6736e7"}],"neutron/tests/unit/objects/test_router.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6d09b66b6ce234184062718dd23e25e07ce66324","unresolved":true,"context_lines":[{"line_number":15,"context_line":"from itertools import chain"},{"line_number":16,"context_line":"from unittest import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from netaddr import IPAddress"},{"line_number":19,"context_line":"from neutron_lib.db import api as db_api"},{"line_number":20,"context_line":"from oslo_utils import uuidutils"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d0a87415_110a5953","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"updated":"2023-03-06 16:46:50.000000000","message":"In Neutron we import the library and the call the method/class from this library\n\nimport netaddr\nfloating_ip_address\u003dnetaddr.IPAddress(f\u002710.{i}.{j}.3\u0027)","commit_id":"5598d84e189c23d9ec7016e8a0c9cbf27e6736e7"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"469466fca1c0b8640a637296f7b75b6829378961","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from itertools import chain"},{"line_number":16,"context_line":"from unittest import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from netaddr import IPAddress"},{"line_number":19,"context_line":"from neutron_lib.db import api as db_api"},{"line_number":20,"context_line":"from oslo_utils import uuidutils"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"13e4c602_52e0577e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"d0a87415_110a5953","updated":"2023-03-06 17:06:36.000000000","message":"Understood. Patch updated.","commit_id":"5598d84e189c23d9ec7016e8a0c9cbf27e6736e7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6d09b66b6ce234184062718dd23e25e07ce66324","unresolved":true,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        # Now try to fetch all the fips for all the routers at once"},{"line_number":340,"context_line":"        original_fips \u003d list(chain.from_iterable(routers.values()))"},{"line_number":341,"context_line":"        compare_results(routers.keys(), original_fips)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"class DvrFipGatewayPortAgentBindingTestCase("}],"source_content_type":"text/x-python","patch_set":3,"id":"76fda7b2_90864b6d","line":341,"range":{"start_line":341,"start_character":8,"end_line":341,"end_character":54},"updated":"2023-03-06 16:46:50.000000000","message":"I would have tested calling \"get_scoped_floating_ips\" with 1 or 2 router IDs only, but that works too.","commit_id":"5598d84e189c23d9ec7016e8a0c9cbf27e6736e7"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"469466fca1c0b8640a637296f7b75b6829378961","unresolved":true,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        # Now try to fetch all the fips for all the routers at once"},{"line_number":340,"context_line":"        original_fips \u003d list(chain.from_iterable(routers.values()))"},{"line_number":341,"context_line":"        compare_results(routers.keys(), original_fips)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"class DvrFipGatewayPortAgentBindingTestCase("}],"source_content_type":"text/x-python","patch_set":3,"id":"9d90b5b1_fc219761","line":341,"range":{"start_line":341,"start_character":8,"end_line":341,"end_character":54},"in_reply_to":"76fda7b2_90864b6d","updated":"2023-03-06 17:06:36.000000000","message":"I have tested calling get_scoped_floating_ips with each router ID individually a couple of lines above this.\n\nThen this makes an additional call to get_scoped_floating_ips with all of the router IDs at once.\n\nI was hoping that would cover all eventualities but happy to make further changes here if you think there are other improvements.","commit_id":"5598d84e189c23d9ec7016e8a0c9cbf27e6736e7"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"8cc5afeb635a12da0093e74fc93f8bed5ce94660","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        # Now try to fetch all the fips for all the routers at once"},{"line_number":340,"context_line":"        original_fips \u003d list(chain.from_iterable(routers.values()))"},{"line_number":341,"context_line":"        compare_results(routers.keys(), original_fips)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"class DvrFipGatewayPortAgentBindingTestCase("}],"source_content_type":"text/x-python","patch_set":3,"id":"7b7f5638_9967bd7f","line":341,"range":{"start_line":341,"start_character":8,"end_line":341,"end_character":54},"in_reply_to":"9d90b5b1_fc219761","updated":"2023-03-07 10:52:53.000000000","message":"Done","commit_id":"5598d84e189c23d9ec7016e8a0c9cbf27e6736e7"}]}