)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"49cfd989adaa188946169efda6c13da50009a1fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"146acf14_aeb2c880","updated":"2023-03-06 14:07:56.000000000","message":"Sounds good. Anychancce that you add a reno note for this? Do you think that you will be able to add a tet for the code added? at least to ensure that we don\u0027t have any regression for the future  ","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f6b6edb06992ddbd3138d02492e13f28e7f4081a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87f7985a_bca681bf","in_reply_to":"146acf14_aeb2c880","updated":"2023-03-08 16:33:50.000000000","message":"The release note is already added. This patch, if approved, should be backported to enable this feature already released.","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"af6b7c40f8b81ce6f5765616c3066b81dff095e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d7b2f1b_2d6b5922","updated":"2023-03-13 08:02:57.000000000","message":"recheck functional","commit_id":"008277b8c12d99438951a308b278203fa7a7c3ef"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a3a881151b1d8ea0b56c26fb98adb12ef4dbfd08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41660bfc_273a3702","updated":"2023-03-10 20:38:07.000000000","message":"recheck unrelated functional test failure","commit_id":"008277b8c12d99438951a308b278203fa7a7c3ef"}],"doc/source/admin/config-ovsfwdriver.rst":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"49cfd989adaa188946169efda6c13da50009a1fc","unresolved":true,"context_lines":[{"line_number":182,"context_line":"ethertypes at present. This is a behavior change compared to the"},{"line_number":183,"context_line":"\"iptables_hybrid\" firewall, which only operates on IP packets and thus does"},{"line_number":184,"context_line":"not address other ethertypes. With the configuration option"},{"line_number":185,"context_line":"``permitted_ethertypes`` is possible to define a set of allowed ethertypes."},{"line_number":186,"context_line":"Any traffic with these allowed ethertypes with destination or generated"},{"line_number":187,"context_line":"from local port and MAC address, will be allowed."},{"line_number":188,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"316c492d_3848450b","line":185,"range":{"start_line":185,"start_character":25,"end_line":185,"end_character":27},"updated":"2023-03-06 14:07:56.000000000","message":"s/is/it is, no?","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd239a46107309cf5b2d004d4aad8373e9b07429","unresolved":false,"context_lines":[{"line_number":182,"context_line":"ethertypes at present. This is a behavior change compared to the"},{"line_number":183,"context_line":"\"iptables_hybrid\" firewall, which only operates on IP packets and thus does"},{"line_number":184,"context_line":"not address other ethertypes. With the configuration option"},{"line_number":185,"context_line":"``permitted_ethertypes`` is possible to define a set of allowed ethertypes."},{"line_number":186,"context_line":"Any traffic with these allowed ethertypes with destination or generated"},{"line_number":187,"context_line":"from local port and MAC address, will be allowed."},{"line_number":188,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6894d7df_0b3da5cf","line":185,"range":{"start_line":185,"start_character":25,"end_line":185,"end_character":27},"in_reply_to":"316c492d_3848450b","updated":"2023-03-08 16:32:53.000000000","message":"Done","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4196550dcff26756ab3ae0076390ea25e23fcfdf","unresolved":true,"context_lines":[{"line_number":183,"context_line":"\"iptables_hybrid\" firewall, which only operates on IP packets and thus does"},{"line_number":184,"context_line":"not address other ethertypes. With the configuration option"},{"line_number":185,"context_line":"``permitted_ethertypes`` is possible to define a set of allowed ethertypes."},{"line_number":186,"context_line":"Any traffic with these allowed ethertypes with destination or generated"},{"line_number":187,"context_line":"from local port and MAC address, will be allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ce5e85a1_31278eba","line":186,"range":{"start_line":186,"start_character":42,"end_line":186,"end_character":46},"updated":"2023-03-06 23:11:39.000000000","message":"s/as the ?","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd239a46107309cf5b2d004d4aad8373e9b07429","unresolved":false,"context_lines":[{"line_number":183,"context_line":"\"iptables_hybrid\" firewall, which only operates on IP packets and thus does"},{"line_number":184,"context_line":"not address other ethertypes. With the configuration option"},{"line_number":185,"context_line":"``permitted_ethertypes`` is possible to define a set of allowed ethertypes."},{"line_number":186,"context_line":"Any traffic with these allowed ethertypes with destination or generated"},{"line_number":187,"context_line":"from local port and MAC address, will be allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b93d2fbc_25dc145e","line":186,"range":{"start_line":186,"start_character":42,"end_line":186,"end_character":46},"in_reply_to":"ce5e85a1_31278eba","updated":"2023-03-08 16:32:53.000000000","message":"no, I want to present both options: packets with destination the a local port and packets generated from a local port.","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4196550dcff26756ab3ae0076390ea25e23fcfdf","unresolved":true,"context_lines":[{"line_number":184,"context_line":"not address other ethertypes. With the configuration option"},{"line_number":185,"context_line":"``permitted_ethertypes`` is possible to define a set of allowed ethertypes."},{"line_number":186,"context_line":"Any traffic with these allowed ethertypes with destination or generated"},{"line_number":187,"context_line":"from local port and MAC address, will be allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"References"},{"line_number":190,"context_line":"~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a60cb279_185c7b82","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":10},"updated":"2023-03-06 23:11:39.000000000","message":"s/from a local","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd239a46107309cf5b2d004d4aad8373e9b07429","unresolved":false,"context_lines":[{"line_number":184,"context_line":"not address other ethertypes. With the configuration option"},{"line_number":185,"context_line":"``permitted_ethertypes`` is possible to define a set of allowed ethertypes."},{"line_number":186,"context_line":"Any traffic with these allowed ethertypes with destination or generated"},{"line_number":187,"context_line":"from local port and MAC address, will be allowed."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"References"},{"line_number":190,"context_line":"~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf41d6ce_eb92d1f2","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":10},"in_reply_to":"a60cb279_185c7b82","updated":"2023-03-08 16:32:53.000000000","message":"Done","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"49cfd989adaa188946169efda6c13da50009a1fc","unresolved":true,"context_lines":[{"line_number":1389,"context_line":"        )"},{"line_number":1390,"context_line":""},{"line_number":1391,"context_line":"        # Allow custom ethertypes"},{"line_number":1392,"context_line":"        for permitted_ethertype in self.permitted_ethertypes:"},{"line_number":1393,"context_line":"            if permitted_ethertype[:2] \u003d\u003d \u00270x\u0027:"},{"line_number":1394,"context_line":"                try:"},{"line_number":1395,"context_line":"                    hex_ethertype \u003d hex(int(permitted_ethertype, base\u003d16))"}],"source_content_type":"text/x-python","patch_set":1,"id":"088e6f55_4074f77f","line":1392,"updated":"2023-03-06 14:07:56.000000000","message":"We don\u0027t have anything to test your add?","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4196550dcff26756ab3ae0076390ea25e23fcfdf","unresolved":true,"context_lines":[{"line_number":1389,"context_line":"        )"},{"line_number":1390,"context_line":""},{"line_number":1391,"context_line":"        # Allow custom ethertypes"},{"line_number":1392,"context_line":"        for permitted_ethertype in self.permitted_ethertypes:"},{"line_number":1393,"context_line":"            if permitted_ethertype[:2] \u003d\u003d \u00270x\u0027:"},{"line_number":1394,"context_line":"                try:"},{"line_number":1395,"context_line":"                    hex_ethertype \u003d hex(int(permitted_ethertype, base\u003d16))"}],"source_content_type":"text/x-python","patch_set":1,"id":"f84c6aca_b485018d","line":1392,"in_reply_to":"088e6f55_4074f77f","updated":"2023-03-06 23:11:39.000000000","message":"+1 looks like there was never a test :(","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd239a46107309cf5b2d004d4aad8373e9b07429","unresolved":false,"context_lines":[{"line_number":1389,"context_line":"        )"},{"line_number":1390,"context_line":""},{"line_number":1391,"context_line":"        # Allow custom ethertypes"},{"line_number":1392,"context_line":"        for permitted_ethertype in self.permitted_ethertypes:"},{"line_number":1393,"context_line":"            if permitted_ethertype[:2] \u003d\u003d \u00270x\u0027:"},{"line_number":1394,"context_line":"                try:"},{"line_number":1395,"context_line":"                    hex_ethertype \u003d hex(int(permitted_ethertype, base\u003d16))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3d902632_745bff03","line":1392,"in_reply_to":"f84c6aca_b485018d","updated":"2023-03-08 16:32:53.000000000","message":"The FW code is only tested in UTs or tempest. I\u0027ll create a UT for this.","commit_id":"55b37f6e4cb5de8089922b4752f7f8bd4ccf2212"}]}