)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eb7a26d50ac3052efd1b12a053863550118c8b3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2618dc5_a8aaf01f","updated":"2023-03-09 03:18:30.000000000","message":"Based on Rodolfo\u0027s comment for opening a new bug and fixing what I found in another patch I\u0027m fine with this.","commit_id":"b9567033fc23e9288bf555eff306145ac66f260a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"de9faed89840f1c048816f4c3d9f23a92183e8d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f7fc50d_ee772a57","updated":"2023-03-08 14:22:59.000000000","message":"Nice catch, but found another issue.","commit_id":"b9567033fc23e9288bf555eff306145ac66f260a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd62e18926f080852c53fd6c5518b0a936e77183","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0535330_61d2163b","updated":"2023-03-10 20:20:20.000000000","message":"recheck tempest-integrated-networking timed out","commit_id":"b9567033fc23e9288bf555eff306145ac66f260a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1bb13158f99eebf2eda19d1cb2dd167821d388f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0ad55ac5_4d8f8821","updated":"2023-03-13 08:03:49.000000000","message":"recheck zuul","commit_id":"b9567033fc23e9288bf555eff306145ac66f260a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b8009a87e47f50398f85ad8360bf3070d114358c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d72025b3_58e17480","in_reply_to":"d2618dc5_a8aaf01f","updated":"2023-03-09 08:12:22.000000000","message":"--\u003e https://bugs.launchpad.net/neutron/+bug/2009804","commit_id":"b9567033fc23e9288bf555eff306145ac66f260a"}],"neutron/agent/ovn/extensions/qos_hwol.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"de9faed89840f1c048816f4c3d9f23a92183e8d2","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    def run(self, event, row, old):"},{"line_number":103,"context_line":"        port_id \u003d row.external_ids[ovn_const.OVN_PORT_EXT_ID_KEY]"},{"line_number":104,"context_line":"        max_kbps, min_kbps \u003d agent_ovsdb.get_port_qos(self.ovn_agent.nb_idl,"},{"line_number":105,"context_line":"                                                      port_id)"},{"line_number":106,"context_line":"        LOG.debug(self.LOG_MSG, str(row.uuid), port_id, max_kbps, event)"},{"line_number":107,"context_line":"        self.ovn_agent.qos_hwol_ext.update_egress(port_id, max_kbps, min_kbps)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fdcf4f83_97709d59","line":105,"updated":"2023-03-08 14:22:59.000000000","message":"So I took a second to look at get_port_qos() and it has a bug here as well:\n\nlsp \u003d nb_idl.lsp_get(port_id).execute(check_error\u003dTrue)\nif not lsp:\n    return {}\n\nThat will trigger a\n\nValueError: not enough values to unpack (expected 2, got 0)\n\nif it ever happens, should just return 0, 0 in that case not an empty dict","commit_id":"b9567033fc23e9288bf555eff306145ac66f260a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0f4a20d2915eb0732cc2cf9834180ae9b5da191f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    def run(self, event, row, old):"},{"line_number":103,"context_line":"        port_id \u003d row.external_ids[ovn_const.OVN_PORT_EXT_ID_KEY]"},{"line_number":104,"context_line":"        max_kbps, min_kbps \u003d agent_ovsdb.get_port_qos(self.ovn_agent.nb_idl,"},{"line_number":105,"context_line":"                                                      port_id)"},{"line_number":106,"context_line":"        LOG.debug(self.LOG_MSG, str(row.uuid), port_id, max_kbps, event)"},{"line_number":107,"context_line":"        self.ovn_agent.qos_hwol_ext.update_egress(port_id, max_kbps, min_kbps)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a441d329_c5f967b2","line":105,"in_reply_to":"fdcf4f83_97709d59","updated":"2023-03-08 18:10:47.000000000","message":"Ufffff this is a big mistake, I\u0027ll open a new bug and push a patch. I never tested this code branch in the UTs in particular because that is very strange to happen. But of course this is an error that must be solved.","commit_id":"b9567033fc23e9288bf555eff306145ac66f260a"}]}