)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"23e1707f121d840940522763fc0939dd604631ad","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for localnet_learn_fdb OVN option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In OVN 22.09, the option \"localnet_learn_fdb\" was added so that"},{"line_number":10,"context_line":"localnet ports can learn MAC addresses and store them in the FDB"},{"line_number":11,"context_line":"table. This avoids flooding issues for VMs on provider networks"},{"line_number":12,"context_line":"when port security is disabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"efde1403_826697a1","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":12},"updated":"2023-04-12 14:33:53.000000000","message":"Please, add sanity check. Examples:\n* https://review.opendev.org/c/openstack/neutron/+/874767\n* https://review.opendev.org/c/openstack/neutron/+/816376\n\n(in this case you can\u0027t check the SB/NB schema version but the OVN version)","commit_id":"d97849532cc0bc5da35099a10921225afc3e5510"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f84918ef0412502793412c743daf997af86fbb4b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for localnet_learn_fdb OVN option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In OVN 22.09, the option \"localnet_learn_fdb\" was added so that"},{"line_number":10,"context_line":"localnet ports can learn MAC addresses and store them in the FDB"},{"line_number":11,"context_line":"table. This avoids flooding issues for VMs on provider networks"},{"line_number":12,"context_line":"when port security is disabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"50c420e2_726ca564","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":12},"in_reply_to":"efde1403_826697a1","updated":"2023-04-13 09:37:09.000000000","message":"Done","commit_id":"d97849532cc0bc5da35099a10921225afc3e5510"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"49247a63fc87864160863584c7327b21411eb1cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6fa75f35_d9191c73","updated":"2023-03-17 15:48:13.000000000","message":"I think we need to mention here that the FDB table will grow depending on the provnet size.\n\nIMO we need to have a follow up patch for a task that performs short-lived connection to the Southbound DB (monitoring the FDB table) to clean all the entries periodically. Another option is a long-lived connection that does it periodically and upon a certain threshold.\n\nWhat do you think?","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2bcb3982c12a9a552dc390ce65795a199f5ad3fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c49c2c95_c60d4b22","in_reply_to":"6fa75f35_d9191c73","updated":"2023-04-12 14:35:49.000000000","message":"+1","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f84918ef0412502793412c743daf997af86fbb4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9735ff97_7b6515ba","in_reply_to":"c49c2c95_c60d4b22","updated":"2023-04-13 09:37:09.000000000","message":"Are you happy with the information on the release note about it?","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0f2b0dfaa1c0c7f2fe8a696a1cad01a85b5e66fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"359a3286_ee996195","updated":"2023-03-23 15:14:47.000000000","message":"-1 just because IMO new config option deserves for short release note. Other than that LGTM for me","commit_id":"3499232e2d5a448dae38da23818ba4245e275dce"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"12b24f475545c887651cdb98c28861923a4ae153","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3dc6f30e_254d8290","updated":"2023-03-24 09:19:38.000000000","message":"recheck neutron-functional-with-uwsgi unrelated","commit_id":"9c82dd684996cc005ef135b0c5e67e74be22b471"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f1f185ba4215a21795551611e5e92ec7109b3111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"84a95ec8_90ec7d1a","updated":"2023-04-05 08:50:22.000000000","message":"recheck neutron-tempest-plugin-ovn","commit_id":"d97849532cc0bc5da35099a10921225afc3e5510"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"28cc1073aa3f16f1ff86b8c550d5fdd57d298f4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2e4e1cea_24814dac","updated":"2023-04-21 08:23:36.000000000","message":"Nice patch","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"379855ba489af5a6e7e60150d203bcb26a6f760c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7528679d_b17f02e4","updated":"2023-04-27 07:46:11.000000000","message":"recheck neutron-fullstack-with-uwsgi unrelated errors, this is getting ridiculous...","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"4abaa391d3128f99ec1687b2d80111d662c0c350","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0e04c537_e719e8b5","updated":"2023-04-26 08:32:15.000000000","message":"recheck neutron-functional-with-uwsgi unrelated failure (QoS)","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6228343c5f346e2173580dcb5279cd677c24d248","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"eebfe13f_152022b6","updated":"2023-04-27 05:33:31.000000000","message":"recheck neutron-functional-with-uwsgi unrelated once more","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e2c2a3324afe79a9d49a4973ec8935c8094aed8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"23bf05da_a20f710d","updated":"2023-04-13 14:21:17.000000000","message":"recheck neutron-functional-with-uwsgi unrelated timeout","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f4148c828933fb77c088f97fa4f4945f50787b61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"88eeb2af_7dff1d6c","updated":"2023-04-13 12:07:45.000000000","message":"recheck neutron-ovs-grenade-dvr-multinode unrelated","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"413978521981afdf3cfa04b13374d2e9660e798f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1bcea898_dd088066","updated":"2023-04-27 10:20:50.000000000","message":"recheck neutron-ovs-grenade-multinode","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a3c75c0470fb30c816e2d14f54dd8d3321aa298a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f13f6c1f_a2f4136e","updated":"2023-04-26 14:22:50.000000000","message":"recheck neutron-ovs-tempest-dvr-ha-multinode-full POST_FAILURE","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"62490f65ac3bfad80cc4d9d4ae17c5dbc7b2b313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c94d1ff0_d5cf8f4c","updated":"2023-04-27 17:08:02.000000000","message":"recheck neutron-tempest-plugin-*","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"316597174c206cb293212ac8bfa6c969f7b649d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"50bd9f16_9ca4844e","updated":"2023-04-28 10:18:52.000000000","message":"recheck neutron-tempest-plugin-* again","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"15044c279f650c92a49e995952fba3c7f391d979","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"82bd5faa_d9f33dd6","updated":"2023-04-26 12:23:26.000000000","message":"recheck neutron-tempest-plugin-* more unrelated failures","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"418faee0286c0fa96c52d437845cc3f8e392cecc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5296282d_0019fe2a","updated":"2023-04-26 05:56:57.000000000","message":"recheck neutron-tempest-plugin-* unrelated failures","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"56f64177892efa5efcbe46dfbe98a9f738c13a37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1c95d9e3_8b04905c","updated":"2023-04-28 07:28:07.000000000","message":"recheck neutron-tempest-plugin-linuxbridge","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"71c856235ed7e7ec9f301c1da9c148776dce54c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8151786b_ab29eade","updated":"2023-04-24 05:17:22.000000000","message":"recheck neutron-tempest-plugin-ovn unrelated","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b1e909dd51eb6bb4502511f1b87c24357115ca52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"404e9fd0_7bacaedf","updated":"2023-04-25 05:29:50.000000000","message":"recheck neutron-templest-plugin-ovn unrelated","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e6a8aec6e216a209049bcdfacbdeab20d44715b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7332656c_1d546669","updated":"2023-04-25 09:22:13.000000000","message":"recheck tempest fixed","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6af484f6d5a8784eaea7b3de60cfef09c3e63a90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a5c33ea5_c2b39b64","updated":"2023-04-28 13:10:28.000000000","message":"recheck vexxhost nodes disabled","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6af484f6d5a8784eaea7b3de60cfef09c3e63a90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e91f6df4_029ad30b","in_reply_to":"7528679d_b17f02e4","updated":"2023-04-28 13:10:28.000000000","message":"Please, read the mailing list, this is a known issue","commit_id":"7dfbdf65a71b7da2865d475cd91988728f734652"}],"neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py":[{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"e18cad0b7ea0fb120f4f9e8d80fc59b20f3852de","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                       \u0027order to disable ``stateful-security-group`` API \u0027"},{"line_number":223,"context_line":"                       \u0027extension as ``allow-stateless`` keyword is only \u0027"},{"line_number":224,"context_line":"                       \u0027supported by OVN \u003e\u003d 21.06.\u0027)),"},{"line_number":225,"context_line":"    cfg.BoolOpt(\u0027localnet_learn_fdb\u0027,"},{"line_number":226,"context_line":"                default\u003dFalse,"},{"line_number":227,"context_line":"                help\u003d_(\u0027If enabled it will allow localnet ports to learn MAC \u0027"},{"line_number":228,"context_line":"                       \u0027addresses and store them in FDB SB table. This avoids \u0027"},{"line_number":229,"context_line":"                       \u0027flooding for traffic towards unknown IPs when port \u0027"},{"line_number":230,"context_line":"                       \u0027security is disabled. It requires OVN 22.09 or \u0027"},{"line_number":231,"context_line":"                       \u0027newer.\u0027)),"},{"line_number":232,"context_line":"]"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e3659d01_5fca5bbb","line":231,"range":{"start_line":225,"start_character":3,"end_line":231,"end_character":34},"updated":"2023-03-21 07:19:15.000000000","message":"As this is a global config, it will affect all provider networks. And if it is modified later it may cause OVN FDB residue. Right?","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"28cc1073aa3f16f1ff86b8c550d5fdd57d298f4f","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                       \u0027order to disable ``stateful-security-group`` API \u0027"},{"line_number":223,"context_line":"                       \u0027extension as ``allow-stateless`` keyword is only \u0027"},{"line_number":224,"context_line":"                       \u0027supported by OVN \u003e\u003d 21.06.\u0027)),"},{"line_number":225,"context_line":"    cfg.BoolOpt(\u0027localnet_learn_fdb\u0027,"},{"line_number":226,"context_line":"                default\u003dFalse,"},{"line_number":227,"context_line":"                help\u003d_(\u0027If enabled it will allow localnet ports to learn MAC \u0027"},{"line_number":228,"context_line":"                       \u0027addresses and store them in FDB SB table. This avoids \u0027"},{"line_number":229,"context_line":"                       \u0027flooding for traffic towards unknown IPs when port \u0027"},{"line_number":230,"context_line":"                       \u0027security is disabled. It requires OVN 22.09 or \u0027"},{"line_number":231,"context_line":"                       \u0027newer.\u0027)),"},{"line_number":232,"context_line":"]"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"74a40ae7_a93b851f","line":231,"range":{"start_line":225,"start_character":3,"end_line":231,"end_character":34},"in_reply_to":"66c6b640_14d32b47","updated":"2023-04-21 08:23:36.000000000","message":"Done","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0fd1c25d40c85372362359b24ed431185970a385","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                       \u0027order to disable ``stateful-security-group`` API \u0027"},{"line_number":223,"context_line":"                       \u0027extension as ``allow-stateless`` keyword is only \u0027"},{"line_number":224,"context_line":"                       \u0027supported by OVN \u003e\u003d 21.06.\u0027)),"},{"line_number":225,"context_line":"    cfg.BoolOpt(\u0027localnet_learn_fdb\u0027,"},{"line_number":226,"context_line":"                default\u003dFalse,"},{"line_number":227,"context_line":"                help\u003d_(\u0027If enabled it will allow localnet ports to learn MAC \u0027"},{"line_number":228,"context_line":"                       \u0027addresses and store them in FDB SB table. This avoids \u0027"},{"line_number":229,"context_line":"                       \u0027flooding for traffic towards unknown IPs when port \u0027"},{"line_number":230,"context_line":"                       \u0027security is disabled. It requires OVN 22.09 or \u0027"},{"line_number":231,"context_line":"                       \u0027newer.\u0027)),"},{"line_number":232,"context_line":"]"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"66c6b640_14d32b47","line":231,"range":{"start_line":225,"start_character":3,"end_line":231,"end_character":34},"in_reply_to":"e3659d01_5fca5bbb","updated":"2023-03-21 09:11:46.000000000","message":"you are right, yes!","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"ff397ed1bec663493fa4cba91d2171d7d15036cb","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                       \u0027order to disable ``stateful-security-group`` API \u0027"},{"line_number":223,"context_line":"                       \u0027extension as ``allow-stateless`` keyword is only \u0027"},{"line_number":224,"context_line":"                       \u0027supported by OVN \u003e\u003d 21.06.\u0027)),"},{"line_number":225,"context_line":"    cfg.BoolOpt(\u0027localnet_learn_fdb\u0027,"},{"line_number":226,"context_line":"                default\u003dFalse,"},{"line_number":227,"context_line":"                help\u003d_(\u0027If enabled it will allow localnet ports to learn MAC \u0027"},{"line_number":228,"context_line":"                       \u0027addresses and store them in FDB SB table. This avoids \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"c5b0c416_0ea19baf","line":225,"range":{"start_line":225,"start_character":17,"end_line":225,"end_character":35},"updated":"2023-03-22 10:08:46.000000000","message":"Would it be better to use the constant LSP_OPTIONS_LOCALNET_LEARN_FDB you created here?","commit_id":"3499232e2d5a448dae38da23818ba4245e275dce"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1ce26958d7343675b3613a40dea0a7425cdee921","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                       \u0027order to disable ``stateful-security-group`` API \u0027"},{"line_number":223,"context_line":"                       \u0027extension as ``allow-stateless`` keyword is only \u0027"},{"line_number":224,"context_line":"                       \u0027supported by OVN \u003e\u003d 21.06.\u0027)),"},{"line_number":225,"context_line":"    cfg.BoolOpt(\u0027localnet_learn_fdb\u0027,"},{"line_number":226,"context_line":"                default\u003dFalse,"},{"line_number":227,"context_line":"                help\u003d_(\u0027If enabled it will allow localnet ports to learn MAC \u0027"},{"line_number":228,"context_line":"                       \u0027addresses and store them in FDB SB table. This avoids \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fb9ac8ef_0d6a35e6","line":225,"range":{"start_line":225,"start_character":17,"end_line":225,"end_character":35},"in_reply_to":"999c2ef6_95bd8844","updated":"2023-03-31 05:29:22.000000000","message":"Done","commit_id":"3499232e2d5a448dae38da23818ba4245e275dce"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"15895093de70d7060e6ada71b796b3a5b8589129","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                       \u0027order to disable ``stateful-security-group`` API \u0027"},{"line_number":223,"context_line":"                       \u0027extension as ``allow-stateless`` keyword is only \u0027"},{"line_number":224,"context_line":"                       \u0027supported by OVN \u003e\u003d 21.06.\u0027)),"},{"line_number":225,"context_line":"    cfg.BoolOpt(\u0027localnet_learn_fdb\u0027,"},{"line_number":226,"context_line":"                default\u003dFalse,"},{"line_number":227,"context_line":"                help\u003d_(\u0027If enabled it will allow localnet ports to learn MAC \u0027"},{"line_number":228,"context_line":"                       \u0027addresses and store them in FDB SB table. This avoids \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"999c2ef6_95bd8844","line":225,"range":{"start_line":225,"start_character":17,"end_line":225,"end_character":35},"in_reply_to":"b9ba1b0f_93b14e0e","updated":"2023-03-22 11:04:09.000000000","message":"Oh, you are right, thanks for pointing it out. I\u0027m not sure of the reason why they are not used here, though.","commit_id":"3499232e2d5a448dae38da23818ba4245e275dce"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1d400c54d43a3c798c5525d6e3eec480570c3037","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                       \u0027order to disable ``stateful-security-group`` API \u0027"},{"line_number":223,"context_line":"                       \u0027extension as ``allow-stateless`` keyword is only \u0027"},{"line_number":224,"context_line":"                       \u0027supported by OVN \u003e\u003d 21.06.\u0027)),"},{"line_number":225,"context_line":"    cfg.BoolOpt(\u0027localnet_learn_fdb\u0027,"},{"line_number":226,"context_line":"                default\u003dFalse,"},{"line_number":227,"context_line":"                help\u003d_(\u0027If enabled it will allow localnet ports to learn MAC \u0027"},{"line_number":228,"context_line":"                       \u0027addresses and store them in FDB SB table. This avoids \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"b9ba1b0f_93b14e0e","line":225,"range":{"start_line":225,"start_character":17,"end_line":225,"end_character":35},"in_reply_to":"c5b0c416_0ea19baf","updated":"2023-03-22 10:37:35.000000000","message":"why? this is the config, I have not seen any constants being used here","commit_id":"3499232e2d5a448dae38da23818ba4245e275dce"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6757b3cefa1033f727343f6298a8534f6d8c4a62","unresolved":true,"context_lines":[{"line_number":654,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":655,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":656,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":657,"context_line":"    def check_localnet_port_has_learn_fdb(self):"},{"line_number":658,"context_line":"        if not self.has_lock:"},{"line_number":659,"context_line":"            return"},{"line_number":660,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a1582026_a3f45ece","line":657,"updated":"2023-03-17 16:06:17.000000000","message":"Would be good to write UTs for this.","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0fd1c25d40c85372362359b24ed431185970a385","unresolved":true,"context_lines":[{"line_number":654,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":655,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":656,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":657,"context_line":"    def check_localnet_port_has_learn_fdb(self):"},{"line_number":658,"context_line":"        if not self.has_lock:"},{"line_number":659,"context_line":"            return"},{"line_number":660,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f96422f8_a86e122a","line":657,"in_reply_to":"a1582026_a3f45ece","updated":"2023-03-21 09:11:46.000000000","message":"indeed, I\u0027ll add then","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"fff756d9bc00117d8530ce844172e5c0459d8d74","unresolved":false,"context_lines":[{"line_number":654,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":655,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":656,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":657,"context_line":"    def check_localnet_port_has_learn_fdb(self):"},{"line_number":658,"context_line":"        if not self.has_lock:"},{"line_number":659,"context_line":"            return"},{"line_number":660,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"44a4d2d8_9e14bdae","line":657,"in_reply_to":"f96422f8_a86e122a","updated":"2023-03-21 17:46:03.000000000","message":"Done","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"49247a63fc87864160863584c7327b21411eb1cc","unresolved":true,"context_lines":[{"line_number":662,"context_line":"            \"Logical_Switch_Port\", (\"type\", \"\u003d\", ovn_const.LSP_TYPE_LOCALNET)"},{"line_number":663,"context_line":"        ).execute(check_error\u003dTrue)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"        value \u003d (\u0027true\u0027 if ovn_conf.is_learn_fdb_enabled()"},{"line_number":666,"context_line":"                 else \u0027false\u0027)"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":669,"context_line":"            for port in ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"80bc3a2e_ed85a739","line":666,"range":{"start_line":665,"start_character":0,"end_line":666,"end_character":30},"updated":"2023-03-17 15:48:13.000000000","message":"value \u003d ovn_conf.is_learn_fdb_enabled() ?\nOr use it directly?\nperhaps also s/value/fdb_enabled so that the var name has a better name?","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0fd1c25d40c85372362359b24ed431185970a385","unresolved":false,"context_lines":[{"line_number":662,"context_line":"            \"Logical_Switch_Port\", (\"type\", \"\u003d\", ovn_const.LSP_TYPE_LOCALNET)"},{"line_number":663,"context_line":"        ).execute(check_error\u003dTrue)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"        value \u003d (\u0027true\u0027 if ovn_conf.is_learn_fdb_enabled()"},{"line_number":666,"context_line":"                 else \u0027false\u0027)"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":669,"context_line":"            for port in ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dcc20b41_832b211e","line":666,"range":{"start_line":665,"start_character":0,"end_line":666,"end_character":30},"in_reply_to":"80bc3a2e_ed85a739","updated":"2023-03-21 09:11:46.000000000","message":"Done","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6757b3cefa1033f727343f6298a8534f6d8c4a62","unresolved":true,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":669,"context_line":"            for port in ports:"},{"line_number":670,"context_line":"                if value:"},{"line_number":671,"context_line":"                    fdb_opt \u003d port.options.get("},{"line_number":672,"context_line":"                        ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB)"},{"line_number":673,"context_line":"                    if not fdb_opt or fdb_opt \u003d\u003d \"false\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"b328377f_0ae14c94","line":670,"updated":"2023-03-17 16:06:17.000000000","message":"This will be evaluated always as True, you need to do:\n if value \u003d\u003d \u0027true\u0027\n\nor\n\n if ovn_conf.is_learn_fdb_enabled():","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0fd1c25d40c85372362359b24ed431185970a385","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":669,"context_line":"            for port in ports:"},{"line_number":670,"context_line":"                if value:"},{"line_number":671,"context_line":"                    fdb_opt \u003d port.options.get("},{"line_number":672,"context_line":"                        ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB)"},{"line_number":673,"context_line":"                    if not fdb_opt or fdb_opt \u003d\u003d \"false\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"181d6f37_163e0f2a","line":670,"in_reply_to":"b328377f_0ae14c94","updated":"2023-03-21 09:11:46.000000000","message":"Done","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"49247a63fc87864160863584c7327b21411eb1cc","unresolved":true,"context_lines":[{"line_number":670,"context_line":"                if value:"},{"line_number":671,"context_line":"                    fdb_opt \u003d port.options.get("},{"line_number":672,"context_line":"                        ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB)"},{"line_number":673,"context_line":"                    if not fdb_opt or fdb_opt \u003d\u003d \"false\":"},{"line_number":674,"context_line":"                        txn.add(self._nb_idl.db_set("},{"line_number":675,"context_line":"                            \u0027Logical_Switch_Port\u0027, port.name,"},{"line_number":676,"context_line":"                            (\u0027options\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d9c4d21c_34b451fc","line":673,"range":{"start_line":673,"start_character":20,"end_line":673,"end_character":56},"updated":"2023-03-17 15:48:13.000000000","message":"can we normalize it to boolean? I thought it was boolean and not a str?","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0fd1c25d40c85372362359b24ed431185970a385","unresolved":false,"context_lines":[{"line_number":670,"context_line":"                if value:"},{"line_number":671,"context_line":"                    fdb_opt \u003d port.options.get("},{"line_number":672,"context_line":"                        ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB)"},{"line_number":673,"context_line":"                    if not fdb_opt or fdb_opt \u003d\u003d \"false\":"},{"line_number":674,"context_line":"                        txn.add(self._nb_idl.db_set("},{"line_number":675,"context_line":"                            \u0027Logical_Switch_Port\u0027, port.name,"},{"line_number":676,"context_line":"                            (\u0027options\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"05d3082c_13f771c1","line":673,"range":{"start_line":673,"start_character":20,"end_line":673,"end_character":56},"in_reply_to":"d9c4d21c_34b451fc","updated":"2023-03-21 09:11:46.000000000","message":"it cannot","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6757b3cefa1033f727343f6298a8534f6d8c4a62","unresolved":true,"context_lines":[{"line_number":676,"context_line":"                            (\u0027options\u0027,"},{"line_number":677,"context_line":"                             {ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB: value})"},{"line_number":678,"context_line":"                        ))"},{"line_number":679,"context_line":"                elif port.options.get("},{"line_number":680,"context_line":"                        ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB):"},{"line_number":681,"context_line":"                    txn.add(self._nb_idl.db_set("},{"line_number":682,"context_line":"                        \u0027Logical_Switch_Port\u0027, port.name,"},{"line_number":683,"context_line":"                        (\u0027options\u0027, {"}],"source_content_type":"text/x-python","patch_set":2,"id":"14b3c14a_010af31f","line":680,"range":{"start_line":679,"start_character":21,"end_line":680,"end_character":65},"updated":"2023-03-17 16:06:17.000000000","message":"port.options.get(ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB) \u003d\u003d \u0027true\u0027:","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0fd1c25d40c85372362359b24ed431185970a385","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                            (\u0027options\u0027,"},{"line_number":677,"context_line":"                             {ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB: value})"},{"line_number":678,"context_line":"                        ))"},{"line_number":679,"context_line":"                elif port.options.get("},{"line_number":680,"context_line":"                        ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB):"},{"line_number":681,"context_line":"                    txn.add(self._nb_idl.db_set("},{"line_number":682,"context_line":"                        \u0027Logical_Switch_Port\u0027, port.name,"},{"line_number":683,"context_line":"                        (\u0027options\u0027, {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef096779_b10165f6","line":680,"range":{"start_line":679,"start_character":21,"end_line":680,"end_character":65},"in_reply_to":"14b3c14a_010af31f","updated":"2023-03-21 09:11:46.000000000","message":"Done","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"23e1707f121d840940522763fc0939dd604631ad","unresolved":true,"context_lines":[{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        raise periodics.NeverAgain()"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    # TODO(ltomasbo): Remove this in the A+4 cycle"},{"line_number":654,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":655,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":656,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"716e3d71_f4d17d86","line":653,"range":{"start_line":653,"start_character":41,"end_line":653,"end_character":42},"updated":"2023-04-12 14:33:53.000000000","message":"Bobcat cycle","commit_id":"d97849532cc0bc5da35099a10921225afc3e5510"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f84918ef0412502793412c743daf997af86fbb4b","unresolved":false,"context_lines":[{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        raise periodics.NeverAgain()"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    # TODO(ltomasbo): Remove this in the A+4 cycle"},{"line_number":654,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":655,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":656,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"6c8de9a2_5c54e2ce","line":653,"range":{"start_line":653,"start_character":41,"end_line":653,"end_character":42},"in_reply_to":"716e3d71_f4d17d86","updated":"2023-04-13 09:37:09.000000000","message":"Done","commit_id":"d97849532cc0bc5da35099a10921225afc3e5510"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"23e1707f121d840940522763fc0939dd604631ad","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        raise periodics.NeverAgain()"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    # TODO(ltomasbo): Remove this in the A+4 cycle"},{"line_number":654,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":655,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":656,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":657,"context_line":"    def check_localnet_port_has_learn_fdb(self):"},{"line_number":658,"context_line":"        if not self.has_lock:"}],"source_content_type":"text/x-python","patch_set":6,"id":"cb730c56_2d7e99f6","line":655,"range":{"start_line":654,"start_character":43,"end_line":655,"end_character":61},"updated":"2023-04-12 14:33:53.000000000","message":"I have a question for all reviewers: this configuration parameter \"localnet_learn_fdb\" should affect all provnet ports. If enabled, all localnet port should have this flag enable (and in the other way around).\n\nIf in 4 cycles we remove this method, once we restart the Neutron server, the localnet ports will keep their configuration, regardless of the Neutron option. If we create new networks, we could have localnet ports with different configurations.\n\nIf this config option applies to all networks, we should be consistent always and execute this method always.","commit_id":"d97849532cc0bc5da35099a10921225afc3e5510"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f84918ef0412502793412c743daf997af86fbb4b","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        raise periodics.NeverAgain()"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    # TODO(ltomasbo): Remove this in the A+4 cycle"},{"line_number":654,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":655,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":656,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":657,"context_line":"    def check_localnet_port_has_learn_fdb(self):"},{"line_number":658,"context_line":"        if not self.has_lock:"}],"source_content_type":"text/x-python","patch_set":6,"id":"926a4ab7_80cc4797","line":655,"range":{"start_line":654,"start_character":43,"end_line":655,"end_character":61},"in_reply_to":"61b5c380_158a3e20","updated":"2023-04-13 09:37:09.000000000","message":"ok, so I\u0027ll remove the remove me","commit_id":"d97849532cc0bc5da35099a10921225afc3e5510"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"36ea53d1ae4497517fda9d28c256b339e74667c9","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        raise periodics.NeverAgain()"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    # TODO(ltomasbo): Remove this in the A+4 cycle"},{"line_number":654,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":655,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":656,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":657,"context_line":"    def check_localnet_port_has_learn_fdb(self):"},{"line_number":658,"context_line":"        if not self.has_lock:"}],"source_content_type":"text/x-python","patch_set":6,"id":"61b5c380_158a3e20","line":655,"range":{"start_line":654,"start_character":43,"end_line":655,"end_character":61},"in_reply_to":"cb730c56_2d7e99f6","updated":"2023-04-13 02:51:00.000000000","message":"+1,it sholud re-apply this config for all networks when neutron-server restart.","commit_id":"d97849532cc0bc5da35099a10921225afc3e5510"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"478f1fb9313aed8599e478fc0d62ee7c4e1d8de0","unresolved":true,"context_lines":[{"line_number":1864,"context_line":"                   ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS: \u0027true\u0027,"},{"line_number":1865,"context_line":"                   ovn_const.LSP_OPTIONS_MCAST_FLOOD: \u0027false\u0027,"},{"line_number":1866,"context_line":"                   ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB: ("},{"line_number":1867,"context_line":"                       ovn_conf.is_learn_fdb_enabled())}"},{"line_number":1868,"context_line":"        cmd \u003d self._nb_idl.create_lswitch_port("},{"line_number":1869,"context_line":"            lport_name\u003dutils.ovn_provnet_port_name(segment[\u0027id\u0027]),"},{"line_number":1870,"context_line":"            lswitch_name\u003dutils.ovn_name(network_id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6c0a789_7f17a12f","line":1867,"updated":"2023-03-17 16:31:31.000000000","message":"Will setting this, even to false, work on an unsupported version?","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1ce26958d7343675b3613a40dea0a7425cdee921","unresolved":false,"context_lines":[{"line_number":1864,"context_line":"                   ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS: \u0027true\u0027,"},{"line_number":1865,"context_line":"                   ovn_const.LSP_OPTIONS_MCAST_FLOOD: \u0027false\u0027,"},{"line_number":1866,"context_line":"                   ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB: ("},{"line_number":1867,"context_line":"                       ovn_conf.is_learn_fdb_enabled())}"},{"line_number":1868,"context_line":"        cmd \u003d self._nb_idl.create_lswitch_port("},{"line_number":1869,"context_line":"            lport_name\u003dutils.ovn_provnet_port_name(segment[\u0027id\u0027]),"},{"line_number":1870,"context_line":"            lswitch_name\u003dutils.ovn_name(network_id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3b6a77a_18185f8c","line":1867,"in_reply_to":"32e8072f_5bcb9b23","updated":"2023-03-31 05:29:22.000000000","message":"Done","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0fd1c25d40c85372362359b24ed431185970a385","unresolved":true,"context_lines":[{"line_number":1864,"context_line":"                   ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS: \u0027true\u0027,"},{"line_number":1865,"context_line":"                   ovn_const.LSP_OPTIONS_MCAST_FLOOD: \u0027false\u0027,"},{"line_number":1866,"context_line":"                   ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB: ("},{"line_number":1867,"context_line":"                       ovn_conf.is_learn_fdb_enabled())}"},{"line_number":1868,"context_line":"        cmd \u003d self._nb_idl.create_lswitch_port("},{"line_number":1869,"context_line":"            lport_name\u003dutils.ovn_provnet_port_name(segment[\u0027id\u0027]),"},{"line_number":1870,"context_line":"            lswitch_name\u003dutils.ovn_name(network_id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"32e8072f_5bcb9b23","line":1867,"in_reply_to":"e6c0a789_7f17a12f","updated":"2023-03-21 09:11:46.000000000","message":"in that case it should be ignored","commit_id":"8c0e78bf8c399498fc9430bfc402e16e0ce1ad05"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"ff397ed1bec663493fa4cba91d2171d7d15036cb","unresolved":true,"context_lines":[{"line_number":588,"context_line":"        nb_idl.lsp_set_options.assert_has_calls(expected_calls)"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"    def test_check_localnet_port_has_learn_fdb(self):"},{"line_number":591,"context_line":"        cfg.CONF.set_override(\u0027localnet_learn_fdb\u0027, \u0027True\u0027,"},{"line_number":592,"context_line":"                              group\u003d\u0027ovn\u0027)"},{"line_number":593,"context_line":"        nb_idl \u003d self.fake_ovn_client._nb_idl"},{"line_number":594,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"405c59b2_8db045bb","line":591,"range":{"start_line":591,"start_character":31,"end_line":591,"end_character":49},"updated":"2023-03-22 10:08:46.000000000","message":"And maybe use the constant here too?","commit_id":"3499232e2d5a448dae38da23818ba4245e275dce"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1d400c54d43a3c798c5525d6e3eec480570c3037","unresolved":true,"context_lines":[{"line_number":588,"context_line":"        nb_idl.lsp_set_options.assert_has_calls(expected_calls)"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"    def test_check_localnet_port_has_learn_fdb(self):"},{"line_number":591,"context_line":"        cfg.CONF.set_override(\u0027localnet_learn_fdb\u0027, \u0027True\u0027,"},{"line_number":592,"context_line":"                              group\u003d\u0027ovn\u0027)"},{"line_number":593,"context_line":"        nb_idl \u003d self.fake_ovn_client._nb_idl"},{"line_number":594,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f261aca_12fc4e43","line":591,"range":{"start_line":591,"start_character":31,"end_line":591,"end_character":49},"in_reply_to":"405c59b2_8db045bb","updated":"2023-03-22 10:37:35.000000000","message":"ditto","commit_id":"3499232e2d5a448dae38da23818ba4245e275dce"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1ce26958d7343675b3613a40dea0a7425cdee921","unresolved":false,"context_lines":[{"line_number":588,"context_line":"        nb_idl.lsp_set_options.assert_has_calls(expected_calls)"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"    def test_check_localnet_port_has_learn_fdb(self):"},{"line_number":591,"context_line":"        cfg.CONF.set_override(\u0027localnet_learn_fdb\u0027, \u0027True\u0027,"},{"line_number":592,"context_line":"                              group\u003d\u0027ovn\u0027)"},{"line_number":593,"context_line":"        nb_idl \u003d self.fake_ovn_client._nb_idl"},{"line_number":594,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"244a69ef_f72391cc","line":591,"range":{"start_line":591,"start_character":31,"end_line":591,"end_character":49},"in_reply_to":"7f261aca_12fc4e43","updated":"2023-03-31 05:29:22.000000000","message":"Done","commit_id":"3499232e2d5a448dae38da23818ba4245e275dce"}],"releasenotes/notes/localnet-learn-fdb-22469280b49701fc.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"23e1707f121d840940522763fc0939dd604631ad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In OVN 22.09 the option \"localnet_learn_fdb\" was added, enabling localnet"},{"line_number":5,"context_line":"    ports to learn MAC addresses and store them at the FDB table."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fdbb8e9b_321551fe","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"updated":"2023-04-12 14:33:53.000000000","message":"+1, thanks for this reno","commit_id":"d97849532cc0bc5da35099a10921225afc3e5510"}]}