)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"096446ff2c2e4f27c15f13d4d5d454006006a1f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9124daf_444b66b9","updated":"2023-03-17 10:32:22.000000000","message":"+1 for a reno note.\nWon\u0027t it be an issue for a deployment that has several addresses on a node? Currently it fails explicitly if \u0027local_ip\u0027 is not set, with default it may lead to non-obvious misconfiguration. ","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"495b052a6fc187ea28ed398ddb74203db8acbe04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c4e12bb_9e6c6361","updated":"2023-03-17 14:07:20.000000000","message":"From what I could tell, most installers and users set local_ip, as does devstack. Can you explain the issue with k8s more as this has been un-set for many years (forever?) and not caused a problem.","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"76a334c2c822724ebf5b3442d2b9f01df84f9d49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf2bfb1e_6b842bb7","updated":"2023-03-23 15:10:47.000000000","message":"One comment, maybe not really 100% related to that patch but more to rationale behind this change. If You want to run neutron-ovs-agent in pod, and You will make tunnels using kubernetes service network, what if Your pod will got different IP address at some point? You will need to change all tunnels in Your cluster? Wouldn\u0027t be better for You to set some known IP addresses for pods maybe?","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"047fffd28fb1ac940103eb636ff554a4a52705e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50fc00c9_52d19e91","updated":"2023-03-17 09:37:39.000000000","message":"Sounds reasonable, could you add reno note for that? Deployers may want to know such update.","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ddc2028724a0ffc7c93b9a1786945753262589c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa90e100_252de1bd","updated":"2023-03-23 10:33:27.000000000","message":"so the goal is to merge this one with my_ip: https://review.opendev.org/c/openstack/neutron/+/878070 am I right?","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"907596e88cd18ebbdd3a87d2c937d314024e8044","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"523e361b_6c05b22e","in_reply_to":"1a01ca54_4de10ba3","updated":"2023-03-17 14:36:52.000000000","message":"I\u0027m not a fan of this since things like ovsdb_connection default to 127.0.0.1 so they\u0027re not exposed externally by default. Changing to another IP would typically mean you have a dedicated management network that is being used instead.","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"5caf867e84ce92d78b0831c4c38895790ecc8242","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a01ca54_4de10ba3","in_reply_to":"20653438_33023530","updated":"2023-03-17 13:55:29.000000000","message":"And this could eventually be used somewhere else, like in ovsdb_connection and stuff like this","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"24596cbddd7d020419dde92cb47888aa3f75f132","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef7d72cf_7fe93874","in_reply_to":"4c4e12bb_9e6c6361","updated":"2023-03-17 15:08:18.000000000","message":"k8s manifests are not templates. So when creating a config file, I need to set a local_ip. But I will know the pod IP only when the it will be up.\n\nAs the pod itself know its own IP it\u0027s much more easier to use is from inside.\n\nThat\u0027s the idea behind this.","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"24596cbddd7d020419dde92cb47888aa3f75f132","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"71fda5c8_1817c913","in_reply_to":"523e361b_6c05b22e","updated":"2023-03-17 15:08:18.000000000","message":"I am not saying I want to change the default ovsdb_connection, I am just saying that introducing \"my_ip\" would also be useful if someone wants to change it, like local_ip.\n\n\nFor the record, I am deploying ovsdb and ovs-vswitchd in containers. I am trying to rely on sockets when possible, e.g.:\novsdb_connection \u003d unix:/var/run/openvswitch/db.sock\n\nBut, when agent is connecting to vswitchd, it\u0027s also expecting the switch to communicate back to neutron on a TCP socket (of_listen_address/of_listen_port).\nI was not able to switch this to a socket (neutron agent seems to listen on TCP socket, not on unix, am I missing something?).\n\nSo, because I am running in different containers, I need to set of_listen_address to something else than 127.0.0.1, but that\u0027s only because of my design.","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"3c2add75be464f015843701e1acbda8e9111d66d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f2bf47bd_cc457a10","in_reply_to":"5d40e0bc_2c0ae24d","updated":"2023-03-21 11:57:46.000000000","message":"Here is another change that describe how my_ip could be implemented:\nhttps://review.opendev.org/c/openstack/neutron/+/878070\n\nI dont think we should have another option for this, my_ip sounds the perfect plan to me for this situation","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"89de932f66ce64353f33480df8f2ddfb6f2053a0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"865744e3_1d7e73fb","in_reply_to":"71fda5c8_1817c913","updated":"2023-03-17 15:52:33.000000000","message":"Can you please point to where in nova this \"my_ip\" in the \"DEFAULT\" section is used? Not sure I got the idea","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c29fc8abdd8d3b169a936bdb9a008fe813a957c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d40e0bc_2c0ae24d","in_reply_to":"7f6959c9_22af4afe","updated":"2023-03-21 09:37:11.000000000","message":"still not sure how introducing \"my_ip\" would address my initial concern. Maybe we could add something like \"local_ip_use_default\" False by default?","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"ce875c840b0355ff75a0cad125845652380f18c2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9e2d9ea7_0548c21f","in_reply_to":"865744e3_1d7e73fb","updated":"2023-03-17 16:26:46.000000000","message":"Yes, it\u0027s here:\nhttps://github.com/openstack/nova/blob/master/nova/conf/netconf.py#L25","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"c987edc7ce86c7760b8d14bde41f97fc2df52ee1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f6959c9_22af4afe","in_reply_to":"9e2d9ea7_0548c21f","updated":"2023-03-17 19:48:59.000000000","message":"Take a look at server_proxyclient_address on that page: \nhttps://docs.openstack.org/nova/latest/install/compute-install-ubuntu.html","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"576154c935d52a8e8945eb81f9b7f9d7abd8e797","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"20653438_33023530","in_reply_to":"a9124daf_444b66b9","updated":"2023-03-17 13:54:53.000000000","message":"One other approach could be to add a \"my_ip\" in the \"DEFAULT\" section (like nova do).\nThis would then allow us to use \"$my_ip\" as value for local_ip.\nThis one would not need a reno as it will not change the local_ip value\n\nBoth ideas sounds good to me, which one do you prefer?","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"e2aed5e96fe489a0868697d82eb975f97e1dccce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0730279_813ba2b7","in_reply_to":"aa90e100_252de1bd","updated":"2023-03-23 11:28:31.000000000","message":"yes, and I will abandon this one","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"e57c90585c4d8cd3ef636ab4acee42502d86a3e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77ae3497_799badcb","in_reply_to":"f00296c3_768d352f","updated":"2023-03-21 16:51:21.000000000","message":"Yes 😊\nif we go with the \"my_ip\" solution, the idea is to abandon this change and keep local_ip undef.\nThis way, the current behavior is not changed, but this would allow operator to set:\nlocal_ip\u003d$my_ip\n\nAnd this would solve my initial issue.","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"26fb0548df8640eab826041f59327da67e114e3f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f00296c3_768d352f","in_reply_to":"f2bf47bd_cc457a10","updated":"2023-03-21 13:01:50.000000000","message":"So is the proposal to use \"my_ip\" whenever \"local_ip\" is not set?","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"}],"neutron/conf/plugins/ml2/drivers/ovs_conf.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"76a334c2c822724ebf5b3442d2b9f01df84f9d49","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    cfg.StrOpt(\u0027tun_peer_patch_port\u0027, default\u003d\u0027patch-int\u0027,"},{"line_number":43,"context_line":"               help\u003d_(\"Peer patch port in tunnel bridge for integration \""},{"line_number":44,"context_line":"                      \"bridge.\")),"},{"line_number":45,"context_line":"    cfg.IPOpt(\u0027local_ip\u0027, default\u003dnetutils.get_my_ipv4(),"},{"line_number":46,"context_line":"              help\u003d_(\"IP address of local overlay (tunnel) network endpoint. \""},{"line_number":47,"context_line":"                     \"Use either an IPv4 or IPv6 address that resides on one \""},{"line_number":48,"context_line":"                     \"of the host network interfaces. The IP version of this \""}],"source_content_type":"text/x-python","patch_set":1,"id":"477c9a87_f2c2a113","line":45,"updated":"2023-03-23 15:10:47.000000000","message":"maybe instead of setting it here as default value, You could make it empty by default and then in neutron-ovs-agent code in https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L272 do something like:\n\n    self.local_ip \u003d ovs_conf.local_ip or netutils.get_my_ipv4()","commit_id":"50e3eb7970dbef7fb44b2402c2639312ecff2325"}]}