)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"15ea4ff73236c914c0072aaadd4e97c931fa5ff0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"gateway."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This new option is not used for now in any neutron code, but may be used by"},{"line_number":14,"context_line":"operators to configure other options (like local_ip, ovsdb_connection, etc."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@gmail.com\u003e"},{"line_number":17,"context_line":"Change-Id: Idee31f2c4fed992ed63a51bfbb8d6e2ebb54cf5d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"31aad4d3_171b83e9","line":14,"updated":"2023-03-23 14:26:44.000000000","message":"Please fix all the line-wrapping in this message.","commit_id":"7cb238ee36a9ee86c869495239f075236977aab7"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"3afe8e026e34e4f9ef17a99fb2cb23f27c51a9bc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"gateway."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This new option is not used for now in any neutron code, but may be used by"},{"line_number":14,"context_line":"operators to configure other options (like local_ip, ovsdb_connection, etc."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@gmail.com\u003e"},{"line_number":17,"context_line":"Change-Id: Idee31f2c4fed992ed63a51bfbb8d6e2ebb54cf5d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f54ff65a_250a150a","line":14,"in_reply_to":"31aad4d3_171b83e9","updated":"2023-05-04 09:07:50.000000000","message":"my bad, vim config fixed 😊","commit_id":"7cb238ee36a9ee86c869495239f075236977aab7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4835fcf75479510563da860685b3cf9263032c3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"864c6f3d_ccec0543","updated":"2023-03-22 14:20:40.000000000","message":"could you also add doc page like Nova has:\nhttps://docs.openstack.org/nova/latest/install/compute-install-ubuntu.html ?","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"739723fc94a40ffd42918f2b8b74b7824685eb07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff711652_03e36608","in_reply_to":"864c6f3d_ccec0543","updated":"2023-03-23 14:16:00.000000000","message":"done","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"15ea4ff73236c914c0072aaadd4e97c931fa5ff0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5d19737c_54de3282","updated":"2023-03-23 14:26:44.000000000","message":"I would just stick to defining the new option in this patch and nothing else.\n\nAlso, just a note that you don\u0027t need to add so many reviewers, the active cores will get an email on initial submission.","commit_id":"7cb238ee36a9ee86c869495239f075236977aab7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"29bf9c03e2cd2a3f33adb9b4d25380f0edb0d596","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4dfac314_b6427ec3","updated":"2023-03-23 15:06:09.000000000","message":"Not directly related, but IMO the suse installation guide should be dropped rather than updated.","commit_id":"7cb238ee36a9ee86c869495239f075236977aab7"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"3afe8e026e34e4f9ef17a99fb2cb23f27c51a9bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2a2b79c3_7bc67cb0","in_reply_to":"5d19737c_54de3282","updated":"2023-05-04 09:07:50.000000000","message":"ack","commit_id":"7cb238ee36a9ee86c869495239f075236977aab7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6bbf7533ee575c9097c5a92029c98ec9c733bafb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0aa8dde1_e9c926d4","updated":"2023-05-05 08:17:32.000000000","message":"I remember we discussed it on one of the meetings, but can\u0027t find it, could you reference it to the commit message?","commit_id":"adaba13bdb9da1f49dcdb1bb7dcfa7c04c556922"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"07a7d2a90b236327bef723cf3ea69b5468bdf9de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"43feec18_48545d61","updated":"2023-06-06 13:02:53.000000000","message":"recheck","commit_id":"adaba13bdb9da1f49dcdb1bb7dcfa7c04c556922"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3143dbbc3cd1fc26dab4d1196a286abbd954f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fd7e3360_0a3d91e8","updated":"2023-06-07 17:43:24.000000000","message":"recheck ovn rally failure\n\nI didn\u0027t see any mention of this change in the meeting notes, unless it was at the drivers meeting?\n\nhttps://meetings.opendev.org/meetings/networking/2023/?C\u003dM;O\u003dD","commit_id":"adaba13bdb9da1f49dcdb1bb7dcfa7c04c556922"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"07a7d2a90b236327bef723cf3ea69b5468bdf9de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"97ee09b5_b729450a","in_reply_to":"0aa8dde1_e9c926d4","updated":"2023-06-06 13:02:53.000000000","message":"I dont remember about this meeting, I am not even sure I was in 😞","commit_id":"adaba13bdb9da1f49dcdb1bb7dcfa7c04c556922"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bc78a77083a73ade4d486c74adcfe4aee64a27d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cba54824_f691b86d","in_reply_to":"fd7e3360_0a3d91e8","updated":"2023-06-08 08:56:09.000000000","message":"Perhaps I mess this topic with something else, I cant find it in any of the meeting logs","commit_id":"adaba13bdb9da1f49dcdb1bb7dcfa7c04c556922"}],"doc/source/install/compute-install-option2-obs.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"15ea4ff73236c914c0072aaadd4e97c931fa5ff0","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"       [DEFAULT]"},{"line_number":20,"context_line":"       # ..."},{"line_number":21,"context_line":"       my_ip \u003d OVERLAY_INTERFACE_IP_ADDRESS"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    .. end"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"438139f6_09d560c6","line":21,"updated":"2023-03-23 14:26:44.000000000","message":"I don\u0027t think this is correct. my_ip is just an IP address on the host, it might not be the IP we want to use for the overlay - the overlay might be on a jumbo-frame interface so the MTU in a guest is 1500 and not 14XX.","commit_id":"7cb238ee36a9ee86c869495239f075236977aab7"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"3afe8e026e34e4f9ef17a99fb2cb23f27c51a9bc","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"       [DEFAULT]"},{"line_number":20,"context_line":"       # ..."},{"line_number":21,"context_line":"       my_ip \u003d OVERLAY_INTERFACE_IP_ADDRESS"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    .. end"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff60a024_88c3d126","line":21,"in_reply_to":"438139f6_09d560c6","updated":"2023-05-04 09:07:50.000000000","message":"ack, so I will remove all the doc change.\nThis option exists, is referenced in config reference only, but not used by default.","commit_id":"7cb238ee36a9ee86c869495239f075236977aab7"}],"neutron/conf/common.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0810ee95ff08257f68cf1d9a8a984e6a968ab1dc","unresolved":true,"context_lines":[{"line_number":157,"context_line":"               \u0027management network.\u0027"},{"line_number":158,"context_line":"               \u0027Possible values:\u0027"},{"line_number":159,"context_line":"               \u0027* String with valid IP address. Default is IPv4 address of \u0027"},{"line_number":160,"context_line":"               \u0027this host.\u0027)),"},{"line_number":161,"context_line":"]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"f54695d0_f6a3f28c","line":160,"updated":"2023-03-21 13:43:55.000000000","message":"I know I\u0027m being pedantic, but reading the get_my_ipv4() code we can\u0027t assume it\u0027s on the management network, it\u0027s simply going to be an IP that can reach the default gateway. The release note actually uses \"external network\". But it looks like this is just a copy/paste from Nova. Looking at other services that define it they use something more generic:\n\n\u0027IP address of this host.\u0027\n\nI like being specific so I\u0027d put:\n\n\u0027IPv4 address of this host. If no address is provided and one cannot \u0027\n\u0027be determined, 127.0.0.1 will be used.\u0027","commit_id":"8a5ab9c738e4bb8edd5a248cdc75c52b69918783"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"ca6e75fc515c789cc5a429864569eae0f961e559","unresolved":false,"context_lines":[{"line_number":157,"context_line":"               \u0027management network.\u0027"},{"line_number":158,"context_line":"               \u0027Possible values:\u0027"},{"line_number":159,"context_line":"               \u0027* String with valid IP address. Default is IPv4 address of \u0027"},{"line_number":160,"context_line":"               \u0027this host.\u0027)),"},{"line_number":161,"context_line":"]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"b60a624e_45bf02f6","line":160,"in_reply_to":"a81fc920_9c6c2abb","updated":"2023-03-21 15:42:32.000000000","message":"Done","commit_id":"8a5ab9c738e4bb8edd5a248cdc75c52b69918783"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"ea3e1884e6303a650037ac8dd59e0f5e58db6aae","unresolved":true,"context_lines":[{"line_number":157,"context_line":"               \u0027management network.\u0027"},{"line_number":158,"context_line":"               \u0027Possible values:\u0027"},{"line_number":159,"context_line":"               \u0027* String with valid IP address. Default is IPv4 address of \u0027"},{"line_number":160,"context_line":"               \u0027this host.\u0027)),"},{"line_number":161,"context_line":"]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"a81fc920_9c6c2abb","line":160,"in_reply_to":"f54695d0_f6a3f28c","updated":"2023-03-21 15:34:29.000000000","message":"ack, it sounds clearer, will do this way","commit_id":"8a5ab9c738e4bb8edd5a248cdc75c52b69918783"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"43ebe5fbbe335efaf0b400fcbd7e1d92c2131d9c","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    cfg.StrOpt(\u0027my_ip\u0027, default\u003dnetutils.get_my_ipv4(),"},{"line_number":156,"context_line":"               help\u003d_(\u0027IPv4 address of this host. If no address is provided, \u0027"},{"line_number":157,"context_line":"                      \u0027and one \u0027"},{"line_number":158,"context_line":"                      \u0027IPv4 address of this host. If no address is provided \u0027"},{"line_number":159,"context_line":"                      \u0027and one cannot be determined, 127.0.0.1 will be \u0027"},{"line_number":160,"context_line":"                      \u0027used.\u0027)),"},{"line_number":161,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"4d73280c_074d6260","line":158,"updated":"2023-03-21 23:49:18.000000000","message":"two duplicate lines above","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"6eeb037227e585d929434ff86fed46d860b09a3e","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    cfg.StrOpt(\u0027my_ip\u0027, default\u003dnetutils.get_my_ipv4(),"},{"line_number":156,"context_line":"               help\u003d_(\u0027IPv4 address of this host. If no address is provided, \u0027"},{"line_number":157,"context_line":"                      \u0027and one \u0027"},{"line_number":158,"context_line":"                      \u0027IPv4 address of this host. If no address is provided \u0027"},{"line_number":159,"context_line":"                      \u0027and one cannot be determined, 127.0.0.1 will be \u0027"},{"line_number":160,"context_line":"                      \u0027used.\u0027)),"},{"line_number":161,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bcccbc64_88a11089","line":158,"in_reply_to":"4d73280c_074d6260","updated":"2023-03-23 14:09:33.000000000","message":"damn, I should sleep during the night instead of writing neutron stuff :(","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"29bf9c03e2cd2a3f33adb9b4d25380f0edb0d596","unresolved":true,"context_lines":[{"line_number":153,"context_line":"                       \u00273. Network scheduling mechanism \u0027"},{"line_number":154,"context_line":"                       \u00274. DHCP RPC/notification\u0027)),"},{"line_number":155,"context_line":"    cfg.StrOpt(\u0027my_ip\u0027, default\u003dnetutils.get_my_ipv4(),"},{"line_number":156,"context_line":"               help\u003d_(\u0027IPv4 address of this host. If no address is provided \u0027"},{"line_number":157,"context_line":"                      \u0027and one cannot be determined, 127.0.0.1 will be \u0027"},{"line_number":158,"context_line":"                      \u0027used.\u0027)),"},{"line_number":159,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5283b553_06d4a7c5","line":156,"updated":"2023-03-23 15:06:09.000000000","message":"Why does this need to be IPv4? In 2023 IPv6 shouldn\u0027t be second class citizen anymore.","commit_id":"7cb238ee36a9ee86c869495239f075236977aab7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5b608b26d923e33f98986fda12f0d58f2819331e","unresolved":true,"context_lines":[{"line_number":153,"context_line":"                       \u00273. Network scheduling mechanism \u0027"},{"line_number":154,"context_line":"                       \u00274. DHCP RPC/notification\u0027)),"},{"line_number":155,"context_line":"    cfg.StrOpt(\u0027my_ip\u0027, default\u003dnetutils.get_my_ipv4(),"},{"line_number":156,"context_line":"               help\u003d_(\u0027IPv4 address of this host. If no address is provided \u0027"},{"line_number":157,"context_line":"                      \u0027and one cannot be determined, 127.0.0.1 will be \u0027"},{"line_number":158,"context_line":"                      \u0027used.\u0027)),"},{"line_number":159,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ad4d9036_b6190306","line":156,"in_reply_to":"5283b553_06d4a7c5","updated":"2023-03-23 15:08:23.000000000","message":"See https://review.opendev.org/c/openstack/oslo.utils/+/878078 😊","commit_id":"7cb238ee36a9ee86c869495239f075236977aab7"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"3afe8e026e34e4f9ef17a99fb2cb23f27c51a9bc","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                       \u00273. Network scheduling mechanism \u0027"},{"line_number":154,"context_line":"                       \u00274. DHCP RPC/notification\u0027)),"},{"line_number":155,"context_line":"    cfg.StrOpt(\u0027my_ip\u0027, default\u003dnetutils.get_my_ipv4(),"},{"line_number":156,"context_line":"               help\u003d_(\u0027IPv4 address of this host. If no address is provided \u0027"},{"line_number":157,"context_line":"                      \u0027and one cannot be determined, 127.0.0.1 will be \u0027"},{"line_number":158,"context_line":"                      \u0027used.\u0027)),"},{"line_number":159,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1de28bb2_577de381","line":156,"in_reply_to":"ad4d9036_b6190306","updated":"2023-05-04 09:07:50.000000000","message":"Done","commit_id":"7cb238ee36a9ee86c869495239f075236977aab7"}],"releasenotes/notes/new-my-ip-config-b8efeb05dd50cfd6.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0810ee95ff08257f68cf1d9a8a984e6a968ab1dc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new config option in DEFAULT section named my_ip."},{"line_number":5,"context_line":"    This new config option will be set by default to the local IPv4 used by"},{"line_number":6,"context_line":"    system to access external network (the one used for contacting default"},{"line_number":7,"context_line":"    gateway)."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a9bb78a5_6d85c4e1","line":4,"range":{"start_line":4,"start_character":53,"end_line":4,"end_character":58},"updated":"2023-03-21 13:43:55.000000000","message":"s/``my_ip``\n\nto make it bold","commit_id":"8a5ab9c738e4bb8edd5a248cdc75c52b69918783"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"ca6e75fc515c789cc5a429864569eae0f961e559","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new config option in DEFAULT section named my_ip."},{"line_number":5,"context_line":"    This new config option will be set by default to the local IPv4 used by"},{"line_number":6,"context_line":"    system to access external network (the one used for contacting default"},{"line_number":7,"context_line":"    gateway)."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"38b7a777_bab071bd","line":4,"range":{"start_line":4,"start_character":53,"end_line":4,"end_character":58},"in_reply_to":"a9bb78a5_6d85c4e1","updated":"2023-03-21 15:42:32.000000000","message":"Done","commit_id":"8a5ab9c738e4bb8edd5a248cdc75c52b69918783"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"43ebe5fbbe335efaf0b400fcbd7e1d92c2131d9c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new config option in DEFAULT section named `my_ip`."},{"line_number":5,"context_line":"    This new config option will be set by default to the local IPv4 used by"},{"line_number":6,"context_line":"    system to access external network (the one used for contacting default"},{"line_number":7,"context_line":"    gateway)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d9eb0258_2990b8f8","line":4,"range":{"start_line":4,"start_character":54,"end_line":4,"end_character":59},"updated":"2023-03-21 23:49:18.000000000","message":"need double `` around this","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"6eeb037227e585d929434ff86fed46d860b09a3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new config option in DEFAULT section named `my_ip`."},{"line_number":5,"context_line":"    This new config option will be set by default to the local IPv4 used by"},{"line_number":6,"context_line":"    system to access external network (the one used for contacting default"},{"line_number":7,"context_line":"    gateway)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"31444984_b19907df","line":4,"range":{"start_line":4,"start_character":54,"end_line":4,"end_character":59},"in_reply_to":"d9eb0258_2990b8f8","updated":"2023-03-23 14:09:33.000000000","message":"Done","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"43ebe5fbbe335efaf0b400fcbd7e1d92c2131d9c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Add a new config option in DEFAULT section named `my_ip`."},{"line_number":5,"context_line":"    This new config option will be set by default to the local IPv4 used by"},{"line_number":6,"context_line":"    system to access external network (the one used for contacting default"},{"line_number":7,"context_line":"    gateway)."},{"line_number":8,"context_line":"    This new setting might be useful for operators that need to configure this IP"},{"line_number":9,"context_line":"    in other part of config (like OVS/local_ip) without relying on any external"},{"line_number":10,"context_line":"    templating system."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"596ba5c3_812e8579","line":7,"updated":"2023-03-21 23:49:18.000000000","message":"This new config option will be set by default to the local IPv4 address\nconfigured to reach the default gateway.","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"6eeb037227e585d929434ff86fed46d860b09a3e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add a new config option in DEFAULT section named `my_ip`."},{"line_number":5,"context_line":"    This new config option will be set by default to the local IPv4 used by"},{"line_number":6,"context_line":"    system to access external network (the one used for contacting default"},{"line_number":7,"context_line":"    gateway)."},{"line_number":8,"context_line":"    This new setting might be useful for operators that need to configure this IP"},{"line_number":9,"context_line":"    in other part of config (like OVS/local_ip) without relying on any external"},{"line_number":10,"context_line":"    templating system."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3d8fbbc3_d983d9f1","line":7,"in_reply_to":"596ba5c3_812e8579","updated":"2023-03-23 14:09:33.000000000","message":"Done","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"43ebe5fbbe335efaf0b400fcbd7e1d92c2131d9c","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    system to access external network (the one used for contacting default"},{"line_number":7,"context_line":"    gateway)."},{"line_number":8,"context_line":"    This new setting might be useful for operators that need to configure this IP"},{"line_number":9,"context_line":"    in other part of config (like OVS/local_ip) without relying on any external"},{"line_number":10,"context_line":"    templating system."},{"line_number":11,"context_line":"    This mechanism is already available in nova and has been transposed in"},{"line_number":12,"context_line":"    neutron."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b8370325_bd5fe92c","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":27},"updated":"2023-03-21 23:49:18.000000000","message":"s/another part of their config ?","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"6eeb037227e585d929434ff86fed46d860b09a3e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    system to access external network (the one used for contacting default"},{"line_number":7,"context_line":"    gateway)."},{"line_number":8,"context_line":"    This new setting might be useful for operators that need to configure this IP"},{"line_number":9,"context_line":"    in other part of config (like OVS/local_ip) without relying on any external"},{"line_number":10,"context_line":"    templating system."},{"line_number":11,"context_line":"    This mechanism is already available in nova and has been transposed in"},{"line_number":12,"context_line":"    neutron."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0f43811b_ed3d8b8b","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":27},"in_reply_to":"b8370325_bd5fe92c","updated":"2023-03-23 14:09:33.000000000","message":"Done","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"43ebe5fbbe335efaf0b400fcbd7e1d92c2131d9c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    in other part of config (like OVS/local_ip) without relying on any external"},{"line_number":10,"context_line":"    templating system."},{"line_number":11,"context_line":"    This mechanism is already available in nova and has been transposed in"},{"line_number":12,"context_line":"    neutron."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"51cc6e8a_a0203077","line":12,"updated":"2023-03-21 23:49:18.000000000","message":"Nova and Neutron should be capitalized, although I\u0027m not sure we even need this sentence.","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"6eeb037227e585d929434ff86fed46d860b09a3e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    in other part of config (like OVS/local_ip) without relying on any external"},{"line_number":10,"context_line":"    templating system."},{"line_number":11,"context_line":"    This mechanism is already available in nova and has been transposed in"},{"line_number":12,"context_line":"    neutron."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"622b7e6d_829eaad5","line":12,"in_reply_to":"51cc6e8a_a0203077","updated":"2023-03-23 14:09:33.000000000","message":"Ack","commit_id":"978e294069e50a70c3d73133cfa7ae57305e3068"}]}