)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30812,"name":"Daniel Hill","email":"daniel.hill@canonical.com","username":"hillpd"},"change_message_id":"fab1536ff99f2549e54ea8d7b90d9298aefbdf9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a929ed94_41519388","updated":"2023-03-22 20:46:42.000000000","message":"Two minor comments; everything else looks good.","commit_id":"6b430df936e6c3b6a141ffbf02e21c39b94645b2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"66da5f991cbaeb5782e680e4b459435ffcea4d5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"371d56a4_2d119643","updated":"2023-03-27 17:52:42.000000000","message":"Thanks, it is really good idea to check these time-to-time","commit_id":"831ac3152dc3c839d0abb6d08af61d411920ce78"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"daf7080d3a045766c5b52f517ca2ceaf3d20af34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"71d3a8a1_5c1c4123","updated":"2023-03-27 17:52:08.000000000","message":"recheck\nrally timeout \u0026 fullstack failure is not related","commit_id":"831ac3152dc3c839d0abb6d08af61d411920ce78"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"379e3cff13ef1fcb2988795dfa4f9aa4e5c07373","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0dd0d09_00e2759c","updated":"2023-04-03 14:30:42.000000000","message":"recheck bug 2012510","commit_id":"831ac3152dc3c839d0abb6d08af61d411920ce78"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e168e9c0938b4c792ea18f9a86580de44e54d0f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a7a42c5_172d6075","updated":"2023-04-02 13:39:37.000000000","message":"recheck rally timeout","commit_id":"831ac3152dc3c839d0abb6d08af61d411920ce78"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e98b252f1bea2c09fc5bbde47129ed046d6824eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"448a4a09_b4801a7f","updated":"2023-04-03 02:32:51.000000000","message":"recheck rally timeout","commit_id":"831ac3152dc3c839d0abb6d08af61d411920ce78"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9f9649d26fccc6a7670627e94b25ef3c044705ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"990c4ad5_b376f8d9","updated":"2023-03-24 19:09:07.000000000","message":"recheck unrelated fullstack test failure","commit_id":"831ac3152dc3c839d0abb6d08af61d411920ce78"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9fbe8ebeba8832227530549b72295d08fa54dead","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a424ad7_d8098a20","updated":"2023-03-23 21:40:38.000000000","message":"recheck unrelated functional test failure","commit_id":"831ac3152dc3c839d0abb6d08af61d411920ce78"}],"neutron/conf/agent/dhcp.py":[{"author":{"_account_id":30812,"name":"Daniel Hill","email":"daniel.hill@canonical.com","username":"hillpd"},"change_message_id":"fab1536ff99f2549e54ea8d7b90d9298aefbdf9d","unresolved":true,"context_lines":[{"line_number":74,"context_line":"               help\u003d_(\u0027Time to sleep between reloading the DHCP allocations. \u0027"},{"line_number":75,"context_line":"                      \u0027This will only be invoked if the value is not 0. \u0027"},{"line_number":76,"context_line":"                      \u0027If a network has N updates in X seconds then \u0027"},{"line_number":77,"context_line":"                      \u0027it will reload once with the port changes in X \u0027"},{"line_number":78,"context_line":"                      \u0027seconds and not N times.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"94c72abf_9e1cbebe","line":77,"range":{"start_line":77,"start_character":43,"end_line":77,"end_character":47},"updated":"2023-03-22 20:46:42.000000000","message":"Let\u0027s clarify this statement further. Here\u0027s the original commit message, which has a bit more detail:\n\"Instead of restarting the dnsmasq agent for every IP we do this in bulk. That is, if a network has N updates in X seconds then we will restart the process once with the ports configured in the X seconds and not N Times.\"\n\nI recommend changing this to: \"If a network has N updates in X seconds, it will reload once instead of N times.\"","commit_id":"6b430df936e6c3b6a141ffbf02e21c39b94645b2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"64d5ef5b3846418d348b1e6edd485cdf93262102","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               help\u003d_(\u0027Time to sleep between reloading the DHCP allocations. \u0027"},{"line_number":75,"context_line":"                      \u0027This will only be invoked if the value is not 0. \u0027"},{"line_number":76,"context_line":"                      \u0027If a network has N updates in X seconds then \u0027"},{"line_number":77,"context_line":"                      \u0027it will reload once with the port changes in X \u0027"},{"line_number":78,"context_line":"                      \u0027seconds and not N times.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"16b5b625_5f720fa0","line":77,"range":{"start_line":77,"start_character":43,"end_line":77,"end_character":47},"in_reply_to":"94c72abf_9e1cbebe","updated":"2023-03-22 22:36:08.000000000","message":"Done","commit_id":"6b430df936e6c3b6a141ffbf02e21c39b94645b2"}],"neutron/conf/quota.py":[{"author":{"_account_id":30812,"name":"Daniel Hill","email":"daniel.hill@canonical.com","username":"hillpd"},"change_message_id":"fab1536ff99f2549e54ea8d7b90d9298aefbdf9d","unresolved":true,"context_lines":[{"line_number":63,"context_line":"               help\u003d_(\u0027Default driver to use for quota checks.\u0027)),"},{"line_number":64,"context_line":"    cfg.BoolOpt(\u0027track_quota_usage\u0027,"},{"line_number":65,"context_line":"                default\u003dTrue,"},{"line_number":66,"context_line":"                help\u003d_(\u0027Keep track in the database of current resource \u0027"},{"line_number":67,"context_line":"                       \u0027quota usage. Plugins which do not leverage the \u0027"},{"line_number":68,"context_line":"                       \u0027neutron database should set this flag to False.\u0027)),"},{"line_number":69,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"b9511731_9006a98d","line":66,"range":{"start_line":66,"start_character":24,"end_line":66,"end_character":28},"updated":"2023-03-22 20:46:42.000000000","message":"The current description is awkward and lacks detail. I\u0027m concerned that it implies quota usage can be disabled when that is not how the setting is implemented.\n\nThe neutron documentation covers this pretty well:\nhttps://docs.openstack.org/neutron/latest/contributor/internals/quota.html#resource-usage-info","commit_id":"6b430df936e6c3b6a141ffbf02e21c39b94645b2"},{"author":{"_account_id":30812,"name":"Daniel Hill","email":"daniel.hill@canonical.com","username":"hillpd"},"change_message_id":"75a71bb07b3770776c7f2249a32540cfff8d46b8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               help\u003d_(\u0027Default driver to use for quota checks.\u0027)),"},{"line_number":64,"context_line":"    cfg.BoolOpt(\u0027track_quota_usage\u0027,"},{"line_number":65,"context_line":"                default\u003dTrue,"},{"line_number":66,"context_line":"                help\u003d_(\u0027Keep track in the database of current resource \u0027"},{"line_number":67,"context_line":"                       \u0027quota usage. Plugins which do not leverage the \u0027"},{"line_number":68,"context_line":"                       \u0027neutron database should set this flag to False.\u0027)),"},{"line_number":69,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"f9a303d4_bacd62e6","line":66,"range":{"start_line":66,"start_character":24,"end_line":66,"end_character":28},"in_reply_to":"2e3bd6c2_1b53757e","updated":"2023-03-31 18:10:10.000000000","message":"Looks good to me.","commit_id":"6b430df936e6c3b6a141ffbf02e21c39b94645b2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"64d5ef5b3846418d348b1e6edd485cdf93262102","unresolved":true,"context_lines":[{"line_number":63,"context_line":"               help\u003d_(\u0027Default driver to use for quota checks.\u0027)),"},{"line_number":64,"context_line":"    cfg.BoolOpt(\u0027track_quota_usage\u0027,"},{"line_number":65,"context_line":"                default\u003dTrue,"},{"line_number":66,"context_line":"                help\u003d_(\u0027Keep track in the database of current resource \u0027"},{"line_number":67,"context_line":"                       \u0027quota usage. Plugins which do not leverage the \u0027"},{"line_number":68,"context_line":"                       \u0027neutron database should set this flag to False.\u0027)),"},{"line_number":69,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"2e3bd6c2_1b53757e","line":66,"range":{"start_line":66,"start_character":24,"end_line":66,"end_character":28},"in_reply_to":"b9511731_9006a98d","updated":"2023-03-22 22:36:08.000000000","message":"Yeah, it\u0027s not very clear. I\u0027ve tried to update this best I can, I will admit the quota code is not my bread and butter, so might need some tweaks.","commit_id":"6b430df936e6c3b6a141ffbf02e21c39b94645b2"}]}