)]}'
{"neutron/tests/functional/plugins/ml2/drivers/macvtap/agent/test_macvtap_neutron_agent.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"484f9bc1698710d3303b69711d8997ed06e88565","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        # time. Because the macvtap interface must be created in the root"},{"line_number":34,"context_line":"        # namespace (``MacvtapManager`` cannot handle namespaces), the test"},{"line_number":35,"context_line":"        # deletes any previous existing interface."},{"line_number":36,"context_line":"        for mac in self.mgr.get_all_devices():"},{"line_number":37,"context_line":"            devices \u003d ip_lib.IPWrapper().get_devices()"},{"line_number":38,"context_line":"            for device in (d for d in devices if d.address \u003d\u003d mac):"},{"line_number":39,"context_line":"                device.link.delete()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Veth is simulating the hosts eth device. In this test it is used as"},{"line_number":42,"context_line":"        # src_dev for the macvtap"}],"source_content_type":"text/x-python","patch_set":1,"id":"9dfb6718_1e973c47","line":39,"range":{"start_line":36,"start_character":8,"end_line":39,"end_character":36},"updated":"2023-03-22 14:22:28.000000000","message":"nit: question: why not in setUp? It is not that important as there\u0027s only one test in this testclass.....","commit_id":"0220236c63b3bb841146ccb0614434a2bd60ac59"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f70989fe58c996f042eb203f3e413c36596b2181","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # time. Because the macvtap interface must be created in the root"},{"line_number":34,"context_line":"        # namespace (``MacvtapManager`` cannot handle namespaces), the test"},{"line_number":35,"context_line":"        # deletes any previous existing interface."},{"line_number":36,"context_line":"        for mac in self.mgr.get_all_devices():"},{"line_number":37,"context_line":"            devices \u003d ip_lib.IPWrapper().get_devices()"},{"line_number":38,"context_line":"            for device in (d for d in devices if d.address \u003d\u003d mac):"},{"line_number":39,"context_line":"                device.link.delete()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Veth is simulating the hosts eth device. In this test it is used as"},{"line_number":42,"context_line":"        # src_dev for the macvtap"}],"source_content_type":"text/x-python","patch_set":1,"id":"633696eb_04419c7f","line":39,"range":{"start_line":36,"start_character":8,"end_line":39,"end_character":36},"in_reply_to":"9dfb6718_1e973c47","updated":"2023-03-24 16:01:11.000000000","message":"For this exact reason, because there is one single test and I\u0027m explicitly deleting the interfaces that are being tested in this test. Apart from this, the comment about the concurrency is true only for the test, not the class [1].\n\n[1]https://review.opendev.org/c/openstack/neutron/+/865414/2/tox.ini","commit_id":"0220236c63b3bb841146ccb0614434a2bd60ac59"}]}
