)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"3d74d43b82af7591ce2b9483a0b9e7168ae5794e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d14f371f_2caadb5c","updated":"2023-04-27 22:14:28.000000000","message":"recheck","commit_id":"e348f1127345add67fc9d19997fc802250576a46"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"06287aac945eb21a933d5100d667cecd6fe36f50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"025cd65d_ed4c99e3","updated":"2023-04-30 14:12:15.000000000","message":"recheck vexxhost nested virt hosts disabled","commit_id":"e348f1127345add67fc9d19997fc802250576a46"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"75443ad707c0ea355e19102579862c88fc56a527","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8c5dc673_9e7d5f8c","updated":"2023-04-28 13:46:17.000000000","message":"recheck vexxhost nested virt hosts disabled","commit_id":"e348f1127345add67fc9d19997fc802250576a46"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"a9522914e214c2f58d3355d58658215f2c2a898b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c335a641_db2ded84","updated":"2023-05-01 20:48:47.000000000","message":"recheck vexxhost nested virt hosts disabled","commit_id":"e348f1127345add67fc9d19997fc802250576a46"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"e6ad3d10f32fbe2e9f26b3a5edfd1e07ad6aae97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fd898efd_94fea7a3","updated":"2023-05-08 22:03:07.000000000","message":"recheck","commit_id":"c3381e1fca4e5abde4643bc2a34f98e433ab9d99"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"be95da3b570b94a867a9f92d4f275ea4a1bb8329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b8cbdde4_b2d24d34","updated":"2023-05-09 10:32:31.000000000","message":"recheck vexxhost nested virt hosts disabled","commit_id":"c3381e1fca4e5abde4643bc2a34f98e433ab9d99"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ce277a8f4cda3089c3fdd927ab44f568e843c9f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"67294bfb_875c7f5a","updated":"2023-05-17 04:37:28.000000000","message":"recheck","commit_id":"056ebadc31820e0429ec7500b7a51911c2ad58f0"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"136cfc2c79708035fb80117b734a54be44c84b55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"37f9e30d_221c6c5c","updated":"2023-05-25 05:48:17.000000000","message":"The failure from here and subsequent patch sets is due to a change of function signature in If2a46f1e0c3b279dee4863e9c952f19c1e246571 causing issues for one of the added unit tests.","commit_id":"a50fdabbb3428331c4f4664c5993e9e45fa3e372"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"5f2d44ba72a74b304438459d1f6828c36566c71a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"80b137da_c85572bf","updated":"2023-06-23 10:09:13.000000000","message":"recheck no bug timed out","commit_id":"1eebdb2c638e09d76c26f45edf761ed4b109896a"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"d836315e16e18f5be8e71875ce2fdfed1d8a3d7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"df35ad4b_725b5f66","updated":"2023-07-03 17:05:54.000000000","message":"Rebased to get out of merge conflict, addressing nit in the process. Would appreciate if previous code-review scores would be restored when convenient. Thanks!","commit_id":"ae6e7153d603b034e4e4c934b446e483999acee6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4c87297997c21e7ce3fe85f0a178bdaf48ecd04c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"83f3a41d_73411cff","updated":"2023-07-04 13:16:32.000000000","message":"You should also add in the commit message that you are explicitly adding the \"output_port\" in the static route, that is the key point if this patch.","commit_id":"ae6e7153d603b034e4e4c934b446e483999acee6"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"1b566855f7c86e899820bdc252cb0c8fe530a5ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"84213bad_717d47cb","in_reply_to":"38554954_b4e84514","updated":"2023-07-06 12:13:49.000000000","message":"After reviewing this again, the `output_port` really belongs together with BFD, so I\u0027ve moved this part to https://review.opendev.org/c/openstack/neutron/+/878543","commit_id":"ae6e7153d603b034e4e4c934b446e483999acee6"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"2ca54d3611f316ebe157af5e667d664b7e6d07e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":28,"id":"38554954_b4e84514","in_reply_to":"83f3a41d_73411cff","updated":"2023-07-05 06:10:07.000000000","message":"Thank you for taking the time to review, Rodoflo, much appreciated!\n\n\u003e You should also add in the commit message that you are explicitly adding the \"output_port\" in the static route, that is the key point if this patch.\n\nGood point, I wonder if I intended for that change to be part of the parent commit, which is why it was not added to the comments. I\u0027ll consider moving it, only applying it when there are actually more than one gw-port and of course adding a comment about it.","commit_id":"ae6e7153d603b034e4e4c934b446e483999acee6"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"083df7f1135583c47d6d043f9237a487b403a296","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"56f26275_c0746ca4","updated":"2023-07-06 16:04:17.000000000","message":"recheck","commit_id":"2c5ea759737e663113d0d1b42e58ac5d98026c1a"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"7c0be8147fdfbeb003758c1f4da0f095791bb9fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"7899364f_8dc6df2f","updated":"2023-08-23 06:25:40.000000000","message":"recheck timed out","commit_id":"4bebf303900bb10ed38c7049ca670485618a7ba1"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"b72d5c1723802350eb126c45348aad395dd0f700","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"e9cd96e4_56a7c35e","updated":"2023-08-29 13:33:39.000000000","message":"recheck timed out","commit_id":"2ba9ef6cec7cb7bd88c1edc9e48c38554efed977"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"975b42e015c57bbef124760b7ebbf4696c40ce72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"1068ba5d_fdabc3ed","updated":"2023-10-20 20:14:39.000000000","message":"recheck timed out","commit_id":"ef27dd19da601ef093c7f9268504604a5ce388d1"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"706913c444e3e5e0ef88f06f1d753b8a3e101a40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"3c2db6e6_ba6ae3d7","updated":"2023-12-07 13:56:18.000000000","message":"recheck","commit_id":"b1a6294c79ccd75007b108f543679f75dfd76311"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5360ac907bb1adc9ed229205395d6bcfa547e59c","unresolved":true,"context_lines":[{"line_number":1141,"context_line":"        lrouter_name \u003d utils.ovn_name(router[\u0027id\u0027])"},{"line_number":1142,"context_line":"        for gw_port in self._get_router_gw_ports(admin_context, router[\u0027id\u0027]):"},{"line_number":1143,"context_line":"            if gw_port[\u0027id\u0027] !\u003d router.get(\u0027gw_port_id\u0027):"},{"line_number":1144,"context_line":"                if not router.get(\u0027enable_default_route_ecmp\u0027, False):"},{"line_number":1145,"context_line":"                    # The `enable_default_route_ecmp` option is not enabled for"},{"line_number":1146,"context_line":"                    # the router, only adding routes for the first gw_port."},{"line_number":1147,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":24,"id":"5f77a558_960e423e","line":1144,"updated":"2023-06-14 20:38:01.000000000","message":"nit: could create a local for this variable outside the loop and use here and below.","commit_id":"2c708eed969d3ec14073dabb42d4fee881110a5d"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"280c5c8ae9a4b768ed5e9ce77101c74fdd739d3a","unresolved":false,"context_lines":[{"line_number":1141,"context_line":"        lrouter_name \u003d utils.ovn_name(router[\u0027id\u0027])"},{"line_number":1142,"context_line":"        for gw_port in self._get_router_gw_ports(admin_context, router[\u0027id\u0027]):"},{"line_number":1143,"context_line":"            if gw_port[\u0027id\u0027] !\u003d router.get(\u0027gw_port_id\u0027):"},{"line_number":1144,"context_line":"                if not router.get(\u0027enable_default_route_ecmp\u0027, False):"},{"line_number":1145,"context_line":"                    # The `enable_default_route_ecmp` option is not enabled for"},{"line_number":1146,"context_line":"                    # the router, only adding routes for the first gw_port."},{"line_number":1147,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":24,"id":"79367dd1_69684461","line":1144,"in_reply_to":"5f77a558_960e423e","updated":"2023-06-19 14:23:52.000000000","message":"Ack","commit_id":"2c708eed969d3ec14073dabb42d4fee881110a5d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b6fbb806556e2f561847d654af29f44f68572589","unresolved":true,"context_lines":[{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"            # 2. Add default route with nexthop as gateway ip"},{"line_number":1145,"context_line":"            if gw_port[\u0027id\u0027] !\u003d router.get(\u0027gw_port_id\u0027):"},{"line_number":1146,"context_line":"                if not router_default_route_ecmp_enabled:"},{"line_number":1147,"context_line":"                    # The `enable_default_route_ecmp` option is not enabled for"},{"line_number":1148,"context_line":"                    # the router, only adding routes for the first gw_port."},{"line_number":1149,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":27,"id":"73ddafad_b99719f6","line":1146,"updated":"2023-06-30 21:46:38.000000000","message":"nit: above two lines probably could have been an \"and\" but don\u0027t need to change","commit_id":"ff7c2281e22a6bbbd008c8dad43f9fcf27f93423"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"7bb1a9e9e13efae1eff7be28675c5b69ae1327eb","unresolved":false,"context_lines":[{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"            # 2. Add default route with nexthop as gateway ip"},{"line_number":1145,"context_line":"            if gw_port[\u0027id\u0027] !\u003d router.get(\u0027gw_port_id\u0027):"},{"line_number":1146,"context_line":"                if not router_default_route_ecmp_enabled:"},{"line_number":1147,"context_line":"                    # The `enable_default_route_ecmp` option is not enabled for"},{"line_number":1148,"context_line":"                    # the router, only adding routes for the first gw_port."},{"line_number":1149,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":27,"id":"3c0ab91a_41ca8b52","line":1146,"in_reply_to":"73ddafad_b99719f6","updated":"2023-07-03 14:49:58.000000000","message":"Ack, need to rebase to get out of merge conflict, so might as well address this","commit_id":"ff7c2281e22a6bbbd008c8dad43f9fcf27f93423"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"083df7f1135583c47d6d043f9237a487b403a296","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"        router_id \u003d None"},{"line_number":1038,"context_line":"        ovn_fip \u003d self._nb_idl.get_floatingip(floatingip[\u0027id\u0027])"},{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":"        check_rev_cmd \u003d self._nb_idl.check_revision_number("},{"line_number":1041,"context_line":"            floatingip[\u0027id\u0027], floatingip, ovn_const.TYPE_FLOATINGIPS)"},{"line_number":1042,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":1043,"context_line":"            txn.add(check_rev_cmd)"}],"source_content_type":"text/x-python","patch_set":29,"id":"aa647308_9d6b9dce","line":1040,"in_reply_to":"50fd3190_6b81fecc","updated":"2023-07-06 16:04:17.000000000","message":"This is just weird, looking at the output of the job, the part of code being referenced does not exist in the project. Fluke?","commit_id":"2c5ea759737e663113d0d1b42e58ac5d98026c1a"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"93ea175e01305e68dd4ff60f6d20f8313526ced0","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"        router_id \u003d None"},{"line_number":1038,"context_line":"        ovn_fip \u003d self._nb_idl.get_floatingip(floatingip[\u0027id\u0027])"},{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":"        check_rev_cmd \u003d self._nb_idl.check_revision_number("},{"line_number":1041,"context_line":"            floatingip[\u0027id\u0027], floatingip, ovn_const.TYPE_FLOATINGIPS)"},{"line_number":1042,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":1043,"context_line":"            txn.add(check_rev_cmd)"}],"source_content_type":"text/x-python","patch_set":29,"id":"15878e74_c5f6a478","line":1040,"in_reply_to":"aa647308_9d6b9dce","updated":"2023-07-06 16:30:27.000000000","message":"Ah, a patch in this series removed `l3` import and that was fine until some other change reintroduced the use of it, so it is effectively a rebase mishap. Will push new patch sets","commit_id":"2c5ea759737e663113d0d1b42e58ac5d98026c1a"}]}