)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ae02999a843f1c66423ce3a08ca499dea8400024","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix intermittent failures in finding metada port in SB DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test_agent_metadata_port_ip_update_event can sometimes fail"},{"line_number":10,"context_line":"with finding the port in SB DB Port_Binding table [1]. This is"},{"line_number":11,"context_line":"due to a race condition between when the port is commited to NB DB"},{"line_number":12,"context_line":",reflected in SB DB and calling lsp_bind on SB DB."},{"line_number":13,"context_line":"This patch simply adds check for the metadata port in SB DB with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"078580ce_bc8f8567","line":10,"range":{"start_line":10,"start_character":50,"end_line":10,"end_character":53},"updated":"2023-03-27 12:33:48.000000000","message":"nit: missing reference","commit_id":"38fde84b1942e9132f414cc65051affde41960d3"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"ec14b3f8a669a1b8aaeeacbbc3ce3c01037bcb40","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix intermittent failures in finding metada port in SB DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test_agent_metadata_port_ip_update_event can sometimes fail"},{"line_number":10,"context_line":"with finding the port in SB DB Port_Binding table [1]. This is"},{"line_number":11,"context_line":"due to a race condition between when the port is commited to NB DB"},{"line_number":12,"context_line":",reflected in SB DB and calling lsp_bind on SB DB."},{"line_number":13,"context_line":"This patch simply adds check for the metadata port in SB DB with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d09dd8e3_5553b3b0","line":10,"range":{"start_line":10,"start_character":50,"end_line":10,"end_character":53},"in_reply_to":"078580ce_bc8f8567","updated":"2023-04-12 19:51:11.000000000","message":"Done","commit_id":"38fde84b1942e9132f414cc65051affde41960d3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5576a3a2a6cc22328f1c120d78873196538969c6","unresolved":true,"context_lines":[{"line_number":13,"context_line":"This patch simply adds check for the metadata port in SB DB with"},{"line_number":14,"context_line":"5s timeout before attempting to bind that logical port."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] shorturl.at/zPVX1"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #2012754"},{"line_number":19,"context_line":"Change-Id: I07fa45401788da6b963830e72a7b3a3cd54662e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2cfeb370_395d259e","line":16,"updated":"2023-04-12 13:43:09.000000000","message":"nit: This is a link to storage.gra.cloud.ovh.net for a failed job, which will eventually go away, the bug reference is probably enough since it has a copy/paste of the output.","commit_id":"8e2db5f406321b898389d45a1362201e16c88036"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"3b07184d871ec08b6e450beaa751da31679b2b4d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch simply adds check for the metadata port in SB DB with"},{"line_number":14,"context_line":"5s timeout before attempting to bind that logical port."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] shorturl.at/zPVX1"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #2012754"},{"line_number":19,"context_line":"Change-Id: I07fa45401788da6b963830e72a7b3a3cd54662e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9296809d_2d6d1e62","line":16,"in_reply_to":"2cfeb370_395d259e","updated":"2023-04-12 15:05:42.000000000","message":"Done","commit_id":"8e2db5f406321b898389d45a1362201e16c88036"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"335532a32e1360eb965062236cb0de751679136a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Miro Tomaska \u003cmtomaska@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-12 14:13:54 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix intermittent failures in finding metada port in SB DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test_agent_metadata_port_ip_update_event can sometimes fail"},{"line_number":10,"context_line":"with finding the port in SB DB Port_Binding table. This is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e5cc5514_c4b20802","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":43},"updated":"2023-04-12 19:18:33.000000000","message":"nit: metadata","commit_id":"c58efe1753dc8910f374a4cdeb224f563fb9be33"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"43e9379a0921be08a60b49ce2e720beb8e6f50b8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Miro Tomaska \u003cmtomaska@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-12 14:13:54 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix intermittent failures in finding metada port in SB DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test_agent_metadata_port_ip_update_event can sometimes fail"},{"line_number":10,"context_line":"with finding the port in SB DB Port_Binding table. This is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b2b8c24b_e3a65855","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":43},"in_reply_to":"e5cc5514_c4b20802","updated":"2023-04-25 17:24:28.000000000","message":"Typo still there","commit_id":"c58efe1753dc8910f374a4cdeb224f563fb9be33"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d511e43ba46f7309bcc3a03ed738bf91477f1b93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"777c8169_3f764289","updated":"2023-04-12 16:09:35.000000000","message":"-1 for visibility","commit_id":"78da96cbce9b2073b5a487195ebba09b454ad60b"}],"neutron/tests/functional/agent/ovn/metadata/test_metadata_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5109b78a41c1af1003bea589de2a768f7c9023c6","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                _metadata_port_in_sb_db,"},{"line_number":238,"context_line":"                timeout\u003d5,"},{"line_number":239,"context_line":"                exception\u003dException("},{"line_number":240,"context_line":"                    \"Metada port {} not found in SB DB after {}s\".format("},{"line_number":241,"context_line":"                        mdt_port_name, 5)))"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            self.sb_api.lsp_bind(mdt_port_name, self.chassis_name).execute("}],"source_content_type":"text/x-python","patch_set":1,"id":"083eaa87_86d59603","line":240,"range":{"start_line":240,"start_character":21,"end_line":240,"end_character":27},"updated":"2023-03-24 17:11:58.000000000","message":"s/Metadata and also spell-out \u0027seconds\u0027\n\nAnd I would follow the format of the other uses in this file, for example L204-210 or L336-338:\n\nexc \u003d Exception(\"...\" % (mdt_port_name, 5))\nn_utils.wait_until_true(...)","commit_id":"8a79aebc6519ab2f15d2be9da1d680630eab7371"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"a529b4212c10accef3e16be4a00638346e4cc2f5","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                _metadata_port_in_sb_db,"},{"line_number":238,"context_line":"                timeout\u003d5,"},{"line_number":239,"context_line":"                exception\u003dException("},{"line_number":240,"context_line":"                    \"Metada port {} not found in SB DB after {}s\".format("},{"line_number":241,"context_line":"                        mdt_port_name, 5)))"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            self.sb_api.lsp_bind(mdt_port_name, self.chassis_name).execute("}],"source_content_type":"text/x-python","patch_set":1,"id":"cb948142_3c2483bf","line":240,"range":{"start_line":240,"start_character":21,"end_line":240,"end_character":27},"in_reply_to":"083eaa87_86d59603","updated":"2023-03-25 03:40:29.000000000","message":"Done","commit_id":"8a79aebc6519ab2f15d2be9da1d680630eab7371"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"70276e7d48b5389be0a9f1872a5ba21b622df346","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                metadata_port_in_sb_db,"},{"line_number":238,"context_line":"                timeout\u003d5,"},{"line_number":239,"context_line":"                exception\u003dException("},{"line_number":240,"context_line":"                    \"Metada port %s not found in the Port_Binding table.\" %"},{"line_number":241,"context_line":"                    mdt_port_name))"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            self.sb_api.lsp_bind(mdt_port_name, self.chassis_name).execute("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f95134c_eff0eb9f","line":240,"range":{"start_line":240,"start_character":21,"end_line":240,"end_character":27},"updated":"2023-04-12 07:06:06.000000000","message":"nit: Metadata","commit_id":"8e2db5f406321b898389d45a1362201e16c88036"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"3b07184d871ec08b6e450beaa751da31679b2b4d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                metadata_port_in_sb_db,"},{"line_number":238,"context_line":"                timeout\u003d5,"},{"line_number":239,"context_line":"                exception\u003dException("},{"line_number":240,"context_line":"                    \"Metada port %s not found in the Port_Binding table.\" %"},{"line_number":241,"context_line":"                    mdt_port_name))"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            self.sb_api.lsp_bind(mdt_port_name, self.chassis_name).execute("}],"source_content_type":"text/x-python","patch_set":3,"id":"795d06ee_f537b755","line":240,"range":{"start_line":240,"start_character":21,"end_line":240,"end_character":27},"in_reply_to":"0c5bb68e_8b96baa7","updated":"2023-04-12 15:05:42.000000000","message":"Done","commit_id":"8e2db5f406321b898389d45a1362201e16c88036"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5576a3a2a6cc22328f1c120d78873196538969c6","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                metadata_port_in_sb_db,"},{"line_number":238,"context_line":"                timeout\u003d5,"},{"line_number":239,"context_line":"                exception\u003dException("},{"line_number":240,"context_line":"                    \"Metada port %s not found in the Port_Binding table.\" %"},{"line_number":241,"context_line":"                    mdt_port_name))"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            self.sb_api.lsp_bind(mdt_port_name, self.chassis_name).execute("}],"source_content_type":"text/x-python","patch_set":3,"id":"0c5bb68e_8b96baa7","line":240,"range":{"start_line":240,"start_character":21,"end_line":240,"end_character":27},"in_reply_to":"7f95134c_eff0eb9f","updated":"2023-04-12 13:43:09.000000000","message":"+1","commit_id":"8e2db5f406321b898389d45a1362201e16c88036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d511e43ba46f7309bcc3a03ed738bf91477f1b93","unresolved":true,"context_lines":[{"line_number":226,"context_line":"                    check_error\u003dTrue, log_errors\u003dTrue) as txn:"},{"line_number":227,"context_line":"                mdt_port_name \u003d self._create_metadata_port(txn, lswitch_name)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            def metadata_port_in_sb_db():"},{"line_number":230,"context_line":"                port_rows \u003d self.sb_api.db_find_rows("},{"line_number":231,"context_line":"                    \u0027Port_Binding\u0027,"},{"line_number":232,"context_line":"                    (\u0027logical_port\u0027, \u0027\u003d\u0027, \u0027{}\u0027.format(mdt_port_name))"}],"source_content_type":"text/x-python","patch_set":4,"id":"137fd422_a7645f36","line":229,"range":{"start_line":229,"start_character":12,"end_line":229,"end_character":41},"updated":"2023-04-12 16:09:35.000000000","message":"That\u0027s enough for testing but I would recommend to use DB events. For example, in this same file we have \"MetadataAgentHealthEvent\". You can use something similar for \"Port_Binding\" filtering by \"logical_port\" and event CREATE.","commit_id":"78da96cbce9b2073b5a487195ebba09b454ad60b"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"ec14b3f8a669a1b8aaeeacbbc3ce3c01037bcb40","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                    check_error\u003dTrue, log_errors\u003dTrue) as txn:"},{"line_number":227,"context_line":"                mdt_port_name \u003d self._create_metadata_port(txn, lswitch_name)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            def metadata_port_in_sb_db():"},{"line_number":230,"context_line":"                port_rows \u003d self.sb_api.db_find_rows("},{"line_number":231,"context_line":"                    \u0027Port_Binding\u0027,"},{"line_number":232,"context_line":"                    (\u0027logical_port\u0027, \u0027\u003d\u0027, \u0027{}\u0027.format(mdt_port_name))"}],"source_content_type":"text/x-python","patch_set":4,"id":"0fabc271_3dfad3b9","line":229,"range":{"start_line":229,"start_character":12,"end_line":229,"end_character":41},"in_reply_to":"137fd422_a7645f36","updated":"2023-04-12 19:51:11.000000000","message":"Thanks, I changed it to DB event implementation.","commit_id":"78da96cbce9b2073b5a487195ebba09b454ad60b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"125203117508433e1254199ea8ceed1a0796281c","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                self.agent.sb_idl.idl.notify_handler.watch_event("},{"line_number":242,"context_line":"                    metadata_port_create_event)"},{"line_number":243,"context_line":"                self._create_metadata_port(txn, lswitch_name, mdt_port_name)"},{"line_number":244,"context_line":"            self.assertTrue(metadata_port_create_event.wait())"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"            self.sb_api.lsp_bind(mdt_port_name, self.chassis_name).execute("},{"line_number":247,"context_line":"                check_error\u003dTrue, log_errors\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"56496425_015c1c46","line":244,"range":{"start_line":244,"start_character":12,"end_line":244,"end_character":62},"updated":"2023-04-25 15:08:04.000000000","message":"Perfect","commit_id":"9d5163301310a8c3cb72e18cbaed89afbc07f674"}]}