)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e334568e65ab4e0c92fcca25687e5bc4759f55a5","unresolved":true,"context_lines":[{"line_number":19,"context_line":"property."},{"line_number":20,"context_line":"This patch make availability to setup domain_name DHCP option from"},{"line_number":21,"context_line":"network dns_domain property if it exist and no static dns_domain option set via"},{"line_number":22,"context_line":"config file"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I4ea7a7e02b82297cddba25cbd524eca7fee9330f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9b037fe4_a5283467","line":22,"updated":"2023-03-29 12:01:30.000000000","message":"This does not really sound right in term of a feature. Usually it\u0027s the opposite that is done. Users can set an option from API, if not we fallback to global config. Here we do the opposite.","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"},{"author":{"_account_id":32358,"name":"Mikhail Stolyarov","display_name":"toggetit","email":"x3om6ak@gmail.com","username":"toggetit"},"change_message_id":"edb54762ff9ccd62f8898a3ac08d80bc43e520d1","unresolved":true,"context_lines":[{"line_number":19,"context_line":"property."},{"line_number":20,"context_line":"This patch make availability to setup domain_name DHCP option from"},{"line_number":21,"context_line":"network dns_domain property if it exist and no static dns_domain option set via"},{"line_number":22,"context_line":"config file"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I4ea7a7e02b82297cddba25cbd524eca7fee9330f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c53a58cf_c3a36930","line":22,"in_reply_to":"9b037fe4_a5283467","updated":"2023-03-29 12:37:21.000000000","message":"Currently users can assign dns_domain via ports, but it\u0027s not apply in DHCP. It\u0027s only used for DNS registration.\nMy patch it\u0027s about applying DHCP domain_name options per network if it exists and if no global option in config file.\nLet me explain.\nWhen dns_domain option in neutron.conf exists - DHCP domain_name added to all created instances. But if we need multiple options (for example for multiple environments)- there is no way to do it. I found that only way to do it is manually add domain_name to OVSDB. But there is a network dns_domain property, and I think there is a perfect option for this.\nSo if we use it we have dynamic configuration:\n\nroot@ost-host:~# ovn-nbctl list dhcp_options\n_uuid               : d487f8b0-03b3-43e0-b184-23c622bfb706\ncidr                : \"192.168.120.0/24\"\nexternal_ids        : {\"neutron:revision_number\"\u003d\"14\", subnet_id\u003d\"b3827b79-e775-4034-ae47-5b0c50b6edc3\"}\noptions             : {classless_static_route\u003d\"{169.254.169.254/32,192.168.120.2, 0.0.0.0/0,192.168.120.1}\", dns_server\u003d\"{172.24.0.8, 172.24.0.9, 172.24.0.10}\", domain_name\u003d\"\\\"domain1.nova.\\\"\", lease_time\u003d\"43200\", mtu\u003d\"1500\", router\u003d\"192.168.120.1\", server_id\u003d\"192.168.120.1\", server_mac\u003d\"fa:16:3e:06:ba:8a\"}\n\n_uuid               : c804cf02-64a6-407a-99c8-82c9e3f98035\ncidr                : \"192.168.25.160/27\"\nexternal_ids        : {\"neutron:revision_number\"\u003d\"32\", subnet_id\u003d\"32b9e50c-8f7b-4432-a085-76a5c67ca461\"}\noptions             : {classless_static_route\u003d\"{169.254.169.254/32,192.168.25.170, 0.0.0.0/0,192.168.25.161}\", dns_server\u003d\"{172.24.0.8, 172.24.0.9, 172.24.0.10}\", domain_name\u003d\"\\\"domain2.nova.\\\"\", lease_time\u003d\"43200\", mtu\u003d\"1500\", router\u003d\"192.168.25.161\", server_id\u003d\"192.168.25.161\", server_mac\u003d\"fa:16:3e:d7:c6:5c\"}","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32358,"name":"Mikhail Stolyarov","display_name":"toggetit","email":"x3om6ak@gmail.com","username":"toggetit"},"change_message_id":"efb5e8decf16fa7e1c170c3ebd26703d3e8ee53d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88150a77_976b8770","updated":"2023-03-29 09:08:49.000000000","message":"Greetings!\nA post a new try regards your comments on https://review.opendev.org/c/openstack/neutron/+/878812\nOVN + DHCP-agent","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"},{"author":{"_account_id":32358,"name":"Mikhail Stolyarov","display_name":"toggetit","email":"x3om6ak@gmail.com","username":"toggetit"},"change_message_id":"edb54762ff9ccd62f8898a3ac08d80bc43e520d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5751f871_8d2569fa","updated":"2023-03-29 12:37:21.000000000","message":"Hello Elvira!\nI trying to resolve issue https://bugs.launchpad.net/neutron/+bug/1960850\nPlease take a look","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1dde93c9146f55c8a9182a86712ab17897131844","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82b95d71_deaf0b7d","updated":"2023-03-29 18:11:05.000000000","message":"My intent was not to have you give up, it was to make you aware of the previous work and its issues.","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1ac798479fce286b0c5980467340cff734d0b7ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f744783c_5c5a864f","updated":"2023-03-29 15:37:05.000000000","message":"This was changed and reverted before, will need to understand why before we put it back.\n\nhttps://review.opendev.org/c/openstack/neutron/+/657806","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b247d761c553bec8325738e9d7b5833495b46ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b71b097_db2c3fb6","updated":"2023-03-29 11:55:22.000000000","message":"isn\u0027t this a bit related to https://review.opendev.org/c/openstack/neutron-specs/+/832658/12/specs/zed/support-dns-subdomains-at-a-network-level.rst ?","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"},{"author":{"_account_id":32358,"name":"Mikhail Stolyarov","display_name":"toggetit","email":"x3om6ak@gmail.com","username":"toggetit"},"change_message_id":"edb54762ff9ccd62f8898a3ac08d80bc43e520d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3606b8e7_48da594d","in_reply_to":"2b71b097_db2c3fb6","updated":"2023-03-29 12:37:21.000000000","message":"As I can understand in your links there is a conversation more about building hostnames (fqdn)","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"},{"author":{"_account_id":32358,"name":"Mikhail Stolyarov","display_name":"toggetit","email":"x3om6ak@gmail.com","username":"toggetit"},"change_message_id":"7025f3670aa5760d783e9c1d6cfc54f577089ecf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c75a12d0_07d2c635","in_reply_to":"82b95d71_deaf0b7d","updated":"2023-03-29 18:26:45.000000000","message":"I understand, but I realize that iceberg is too deep for me - I\u0027m not developer, I\u0027m administrator just trying to solve small issue.\nMaybe someone more involved to all aspects of neutron code solve my pain in future \u003d) At least I can do some manual patching.\nThank you for your time!","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1ac798479fce286b0c5980467340cff734d0b7ad","unresolved":true,"context_lines":[{"line_number":782,"context_line":"                        ip_addresses[0].replace(\u0027.\u0027, \u0027-\u0027).replace(\u0027:\u0027, \u0027-\u0027))"},{"line_number":783,"context_line":"            fqdn \u003d hostname"},{"line_number":784,"context_line":"            if self.conf.dns_domain:"},{"line_number":785,"context_line":"                fqdn \u003d \u0027%s.%s\u0027 % (fqdn, self.conf.dns_domain)"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"        return hostname, fqdn"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c2523e0e_54c4680d","line":785,"updated":"2023-03-29 15:37:05.000000000","message":"What about here?","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1ac798479fce286b0c5980467340cff734d0b7ad","unresolved":true,"context_lines":[{"line_number":1240,"context_line":"                # Here is something to check still"},{"line_number":1241,"context_line":"                subnets_without_nameservers.add(subnet.id)"},{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"            if self.conf.dns_domain and subnet.ip_version \u003d\u003d 6:"},{"line_number":1244,"context_line":"                # This should be change also"},{"line_number":1245,"context_line":"                options.append("},{"line_number":1246,"context_line":"                    self._format_option("}],"source_content_type":"text/x-python","patch_set":1,"id":"c5b0dce6_7eb9ed67","line":1243,"updated":"2023-03-29 15:37:05.000000000","message":"Or here?\n\nIt almost feels like there should be a method to return \"dns_domain\"","commit_id":"25a4e2bab63b278951a4e4d76d550818f5ed24c2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"26c16d29daf647c113699035760f7630255de36f","unresolved":true,"context_lines":[{"line_number":458,"context_line":"        ret_val \u003d \u0027\u0027"},{"line_number":459,"context_line":"        if self.conf.dns_domain:"},{"line_number":460,"context_line":"            ret_val \u003d self.conf.dns_domain"},{"line_number":461,"context_line":"        elif self.network.dns_domain:"},{"line_number":462,"context_line":"            ret_val \u003d self.network.dns_domain"},{"line_number":463,"context_line":"        return ret_val"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e14655bc_d2a1ccdb","line":461,"range":{"start_line":461,"start_character":0,"end_line":461,"end_character":37},"updated":"2025-01-27 11:05:02.000000000","message":"hmmmm, this dns_domain is empty most of the cases, I have to check why","commit_id":"896116dd168f71bfba8f334bc15126303a26c878"}]}