)]}'
{"neutron/db/migration/alembic_migrations/versions/33c3db036fe4_set_length_of_description_field_metering.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"59079502974eb493101498b85be279569c0198bc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    bind \u003d op.get_bind()"},{"line_number":44,"context_line":"    engine \u003d bind.engine"},{"line_number":45,"context_line":"    insp \u003d sa.engine.reflection.Inspector.from_engine(engine)"},{"line_number":46,"context_line":"    if \u0027meteringlabels\u0027 in insp.get_table_names():"},{"line_number":47,"context_line":"        op.alter_column(\u0027meteringlabels\u0027, \u0027description\u0027, type_\u003dsa.String(1024),"},{"line_number":48,"context_line":"                        existing_nullable\u003dTrue)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F7eg%3D","line":46,"updated":"2014-04-16 12:56:40.000000000","message":"If this table is present, this, in my opinion, necessarily means we have run the previous migration or that the schema were autogenerated, so your approach looks safe - and the best way for addressing the grenade issue.\n\nAlso, if the metering labels table is not present, I think it might be a good idea to import the original migration and run the upgrade method for it. This way we will also fix the problem for everybody who enables the metering plugin now.","commit_id":"1f574dbd857a9b877f58940f973c15e101df66f2"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"90cbf3300e0319f3f251897037efedaa947b631a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    if not migration.should_run(active_plugins, migration_for_plugins):"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    bind \u003d op.get_bind()"},{"line_number":46,"context_line":"    insp \u003d sa.engine.reflection.Inspector.from_engine(bind)"},{"line_number":47,"context_line":"    if \u0027meteringlabels\u0027 not in insp.get_table_names():"},{"line_number":48,"context_line":"        script \u003d ScriptDirectory.from_config(context.config)"},{"line_number":49,"context_line":"        run_migration \u003d script.get_revision(\u0027569e98a8132b\u0027).module"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FtwM%3D","line":46,"updated":"2014-04-18 00:25:03.000000000","message":"This does not seem to reliably fix offline migrations.  Need to test more.","commit_id":"efc68e60f95d9bda4424eefc9cc638ded7e9aa16"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"1a84fa5bb60e5a4c15f516ff62640481cedad7eb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    if not migration.should_run(active_plugins, migration_for_plugins):"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    bind \u003d op.get_bind()"},{"line_number":46,"context_line":"    insp \u003d sa.engine.reflection.Inspector.from_engine(bind)"},{"line_number":47,"context_line":"    if \u0027meteringlabels\u0027 not in insp.get_table_names():"},{"line_number":48,"context_line":"        script \u003d ScriptDirectory.from_config(context.config)"},{"line_number":49,"context_line":"        run_migration \u003d script.get_revision(\u0027569e98a8132b\u0027).module"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FifA%3D","line":46,"in_reply_to":"AAAAXH%2F%2Fqcs%3D","updated":"2014-04-19 22:56:04.000000000","message":"I think Ann meant the migration with the issue has been merged a while ago, so there could be a number of patches depending on the new HEAD, so removing the migration will break all of them.","commit_id":"efc68e60f95d9bda4424eefc9cc638ded7e9aa16"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"aa50ed23d84b69168cf12c22ffd5ca8eeb29f3ed","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    if not migration.should_run(active_plugins, migration_for_plugins):"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    bind \u003d op.get_bind()"},{"line_number":46,"context_line":"    insp \u003d sa.engine.reflection.Inspector.from_engine(bind)"},{"line_number":47,"context_line":"    if \u0027meteringlabels\u0027 not in insp.get_table_names():"},{"line_number":48,"context_line":"        script \u003d ScriptDirectory.from_config(context.config)"},{"line_number":49,"context_line":"        run_migration \u003d script.get_revision(\u0027569e98a8132b\u0027).module"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2Fqcs%3D","line":46,"in_reply_to":"AAAAXH%2F%2FsfQ%3D","updated":"2014-04-18 12:51:32.000000000","message":"FYI: https://review.openstack.org/87543\nis pointing to a review still in progress.","commit_id":"efc68e60f95d9bda4424eefc9cc638ded7e9aa16"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"bea76dd7f207c50b6a639dc6bc3822493e3bcce7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    if not migration.should_run(active_plugins, migration_for_plugins):"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    bind \u003d op.get_bind()"},{"line_number":46,"context_line":"    insp \u003d sa.engine.reflection.Inspector.from_engine(bind)"},{"line_number":47,"context_line":"    if \u0027meteringlabels\u0027 not in insp.get_table_names():"},{"line_number":48,"context_line":"        script \u003d ScriptDirectory.from_config(context.config)"},{"line_number":49,"context_line":"        run_migration \u003d script.get_revision(\u0027569e98a8132b\u0027).module"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FsfQ%3D","line":46,"in_reply_to":"AAAAXH%2F%2FtwM%3D","updated":"2014-04-18 06:24:41.000000000","message":"There is only two options to fix Grenade:\n1) As it is shown here.\n2) Remove this migration https://review.openstack.org/87543. But as it was merged more than a week a ago it is a bad idea.\n\nIf you could suggest something please do,  but I don\u0027t find any other options.","commit_id":"efc68e60f95d9bda4424eefc9cc638ded7e9aa16"}]}
