)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"85078e604ad1669132ed5c063849b055ea3dc79a","unresolved":true,"context_lines":[{"line_number":14,"context_line":"in TestMl2DbOperationBounds class as this class is expected to check"},{"line_number":15,"context_line":"DbOperators made by ML2 plugin while listing ports so there\u0027s no need to"},{"line_number":16,"context_line":"include policy checks there too."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2560edb915f7393fcda50dd4a37a1d366bd0ce59"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0caf8d8e_2e076d47","line":17,"updated":"2023-04-12 13:22:44.000000000","message":"isn\u0027t there a bug for this issue?","commit_id":"8eecccfeae1cef3585cafa2046e85362b4e0d875"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e5daa07e7394678b7ccd73b96929cd2d4deff7f7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"in TestMl2DbOperationBounds class as this class is expected to check"},{"line_number":15,"context_line":"DbOperators made by ML2 plugin while listing ports so there\u0027s no need to"},{"line_number":16,"context_line":"include policy checks there too."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2560edb915f7393fcda50dd4a37a1d366bd0ce59"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b7cd6421_eff4b39e","line":17,"in_reply_to":"0caf8d8e_2e076d47","updated":"2023-04-12 13:32:28.000000000","message":"No, I forgot to report one. Do You want me to do it?","commit_id":"8eecccfeae1cef3585cafa2046e85362b4e0d875"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"746498699bd06155631939ea41fc603a41eb9f1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae91166e_a9458359","updated":"2023-04-11 17:50:34.000000000","message":"-1 for visibility\n\nThe issue in the UTs are the policy calls and the cache. With this new rule we need to check the port belongs to a network. The policy enforcement list the networks (as seen in the logs) when doing the policy check.\n\nIf that happens sometimes only is because of the OwnerCheck class cache. I didn\u0027t have time to check it but if we disable the OwnerCheck cache or we mock it, we\u0027ll be able to pass this test.","commit_id":"debf9449b36633791b0608f37c7ef748d6c64360"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"42334bdbb190284c3c7b32f60e139d1b90874e02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a07ec60_5509c96c","updated":"2023-04-11 17:58:57.000000000","message":"In TestMl2DbOperationBounds\n\n  mock.patch.object(policy, \u0027enforce\u0027).start()","commit_id":"debf9449b36633791b0608f37c7ef748d6c64360"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e5daa07e7394678b7ccd73b96929cd2d4deff7f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"241e7095_7bd2bd69","in_reply_to":"3a07ec60_5509c96c","updated":"2023-04-12 13:32:28.000000000","message":"Thx. (almost) that fixed the issue. I needed to mock policy.check instead of policy.enforce but now it should be good.","commit_id":"debf9449b36633791b0608f37c7ef748d6c64360"}],"neutron/conf/policies/port.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c6374980dda7bd8a90afc5383263af46042b6f8b","unresolved":true,"context_lines":[{"line_number":276,"context_line":"        check_str\u003dneutron_policy.policy_or("},{"line_number":277,"context_line":"            base.ADMIN,"},{"line_number":278,"context_line":"            neutron_policy.RULE_ADVSVC,"},{"line_number":279,"context_line":"            base.RULE_NET_OWNER,"},{"line_number":280,"context_line":"            base.PROJECT_READER"},{"line_number":281,"context_line":"        ),"},{"line_number":282,"context_line":"        scope_types\u003d[\u0027project\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"feaf759a_48d48dbf","line":279,"updated":"2023-04-07 16:01:37.000000000","message":"This actually seems to be triggering the unit test failures, I thought the gate was broken due to a library change but it\u0027s not according to my test patch today, https://review.opendev.org/c/openstack/neutron/+/879894","commit_id":"debf9449b36633791b0608f37c7ef748d6c64360"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61625aa7e41113db243e807b1f4eadabd3b0ae27","unresolved":true,"context_lines":[{"line_number":276,"context_line":"        check_str\u003dneutron_policy.policy_or("},{"line_number":277,"context_line":"            base.ADMIN,"},{"line_number":278,"context_line":"            neutron_policy.RULE_ADVSVC,"},{"line_number":279,"context_line":"            base.RULE_NET_OWNER,"},{"line_number":280,"context_line":"            base.PROJECT_READER"},{"line_number":281,"context_line":"        ),"},{"line_number":282,"context_line":"        scope_types\u003d[\u0027project\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"e00035c2_97be2eac","line":279,"in_reply_to":"7c251c4c_3b4fe195","updated":"2023-04-11 14:34:33.000000000","message":"This failure is related to that change but I have no idea how. First of all, new policies aren\u0027t used by default yet so it shouldn\u0027t cause any difference. And second - this is not really reproducible failure if only this one test is run, so it probably is somehow interfered by some other test.","commit_id":"debf9449b36633791b0608f37c7ef748d6c64360"},{"author":{"_account_id":33983,"name":"Luigi Dino Tamagnone","display_name":"luigi","email":"ltamagno@redhat.com","username":"ltamagno"},"change_message_id":"ebdd39da4e55de52e9b27d2c869bf68c201d9970","unresolved":true,"context_lines":[{"line_number":276,"context_line":"        check_str\u003dneutron_policy.policy_or("},{"line_number":277,"context_line":"            base.ADMIN,"},{"line_number":278,"context_line":"            neutron_policy.RULE_ADVSVC,"},{"line_number":279,"context_line":"            base.RULE_NET_OWNER,"},{"line_number":280,"context_line":"            base.PROJECT_READER"},{"line_number":281,"context_line":"        ),"},{"line_number":282,"context_line":"        scope_types\u003d[\u0027project\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c251c4c_3b4fe195","line":279,"in_reply_to":"feaf759a_48d48dbf","updated":"2023-04-08 07:40:10.000000000","message":"All 4 tests are failing on the same check:\nneutron.tests.unit.plugins.ml2.test_plugin.TestMl2DbOperationBoundsTenant.test_port_list_queries_constant\n    testtools.matchers._impl.MismatchError: 21 !\u003d 8: queries before:\n[...]    \nneutron.tests.unit.plugins.ml2.test_plugin.TestMl2DbOperationBoundsTenantRbac.test_port_list_queries_constant\n    testtools.matchers._impl.MismatchError: 8 !\u003d 21: queries before:\n    \nThe test is about the port list in a shared network, if the meaning of this patch is changing what a network owner can see about his network, probably these fails are expected.","commit_id":"debf9449b36633791b0608f37c7ef748d6c64360"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"32dc50c42983b83b64cc49fb79ee150ff351e5dc","unresolved":true,"context_lines":[{"line_number":905,"context_line":"        self.kwargs \u003d self.get_api_kwargs()"},{"line_number":906,"context_line":"        # NOTE(slaweq): In this class we are not testing any operations related"},{"line_number":907,"context_line":"        # to policy module so we don\u0027t need to checu policies"},{"line_number":908,"context_line":"        mock.patch(\u0027neutron.policy.check\u0027).start()"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"    def make_network(self):"},{"line_number":911,"context_line":"        return self._make_network(self.fmt, \u0027name\u0027, True, **self.kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0e5d64b5_319abdf5","line":908,"updated":"2023-04-14 10:07:04.000000000","message":"+1","commit_id":"8eecccfeae1cef3585cafa2046e85362b4e0d875"}]}
