)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d2fddff6ac4c3277ebbbfbcdcc4dfa8c4ae7eadb","unresolved":true,"context_lines":[{"line_number":12,"context_line":"a number of times that can cause the subport status to"},{"line_number":13,"context_line":"remain DOWN."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I382b02267ddd30fdb006818fe607e0abc6d1bcbc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"09cc71fb_ac065b57","line":15,"updated":"2023-07-25 19:29:52.000000000","message":"can we get a LP bug linked here?","commit_id":"08712cfdfaaf4616d69984ca6a11038e429fbc61"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b588bb64e6ccc629358d92b5b5f27f3d617d6684","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7e59fe85_7587a5c9","updated":"2023-04-14 14:07:48.000000000","message":"Hi,\n\nTwo early comments:\n\n* It would be good to have this linked to a bug report.\n\n* Please be careful with cascading an update to all subports of a trunk. This can easily kill performance. If there\u0027s a way to avoid the cascading update (for example a single mass update), please consider that too. If the cascading update cannot be avoided, then it would be good to at least test and measure what is the maximum number of subports on a trunk before we start getting timeouts.","commit_id":"936fe4e8f7707e9d1559b499381208025c16bf52"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a68b171841a2da1bd3ed62c4f2dd08707fcc1b6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eb1a6196_ac569af3","updated":"2023-04-23 22:34:33.000000000","message":"Would need additional tests as well.","commit_id":"936fe4e8f7707e9d1559b499381208025c16bf52"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"3680eeba2335cd628c57a4db93908b69c9ff6af9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd5d15df_aae2b3ef","in_reply_to":"7e59fe85_7587a5c9","updated":"2023-04-14 14:10:46.000000000","message":"Thanks for your comments! I\u0027ll create the LP and I\u0027ll look if another way to update the subports is possible!","commit_id":"936fe4e8f7707e9d1559b499381208025c16bf52"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f1834c46213a526b02b68a2b937d057744e87163","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f5fc0cf6_743bdf48","updated":"2023-04-27 15:34:35.000000000","message":"A couple of comments:\n1) Try, if possible, to create a method to add the requested chassis and rarp config, in order to not duplicate code.\n2) Testing","commit_id":"08712cfdfaaf4616d69984ca6a11038e429fbc61"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"092842d1996ddaa32ff372cabe88aa75f9fbca38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cea1e3c7_2641ee45","updated":"2023-05-05 09:06:04.000000000","message":"please check locally the basic things before uploading to gerrit.\nwith tox -epep8 you can execute the static code check, and with tox -epy310 -- neutron.tests.unit.services.trunk.test_plugin yu can execute the most probably affected unit tests. (with tox -epy310 all unit tests will be executed)","commit_id":"08712cfdfaaf4616d69984ca6a11038e429fbc61"}],"neutron/services/ovn_l3/plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a68b171841a2da1bd3ed62c4f2dd08707fcc1b6a","unresolved":true,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if event \u003d\u003d events.AFTER_UPDATE and \\"},{"line_number":518,"context_line":"                utils.is_lsp_router_port(current) or \\"},{"line_number":519,"context_line":"                current.get(\u0027device_owner\u0027, \u0027\u0027) \u003d\u003d \u0027trunk:subport\u0027:"},{"line_number":520,"context_line":"            # We call the update_router port with if_exists, because neutron,"},{"line_number":521,"context_line":"            # internally creates the port, and then calls update, which will"},{"line_number":522,"context_line":"            # trigger this callback even before we had the chance to create"}],"source_content_type":"text/x-python","patch_set":2,"id":"b1055d77_2eb4fa26","line":519,"updated":"2023-04-23 22:34:33.000000000","message":"Should use () around these and not \\, similar to L511","commit_id":"936fe4e8f7707e9d1559b499381208025c16bf52"}],"neutron/services/trunk/plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a68b171841a2da1bd3ed62c4f2dd08707fcc1b6a","unresolved":true,"context_lines":[{"line_number":512,"context_line":"                context, trunk_id,"},{"line_number":513,"context_line":"                {\u0027trunk\u0027: {\u0027status\u0027: constants.TRUNK_ACTIVE_STATUS}})"},{"line_number":514,"context_line":"        if ovn_const.MIGRATING_ATTR in updated_pb and \\"},{"line_number":515,"context_line":"                ovn_const.MIGRATING_ATTR not in original_pb:"},{"line_number":516,"context_line":"            for subport_id in trunk_details[\u0027sub_ports\u0027]:"},{"line_number":517,"context_line":"                self.update_subport("},{"line_number":518,"context_line":"                    context, subport_id[\u0027port_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"50dab95e_6039884c","line":515,"updated":"2023-04-23 22:34:33.000000000","message":"Here too.","commit_id":"936fe4e8f7707e9d1559b499381208025c16bf52"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d6260538f580cd2cb31d3fdb7e28ab4cf90de26b","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        check_rev_cmd \u003d ovn_client._nb_idl.check_revision_number("},{"line_number":308,"context_line":"            subport_id, db_subport, ovn_const.TYPE_PORTS)"},{"line_number":309,"context_line":"        with ovn_client._nb_idl.transaction(check_error\u003dTrue,"},{"line_number":310,"context_line":"                                          revision_mismatch_raise\u003dTrue) as txn:"},{"line_number":311,"context_line":"            txn.add(check_rev_cmd)"},{"line_number":312,"context_line":"            new_options \u003d {}"},{"line_number":313,"context_line":"            new_options[\u0027activation-strategy\u0027]\u003d\u0027rarp\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"58b4e002_1c3a9f1e","line":310,"range":{"start_line":309,"start_character":8,"end_line":310,"end_character":79},"updated":"2023-07-17 13:09:25.000000000","message":"This is driver specific. We can\u0027t implement that here because this is common for OVS, LB and OVN (the 3 implemented drivers).","commit_id":"08712cfdfaaf4616d69984ca6a11038e429fbc61"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0ebe4c8866b22e374ed2f4b5d8faaa7ec7776bbf","unresolved":true,"context_lines":[{"line_number":310,"context_line":"                                          revision_mismatch_raise\u003dTrue) as txn:"},{"line_number":311,"context_line":"            txn.add(check_rev_cmd)"},{"line_number":312,"context_line":"            new_options \u003d {}"},{"line_number":313,"context_line":"            new_options[\u0027activation-strategy\u0027]\u003d\u0027rarp\u0027"},{"line_number":314,"context_line":"            new_options[ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS]\u003d\u0027true\u0027"},{"line_number":315,"context_line":"            new_options[ovn_const.LSP_OPTIONS_REQUESTED_CHASSIS_KEY]\u003dbinding_profile[\u0027migrating_to\u0027]"},{"line_number":316,"context_line":"            txn.add(ovn_client._nb_idl.set_lswitch_port("}],"source_content_type":"text/x-python","patch_set":4,"id":"90b5132b_a547d7a3","line":313,"updated":"2023-07-17 16:20:57.000000000","message":"I don\u0027t think this is effective for subports, is it?","commit_id":"08712cfdfaaf4616d69984ca6a11038e429fbc61"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0ebe4c8866b22e374ed2f4b5d8faaa7ec7776bbf","unresolved":true,"context_lines":[{"line_number":310,"context_line":"                                          revision_mismatch_raise\u003dTrue) as txn:"},{"line_number":311,"context_line":"            txn.add(check_rev_cmd)"},{"line_number":312,"context_line":"            new_options \u003d {}"},{"line_number":313,"context_line":"            new_options[\u0027activation-strategy\u0027]\u003d\u0027rarp\u0027"},{"line_number":314,"context_line":"            new_options[ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS]\u003d\u0027true\u0027"},{"line_number":315,"context_line":"            new_options[ovn_const.LSP_OPTIONS_REQUESTED_CHASSIS_KEY]\u003dbinding_profile[\u0027migrating_to\u0027]"},{"line_number":316,"context_line":"            txn.add(ovn_client._nb_idl.set_lswitch_port("}],"source_content_type":"text/x-python","patch_set":4,"id":"3206dc6f_8348a0e8","line":313,"updated":"2023-07-17 16:20:57.000000000","message":"this code section is duplicating code that sets the same options for a regular VIF. I think you should reuse the code instead of duplicating it.\n\nThis is especially important because there\u0027s another patch in flight that removes FLOOD_REPORTS\u003dtrue: https://review.opendev.org/c/openstack/neutron/+/888127 and if you may reintroduce the issue it is trying to address.","commit_id":"08712cfdfaaf4616d69984ca6a11038e429fbc61"}]}