)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"34cbb5ae7ceab83c87acc520b84bbeb330e8eecc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f93ce00e_bdd00cb8","updated":"2023-04-17 10:58:20.000000000","message":"Please report a launchpad bug and provide a way to test it.","commit_id":"6f5101890256a93c026fa002d11010fa21dc4cff"},{"author":{"_account_id":30772,"name":"Ihtisham ul Haq","display_name":"Ihtisham ul Haq","email":"ihtisham.ul_haq@mail.schwarz","username":"ihtisham","status":"STACKIT (Schwarz IT)"},"change_message_id":"632926c9e12f07286e44016b37d196a0578a935c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"164d7955_590bb444","in_reply_to":"eb20c2f3_8fe01a05","updated":"2023-04-20 10:51:48.000000000","message":"Done","commit_id":"6f5101890256a93c026fa002d11010fa21dc4cff"},{"author":{"_account_id":30772,"name":"Ihtisham ul Haq","display_name":"Ihtisham ul Haq","email":"ihtisham.ul_haq@mail.schwarz","username":"ihtisham","status":"STACKIT (Schwarz IT)"},"change_message_id":"048fd32e23d8a3d2be18c39d4e4ba392211cf4df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb20c2f3_8fe01a05","in_reply_to":"f93ce00e_bdd00cb8","updated":"2023-04-17 18:33:38.000000000","message":"Bug reported, also includes steps for for reproduction/testing:\n\nhttps://launchpad.net/bugs/2016704","commit_id":"6f5101890256a93c026fa002d11010fa21dc4cff"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2881605462e9b8f14bde0f811731307764ce4209","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4acab113_3529502a","updated":"2023-04-20 10:40:15.000000000","message":"This change is indeed improving the DB performance.\n\nI would add some explanation in the commit message. For example:\n\"\"\"\nUse a explicit inner join for networks in port query\n\nThis improves the performance of the database when fetching a list of ports\nfor a project user. This change creates an inner join with the networks\nbelonging to the ports.\n\nPrevious SQL query:\n  SELECT ports ...\n  FROM network, ports ...\n  WHERE ports.project_id \u003d \u003cproject\u003e\n    OR ports.network_id \u003d networks.id\n    AND networks.project_id \u003d \u003cproject\u003e\n\nCurrent SQL query:\n  SELECT ports ...\n  FROM ports\n  INNER JOIN networks ON networks.id \u003d ports.network_id\n  WHERE ports.project_id \u003d \u003cproject\u003e\n    OR networks.project_id \u003d \u003cproject\u003e\n\nCloses-Bug: #2016704\n\"\"\"","commit_id":"489d603fa44ec3ece984233288bb6f5702365762"},{"author":{"_account_id":30772,"name":"Ihtisham ul Haq","display_name":"Ihtisham ul Haq","email":"ihtisham.ul_haq@mail.schwarz","username":"ihtisham","status":"STACKIT (Schwarz IT)"},"change_message_id":"f021a1fcfada451e9893146e3c176d973da36b82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a4245d3c_11789a11","updated":"2023-04-18 08:51:44.000000000","message":"recheck","commit_id":"489d603fa44ec3ece984233288bb6f5702365762"},{"author":{"_account_id":30772,"name":"Ihtisham ul Haq","display_name":"Ihtisham ul Haq","email":"ihtisham.ul_haq@mail.schwarz","username":"ihtisham","status":"STACKIT (Schwarz IT)"},"change_message_id":"632926c9e12f07286e44016b37d196a0578a935c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6dbeca5e_ddb4bd22","in_reply_to":"4acab113_3529502a","updated":"2023-04-20 10:51:48.000000000","message":"Thanks, done.","commit_id":"489d603fa44ec3ece984233288bb6f5702365762"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"edb17e483a5641a4704c5d93b873b7d1fb902240","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7d3d6657_d50c3f15","updated":"2023-04-20 11:12:05.000000000","message":"This is a candidate to be backported","commit_id":"f23d7af8d7e36b9d52a8c8ccf64355e22f3adb9c"},{"author":{"_account_id":30772,"name":"Ihtisham ul Haq","display_name":"Ihtisham ul Haq","email":"ihtisham.ul_haq@mail.schwarz","username":"ihtisham","status":"STACKIT (Schwarz IT)"},"change_message_id":"815d2f8156b815af71fcb08f3409614abb2e545f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"517a39b4_bda4945c","updated":"2023-04-20 14:03:27.000000000","message":"recheck","commit_id":"f23d7af8d7e36b9d52a8c8ccf64355e22f3adb9c"},{"author":{"_account_id":30772,"name":"Ihtisham ul Haq","display_name":"Ihtisham ul Haq","email":"ihtisham.ul_haq@mail.schwarz","username":"ihtisham","status":"STACKIT (Schwarz IT)"},"change_message_id":"00ec4c1cf309af84e0fa719d344de92ff0dee520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6ea81135_217a0cfd","updated":"2023-04-26 11:10:05.000000000","message":"recheck","commit_id":"f23d7af8d7e36b9d52a8c8ccf64355e22f3adb9c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"604861d3fb9dc260137edd1884bb6d7e9889b87a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ebb0d1b7_a809a22d","updated":"2023-04-28 19:45:22.000000000","message":"recheck Public network connectivity check failed","commit_id":"f23d7af8d7e36b9d52a8c8ccf64355e22f3adb9c"},{"author":{"_account_id":30772,"name":"Ihtisham ul Haq","display_name":"Ihtisham ul Haq","email":"ihtisham.ul_haq@mail.schwarz","username":"ihtisham","status":"STACKIT (Schwarz IT)"},"change_message_id":"3693f7f7924950583a51b40bb518b306107cc650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c299fd35_2fe56b6b","updated":"2023-05-17 12:54:48.000000000","message":"recheck failure due to https://bugs.launchpad.net/neutron/+bug/2007166 not related to this change","commit_id":"f23d7af8d7e36b9d52a8c8ccf64355e22f3adb9c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b01daf0ae2f3b635ced8c70b9f8b95b2c3e744fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ec7a929c_df167aaf","updated":"2023-04-25 09:22:34.000000000","message":"recheck tempest fixed","commit_id":"f23d7af8d7e36b9d52a8c8ccf64355e22f3adb9c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7d5d1713289eb392f3c74a83f5a5402d610783e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6bd59244_0c5157ab","updated":"2023-04-24 22:06:57.000000000","message":"recheck tooz constraint merged","commit_id":"f23d7af8d7e36b9d52a8c8ccf64355e22f3adb9c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"943df5ba7ff977d3423d7fac60d3abfc5ce68172","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9a405568_7c234c00","updated":"2023-04-28 15:39:52.000000000","message":"recheck vexxhost nodes disabled","commit_id":"f23d7af8d7e36b9d52a8c8ccf64355e22f3adb9c"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"d9c5ce72aba38660831a5845834d97a4fde1ab61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c078c92b_f8d4c2a7","updated":"2023-04-24 21:32:18.000000000","message":"very nice, simple and very effective!","commit_id":"f23d7af8d7e36b9d52a8c8ccf64355e22f3adb9c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"36b2b3b6e5e3237e531afae5bf7af1f6f8f66526","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"84d76d66_59274683","in_reply_to":"6ea81135_217a0cfd","updated":"2023-04-27 09:00:54.000000000","message":"Please recheck with reason, if you have bug report with the same issue, add to the comment as reference, if you have no bug number just check the failure if it is really not related to your change, and add a comment about it","commit_id":"f23d7af8d7e36b9d52a8c8ccf64355e22f3adb9c"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2881605462e9b8f14bde0f811731307764ce4209","unresolved":true,"context_lines":[{"line_number":113,"context_line":"def _port_query_hook(context, original_model, query):"},{"line_number":114,"context_line":"    # Apply the port query only in non-admin and non-advsvc context"},{"line_number":115,"context_line":"    if ndb_utils.model_query_scope_is_project(context, original_model):"},{"line_number":116,"context_line":"        query \u003d query.join(models_v2.Network)"},{"line_number":117,"context_line":"    return query"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"4291e60c_b7c9bd0c","line":116,"range":{"start_line":116,"start_character":26,"end_line":116,"end_character":45},"updated":"2023-04-20 10:40:15.000000000","message":"make the inner join relationship explicit:\n  query \u003d query.join(models_v2.Network,\n                     models_v2.Network.id \u003d\u003d models_v2.Port.network_id)","commit_id":"489d603fa44ec3ece984233288bb6f5702365762"},{"author":{"_account_id":30772,"name":"Ihtisham ul Haq","display_name":"Ihtisham ul Haq","email":"ihtisham.ul_haq@mail.schwarz","username":"ihtisham","status":"STACKIT (Schwarz IT)"},"change_message_id":"632926c9e12f07286e44016b37d196a0578a935c","unresolved":true,"context_lines":[{"line_number":113,"context_line":"def _port_query_hook(context, original_model, query):"},{"line_number":114,"context_line":"    # Apply the port query only in non-admin and non-advsvc context"},{"line_number":115,"context_line":"    if ndb_utils.model_query_scope_is_project(context, original_model):"},{"line_number":116,"context_line":"        query \u003d query.join(models_v2.Network)"},{"line_number":117,"context_line":"    return query"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"64d999b2_249833eb","line":116,"range":{"start_line":116,"start_character":26,"end_line":116,"end_character":45},"in_reply_to":"4291e60c_b7c9bd0c","updated":"2023-04-20 10:51:48.000000000","message":"Updated","commit_id":"489d603fa44ec3ece984233288bb6f5702365762"}]}