)]}'
{"neutron/tests/functional/agent/linux/test_keepalived.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"06f5dc7bc0125f2615fa75bc798093bee98d94ab","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            # that SIGKILL gets called on a process that just exited due to"},{"line_number":60,"context_line":"            # SIGTERM. Ignore this condition so the test is not marked as"},{"line_number":61,"context_line":"            # failed."},{"line_number":62,"context_line":"            if not (len(process_err.args) \u003e 0 and"},{"line_number":63,"context_line":"                    \"No such process\" in process_err.args[0]):"},{"line_number":64,"context_line":"                raise"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e91a7ab1_4bc01910","line":62,"updated":"2023-04-23 16:11:32.000000000","message":"Something looks not right with the condition.\n\nI think you just want `if len(..) \u003e 0 and \"No ...\" in ...[0]`, right?","commit_id":"43829301f3ea280913932af9c7eb7cbc42fde8c5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f3d0e81a4c200c4946f1e95f9336203cabeb3769","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            # that SIGKILL gets called on a process that just exited due to"},{"line_number":60,"context_line":"            # SIGTERM. Ignore this condition so the test is not marked as"},{"line_number":61,"context_line":"            # failed."},{"line_number":62,"context_line":"            if not (len(process_err.args) \u003e 0 and"},{"line_number":63,"context_line":"                    \"No such process\" in process_err.args[0]):"},{"line_number":64,"context_line":"                raise"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"29c6a2ed_b8f6a42e","line":62,"in_reply_to":"249b99d5_292a3718","updated":"2023-04-25 08:26:02.000000000","message":"Oh yes I missed the parenthesis. My mistake.\n\nIn case of this error you don\u0027t have a ESRCH returned? may be better to check by error code, no?","commit_id":"43829301f3ea280913932af9c7eb7cbc42fde8c5"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"3198296568ac70cc00f88c42e5c29f5b394e3070","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            # that SIGKILL gets called on a process that just exited due to"},{"line_number":60,"context_line":"            # SIGTERM. Ignore this condition so the test is not marked as"},{"line_number":61,"context_line":"            # failed."},{"line_number":62,"context_line":"            if not (len(process_err.args) \u003e 0 and"},{"line_number":63,"context_line":"                    \"No such process\" in process_err.args[0]):"},{"line_number":64,"context_line":"                raise"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4ab37197_7784a15f","line":62,"in_reply_to":"29c6a2ed_b8f6a42e","updated":"2023-04-25 14:48:39.000000000","message":"As far as I can tell in this case the only object I can work with it is the ProcessExecutionError which returns exit code 1 and arguments. See Traceback in this link\nhttps://32177b17610869e1b83a-af1192da167b817506a58f20e6af9357.ssl.cf2.rackcdn.com/periodic/opendev.org/openstack/neutron/master/neutron-functional-with-uwsgi-fips/dc3710e/testr_results.html","commit_id":"43829301f3ea280913932af9c7eb7cbc42fde8c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6c9c0e4b191f47146e0ad7e864bb06e2440ab2cf","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            # that SIGKILL gets called on a process that just exited due to"},{"line_number":60,"context_line":"            # SIGTERM. Ignore this condition so the test is not marked as"},{"line_number":61,"context_line":"            # failed."},{"line_number":62,"context_line":"            if not (len(process_err.args) \u003e 0 and"},{"line_number":63,"context_line":"                    \"No such process\" in process_err.args[0]):"},{"line_number":64,"context_line":"                raise"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"33080dca_0ffdd1e6","line":62,"in_reply_to":"4ab37197_7784a15f","updated":"2023-04-26 07:33:47.000000000","message":"as this is in test only I\u0027m ok with current approach. Thx Miro","commit_id":"43829301f3ea280913932af9c7eb7cbc42fde8c5"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"916008507f31379276b294cd767fd221485270ad","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            # that SIGKILL gets called on a process that just exited due to"},{"line_number":60,"context_line":"            # SIGTERM. Ignore this condition so the test is not marked as"},{"line_number":61,"context_line":"            # failed."},{"line_number":62,"context_line":"            if not (len(process_err.args) \u003e 0 and"},{"line_number":63,"context_line":"                    \"No such process\" in process_err.args[0]):"},{"line_number":64,"context_line":"                raise"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"249b99d5_292a3718","line":62,"in_reply_to":"e91a7ab1_4bc01910","updated":"2023-04-24 15:45:28.000000000","message":"The indent is to NOT to raise if \"no such process\" error occurs. The len() check is there just to perform safe list access. So to me this logic is OK.","commit_id":"43829301f3ea280913932af9c7eb7cbc42fde8c5"}]}