)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"172215105eb4a58f8f09937ec305f7b4408c0f0c","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Note the same test with less concurrency does not replicate this error."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch adds a retry mechanism when fetching the metadata port for"},{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases. The patch also improves"},{"line_number":32,"context_line":"a little the error logged to discriminate between the port not being"},{"line_number":33,"context_line":"found or the IP configuration being missing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7f39743d_808e9902","line":30,"updated":"2024-02-21 17:04:09.000000000","message":"`hopefully` suggests that maybe it should be configurable","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"172215105eb4a58f8f09937ec305f7b4408c0f0c","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Note the same test with less concurrency does not replicate this error."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch adds a retry mechanism when fetching the metadata port for"},{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases. The patch also improves"},{"line_number":32,"context_line":"a little the error logged to discriminate between the port not being"},{"line_number":33,"context_line":"found or the IP configuration being missing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"424992cb_ebd34ef4","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":23},"updated":"2024-02-21 17:04:09.000000000","message":"what happens when 10 seconds end? will the port never recover? would it make sense to keep retrying to allow \"eventual consistency\" do its work?","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b1faa0d9adbe4fb49d309c3cde2776069e1d5d4","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Note the same test with less concurrency does not replicate this error."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch adds a retry mechanism when fetching the metadata port for"},{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases. The patch also improves"},{"line_number":32,"context_line":"a little the error logged to discriminate between the port not being"},{"line_number":33,"context_line":"found or the IP configuration being missing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"e0298f0c_559fa86f","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":23},"in_reply_to":"424992cb_ebd34ef4","updated":"2024-02-23 00:22:13.000000000","message":"We give-up and teardown the namespace. I don\u0027t think there is an easy way to keep trying, an admin would have to restart the agent for it to try again.","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b1faa0d9adbe4fb49d309c3cde2776069e1d5d4","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Note the same test with less concurrency does not replicate this error."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch adds a retry mechanism when fetching the metadata port for"},{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases. The patch also improves"},{"line_number":32,"context_line":"a little the error logged to discriminate between the port not being"},{"line_number":33,"context_line":"found or the IP configuration being missing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"b69a7077_4057f4c3","line":30,"in_reply_to":"7f39743d_808e9902","updated":"2024-02-23 00:22:13.000000000","message":"Generally retrying helps, but I\u0027d be open to suggestions for follow-ons to make it better.","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"41a86930adb70c6df09d355b2f3ffbcbdd0d5e93","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Note the same test with less concurrency does not replicate this error."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch adds a retry mechanism when fetching the metadata port for"},{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases. The patch also improves"},{"line_number":32,"context_line":"a little the error logged to discriminate between the port not being"},{"line_number":33,"context_line":"found or the IP configuration being missing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"04c95568_8b736710","line":30,"in_reply_to":"b69a7077_4057f4c3","updated":"2024-08-15 23:54:59.000000000","message":"I\u0027d rather not add a configurable, I just removed the \u0027hopefully\u0027 word.","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"41a86930adb70c6df09d355b2f3ffbcbdd0d5e93","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Note the same test with less concurrency does not replicate this error."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch adds a retry mechanism when fetching the metadata port for"},{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases. The patch also improves"},{"line_number":32,"context_line":"a little the error logged to discriminate between the port not being"},{"line_number":33,"context_line":"found or the IP configuration being missing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"94c4cb4a_faae093a","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":23},"in_reply_to":"e0298f0c_559fa86f","updated":"2024-08-15 23:54:59.000000000","message":"Done","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a343542c0806d99a5c08565ca313ae9cd98c2d9a","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch adds a retry mechanism when fetching the metadata port for"},{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases. The patch also improves"},{"line_number":32,"context_line":"a little the error logged to discriminate between the port not being"},{"line_number":33,"context_line":"found or the IP configuration being missing."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Closes-Bug: #2017748"},{"line_number":36,"context_line":"Change-Id: I762c894f38f9b2856853b781822063d9a6c448e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"cd7101f6_11be1f54","line":33,"range":{"start_line":31,"start_character":49,"end_line":33,"end_character":44},"updated":"2024-02-05 19:34:53.000000000","message":"My latest update removes the logging differences, so will have to update this message.","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b1faa0d9adbe4fb49d309c3cde2776069e1d5d4","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch adds a retry mechanism when fetching the metadata port for"},{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases. The patch also improves"},{"line_number":32,"context_line":"a little the error logged to discriminate between the port not being"},{"line_number":33,"context_line":"found or the IP configuration being missing."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Closes-Bug: #2017748"},{"line_number":36,"context_line":"Change-Id: I762c894f38f9b2856853b781822063d9a6c448e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"f853a401_e919e45d","line":33,"range":{"start_line":31,"start_character":49,"end_line":33,"end_character":44},"in_reply_to":"cd7101f6_11be1f54","updated":"2024-02-23 00:22:13.000000000","message":"Done","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"172215105eb4a58f8f09937ec305f7b4408c0f0c","unresolved":true,"context_lines":[{"line_number":32,"context_line":"a little the error logged to discriminate between the port not being"},{"line_number":33,"context_line":"found or the IP configuration being missing."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Closes-Bug: #2017748"},{"line_number":36,"context_line":"Change-Id: I762c894f38f9b2856853b781822063d9a6c448e5"},{"line_number":37,"context_line":"Signed-off-by: Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"e15f5015_f70979ed","line":35,"updated":"2024-02-21 17:04:09.000000000","message":"this bug is already closed. is the bug not fixed yet? is it \u0027Related-Bug\u0027?","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b1faa0d9adbe4fb49d309c3cde2776069e1d5d4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"a little the error logged to discriminate between the port not being"},{"line_number":33,"context_line":"found or the IP configuration being missing."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Closes-Bug: #2017748"},{"line_number":36,"context_line":"Change-Id: I762c894f38f9b2856853b781822063d9a6c448e5"},{"line_number":37,"context_line":"Signed-off-by: Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"45e661dc_df18c66e","line":35,"in_reply_to":"e15f5015_f70979ed","updated":"2024-02-23 00:22:13.000000000","message":"Done","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cc90dda1eb04953d4db2daf25d7e7314e6d06608","unresolved":true,"context_lines":[{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Closes-Bug: #2017748"},{"line_number":34,"context_line":"Change-Id: I762c894f38f9b2856853b781822063d9a6c448e5"},{"line_number":35,"context_line":"Signed-off-by: Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a13dc53_d0c8122c","line":33,"updated":"2024-05-01 16:13:06.000000000","message":"the bug is marked closed already; is it still valid? (I believe I asked before about it...)","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"41a86930adb70c6df09d355b2f3ffbcbdd0d5e93","unresolved":false,"context_lines":[{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Closes-Bug: #2017748"},{"line_number":34,"context_line":"Change-Id: I762c894f38f9b2856853b781822063d9a6c448e5"},{"line_number":35,"context_line":"Signed-off-by: Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"302d85c8_1df40f09","line":33,"in_reply_to":"6db6a9c2_b801b0f8","updated":"2024-08-15 23:54:59.000000000","message":"Done","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"989abd79ee3cd7eca74c94a874ed1e3e1184f765","unresolved":true,"context_lines":[{"line_number":30,"context_line":"a maximum of 10 seconds. That (hopefully) should be enough for OVN to"},{"line_number":31,"context_line":"propagate the information between the databases."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Closes-Bug: #2017748"},{"line_number":34,"context_line":"Change-Id: I762c894f38f9b2856853b781822063d9a6c448e5"},{"line_number":35,"context_line":"Signed-off-by: Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"6db6a9c2_b801b0f8","line":33,"in_reply_to":"9a13dc53_d0c8122c","updated":"2024-05-01 19:40:37.000000000","message":"I believe it\u0027s still valid, I could change this to Related-bug as we still see this failure.","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ac7a33987899c55d3602b0bd1d3a5317144f3960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a6a7f698_4a11342d","updated":"2023-04-25 15:59:42.000000000","message":"I know you are still working on this. Looks very interesting.\n\nIf possible, please open a LP bug.\n\nThanks!","commit_id":"bb0948f66af022bcd105a665a0b4cf2036aac425"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9b0e1a104239aa76f21833a5d404833d0a2b7103","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9836fbe7_fd7a978e","updated":"2023-04-25 15:55:19.000000000","message":"Need an LP and tests. WIP","commit_id":"bb0948f66af022bcd105a665a0b4cf2036aac425"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a5007ba8a42d0bd4dc346770a6812f884f57f436","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3f47fef_b8601951","in_reply_to":"a6a7f698_4a11342d","updated":"2023-04-26 08:47:10.000000000","message":"Sure I am on it. Also needs some tests","commit_id":"bb0948f66af022bcd105a665a0b4cf2036aac425"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"37a850b830b006c6774e9561e94171ef3c5ed679","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"06fcf13f_eabab1fc","updated":"2023-05-11 12:14:38.000000000","message":"Getting back to this, thank you all for the ideas/comments!","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"82f3ba9f21273ef41b7649d498da75339e05732b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32dc0d5f_cafadd1b","updated":"2023-05-11 01:48:47.000000000","message":"Thanks for the fix. I like the logging improvements.","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f72642726d224a970cc05dc0b5afc2a3e442e03c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"303fd816_dce2ad3a","updated":"2023-04-26 13:55:13.000000000","message":"Thanks for working on this Lucas, we might have seen this in one of our environments as well.","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f761c4244970e7279dc01bea7d2c80172b147ab5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a61cd78_7a93d5b7","updated":"2023-05-11 10:30:17.000000000","message":"recheck tempest ipv6","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"799b75691ae76d22b1ed5608118992570bcd9cc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"859bf357_03dad2f2","updated":"2023-05-17 15:36:16.000000000","message":"I still don\u0027t understand why the test is failing.","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"16090800f38cae1a456b19c35c52a823eeaf8acb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b0e2d6b_0580ee46","updated":"2023-05-11 14:28:02.000000000","message":"LGTM. Thanks Lucas","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cc9cc8c523ba7a1c0684ab10823e98f21babbe83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a531905_1bbf7bf6","updated":"2023-05-11 15:51:36.000000000","message":"recheck \"no interfaces have a carrier\" failure","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"58760af91905bbfc8c14643b842c54312e9351bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de4cd45f_87e87293","updated":"2023-05-15 19:24:58.000000000","message":"recheck metadata failure\n\nNot sure if the ERRORs here are related?\n\nhttps://53fa70b395e77b86c260-73c930168e2b5366764f1169d2ac4ce3.ssl.cf5.rackcdn.com/881487/3/check/tempest-integrated-networking/b3dc31d/controller/logs/screen-q-ovn-metadata-agent.txt","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e52cafde80b0acd04d24b218b0b655d2443571c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"317524d6_3d483683","updated":"2023-05-15 16:47:57.000000000","message":"recheck test_vlan_transparent_allowed_address_pairs failure","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"82093d88cf80cea4a28fdd2db9dd8e17d0ec1ada","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8452d677_df7b5bac","updated":"2023-05-15 14:19:04.000000000","message":"recheck unrelated tempest failure","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5aaa96637930ee7e2fea8d58e496768b023c4730","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2f91a28c_0533eb07","updated":"2023-05-17 16:22:36.000000000","message":"Trying to debug job failure, don\u0027t merge","commit_id":"66f02a933984a9768411e8705c0bd1dcc35a834a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f648b18b542c514601f21b8fc7c5564f1678bf93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4d85a949_c0af8b55","updated":"2023-05-23 12:08:33.000000000","message":"I think we will need to analyze this better cause the errors does seem related","commit_id":"61058a07a5b6d0f81f74132e1c8ed7e8d60ae8db"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"2809e4b9f3c66c5fdf8db92db26f7d07ade12de8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"264a157f_b40d4ec7","updated":"2023-05-19 02:05:29.000000000","message":"LGTM","commit_id":"61058a07a5b6d0f81f74132e1c8ed7e8d60ae8db"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c5cb94d8c1157336827e3a032424d34010747686","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bfb6b734_8b1abcf5","updated":"2023-05-22 14:23:25.000000000","message":"recheck unrelated tempest failure","commit_id":"61058a07a5b6d0f81f74132e1c8ed7e8d60ae8db"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb23e96a1c14fd3252e462a269444189526e93da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0e64b0c3_635addd2","updated":"2024-01-18 12:23:27.000000000","message":"Hi Lucas, is this patch still valid?","commit_id":"ba9ddfae445f5dbf22b480e4442bf64d819bd66a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7158f9dc7f6b813111d7fd4987fbe15bc8ac9c20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3df8745c_6df39f62","updated":"2024-01-31 22:38:41.000000000","message":"Need to update to fix py38 failure","commit_id":"497e7130d94de276d450ecb2b7bd2c7af074133c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"172215105eb4a58f8f09937ec305f7b4408c0f0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"daf008f2_77226516","updated":"2024-02-21 17:04:09.000000000","message":"---\n\nIn general, it seems to me wrong that the agent proceeds with any provisioning decisions before metadata port mac is ready. Perhaps there should be two paths to provision a port metadata:\n\n- port is up (ignore if local metadata-port-mac mapping is empty.)\n- metadata-port-mac is updated (then populate the mapping and provision all relevant ports.)","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"037050c02d053e01c83c7ff49f4f216ae383b1a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bbdd913a_519dcd65","updated":"2024-02-01 06:17:38.000000000","message":"recheck neutron-functional-with-uwsgi","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9465592e5070aec42729e485b9725a3762322ada","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6d3241fe_a8624f39","in_reply_to":"2e73834f_7d3b4f15","updated":"2024-05-16 16:32:23.000000000","message":"Can we please comment on it?","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e2c8455bb291b37490a491c3f0a6a23920793361","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"973de180_87bfd9c1","in_reply_to":"6d3241fe_a8624f39","updated":"2024-05-19 00:44:08.000000000","message":"I think according to the code today we will not provision a datapath here if the mac is not set, it\u0027s the first check in provision_datapath().\n\nAlso, if provision_datapath() ever raises a ConfigException it will resync everything.\n\nI would have to run through the scenarios you listed (I\u0027ve been out of office for over a week), but is there a case where the mac of a metadata port will change after creation?","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"41a86930adb70c6df09d355b2f3ffbcbdd0d5e93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"26295e90_ff5f9799","in_reply_to":"973de180_87bfd9c1","updated":"2024-08-15 23:54:59.000000000","message":"I believe this is resolved as provisioning will not be completed if the metadata port does not have a mac.","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cc90dda1eb04953d4db2daf25d7e7314e6d06608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2e73834f_7d3b4f15","in_reply_to":"daf008f2_77226516","updated":"2024-05-01 16:13:06.000000000","message":"Was this comment addressed? I don\u0027t see it.","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"7eb8425e10c3ceb53dd104662391d94e33348ce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a591f762_45b0b955","updated":"2024-05-01 16:31:28.000000000","message":"Can this be reproduced with https://review.opendev.org/c/openstack/neutron/+/903796 applied?\n\nUnder load I saw that ovsdb-server will sometimes merge an insert/update into an \"updated insert\" notification and this is expected behavior.","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"59eb0356541c3348c91702be358b3b6e616e90c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"45bddeaf_6b43c13f","updated":"2024-07-22 09:15:45.000000000","message":"Hi, is this retry patch still valid? \n\nThe patch (https://review.opendev.org/c/openstack/neutron/+/903796) requires a refactor patch (commit 6205158831), making it almost impossible to backport to older versions (eg: yoga). Should we proceed with this retry patch? it should also be able to fix the problem in theory. thanks.","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dd3b1bf9e81c216c373b21ef600a141ce8ec87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"08ecdb14_e5481d75","updated":"2024-03-06 08:35:00.000000000","message":"Will you backport it?","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"989abd79ee3cd7eca74c94a874ed1e3e1184f765","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"911fab71_33a15a9a","updated":"2024-05-01 19:40:37.000000000","message":"recheck get some new logs","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"09ea216d68148afc268f4e75c8f94bd56b6d8465","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"241e1fec_a171ff0d","updated":"2024-02-26 14:23:51.000000000","message":"recheck unrelated test failure","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"de58cf8740fa1c0fd1c832cc5e48b94dda1e62d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5c0ad7da_b010d579","updated":"2024-02-23 23:22:11.000000000","message":"recheck unrelated test failure","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d7fef740aa0bb9a59d896c880d7423745c604afa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c2912148_20ba1cbf","updated":"2024-02-23 16:31:50.000000000","message":"recheck, https://review.opendev.org/c/openstack/neutron/+/909998 merged","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"16325ee3ff97cb974fc855d115163dac3e7d4a78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"dc3a1042_ca418e41","in_reply_to":"08ecdb14_e5481d75","updated":"2024-03-06 11:41:46.000000000","message":"Can be backported after it\u0027s merged on master","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"15968bf1ba9b08d070f050f25cec9b329ec49052","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"646747ab_e6524e79","in_reply_to":"2dfdd89c_e7fbf233","updated":"2024-08-19 20:00:22.000000000","message":"It\u0027s all about customers. I would be curious if you were able to get this back to Wallaby, a couple of us tried and it didn\u0027t turn out well.","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"809afedb75485192541498bea3ddac190975530f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bd4bd80b_91b0e7de","in_reply_to":"417371c4_b4c65ac6","updated":"2024-08-16 17:26:08.000000000","message":"Terry - I understand, there\u0027s just no way to backport that change to Yoga (too many requirements and conflicts) so figured I\u0027d rebase this one and check the logs at least.","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"41a86930adb70c6df09d355b2f3ffbcbdd0d5e93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"839f989c_ae0196cf","in_reply_to":"45bddeaf_6b43c13f","updated":"2024-08-15 23:54:59.000000000","message":"According to Terry the other patch should fix the problem, but I guess I don\u0027t see any reason to not attempt the retry. Let me rebase this and see what others think.","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a128b75dcfa80a747837f27a2babf764fc7ad2cc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"764fb50a_060198f9","in_reply_to":"646747ab_e6524e79","updated":"2024-08-20 15:24:46.000000000","message":"I get the customer thing--we do downstream backports for them all the time (as you know!). It\u0027s just the targeting for master when it\u0027s not needed there instead of just doing the different fix in the branch that needs it that I don\u0027t really get.\n\nThe patch we merged downstream relied on @libosvar@redhat.com\u0027s refactor patch, but it turns out that the original version of my backport was prior to that, so I posted it here: https://review.opendev.org/c/openstack/neutron/+/926656 (after already going to the trouble of posting a different version with both the refactor backported and my patch on top of it--which we can probably abandon).","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"593cb5d357f46777402bb051457e419ef0d4842a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"417371c4_b4c65ac6","in_reply_to":"839f989c_ae0196cf","updated":"2024-08-16 16:31:52.000000000","message":"I just have moral issues with retries. ;) They are too frequently used as a bandaid to work around problems that should be solved more directly.\n\nThat isn\u0027t to say that this is necessarily one of those times and there couldn\u0027t be some other theoretical way for the data to not be created. But I\u0027d really like to know what that is before trying to throw in a random retry; that way we could fix the real underlying race condition instead of just trying again just in case.","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"989abd79ee3cd7eca74c94a874ed1e3e1184f765","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fd380662_f02bdcf7","in_reply_to":"a591f762_45b0b955","updated":"2024-05-01 19:40:37.000000000","message":"Well, from my comment a year ago it still happened, but I see your change has merged since then. All the logs are long gone, I\u0027ll generate some new ones to check.","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"893a69cb864e63d5342826458791d884678b9e23","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2dfdd89c_e7fbf233","in_reply_to":"bd4bd80b_91b0e7de","updated":"2024-08-19 18:26:40.000000000","message":"I\u0027m probably missing something, this is a patch to master. And isn\u0027t yoga in the \"unmaintained\" branches? Why would we make an unneeded change to master because a fix couldn\u0027t be easily backported to an unmaintained branch? If we were going to maintain yoga and make a fix for it, wouldn\u0027t we just do this different fix there?\n\nAlso, I\u0027m almost 100% sure we did a downstream backport of this to wallaby (since it too was unmaintained upstream). I\u0027m sure there were some other downstream-only backports applied as well so it might not be a 1:1 thing, but I can check and see how big of a change it would be to do something for yoga if we\u0027re still doing backports to there.","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"2711dacb7db5644013cbbdc510cc7191b6cc4ecf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a7e86a8c_9a4af5bc","updated":"2024-08-16 16:24:17.000000000","message":"Did this not get fixed with https://review.opendev.org/c/openstack/neutron/+/904716?","commit_id":"e11c8be99caa24173288f1a309adecafe61a5cd4"},{"author":{"_account_id":37239,"name":"volkan ural","display_name":"WiCloudX","email":"uralvolkan278@gmail.com","username":"Kaostattoo89"},"change_message_id":"a693a2feb55a1646516093ca9734eeb1c9c5d2c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"156b5955_f8a53ecd","updated":"2024-08-16 04:37:00.000000000","message":"meta","commit_id":"e11c8be99caa24173288f1a309adecafe61a5cd4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"daab6fdbc6faf82361f7ee108ea5cb6b57e09169","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"bb7b863a_0f7cce0d","updated":"2024-08-16 02:10:32.000000000","message":"recheck stack.sh failure","commit_id":"e11c8be99caa24173288f1a309adecafe61a5cd4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"809afedb75485192541498bea3ddac190975530f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5ea40244_1609cca5","updated":"2024-08-16 17:26:08.000000000","message":"recheck unrelated tempest failure","commit_id":"e11c8be99caa24173288f1a309adecafe61a5cd4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3e5d52a92397a007fb0812cce4a23830c9d7f4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e863e7e2_3709358d","updated":"2024-08-16 13:00:16.000000000","message":"recheck unrelated tempest failure","commit_id":"e11c8be99caa24173288f1a309adecafe61a5cd4"}],"neutron/agent/ovn/metadata/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f72642726d224a970cc05dc0b5afc2a3e442e03c","unresolved":true,"context_lines":[{"line_number":527,"context_line":"        if not metadata_port:"},{"line_number":528,"context_line":"            raise RuntimeError("},{"line_number":529,"context_line":"                _(\u0027No metadata port found for network %s (datapath: %s)\u0027) % ("},{"line_number":530,"context_line":"                    net_name, datapath_uuid))"},{"line_number":531,"context_line":"        if not (metadata_port.mac and metadata_port.external_ids.get("},{"line_number":532,"context_line":"                ovn_const.OVN_CIDRS_EXT_ID_KEY, None)):"},{"line_number":533,"context_line":"            raise RuntimeError("}],"source_content_type":"text/x-python","patch_set":2,"id":"12dc0659_17b2b7e8","line":530,"updated":"2023-04-26 13:55:13.000000000","message":"So looking in the failed tempest test logs shows this error a lot, I would have thought it would only be logged if it completely failed? and not on each raise?\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_642/881487/2/check/tempest-integrated-networking/6422550/controller/logs/screen-q-ovn-metadata-agent.txt\n\nAnd of course the failure test in that case didn\u0027t get metadata, don\u0027t know if it\u0027s related though.\n\nOne thing that might be useful after looking at that log though is a debug message indicating the port was found. I know something gets logged in provision_datapath() for the network, but putting something here before the return would be good imo.","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ee4bba652cd8a633a8a3e1942400821810a277fd","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        if not metadata_port:"},{"line_number":528,"context_line":"            raise RuntimeError("},{"line_number":529,"context_line":"                _(\u0027No metadata port found for network %s (datapath: %s)\u0027) % ("},{"line_number":530,"context_line":"                    net_name, datapath_uuid))"},{"line_number":531,"context_line":"        if not (metadata_port.mac and metadata_port.external_ids.get("},{"line_number":532,"context_line":"                ovn_const.OVN_CIDRS_EXT_ID_KEY, None)):"},{"line_number":533,"context_line":"            raise RuntimeError("}],"source_content_type":"text/x-python","patch_set":2,"id":"0bbbcacc_3dbff7d6","line":530,"in_reply_to":"12c58829_a7a7c397","updated":"2023-05-11 12:33:24.000000000","message":"Done","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"37a850b830b006c6774e9561e94171ef3c5ed679","unresolved":true,"context_lines":[{"line_number":527,"context_line":"        if not metadata_port:"},{"line_number":528,"context_line":"            raise RuntimeError("},{"line_number":529,"context_line":"                _(\u0027No metadata port found for network %s (datapath: %s)\u0027) % ("},{"line_number":530,"context_line":"                    net_name, datapath_uuid))"},{"line_number":531,"context_line":"        if not (metadata_port.mac and metadata_port.external_ids.get("},{"line_number":532,"context_line":"                ovn_const.OVN_CIDRS_EXT_ID_KEY, None)):"},{"line_number":533,"context_line":"            raise RuntimeError("}],"source_content_type":"text/x-python","patch_set":2,"id":"12c58829_a7a7c397","line":530,"in_reply_to":"12dc0659_17b2b7e8","updated":"2023-05-11 12:14:38.000000000","message":"Will take a look, thanks for the pointers!","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"82f3ba9f21273ef41b7649d498da75339e05732b","unresolved":true,"context_lines":[{"line_number":528,"context_line":"            raise RuntimeError("},{"line_number":529,"context_line":"                _(\u0027No metadata port found for network %s (datapath: %s)\u0027) % ("},{"line_number":530,"context_line":"                    net_name, datapath_uuid))"},{"line_number":531,"context_line":"        if not (metadata_port.mac and metadata_port.external_ids.get("},{"line_number":532,"context_line":"                ovn_const.OVN_CIDRS_EXT_ID_KEY, None)):"},{"line_number":533,"context_line":"            raise RuntimeError("},{"line_number":534,"context_line":"                _(\u0027Metadata port found for network %s (datapath: %s) but is \u0027"},{"line_number":535,"context_line":"                  \u0027missing IP address configuration\u0027) % (net_name,"},{"line_number":536,"context_line":"                                                         datapath_uuid))"},{"line_number":537,"context_line":"        return metadata_port"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def _get_provision_params(self, datapath):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5c1d4695_42ac926e","line":536,"range":{"start_line":531,"start_character":2,"end_line":536,"end_character":72},"updated":"2023-05-11 01:48:47.000000000","message":"nit: We could split this up to metadata_port.mac check+raise and external_ids check+raise. I am only suggesting this because we started checking explicitly for every condition why a metadapart is invalid.","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"37a850b830b006c6774e9561e94171ef3c5ed679","unresolved":true,"context_lines":[{"line_number":528,"context_line":"            raise RuntimeError("},{"line_number":529,"context_line":"                _(\u0027No metadata port found for network %s (datapath: %s)\u0027) % ("},{"line_number":530,"context_line":"                    net_name, datapath_uuid))"},{"line_number":531,"context_line":"        if not (metadata_port.mac and metadata_port.external_ids.get("},{"line_number":532,"context_line":"                ovn_const.OVN_CIDRS_EXT_ID_KEY, None)):"},{"line_number":533,"context_line":"            raise RuntimeError("},{"line_number":534,"context_line":"                _(\u0027Metadata port found for network %s (datapath: %s) but is \u0027"},{"line_number":535,"context_line":"                  \u0027missing IP address configuration\u0027) % (net_name,"},{"line_number":536,"context_line":"                                                         datapath_uuid))"},{"line_number":537,"context_line":"        return metadata_port"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def _get_provision_params(self, datapath):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bbc1fc1f_87cd6ea4","line":536,"range":{"start_line":531,"start_character":2,"end_line":536,"end_character":72},"in_reply_to":"5c1d4695_42ac926e","updated":"2023-05-11 12:14:38.000000000","message":"Sounds good, can raise more specific errors on each case as well. Thank you for the suggestion","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ee4bba652cd8a633a8a3e1942400821810a277fd","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            raise RuntimeError("},{"line_number":529,"context_line":"                _(\u0027No metadata port found for network %s (datapath: %s)\u0027) % ("},{"line_number":530,"context_line":"                    net_name, datapath_uuid))"},{"line_number":531,"context_line":"        if not (metadata_port.mac and metadata_port.external_ids.get("},{"line_number":532,"context_line":"                ovn_const.OVN_CIDRS_EXT_ID_KEY, None)):"},{"line_number":533,"context_line":"            raise RuntimeError("},{"line_number":534,"context_line":"                _(\u0027Metadata port found for network %s (datapath: %s) but is \u0027"},{"line_number":535,"context_line":"                  \u0027missing IP address configuration\u0027) % (net_name,"},{"line_number":536,"context_line":"                                                         datapath_uuid))"},{"line_number":537,"context_line":"        return metadata_port"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def _get_provision_params(self, datapath):"}],"source_content_type":"text/x-python","patch_set":2,"id":"50ae8197_f84b1d32","line":536,"range":{"start_line":531,"start_character":2,"end_line":536,"end_character":72},"in_reply_to":"bbc1fc1f_87cd6ea4","updated":"2023-05-11 12:33:24.000000000","message":"Done","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"23fc715886264f8fd7322f3be7fd5504833d6ab6","unresolved":true,"context_lines":[{"line_number":582,"context_line":"                datapath_ports_ips.extend(self._get_port_ips(chassis_port))"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        if not datapath_ports_ips:"},{"line_number":585,"context_line":"            LOG.debug(\"No valid VIF ports were found for network %s, \""},{"line_number":586,"context_line":"                      \"tearing the namespace down if needed\", net_name)"},{"line_number":587,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":588,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"a1251a77_1ab4409d","line":585,"range":{"start_line":585,"start_character":16,"end_line":585,"end_character":21},"updated":"2023-05-10 19:12:37.000000000","message":"This should probably also be info and not debug.","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ee4bba652cd8a633a8a3e1942400821810a277fd","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                datapath_ports_ips.extend(self._get_port_ips(chassis_port))"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        if not datapath_ports_ips:"},{"line_number":585,"context_line":"            LOG.debug(\"No valid VIF ports were found for network %s, \""},{"line_number":586,"context_line":"                      \"tearing the namespace down if needed\", net_name)"},{"line_number":587,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":588,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae4d637_04f7b4bd","line":585,"range":{"start_line":585,"start_character":16,"end_line":585,"end_character":21},"in_reply_to":"6ebf8a4a_b930c23a","updated":"2023-05-11 12:33:24.000000000","message":"Done","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7e9da98d18b0bf2f6a078fbf095246fc692e8c78","unresolved":true,"context_lines":[{"line_number":582,"context_line":"                datapath_ports_ips.extend(self._get_port_ips(chassis_port))"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        if not datapath_ports_ips:"},{"line_number":585,"context_line":"            LOG.debug(\"No valid VIF ports were found for network %s, \""},{"line_number":586,"context_line":"                      \"tearing the namespace down if needed\", net_name)"},{"line_number":587,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":588,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ebf8a4a_b930c23a","line":585,"range":{"start_line":585,"start_character":16,"end_line":585,"end_character":21},"in_reply_to":"81d2d731_a6badd59","updated":"2023-05-11 12:22:56.000000000","message":"Ah no, I agree INFO should be good here.","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"82f3ba9f21273ef41b7649d498da75339e05732b","unresolved":true,"context_lines":[{"line_number":582,"context_line":"                datapath_ports_ips.extend(self._get_port_ips(chassis_port))"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        if not datapath_ports_ips:"},{"line_number":585,"context_line":"            LOG.debug(\"No valid VIF ports were found for network %s, \""},{"line_number":586,"context_line":"                      \"tearing the namespace down if needed\", net_name)"},{"line_number":587,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":588,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"e1b08fa4_8ccb80f1","line":585,"range":{"start_line":585,"start_character":16,"end_line":585,"end_character":21},"in_reply_to":"a1251a77_1ab4409d","updated":"2023-05-11 01:48:47.000000000","message":"I agree now. When I added these logs few months ago I thought that these exceptions would be very rare but obviously I was wrong 😊 .","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"37a850b830b006c6774e9561e94171ef3c5ed679","unresolved":true,"context_lines":[{"line_number":582,"context_line":"                datapath_ports_ips.extend(self._get_port_ips(chassis_port))"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        if not datapath_ports_ips:"},{"line_number":585,"context_line":"            LOG.debug(\"No valid VIF ports were found for network %s, \""},{"line_number":586,"context_line":"                      \"tearing the namespace down if needed\", net_name)"},{"line_number":587,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":588,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"81d2d731_a6badd59","line":585,"range":{"start_line":585,"start_character":16,"end_line":585,"end_character":21},"in_reply_to":"e1b08fa4_8ccb80f1","updated":"2023-05-11 12:14:38.000000000","message":"I agree. But, probably a warning instead of info ?","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"23fc715886264f8fd7322f3be7fd5504833d6ab6","unresolved":true,"context_lines":[{"line_number":586,"context_line":"                      \"tearing the namespace down if needed\", net_name)"},{"line_number":587,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":588,"context_line":"            return"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        return net_name, datapath_ports_ips, metadata_port_info"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    def provision_datapath(self, datapath):"}],"source_content_type":"text/x-python","patch_set":2,"id":"755d0917_372409ee","line":589,"updated":"2023-05-10 19:12:37.000000000","message":"From my previous comment, something like this here:\n\nLOG.debug(\"Metadata port found for network %s, info: %s\", net_name, metadata_port_info)\n\nI think that would print something useful.","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ee4bba652cd8a633a8a3e1942400821810a277fd","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                      \"tearing the namespace down if needed\", net_name)"},{"line_number":587,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":588,"context_line":"            return"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        return net_name, datapath_ports_ips, metadata_port_info"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    def provision_datapath(self, datapath):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4fc5905b_68f286f3","line":589,"in_reply_to":"63d5d293_30b3e489","updated":"2023-05-11 12:33:24.000000000","message":"Done","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"37a850b830b006c6774e9561e94171ef3c5ed679","unresolved":true,"context_lines":[{"line_number":586,"context_line":"                      \"tearing the namespace down if needed\", net_name)"},{"line_number":587,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":588,"context_line":"            return"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        return net_name, datapath_ports_ips, metadata_port_info"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    def provision_datapath(self, datapath):"}],"source_content_type":"text/x-python","patch_set":2,"id":"63d5d293_30b3e489","line":589,"in_reply_to":"755d0917_372409ee","updated":"2023-05-11 12:14:38.000000000","message":"++ Indeed","commit_id":"513f3ac3dd8b42ab53991ef7a025223c9ac3f445"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"799b75691ae76d22b1ed5608118992570bcd9cc2","unresolved":true,"context_lines":[{"line_number":531,"context_line":"        if not metadata_port.mac:"},{"line_number":532,"context_line":"            raise RuntimeError("},{"line_number":533,"context_line":"                _(\u0027Metadata port found for network %s (datapath: %s) but is \u0027"},{"line_number":534,"context_line":"                  \u0027missing the IP address information\u0027) % (net_name,"},{"line_number":535,"context_line":"                                                           datapath_uuid))"},{"line_number":536,"context_line":"        if not metadata_port.external_ids.get("},{"line_number":537,"context_line":"                ovn_const.OVN_CIDRS_EXT_ID_KEY, None):"}],"source_content_type":"text/x-python","patch_set":3,"id":"c5cc6987_90dd3408","line":534,"range":{"start_line":534,"start_character":31,"end_line":534,"end_character":33},"updated":"2023-05-17 15:36:16.000000000","message":"s/MAC","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"886f687deea6fd7b5dc5db04fb9ad6db70c7bf7f","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        if not metadata_port.mac:"},{"line_number":532,"context_line":"            raise RuntimeError("},{"line_number":533,"context_line":"                _(\u0027Metadata port found for network %s (datapath: %s) but is \u0027"},{"line_number":534,"context_line":"                  \u0027missing the IP address information\u0027) % (net_name,"},{"line_number":535,"context_line":"                                                           datapath_uuid))"},{"line_number":536,"context_line":"        if not metadata_port.external_ids.get("},{"line_number":537,"context_line":"                ovn_const.OVN_CIDRS_EXT_ID_KEY, None):"}],"source_content_type":"text/x-python","patch_set":3,"id":"24e3d6a5_dae538e7","line":534,"range":{"start_line":534,"start_character":31,"end_line":534,"end_character":33},"in_reply_to":"c5cc6987_90dd3408","updated":"2023-05-17 18:58:03.000000000","message":"Done","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"799b75691ae76d22b1ed5608118992570bcd9cc2","unresolved":true,"context_lines":[{"line_number":537,"context_line":"                ovn_const.OVN_CIDRS_EXT_ID_KEY, None):"},{"line_number":538,"context_line":"            raise RuntimeError("},{"line_number":539,"context_line":"                _(\u0027Metadata port found for network %s (datapath: %s) but is \u0027"},{"line_number":540,"context_line":"                  \u0027missing \"neutron:cidrs\" external id\u0027) % (net_name,"},{"line_number":541,"context_line":"                                                            datapath_uuid))"},{"line_number":542,"context_line":"        return metadata_port"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a3e1f399_8012c807","line":540,"range":{"start_line":540,"start_character":27,"end_line":540,"end_character":54},"updated":"2023-05-17 15:36:16.000000000","message":"s/IP address information\n\nAt least this is what the callee is using this value for.","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"886f687deea6fd7b5dc5db04fb9ad6db70c7bf7f","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                ovn_const.OVN_CIDRS_EXT_ID_KEY, None):"},{"line_number":538,"context_line":"            raise RuntimeError("},{"line_number":539,"context_line":"                _(\u0027Metadata port found for network %s (datapath: %s) but is \u0027"},{"line_number":540,"context_line":"                  \u0027missing \"neutron:cidrs\" external id\u0027) % (net_name,"},{"line_number":541,"context_line":"                                                            datapath_uuid))"},{"line_number":542,"context_line":"        return metadata_port"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"055b1f20_15709d67","line":540,"range":{"start_line":540,"start_character":27,"end_line":540,"end_character":54},"in_reply_to":"a3e1f399_8012c807","updated":"2023-05-17 18:58:03.000000000","message":"Done","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"12db5191502c76b5f0986e5afa6136a266e60fde","unresolved":true,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        try:"},{"line_number":561,"context_line":"            metadata_port \u003d self._find_metadata_port(datapath_uuid, net_name)"},{"line_number":562,"context_line":"        except RuntimeError as e:"},{"line_number":563,"context_line":"            LOG.error(e)"},{"line_number":564,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":565,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"4ff5f623_5edf1463","line":562,"range":{"start_line":562,"start_character":15,"end_line":562,"end_character":27},"updated":"2023-05-16 00:38:32.000000000","message":"I wonder if this should be tenacity.RetryError ?\n\nI\u0027m definitely thinking the new code above has something to do with the failure.","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c56d75c369d84579c134358eab776f72f84035d2","unresolved":false,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        try:"},{"line_number":561,"context_line":"            metadata_port \u003d self._find_metadata_port(datapath_uuid, net_name)"},{"line_number":562,"context_line":"        except RuntimeError as e:"},{"line_number":563,"context_line":"            LOG.error(e)"},{"line_number":564,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":565,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"498b7ace_24d58d77","line":562,"range":{"start_line":562,"start_character":15,"end_line":562,"end_character":27},"in_reply_to":"2ea54da8_59776133","updated":"2023-05-17 18:57:47.000000000","message":"Done","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"799b75691ae76d22b1ed5608118992570bcd9cc2","unresolved":true,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        try:"},{"line_number":561,"context_line":"            metadata_port \u003d self._find_metadata_port(datapath_uuid, net_name)"},{"line_number":562,"context_line":"        except RuntimeError as e:"},{"line_number":563,"context_line":"            LOG.error(e)"},{"line_number":564,"context_line":"            self.teardown_datapath(net_name)"},{"line_number":565,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"2ea54da8_59776133","line":562,"range":{"start_line":562,"start_character":15,"end_line":562,"end_character":27},"in_reply_to":"4ff5f623_5edf1463","updated":"2023-05-17 15:36:16.000000000","message":"You can ignore this comment, I tested something local and it does raise a RuntimeError on final failure.","commit_id":"f10de8edb90706a9f64ba23a2a01fec192fdf4e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c56d75c369d84579c134358eab776f72f84035d2","unresolved":true,"context_lines":[{"line_number":519,"context_line":"        LOG.debug(\u0027Retrying %s: attempt %s ended with: %s\u0027,"},{"line_number":520,"context_line":"                  retry_state.fn, retry_state.attempt_number,"},{"line_number":521,"context_line":"                  retry_state.outcome)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    @tenacity.retry(retry\u003dtenacity.retry_if_exception_type(RuntimeError),"},{"line_number":524,"context_line":"                    wait\u003dtenacity.wait_exponential(),"},{"line_number":525,"context_line":"                    stop\u003dtenacity.stop_after_delay(10),"}],"source_content_type":"text/x-python","patch_set":4,"id":"0210025e_259968e8","line":522,"updated":"2023-05-17 18:57:47.000000000","message":"So this did show up in the logs, but didn\u0027t get me any closer to resolving things. In every case it completely failed once it started retrying. Of course the IPv6 job passed this time which didn\u0027t help, but maybe there are some intended failures there? Either way I\u0027ll remove it for the next PS.\n\nI am wondering if the retry seemed to help in any downstream load testing?","commit_id":"66f02a933984a9768411e8705c0bd1dcc35a834a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c5cb94d8c1157336827e3a032424d34010747686","unresolved":true,"context_lines":[{"line_number":519,"context_line":"        LOG.debug(\u0027Retrying %s: attempt %s ended with: %s\u0027,"},{"line_number":520,"context_line":"                  retry_state.fn, retry_state.attempt_number,"},{"line_number":521,"context_line":"                  retry_state.outcome)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    @tenacity.retry(retry\u003dtenacity.retry_if_exception_type(RuntimeError),"},{"line_number":524,"context_line":"                    wait\u003dtenacity.wait_exponential(),"},{"line_number":525,"context_line":"                    stop\u003dtenacity.stop_after_delay(10),"}],"source_content_type":"text/x-python","patch_set":4,"id":"876a08a3_43a0fea1","line":522,"in_reply_to":"0210025e_259968e8","updated":"2023-05-22 14:23:25.000000000","message":"Miro - so did this change help in load testing? I\u0027m asking because I still see metadata port failures in the test runs here.","commit_id":"66f02a933984a9768411e8705c0bd1dcc35a834a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"419122214bfe5a4aed3d81547105dfe53b294b15","unresolved":true,"context_lines":[{"line_number":109,"context_line":"                net_name \u003d ovn_utils.get_network_name_from_datapath("},{"line_number":110,"context_line":"                    row.datapath)"},{"line_number":111,"context_line":"                LOG.info(self.LOG_MSG, row.logical_port, net_name)"},{"line_number":112,"context_line":"                self.agent.provision_datapath(row.datapath)"},{"line_number":113,"context_line":"            except ConfigException:"},{"line_number":114,"context_line":"                # We\u0027re now in the reader lock mode, we need to exit the"},{"line_number":115,"context_line":"                # context and then use writer lock"}],"source_content_type":"text/x-python","patch_set":6,"id":"42c152ac_59ec5a48","line":112,"updated":"2023-05-23 20:13:20.000000000","message":"So is this the line calling into the code below, right? If so, and it really is holding the read lock, will retrying to get the metadata port actually work? Can a writer get in and update it? Should it instead trigger a ConfigException() and force a full re-sync? I\u0027m just not sure how this code will get re-triggered again, or maybe it will happen via sync() on L380?\n\nSince you\u0027re more familiar with the code I\u0027ll wait for your thoughts.\n\nThanks","commit_id":"61058a07a5b6d0f81f74132e1c8ed7e8d60ae8db"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a4f03e448cae762ee48fba9cf2b1da2cfc82ea75","unresolved":true,"context_lines":[{"line_number":614,"context_line":"        metadata_port \u003d self.sb_idl.get_metadata_port_network(datapath_uuid)"},{"line_number":615,"context_line":"        # If there\u0027s no metadata port or it doesn\u0027t have a MAC address, then"},{"line_number":616,"context_line":"        # tear the namespace down if needed."},{"line_number":617,"context_line":"        if not metadata_port:"},{"line_number":618,"context_line":"            raise RuntimeError("},{"line_number":619,"context_line":"                _(\u0027No metadata port found for network %s (datapath: %s)\u0027) % ("},{"line_number":620,"context_line":"                    net_name, datapath_uuid))"},{"line_number":621,"context_line":"        if not metadata_port.mac:"},{"line_number":622,"context_line":"            raise RuntimeError("},{"line_number":623,"context_line":"                _(\u0027Metadata port found for network %s (datapath: %s) but is \u0027"},{"line_number":624,"context_line":"                  \u0027missing the MAC address information\u0027) % (net_name,"},{"line_number":625,"context_line":"                                                            datapath_uuid))"},{"line_number":626,"context_line":"        return metadata_port"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    def _get_provision_params(self, datapath):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3b2396_0a73bfa4","line":625,"range":{"start_line":617,"start_character":8,"end_line":625,"end_character":75},"updated":"2024-01-23 07:31:28.000000000","message":"That will write an exception message in the logs anytime we retry the method. I would prefer just to retry the metadata port retrieval, checking for the port and the mac. If after some retries, any of these parameters is missing, then write this error in the logs. Is sometimes confusing for us (an even more for other users) to see exceptions in the logs without any other consequence (the system will work fine); that will most probably lead to a question/bug to the software provider.","commit_id":"06b682cf58d44875d0eeb8186576e42af4aea29f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7158f9dc7f6b813111d7fd4987fbe15bc8ac9c20","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        metadata_port \u003d self.sb_idl.get_metadata_port_network(datapath_uuid)"},{"line_number":615,"context_line":"        # If there\u0027s no metadata port or it doesn\u0027t have a MAC address, then"},{"line_number":616,"context_line":"        # tear the namespace down if needed."},{"line_number":617,"context_line":"        if not metadata_port:"},{"line_number":618,"context_line":"            raise RuntimeError("},{"line_number":619,"context_line":"                _(\u0027No metadata port found for network %s (datapath: %s)\u0027) % ("},{"line_number":620,"context_line":"                    net_name, datapath_uuid))"},{"line_number":621,"context_line":"        if not metadata_port.mac:"},{"line_number":622,"context_line":"            raise RuntimeError("},{"line_number":623,"context_line":"                _(\u0027Metadata port found for network %s (datapath: %s) but is \u0027"},{"line_number":624,"context_line":"                  \u0027missing the MAC address information\u0027) % (net_name,"},{"line_number":625,"context_line":"                                                            datapath_uuid))"},{"line_number":626,"context_line":"        return metadata_port"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    def _get_provision_params(self, datapath):"}],"source_content_type":"text/x-python","patch_set":8,"id":"430f49f3_a4c10ee7","line":625,"range":{"start_line":617,"start_character":8,"end_line":625,"end_character":75},"in_reply_to":"978ae86d_96a92eff","updated":"2024-01-31 22:38:41.000000000","message":"Done","commit_id":"06b682cf58d44875d0eeb8186576e42af4aea29f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e16c29bc30913fb086e6e46a03e312ef112246ff","unresolved":true,"context_lines":[{"line_number":614,"context_line":"        metadata_port \u003d self.sb_idl.get_metadata_port_network(datapath_uuid)"},{"line_number":615,"context_line":"        # If there\u0027s no metadata port or it doesn\u0027t have a MAC address, then"},{"line_number":616,"context_line":"        # tear the namespace down if needed."},{"line_number":617,"context_line":"        if not metadata_port:"},{"line_number":618,"context_line":"            raise RuntimeError("},{"line_number":619,"context_line":"                _(\u0027No metadata port found for network %s (datapath: %s)\u0027) % ("},{"line_number":620,"context_line":"                    net_name, datapath_uuid))"},{"line_number":621,"context_line":"        if not metadata_port.mac:"},{"line_number":622,"context_line":"            raise RuntimeError("},{"line_number":623,"context_line":"                _(\u0027Metadata port found for network %s (datapath: %s) but is \u0027"},{"line_number":624,"context_line":"                  \u0027missing the MAC address information\u0027) % (net_name,"},{"line_number":625,"context_line":"                                                            datapath_uuid))"},{"line_number":626,"context_line":"        return metadata_port"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    def _get_provision_params(self, datapath):"}],"source_content_type":"text/x-python","patch_set":8,"id":"978ae86d_96a92eff","line":625,"range":{"start_line":617,"start_character":8,"end_line":625,"end_character":75},"in_reply_to":"ba3b2396_0a73bfa4","updated":"2024-01-31 21:40:28.000000000","message":"Right, let me change that.","commit_id":"06b682cf58d44875d0eeb8186576e42af4aea29f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"172215105eb4a58f8f09937ec305f7b4408c0f0c","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def _metadata_port_invalid(result):"},{"line_number":81,"context_line":"    # \u0027result\u0027 will be a metadata port, it must have a MAC address"},{"line_number":82,"context_line":"    return not (result and result.mac)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"8488f7c9_ab957e73","line":81,"updated":"2024-02-21 17:04:09.000000000","message":"this comment suggest the name of the argument should be more clear (`metadata_port`?)","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b1faa0d9adbe4fb49d309c3cde2776069e1d5d4","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def _metadata_port_invalid(result):"},{"line_number":81,"context_line":"    # \u0027result\u0027 will be a metadata port, it must have a MAC address"},{"line_number":82,"context_line":"    return not (result and result.mac)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"4b85e765_c57655bd","line":81,"in_reply_to":"8488f7c9_ab957e73","updated":"2024-02-23 00:22:13.000000000","message":"Done","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a343542c0806d99a5c08565ca313ae9cd98c2d9a","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def _metadata_port_invalid(result):"},{"line_number":81,"context_line":"    # \u0027result\u0027 will be a metadata port, it must have a MAC address"},{"line_number":82,"context_line":"    return not (result and result.mac)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class ConfigException(Exception):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ea3c791b_22f5f543","line":82,"updated":"2024-02-05 19:34:53.000000000","message":"I could put additional LOG.debug here so we know what is wrong, will wait for review comments.","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"41a86930adb70c6df09d355b2f3ffbcbdd0d5e93","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def _metadata_port_invalid(result):"},{"line_number":81,"context_line":"    # \u0027result\u0027 will be a metadata port, it must have a MAC address"},{"line_number":82,"context_line":"    return not (result and result.mac)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class ConfigException(Exception):"}],"source_content_type":"text/x-python","patch_set":11,"id":"c6395580_ee24b0aa","line":82,"in_reply_to":"ea3c791b_22f5f543","updated":"2024-08-15 23:54:59.000000000","message":"Done","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"172215105eb4a58f8f09937ec305f7b4408c0f0c","unresolved":true,"context_lines":[{"line_number":618,"context_line":"        return self.sb_idl.get_metadata_port_network(datapath_uuid)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _find_metadata_port(self, datapath_uuid, net_name):"},{"line_number":621,"context_line":"        metadata_port \u003d None"},{"line_number":622,"context_line":"        try:"},{"line_number":623,"context_line":"            metadata_port \u003d self._get_metadata_port(datapath_uuid, net_name)"},{"line_number":624,"context_line":"        except tenacity.RetryError:"}],"source_content_type":"text/x-python","patch_set":11,"id":"6ebae8ff_d4f78867","line":621,"updated":"2024-02-21 17:04:09.000000000","message":"lines 621 and 627 are not needed.","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b1faa0d9adbe4fb49d309c3cde2776069e1d5d4","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        return self.sb_idl.get_metadata_port_network(datapath_uuid)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _find_metadata_port(self, datapath_uuid, net_name):"},{"line_number":621,"context_line":"        metadata_port \u003d None"},{"line_number":622,"context_line":"        try:"},{"line_number":623,"context_line":"            metadata_port \u003d self._get_metadata_port(datapath_uuid, net_name)"},{"line_number":624,"context_line":"        except tenacity.RetryError:"}],"source_content_type":"text/x-python","patch_set":11,"id":"81444c05_982488d6","line":621,"in_reply_to":"6ebae8ff_d4f78867","updated":"2024-02-23 00:22:13.000000000","message":"Done","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"172215105eb4a58f8f09937ec305f7b4408c0f0c","unresolved":true,"context_lines":[{"line_number":620,"context_line":"    def _find_metadata_port(self, datapath_uuid, net_name):"},{"line_number":621,"context_line":"        metadata_port \u003d None"},{"line_number":622,"context_line":"        try:"},{"line_number":623,"context_line":"            metadata_port \u003d self._get_metadata_port(datapath_uuid, net_name)"},{"line_number":624,"context_line":"        except tenacity.RetryError:"},{"line_number":625,"context_line":"            # This will cause a return of None to caller"},{"line_number":626,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":11,"id":"ac2a8905_08b7f5ad","line":623,"updated":"2024-02-21 17:04:09.000000000","message":"you can return here\n\n\n```\ntry:\n    return ...\nexcept ...:\n    pass\n```\n\n(or `pass`-\u003e`return None` if you\u0027d like to be more explicit for those who don\u0027t know that python returns None implicitly.)","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b1faa0d9adbe4fb49d309c3cde2776069e1d5d4","unresolved":false,"context_lines":[{"line_number":620,"context_line":"    def _find_metadata_port(self, datapath_uuid, net_name):"},{"line_number":621,"context_line":"        metadata_port \u003d None"},{"line_number":622,"context_line":"        try:"},{"line_number":623,"context_line":"            metadata_port \u003d self._get_metadata_port(datapath_uuid, net_name)"},{"line_number":624,"context_line":"        except tenacity.RetryError:"},{"line_number":625,"context_line":"            # This will cause a return of None to caller"},{"line_number":626,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":11,"id":"12c91f23_470adf15","line":623,"in_reply_to":"ac2a8905_08b7f5ad","updated":"2024-02-23 00:22:13.000000000","message":"Done","commit_id":"9abae8678f064f9576611613e32fdd31b2f845b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"876d40a53942aa2d8fa1073c116a596eeeaf2ef0","unresolved":true,"context_lines":[{"line_number":621,"context_line":"        try:"},{"line_number":622,"context_line":"            return self._get_metadata_port(datapath_uuid, net_name)"},{"line_number":623,"context_line":"        except tenacity.RetryError:"},{"line_number":624,"context_line":"            # This will cause a return of None to caller"},{"line_number":625,"context_line":"            pass"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def _get_provision_params(self, datapath):"}],"source_content_type":"text/x-python","patch_set":12,"id":"c583bc16_45bc5605","line":624,"updated":"2024-05-01 16:16:05.000000000","message":"(nit) this comment is unnecessary; it\u0027s well known python implicitly returns None; but if we\u0027d like to be more explicit for some reason, a bare `return` or even `return None` would be better than a comment explaining how python works.","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"41a86930adb70c6df09d355b2f3ffbcbdd0d5e93","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        try:"},{"line_number":622,"context_line":"            return self._get_metadata_port(datapath_uuid, net_name)"},{"line_number":623,"context_line":"        except tenacity.RetryError:"},{"line_number":624,"context_line":"            # This will cause a return of None to caller"},{"line_number":625,"context_line":"            pass"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def _get_provision_params(self, datapath):"}],"source_content_type":"text/x-python","patch_set":12,"id":"dc3fdaa9_fc22fe8e","line":624,"in_reply_to":"b1d4a54f_c665841c","updated":"2024-08-15 23:54:59.000000000","message":"Done","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"989abd79ee3cd7eca74c94a874ed1e3e1184f765","unresolved":true,"context_lines":[{"line_number":621,"context_line":"        try:"},{"line_number":622,"context_line":"            return self._get_metadata_port(datapath_uuid, net_name)"},{"line_number":623,"context_line":"        except tenacity.RetryError:"},{"line_number":624,"context_line":"            # This will cause a return of None to caller"},{"line_number":625,"context_line":"            pass"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def _get_provision_params(self, datapath):"}],"source_content_type":"text/x-python","patch_set":12,"id":"b1d4a54f_c665841c","line":624,"in_reply_to":"c583bc16_45bc5605","updated":"2024-05-01 19:40:37.000000000","message":"I can remove my over-engineered comment :)","commit_id":"01b90cd7480f89654e76dbbad69cf9907761fb4f"}]}