)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e44ff06fcf8549d060a5b274ad5d6ecb473e6d4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f56b0230_ac0e7a5f","updated":"2023-04-28 20:31:17.000000000","message":"recheck grenade","commit_id":"f2716da9a768f5e1f6b1318ba61a4b7eafd8d478"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ff955ed63c9862aa5bd05db22ce217f01882ca6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4109c8aa_72d05187","updated":"2023-05-02 15:49:21.000000000","message":"recheck fullstack","commit_id":"f6bec7095e67bc9426f6d768fd2e2220dc3720a4"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a5cc33555544cb0d39de7eefc007418bad380dce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3bc8a4ea_05dc5951","updated":"2023-05-08 08:50:44.000000000","message":"unit test failure seems related: test_validate_revisions failed with:\n\"ft1.1: neutron.tests.unit.db.test_migration.TestSafetyChecks.test_validate_revisionstesttools.testresult.real._StringException: pythonlogging:\u0027\u0027: {{{ERROR [alembic.util.messaging] Unexpected number of alembic branch points: fc153938cdc1, kilo}}}\nstdout: {{{FAILED: Unexpected number of alembic branch points: fc153938cdc1, kilo}}}\ntraceback-1: {{{AssertionError: Forced Test Failure}}}\"","commit_id":"f0957c8a41ebb7f0db4b899813362fb2747b4324"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"c13b3dac9b8ac006dfc7712921211dcb11567b06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6bb0c660_b9ee41f2","updated":"2023-06-01 12:36:21.000000000","message":"Good to have and alembic migration looks correct","commit_id":"6a2ccfac32c2993e11ee9d958886d786914131e8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ffc77e9232219082cf3cdef9e7e9162e17120f5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6d4e99b3_31ca91e2","updated":"2023-06-02 10:53:17.000000000","message":"I now have doubts how it will work. If You look at the l3_hamode_db code: it \"by design\" creates that network so it don\u0027t belongs to any project. So how it will be unique?","commit_id":"6a2ccfac32c2993e11ee9d958886d786914131e8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ef52f749f3a44a631456a3731428d9743720cd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"44c4ae31_bba7de8b","updated":"2023-06-09 16:12:55.000000000","message":"recheck neutron-tempest-plugin-openvswitch-iptables_hybrid","commit_id":"6a2ccfac32c2993e11ee9d958886d786914131e8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ef16f50e6499a2bda2a3b31a74535e9135b82b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c51bff72_302bd369","in_reply_to":"6d4e99b3_31ca91e2","updated":"2023-06-02 13:19:51.000000000","message":"Hold on! The \"L3HARouterNetwork\" binding is a reference to a network and a project IDs [1]. The HA network is \"marked\" as HA because it has a referred \"L3HARouterNetwork\" register created. But the HA network creation is always called with a project ID. This project ID comes from the router creation project ID [2][3]. So we are always passing the project ID in the register call.\n\n[1]https://github.com/openstack/neutron/blob/5d80a0152068daeb72393a1cd7f439bb58204234/neutron/db/l3_hamode_db.py#L197-L198\n[2]https://github.com/openstack/neutron/blob/5d80a0152068daeb72393a1cd7f439bb58204234/neutron/db/l3_hamode_db.py#L362-L363\n[3]https://github.com/openstack/neutron/blob/5d80a0152068daeb72393a1cd7f439bb58204234/neutron/db/l3_hamode_db.py#L373-L374","commit_id":"6a2ccfac32c2993e11ee9d958886d786914131e8"}],"neutron/db/migration/alembic_migrations/versions/2023.2/expand/682c319773d7_create_l3harouternetwork_project_id_.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"62f3bac6703c6a02444357d9ab31f3e952a92e55","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def upgrade():"},{"line_number":37,"context_line":"    op.create_unique_constraint("},{"line_number":38,"context_line":"        constraint_name\u003d\u0027uniq_%s0%s\u0027 % (TABLE, COLUMN),"},{"line_number":39,"context_line":"        table_name\u003dTABLE,"},{"line_number":40,"context_line":"        columns\u003d[COLUMN])"}],"source_content_type":"text/x-python","patch_set":9,"id":"774100c5_6f0c56a1","line":38,"updated":"2023-05-08 10:22:54.000000000","message":"Technically this is not an \"expand\" migration. It may be worth a comment that this is here in the expand folder to fix a bug.\n\nAlso shall we provide upgrade instructions for the case when this constraint cannot be created due to already existing db contents? I guess that can happen in real life, otherwise we would not be creating this constraint in the first place.","commit_id":"a6fd416ccb8628fb5b6a8e782b86c3fddcfc799a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"97853ebd8a2b4c275dcc2b26da553e76f1ae8e2e","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def upgrade():"},{"line_number":37,"context_line":"    op.create_unique_constraint("},{"line_number":38,"context_line":"        constraint_name\u003d\u0027uniq_%s0%s\u0027 % (TABLE, COLUMN),"},{"line_number":39,"context_line":"        table_name\u003dTABLE,"},{"line_number":40,"context_line":"        columns\u003d[COLUMN])"}],"source_content_type":"text/x-python","patch_set":9,"id":"a580ea04_5f426bec","line":38,"in_reply_to":"774100c5_6f0c56a1","updated":"2023-05-10 11:43:58.000000000","message":"1) Checking now the code, I don\u0027t know why this is not failing. As you mentioned, this is not an expansion but a contraction. Because we don\u0027t have this second path (contraction), we allow that with the corresponding exceptions.\n\n2) Actually what I should do is to provide an upgrade check to ensure that we have just zero or one HA networks per project. This upgrade check will fail if there are more than one HA network per project. If that is fixed before the alembic migration, it won\u0027t fail. I\u0027ll push a new PS soon.","commit_id":"a6fd416ccb8628fb5b6a8e782b86c3fddcfc799a"}]}