)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35969,"name":"Tobias Fischer","display_name":"Tobias","email":"tobias.fischer@cloudandheat.com","username":"tobfisch"},"change_message_id":"4d7992aac7caf7f54919ce632fa9673ce81cac5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a9c4522_9a9ad097","updated":"2023-05-02 07:52:42.000000000","message":"We still see performance reduction for port deletions, but for test purposes we completely removed the locks introduced in [1]. \nIn this case we saw the same performance reduction for port deletions as with patch we want to introduce.\nSo the initial locks somehow improved the performance of port deletions.\n\n[1] https://review.opendev.org/c/openstack/neutron/+/713045","commit_id":"287fdff164abbd09a902274edf005c717c377772"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7e0e1f3e819027978c60d57a0b9642c79141a8e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5c1f9db4_47e08a21","updated":"2023-05-04 11:48:43.000000000","message":"Please, fix the pep8 errors","commit_id":"45d5d69b8a2f4651ac167749a7e8ea715a682519"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1908b58502dbd405512563ed28f8e05895f294ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"98737164_251a2704","updated":"2023-05-05 18:10:00.000000000","message":"Nice optimization! I also liked a lot that you profusely commented the changes to HasInUse. Future maintainers will be thankful","commit_id":"c0af5b3b5ea89d3147adf1054625f29d5b01b309"}],"neutron/db/migration/alembic_migrations/versions/2023.2/expand/93f394357a27_remove_in_use_on_subnets.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7e0e1f3e819027978c60d57a0b9642c79141a8e1","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    \"\"\"Support dropping \u0027in_use\u0027 column in table \u0027subnets\u0027\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    return {"},{"line_number":41,"context_line":"        sa.Column: [\u0027in_use\u0027] % \u0027subnets\u0027"},{"line_number":42,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"c34a34a5_08fa1479","line":41,"range":{"start_line":41,"start_character":21,"end_line":41,"end_character":27},"updated":"2023-05-04 11:48:43.000000000","message":"%s.in_use","commit_id":"45d5d69b8a2f4651ac167749a7e8ea715a682519"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"916b9cc0b2a55a998de2caf17b39f0a900966520","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    \"\"\"Support dropping \u0027in_use\u0027 column in table \u0027subnets\u0027\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    return {"},{"line_number":41,"context_line":"        sa.Column: [\u0027in_use\u0027] % \u0027subnets\u0027"},{"line_number":42,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"9d4c58c7_a9378686","line":41,"range":{"start_line":41,"start_character":21,"end_line":41,"end_character":27},"in_reply_to":"c34a34a5_08fa1479","updated":"2023-05-04 12:49:21.000000000","message":"Actually, there is no need to format any string, use a single string \"subnets.in_user\". You are no using a constant.","commit_id":"45d5d69b8a2f4651ac167749a7e8ea715a682519"}],"neutron/db/models_v2.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1908b58502dbd405512563ed28f8e05895f294ac","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    \"write_lock_register\" takes an exclusive DB lock on the row specified by"},{"line_number":48,"context_line":"    the filters. The lock is automatically released on transaction commit."},{"line_number":49,"context_line":"    You may only have one write lock on each row at a time. It therefor"},{"line_number":50,"context_line":"    blocks all other read and write locks to this row."},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"642fbdc6_05445740","line":49,"range":{"start_line":49,"start_character":63,"end_line":49,"end_character":71},"updated":"2023-05-05 18:10:00.000000000","message":"nit: therefore","commit_id":"c0af5b3b5ea89d3147adf1054625f29d5b01b309"}]}