)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"aa77a9c02017f71942747ca8918b009c79151edf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3cceb8c_c48c4b74","updated":"2023-05-17 17:30:26.000000000","message":"check experimental","commit_id":"1d5a42daac3426bad3d51c8065900e8373107916"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"65fb0aea84b60deb60e1e2f53456b17498afbfab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"10253991_6a4bffcd","updated":"2023-05-18 08:51:27.000000000","message":"check experimental","commit_id":"01b4b8001994f94403c41f36a2a632a70cd4fc44"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b857384b907475237024f38bffd577232d6aa45f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93c0bca9_beecb96d","updated":"2023-05-18 09:14:30.000000000","message":"check experimental","commit_id":"d458eaff727d43e67afd637eb4f3b2d39a2056ed"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d14627d6a7f0555f7db5e7a54018f51dc5ffe8bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9657f169_296db0fd","updated":"2023-05-19 09:49:20.000000000","message":"recheck neutron-ovn-rally-task","commit_id":"d458eaff727d43e67afd637eb4f3b2d39a2056ed"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"299f81071835e194df8f41e4462f3556b8a928d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6c0454f8_b6e28acc","updated":"2023-05-31 08:05:35.000000000","message":"recheck\ngrenade-multinode ServersTestManualDisk failure","commit_id":"6fa3d8019ffd416ad3eb90e6e9a364d4b6e23e80"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c3486a3d7beb395a882b543aca4b6c9300454066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"932d883e_6a5d3f8f","updated":"2023-05-23 15:03:32.000000000","message":"recheck FT unrelated","commit_id":"6fa3d8019ffd416ad3eb90e6e9a364d4b6e23e80"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74fc0085d69d363d5d446743cf06106b98be60bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a3a178e_d8d851d6","updated":"2023-05-30 14:49:35.000000000","message":"recheck functional","commit_id":"6fa3d8019ffd416ad3eb90e6e9a364d4b6e23e80"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0259298c26b623f5dd65fa37206065b35bd9513c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cdd7efc5_077cf4fa","updated":"2023-05-30 04:58:29.000000000","message":"recheck missing metadata flows, seems https://bugs.launchpad.net/neutron/+bug/2007166 reappeared","commit_id":"6fa3d8019ffd416ad3eb90e6e9a364d4b6e23e80"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a501e51a35d793adbd0d5557293aec5d555492ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"750a65b7_9595d8ed","updated":"2023-05-30 06:34:32.000000000","message":"recheck tempest","commit_id":"6fa3d8019ffd416ad3eb90e6e9a364d4b6e23e80"}],"neutron/common/_constants.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b96360a6b579c4c63c5dce324e5393d3b75e49a8","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from sqlalchemy.sql import elements"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"820a1f72_34033a52","line":16,"updated":"2023-05-18 08:59:37.000000000","message":"why this import is in different section than neutron_lib? IMO it should be in the same section of imports","commit_id":"01b4b8001994f94403c41f36a2a632a70cd4fc44"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4167c23430c3de2b68ebb03952ce940d9076f2b1","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from sqlalchemy.sql import elements"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"060d3791_dfc16bf4","line":16,"in_reply_to":"820a1f72_34033a52","updated":"2023-05-18 09:12:52.000000000","message":"Right!","commit_id":"01b4b8001994f94403c41f36a2a632a70cd4fc44"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b96360a6b579c4c63c5dce324e5393d3b75e49a8","unresolved":true,"context_lines":[{"line_number":95,"context_line":"# TODO(haleyb): move this constant to neutron_lib.constants"},{"line_number":96,"context_line":"IPV4_MIN_MTU \u003d 68"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# TODO(ralonsoh): move to neutron-lib.db.contants"},{"line_number":100,"context_line":"SQL_EMPTY_STRING \u003d elements.TextClause(\"\u0027\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"cb0184ef_9f3d84eb","line":98,"updated":"2023-05-18 08:59:37.000000000","message":"nit: one empty line should be enough probably","commit_id":"01b4b8001994f94403c41f36a2a632a70cd4fc44"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4562a6d4b853c3cce6c6917d959f18cb19f98b3b","unresolved":true,"context_lines":[{"line_number":95,"context_line":"# TODO(haleyb): move this constant to neutron_lib.constants"},{"line_number":96,"context_line":"IPV4_MIN_MTU \u003d 68"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# TODO(ralonsoh): move to neutron-lib.db.contants"},{"line_number":100,"context_line":"SQL_EMPTY_STRING \u003d elements.TextClause(\"\u0027\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc68b0ee_72e5c818","line":98,"in_reply_to":"050d6d43_e9057f9d","updated":"2023-05-18 09:43:01.000000000","message":"but I was just saying about empty L96 and L97 above that constant. I think that one empty line should be enough 😊","commit_id":"01b4b8001994f94403c41f36a2a632a70cd4fc44"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4167c23430c3de2b68ebb03952ce940d9076f2b1","unresolved":true,"context_lines":[{"line_number":95,"context_line":"# TODO(haleyb): move this constant to neutron_lib.constants"},{"line_number":96,"context_line":"IPV4_MIN_MTU \u003d 68"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# TODO(ralonsoh): move to neutron-lib.db.contants"},{"line_number":100,"context_line":"SQL_EMPTY_STRING \u003d elements.TextClause(\"\u0027\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"050d6d43_e9057f9d","line":98,"in_reply_to":"cb0184ef_9f3d84eb","updated":"2023-05-18 09:12:52.000000000","message":"No, we need both. The SQL string will contain what is inside the outer string. For example, with TextClause(\"\u0027\u0027\"), the output will be:\n  `vif_details` varchar(4095) NOT NULL DEFAULT \u0027\u0027","commit_id":"01b4b8001994f94403c41f36a2a632a70cd4fc44"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"052bc12bc400556ef0250b0fd83d4743a006e8a5","unresolved":true,"context_lines":[{"line_number":95,"context_line":"# TODO(haleyb): move this constant to neutron_lib.constants"},{"line_number":96,"context_line":"IPV4_MIN_MTU \u003d 68"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# TODO(ralonsoh): move to neutron-lib.db.contants"},{"line_number":100,"context_line":"SQL_EMPTY_STRING \u003d elements.TextClause(\"\u0027\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"21780380_853d3f62","line":98,"in_reply_to":"dc68b0ee_72e5c818","updated":"2023-05-19 09:50:57.000000000","message":"Ahhhhh sorry, rigth","commit_id":"01b4b8001994f94403c41f36a2a632a70cd4fc44"}],"neutron/tests/functional/db/test_migrations.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b96360a6b579c4c63c5dce324e5393d3b75e49a8","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def upgrade(engine, alembic_config, branch_name\u003d\u0027heads\u0027):"},{"line_number":68,"context_line":"    cfg.CONF.set_override(\u0027connection\u0027, engine.url, group\u003d\u0027database\u0027)"},{"line_number":69,"context_line":"    migration.do_alembic_command(alembic_config, \u0027upgrade\u0027,"},{"line_number":70,"context_line":"                                 branch_name)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b7edd914_63e553d9","line":68,"updated":"2023-05-18 08:59:37.000000000","message":"is this change intentional? It reverts one of the previous commits in this chain, no?","commit_id":"01b4b8001994f94403c41f36a2a632a70cd4fc44"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4167c23430c3de2b68ebb03952ce940d9076f2b1","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def upgrade(engine, alembic_config, branch_name\u003d\u0027heads\u0027):"},{"line_number":68,"context_line":"    cfg.CONF.set_override(\u0027connection\u0027, engine.url, group\u003d\u0027database\u0027)"},{"line_number":69,"context_line":"    migration.do_alembic_command(alembic_config, \u0027upgrade\u0027,"},{"line_number":70,"context_line":"                                 branch_name)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cfc9c733_bf6f6521","line":68,"in_reply_to":"b7edd914_63e553d9","updated":"2023-05-18 09:12:52.000000000","message":"Nope, that is garbage from... I don\u0027t know. I mixed things here.\n\nAhhh, I think I checkout master and this is why I\u0027m overriding what I\u0027m doing in the first patch of this series.","commit_id":"01b4b8001994f94403c41f36a2a632a70cd4fc44"}]}