)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0d78366e597b44f1e9bd7165d65f3e293dd2d9ed","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-25 15:26:31 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[OVN] The L3 scheduler does not use all chassis by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Any OVN scheduler, inheriting from ``OVNGatewayScheduler``, calls"},{"line_number":10,"context_line":"``_schedule_gateway`` to make the decision of in what chassis the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"844600fd_5948ddcf","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":31},"updated":"2023-05-25 20:40:05.000000000","message":"s/should not","commit_id":"413044f253b6d434164e8a94dbeccec7b1b79ebe"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e42612de1273e5e90dd152ffd02359c0896e05f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2825ce82_9743533c","updated":"2023-05-29 14:57:31.000000000","message":"Please folks, join the discussion about what should we do if the LRP has no available chassis to be scheduled.","commit_id":"413044f253b6d434164e8a94dbeccec7b1b79ebe"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44f01ce8b630aef63dcaadf695afb32fa9022791","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d891f4e_f75c22e2","updated":"2023-05-25 17:30:58.000000000","message":"recheck neutron-ovs-grenade-multinode","commit_id":"413044f253b6d434164e8a94dbeccec7b1b79ebe"}],"neutron/scheduler/l3_ovn_scheduler.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0d78366e597b44f1e9bd7165d65f3e293dd2d9ed","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                return existing_chassis"},{"line_number":72,"context_line":"        if not candidates:"},{"line_number":73,"context_line":"            LOG.warning(\u0027Gateway %s was not scheduled on any chassis, no \u0027"},{"line_number":74,"context_line":"                        \u0027candidates are available\u0027, gateway_name)"},{"line_number":75,"context_line":"            return [ovn_const.OVN_GATEWAY_INVALID_CHASSIS]"},{"line_number":76,"context_line":"        chassis_count \u003d ovn_const.MAX_GW_CHASSIS - len(existing_chassis)"},{"line_number":77,"context_line":"        # The actual binding of the gateway to a chassis via the options"}],"source_content_type":"text/x-python","patch_set":2,"id":"1073d93c_8114c798","line":74,"updated":"2023-05-25 20:40:05.000000000","message":"I was just trying to think what the user can do in this case, and I guess the answer is just wait for the next sync event to run hoping someone has added a gateway. Basically, when someone says \"my router isn\u0027t working\" I\u0027m hoping there\u0027s an obvious way to notice and fix it.","commit_id":"413044f253b6d434164e8a94dbeccec7b1b79ebe"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e42612de1273e5e90dd152ffd02359c0896e05f0","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                return existing_chassis"},{"line_number":72,"context_line":"        if not candidates:"},{"line_number":73,"context_line":"            LOG.warning(\u0027Gateway %s was not scheduled on any chassis, no \u0027"},{"line_number":74,"context_line":"                        \u0027candidates are available\u0027, gateway_name)"},{"line_number":75,"context_line":"            return [ovn_const.OVN_GATEWAY_INVALID_CHASSIS]"},{"line_number":76,"context_line":"        chassis_count \u003d ovn_const.MAX_GW_CHASSIS - len(existing_chassis)"},{"line_number":77,"context_line":"        # The actual binding of the gateway to a chassis via the options"}],"source_content_type":"text/x-python","patch_set":2,"id":"3e665c5e_a95b5bba","line":74,"in_reply_to":"1073d93c_8114c798","updated":"2023-05-29 14:57:31.000000000","message":"Thanks for raising this discussion. Actually what I would like to propose here is to raise an exception, instead of using this invalid chassis. If the LRP is not assigned to a valid chassis, we should fail here.\n\nIn fact (I need to confirm that), we should make a pre_commit check when the Neutron GW port is updated/created. If the mech driver (OVN in this case) can\u0027t assign the LRP, should fail before changing anything in the Neutron DB (nor the OVN DB, that is updated after).","commit_id":"413044f253b6d434164e8a94dbeccec7b1b79ebe"}]}