)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a66efb15c9d313dd3b1ce05e37a610b416a316a3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-30 12:09:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dhcp/agent: fix \u0027get_metadata_bind_interface\u0027 driver call when segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027get_metadata_bind_interface\u0027 driver call has a different behavior"},{"line_number":10,"context_line":"than the other methods, it is expected to return metadata interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"57300f0b_8fbed0e5","line":7,"updated":"2023-06-05 08:41:25.000000000","message":"when segments.... ?","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f5c99b784d8c119c8636df93b16efb49f838c40e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-30 12:09:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dhcp/agent: fix \u0027get_metadata_bind_interface\u0027 driver call when segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027get_metadata_bind_interface\u0027 driver call has a different behavior"},{"line_number":10,"context_line":"than the other methods, it is expected to return metadata interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c5e29c90_0e7b9400","line":7,"in_reply_to":"57300f0b_8fbed0e5","updated":"2023-06-06 08:12:19.000000000","message":"Done","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a66efb15c9d313dd3b1ce05e37a610b416a316a3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"dhcp/agent: fix \u0027get_metadata_bind_interface\u0027 driver call when segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027get_metadata_bind_interface\u0027 driver call has a different behavior"},{"line_number":10,"context_line":"than the other methods, it is expected to return metadata interface"},{"line_number":11,"context_line":"name."},{"line_number":12,"context_line":"When introduced multisegments support this particularity was not"},{"line_number":13,"context_line":"takken into account."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"79b38493_dbff20c1","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":8},"updated":"2023-06-05 08:41:25.000000000","message":"nit: than other methods ?","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f5c99b784d8c119c8636df93b16efb49f838c40e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"dhcp/agent: fix \u0027get_metadata_bind_interface\u0027 driver call when segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027get_metadata_bind_interface\u0027 driver call has a different behavior"},{"line_number":10,"context_line":"than the other methods, it is expected to return metadata interface"},{"line_number":11,"context_line":"name."},{"line_number":12,"context_line":"When introduced multisegments support this particularity was not"},{"line_number":13,"context_line":"takken into account."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"727c16de_550a8efd","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":8},"in_reply_to":"79b38493_dbff20c1","updated":"2023-06-06 08:12:19.000000000","message":"Done","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a66efb15c9d313dd3b1ce05e37a610b416a316a3","unresolved":true,"context_lines":[{"line_number":10,"context_line":"than the other methods, it is expected to return metadata interface"},{"line_number":11,"context_line":"name."},{"line_number":12,"context_line":"When introduced multisegments support this particularity was not"},{"line_number":13,"context_line":"takken into account."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The fix is making the call acceptable in the purpose of the current"},{"line_number":16,"context_line":"driver interface."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c388fa17_8f93ee69","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":6},"updated":"2023-06-05 08:41:25.000000000","message":"nit: taken","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f5c99b784d8c119c8636df93b16efb49f838c40e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"than the other methods, it is expected to return metadata interface"},{"line_number":11,"context_line":"name."},{"line_number":12,"context_line":"When introduced multisegments support this particularity was not"},{"line_number":13,"context_line":"takken into account."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The fix is making the call acceptable in the purpose of the current"},{"line_number":16,"context_line":"driver interface."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"33a4b0f6_57c3580b","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":6},"in_reply_to":"c388fa17_8f93ee69","updated":"2023-06-06 08:12:19.000000000","message":"Done","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f5c99b784d8c119c8636df93b16efb49f838c40e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cd23e603_b55c4fdf","updated":"2023-06-06 08:12:19.000000000","message":"Thank you for your comments","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fda3db89ed6adc7de2acc49ab49503ae28ddb053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"457f4a6f_c2b8531f","updated":"2023-05-30 13:08:35.000000000","message":"recheck grenade","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b7932d011e7ff0bd8c8efb84c85f89ebeaa21558","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6e9003f_b90ffb77","updated":"2023-06-06 12:27:33.000000000","message":"recheck time out","commit_id":"743b23761d269bb925ee124c5c49e4d14471b1fd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2022148bb516075efc1652f92a2308b6999fdd27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0f552db_1d9ac254","updated":"2023-06-08 06:49:34.000000000","message":"Fixed, thank you.","commit_id":"a9323f0325cc4227ca6f1f0316913aa7a2d315f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"44c93379fe65cbdcfd13ad34b89a7ce7ee48e221","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db5be153_8f44b883","updated":"2023-06-14 07:09:22.000000000","message":"If I understand well there should be some refactoring/reorg of dhcp/agent.py in a follow-up patch?","commit_id":"a9323f0325cc4227ca6f1f0316913aa7a2d315f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5c4ec1c8566a38885c8b4857545c12d7f858da86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"00a67f0c_9cf2d817","updated":"2023-06-13 08:28:35.000000000","message":"recheck","commit_id":"a9323f0325cc4227ca6f1f0316913aa7a2d315f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"180c06077e3a76597ba53cc5a52f38ca6c64b401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"80f2a9a8_4fb8a010","updated":"2023-06-21 08:45:39.000000000","message":"recheck fullstask timeout","commit_id":"a9323f0325cc4227ca6f1f0316913aa7a2d315f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b61233ac6b994f83045ff224a216cbdd532ed800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ccbf4ee_29803645","updated":"2023-06-22 13:42:20.000000000","message":"recheck grenade","commit_id":"a9323f0325cc4227ca6f1f0316913aa7a2d315f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b9a16e4bfa439aac129476cb4af97192600fb94c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"af7fa6d5_823a7581","updated":"2023-06-22 07:34:17.000000000","message":"recheck test_multiple_ports_portrange_remote","commit_id":"a9323f0325cc4227ca6f1f0316913aa7a2d315f5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e677acf5e8357220cc9adff4e7d2505da864c453","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c9e5aacb_90cbbcb7","in_reply_to":"00a67f0c_9cf2d817","updated":"2023-06-13 08:51:24.000000000","message":"please don\u0027t use \"bare recheck\" :-)\n\nFor this grenade issue there is already a bug report: https://bugs.launchpad.net/grenade/+bug/2020643","commit_id":"a9323f0325cc4227ca6f1f0316913aa7a2d315f5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"be7b897f2f4414cf477d98c6a98723cd1e2d967f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c321cb83_518ed9f3","in_reply_to":"c9e5aacb_90cbbcb7","updated":"2023-06-14 13:02:39.000000000","message":"My mistake, sorry Lajos I should have been distracted when I typed recheck ... :-)","commit_id":"a9323f0325cc4227ca6f1f0316913aa7a2d315f5"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"376246f7e4cd7ba8315aadee7f94fa318e46339e","unresolved":true,"context_lines":[{"line_number":218,"context_line":"        if sid_subnets:"},{"line_number":219,"context_line":"            ret \u003d []"},{"line_number":220,"context_line":"            for seg_id, subnets in sid_subnets.items():"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"                # TODO(sahid): This whole part should be removed in future."},{"line_number":223,"context_line":"                segment \u003d sid_segment.get(seg_id)"},{"line_number":224,"context_line":"                if segment and segment.segment_index \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3a91dbc_c7c98494","side":"PARENT","line":221,"updated":"2023-05-30 11:55:22.000000000","message":"nit: not needed, I will clean this when I will get reviews","commit_id":"9e6675ec06d3f37564d3fa328afdb9b816a5384e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f5c99b784d8c119c8636df93b16efb49f838c40e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        if sid_subnets:"},{"line_number":219,"context_line":"            ret \u003d []"},{"line_number":220,"context_line":"            for seg_id, subnets in sid_subnets.items():"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"                # TODO(sahid): This whole part should be removed in future."},{"line_number":223,"context_line":"                segment \u003d sid_segment.get(seg_id)"},{"line_number":224,"context_line":"                if segment and segment.segment_index \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"52afd7e8_c6338b8e","side":"PARENT","line":221,"in_reply_to":"e3a91dbc_c7c98494","updated":"2023-06-06 08:12:19.000000000","message":"Done","commit_id":"9e6675ec06d3f37564d3fa328afdb9b816a5384e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ac112c60f2f48823332a5877206b1c6c1c976e39","unresolved":true,"context_lines":[{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":"        if (action not in [\u0027get_metadata_bind_interface\u0027] and"},{"line_number":210,"context_line":"                \u0027segments\u0027 in network and network.segments):"},{"line_number":211,"context_line":"            # In case of multi-segments network, let\u0027s group network per"},{"line_number":212,"context_line":"            # segments.  We can then create DHPC process per segmentation"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf11a958_f60608e6","line":209,"updated":"2023-05-30 14:59:02.000000000","message":"The alternative is to just check for this action and return early.\n\nif action \u003d\u003d \u0027get_metadata_bind_interface\u0027:\n    return self._call_driver(action, network, **action_kwargs)","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a66efb15c9d313dd3b1ce05e37a610b416a316a3","unresolved":true,"context_lines":[{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":"        if (action not in [\u0027get_metadata_bind_interface\u0027] and"},{"line_number":210,"context_line":"                \u0027segments\u0027 in network and network.segments):"},{"line_number":211,"context_line":"            # In case of multi-segments network, let\u0027s group network per"},{"line_number":212,"context_line":"            # segments.  We can then create DHPC process per segmentation"}],"source_content_type":"text/x-python","patch_set":1,"id":"d69dcb2f_f6365459","line":209,"in_reply_to":"55bb3a13_68f6f50e","updated":"2023-06-05 08:41:25.000000000","message":"+1","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"50a533ec63edc3e006385b76056ec2583315db15","unresolved":true,"context_lines":[{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":"        if (action not in [\u0027get_metadata_bind_interface\u0027] and"},{"line_number":210,"context_line":"                \u0027segments\u0027 in network and network.segments):"},{"line_number":211,"context_line":"            # In case of multi-segments network, let\u0027s group network per"},{"line_number":212,"context_line":"            # segments.  We can then create DHPC process per segmentation"}],"source_content_type":"text/x-python","patch_set":1,"id":"55bb3a13_68f6f50e","line":209,"in_reply_to":"bf11a958_f60608e6","updated":"2023-06-01 14:09:24.000000000","message":"Yeah, after looking I would vote to have this special condition check on it\u0027s own, but just my opinion.","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f5c99b784d8c119c8636df93b16efb49f838c40e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                     action, action_kwargs)"},{"line_number":207,"context_line":"            # There is nothing we can do."},{"line_number":208,"context_line":"            return"},{"line_number":209,"context_line":"        if (action not in [\u0027get_metadata_bind_interface\u0027] and"},{"line_number":210,"context_line":"                \u0027segments\u0027 in network and network.segments):"},{"line_number":211,"context_line":"            # In case of multi-segments network, let\u0027s group network per"},{"line_number":212,"context_line":"            # segments.  We can then create DHPC process per segmentation"}],"source_content_type":"text/x-python","patch_set":1,"id":"e4e4ce0e_8dff69b8","line":209,"in_reply_to":"d69dcb2f_f6365459","updated":"2023-06-06 08:12:19.000000000","message":"Done","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"50a533ec63edc3e006385b76056ec2583315db15","unresolved":true,"context_lines":[{"line_number":216,"context_line":"                sid_segment[segment.id] \u003d segment"},{"line_number":217,"context_line":"            for subnet in network.subnets:"},{"line_number":218,"context_line":"                sid_subnets[subnet.get(\u0027segment_id\u0027)].append(subnet)"},{"line_number":219,"context_line":"        if sid_subnets:"},{"line_number":220,"context_line":"            ret \u003d []"},{"line_number":221,"context_line":"            for seg_id, subnets in sid_subnets.items():"},{"line_number":222,"context_line":"                # TODO(sahid): This whole part should be removed in future."}],"source_content_type":"text/x-python","patch_set":1,"id":"412b4823_7a83625b","line":219,"updated":"2023-06-01 14:09:24.000000000","message":"Sahid - if you\u0027re going to do a follow-on to remove code based on your TODO, it seems like this whole block can be indented since sid_subnets will only be set if there are network segments.","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f5c99b784d8c119c8636df93b16efb49f838c40e","unresolved":true,"context_lines":[{"line_number":216,"context_line":"                sid_segment[segment.id] \u003d segment"},{"line_number":217,"context_line":"            for subnet in network.subnets:"},{"line_number":218,"context_line":"                sid_subnets[subnet.get(\u0027segment_id\u0027)].append(subnet)"},{"line_number":219,"context_line":"        if sid_subnets:"},{"line_number":220,"context_line":"            ret \u003d []"},{"line_number":221,"context_line":"            for seg_id, subnets in sid_subnets.items():"},{"line_number":222,"context_line":"                # TODO(sahid): This whole part should be removed in future."}],"source_content_type":"text/x-python","patch_set":1,"id":"36789f1f_097848da","line":219,"in_reply_to":"412b4823_7a83625b","updated":"2023-06-06 08:12:19.000000000","message":"I have created a change to add some details regarding the TODO. Basically we don\u0027t want to remove it today as we want to ensure all deployments have migrated to a version that has this code. https://review.opendev.org/c/openstack/neutron/+/885341/1\n\nThat is said I\u0027m not sure to see how I removed the if.. else?","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"50a533ec63edc3e006385b76056ec2583315db15","unresolved":true,"context_lines":[{"line_number":232,"context_line":"                    action, net_seg, segment\u003dsid_segment.get(seg_id),"},{"line_number":233,"context_line":"                    **action_kwargs))"},{"line_number":234,"context_line":"            return all(ret)"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            # In case subnets are not attached to segments. default behavior."},{"line_number":237,"context_line":"            return self._call_driver("},{"line_number":238,"context_line":"                action, network, **action_kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"956c016d_cc41cf24","line":235,"updated":"2023-06-01 14:09:24.000000000","message":"And if you made the above change, this else can be removed, right? Or do you not want to initiate a _call_driver() then? Either way for a follow-on change.","commit_id":"c5f9715cc505160773ace5aa8a45e9ec4c5c0000"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"132e0c02ac2c87659257bd8a83643b16e5968213","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        if action \u003d\u003d \u0027get_metadata_bind_interface\u0027:"},{"line_number":210,"context_line":"            # Special condition check that return string instead of a bool."},{"line_number":211,"context_line":"            return self._call_driver(action, network, **action_kwargs)"},{"line_number":212,"context_line":"        if (\u0027segments\u0027 in network and network.segments):"},{"line_number":213,"context_line":"            # In case of multi-segments network, let\u0027s group network per"},{"line_number":214,"context_line":"            # segments.  We can then create DHPC process per segmentation"},{"line_number":215,"context_line":"            # id. All subnets on a same network that are sharing the same"}],"source_content_type":"text/x-python","patch_set":2,"id":"0ba86198_a3c10cc4","line":212,"updated":"2023-06-07 17:24:45.000000000","message":"Can you remove the () from here? It is not in the original and should stay the same.","commit_id":"743b23761d269bb925ee124c5c49e4d14471b1fd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2022148bb516075efc1652f92a2308b6999fdd27","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        if action \u003d\u003d \u0027get_metadata_bind_interface\u0027:"},{"line_number":210,"context_line":"            # Special condition check that return string instead of a bool."},{"line_number":211,"context_line":"            return self._call_driver(action, network, **action_kwargs)"},{"line_number":212,"context_line":"        if (\u0027segments\u0027 in network and network.segments):"},{"line_number":213,"context_line":"            # In case of multi-segments network, let\u0027s group network per"},{"line_number":214,"context_line":"            # segments.  We can then create DHPC process per segmentation"},{"line_number":215,"context_line":"            # id. All subnets on a same network that are sharing the same"}],"source_content_type":"text/x-python","patch_set":2,"id":"cf903647_b79eca9a","line":212,"in_reply_to":"0ba86198_a3c10cc4","updated":"2023-06-08 06:49:34.000000000","message":"Done","commit_id":"743b23761d269bb925ee124c5c49e4d14471b1fd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"132e0c02ac2c87659257bd8a83643b16e5968213","unresolved":true,"context_lines":[{"line_number":219,"context_line":"            for subnet in network.subnets:"},{"line_number":220,"context_line":"                sid_subnets[subnet.get(\u0027segment_id\u0027)].append(subnet)"},{"line_number":221,"context_line":"        if sid_subnets:"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            ret \u003d []"},{"line_number":224,"context_line":"            for seg_id, subnets in sid_subnets.items():"},{"line_number":225,"context_line":"                # TODO(sahid): This whole part should be removed in future."}],"source_content_type":"text/x-python","patch_set":2,"id":"bb210a89_549383e5","line":222,"updated":"2023-06-07 17:24:45.000000000","message":"extra blank line and line removed below, should leave as before","commit_id":"743b23761d269bb925ee124c5c49e4d14471b1fd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2022148bb516075efc1652f92a2308b6999fdd27","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            for subnet in network.subnets:"},{"line_number":220,"context_line":"                sid_subnets[subnet.get(\u0027segment_id\u0027)].append(subnet)"},{"line_number":221,"context_line":"        if sid_subnets:"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            ret \u003d []"},{"line_number":224,"context_line":"            for seg_id, subnets in sid_subnets.items():"},{"line_number":225,"context_line":"                # TODO(sahid): This whole part should be removed in future."}],"source_content_type":"text/x-python","patch_set":2,"id":"47fb2f0c_337ef4cf","line":222,"in_reply_to":"bb210a89_549383e5","updated":"2023-06-08 06:49:34.000000000","message":"Done","commit_id":"743b23761d269bb925ee124c5c49e4d14471b1fd"}]}