)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"204b37bcc2d3e665a141c3cf77d356d9d90d18c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ea54edf_4ab06b04","updated":"2023-05-30 15:03:47.000000000","message":"Any new config options should also have a release note.","commit_id":"654ca7d05c4b3db85194b770f50135ed18186664"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"25df5d220410d14ebe39dde85f965f8721f42e4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99a018ed_f23c7e8a","in_reply_to":"4bd83f3f_a488ce6e","updated":"2023-06-06 15:27:24.000000000","message":"Done","commit_id":"654ca7d05c4b3db85194b770f50135ed18186664"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"91d4ab6eb2747b8e3a350600ee9fbcb830ef5672","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e08057d1_22a98070","in_reply_to":"9ea54edf_4ab06b04","updated":"2023-05-30 15:36:55.000000000","message":"Agree, will do","commit_id":"654ca7d05c4b3db85194b770f50135ed18186664"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6ad7de7576c4f72df69ea182791a9ec8bcd784e6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4bd83f3f_a488ce6e","in_reply_to":"e08057d1_22a98070","updated":"2023-06-01 08:56:56.000000000","message":"+1","commit_id":"654ca7d05c4b3db85194b770f50135ed18186664"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7c453597ab677a662b8d826420ab296277a57be1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1117c52d_eab67cad","updated":"2023-05-31 14:24:30.000000000","message":"Looks like PS4 un-did changed in PS3.","commit_id":"26343e6f42d7f53d35a7e8074b1089c42f3d3a57"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"25df5d220410d14ebe39dde85f965f8721f42e4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7648a461_5b09118e","in_reply_to":"1117c52d_eab67cad","updated":"2023-06-06 15:27:24.000000000","message":"done","commit_id":"26343e6f42d7f53d35a7e8074b1089c42f3d3a57"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e9e660d2c17e4ce640328e678d575792d5a20899","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"911fb847_e423e1a0","updated":"2023-06-07 14:52:55.000000000","message":"++","commit_id":"7f5c0b3383bcf34ece5b9bd17f37044634169e6f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9c199fd4c549cb15d8bf7ec0db29cfcc261d3026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7df998ec_1ce7da30","updated":"2023-06-07 12:24:10.000000000","message":"recheck\nfullstack timeout, but tests were green","commit_id":"7f5c0b3383bcf34ece5b9bd17f37044634169e6f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"830ca7bc79d2412e686f001d8d05a67330fc3cb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"745166da_af89879d","updated":"2023-06-11 09:33:51.000000000","message":"ACK Brian, let\u0027s fix this first. Thanks","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"961ca7fd153abc7a4bca1666cd31f28e6ce35f4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"460ecb18_cc623919","updated":"2023-06-20 08:05:21.000000000","message":"recheck\nhit of https://bugs.launchpad.net/grenade/+bug/2020643","commit_id":"078e4afb05bebe2503fbd1032389fe9bc2964de7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5e5525448b8fedcf42146b308bd259304bbd32c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"85ca319a_d3193bd0","updated":"2023-09-07 07:37:50.000000000","message":"recheck\nfunctional hit https://launchpad.net/bugs/2034540","commit_id":"2512b2ad3dd883635146cf6a0adee9b95b253817"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"84a18cf29f00180bdd2efccdf019cb212015102e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ca581c49_9fde20f7","updated":"2023-12-08 09:41:27.000000000","message":"recheck - unrelated connection issues","commit_id":"878ea0dfd5e0af358b3d0bbd3a7888b55569d7cf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a2d534d351e9788e89b83aaf1f2e838c0a042c3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c9b9e270_285a7401","updated":"2023-12-01 18:20:25.000000000","message":"recheck get new zuul run","commit_id":"878ea0dfd5e0af358b3d0bbd3a7888b55569d7cf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d8bb6cc5653573f40deeb035502b0a2aee75d08a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1db2425c_69c89d4a","updated":"2023-12-01 22:32:02.000000000","message":"recheck unrelated failure","commit_id":"878ea0dfd5e0af358b3d0bbd3a7888b55569d7cf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61cefe2add8f6fe91c35a5f208c21467862aa8f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"29a8a0e8_2614c02d","updated":"2023-12-05 01:47:54.000000000","message":"recheck unrelated failure","commit_id":"878ea0dfd5e0af358b3d0bbd3a7888b55569d7cf"}],"neutron/conf/common.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"204b37bcc2d3e665a141c3cf77d356d9d90d18c6","unresolved":true,"context_lines":[{"line_number":157,"context_line":"                       \u00273. Network scheduling mechanism \u0027"},{"line_number":158,"context_line":"                       \u00274. DHCP RPC/notification\u0027)),"},{"line_number":159,"context_line":"    cfg.BoolOpt(\u0027enable_signals\u0027, default\u003dTrue,"},{"line_number":160,"context_line":"                help\u003d_(\u0027If False, neutron will not listen for any Signal \u0027"},{"line_number":161,"context_line":"                       \u0027like SIGINT or SIGTERM. This is useful when running \u0027"},{"line_number":162,"context_line":"                       \u0027behind a wsgi server like apache/mod_wsgi\u0027)),"},{"line_number":163,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"24cac1bf_0e518c3f","line":160,"range":{"start_line":160,"start_character":34,"end_line":160,"end_character":41},"updated":"2023-05-30 15:03:47.000000000","message":"s/neutron-server or Neutron?","commit_id":"654ca7d05c4b3db85194b770f50135ed18186664"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"91d4ab6eb2747b8e3a350600ee9fbcb830ef5672","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                       \u00273. Network scheduling mechanism \u0027"},{"line_number":158,"context_line":"                       \u00274. DHCP RPC/notification\u0027)),"},{"line_number":159,"context_line":"    cfg.BoolOpt(\u0027enable_signals\u0027, default\u003dTrue,"},{"line_number":160,"context_line":"                help\u003d_(\u0027If False, neutron will not listen for any Signal \u0027"},{"line_number":161,"context_line":"                       \u0027like SIGINT or SIGTERM. This is useful when running \u0027"},{"line_number":162,"context_line":"                       \u0027behind a wsgi server like apache/mod_wsgi\u0027)),"},{"line_number":163,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ad400cf6_dc0cb03c","line":160,"range":{"start_line":160,"start_character":34,"end_line":160,"end_character":41},"in_reply_to":"24cac1bf_0e518c3f","updated":"2023-05-30 15:36:55.000000000","message":"neutron-server, done","commit_id":"654ca7d05c4b3db85194b770f50135ed18186664"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a0ba28644a65d428d0e01a7b9906a8bca79bf4a0","unresolved":true,"context_lines":[{"line_number":162,"context_line":"                      \u0027and one cannot be determined, 127.0.0.1 will be \u0027"},{"line_number":163,"context_line":"                      \u0027used.\u0027)),"},{"line_number":164,"context_line":"    cfg.BoolOpt(\u0027enable_signals\u0027, default\u003dTrue,"},{"line_number":165,"context_line":"                help\u003d_(\u0027If False, neutron will not listen for any Signal \u0027"},{"line_number":166,"context_line":"                       \u0027like SIGINT or SIGTERM. This is useful when running \u0027"},{"line_number":167,"context_line":"                       \u0027behind a wsgi server like apache/mod_wsgi\u0027)),"},{"line_number":168,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"bde41bf1_36f62bdc","line":165,"range":{"start_line":165,"start_character":34,"end_line":165,"end_character":41},"updated":"2023-06-09 15:08:02.000000000","message":"s/neutron-server","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a0ba28644a65d428d0e01a7b9906a8bca79bf4a0","unresolved":true,"context_lines":[{"line_number":162,"context_line":"                      \u0027and one cannot be determined, 127.0.0.1 will be \u0027"},{"line_number":163,"context_line":"                      \u0027used.\u0027)),"},{"line_number":164,"context_line":"    cfg.BoolOpt(\u0027enable_signals\u0027, default\u003dTrue,"},{"line_number":165,"context_line":"                help\u003d_(\u0027If False, neutron will not listen for any Signal \u0027"},{"line_number":166,"context_line":"                       \u0027like SIGINT or SIGTERM. This is useful when running \u0027"},{"line_number":167,"context_line":"                       \u0027behind a wsgi server like apache/mod_wsgi\u0027)),"},{"line_number":168,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"2f89a104_3085441b","line":165,"range":{"start_line":165,"start_character":66,"end_line":165,"end_character":72},"updated":"2023-06-09 15:08:02.000000000","message":"s/signals (lowercase)","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"16b8cb1749ddd803b0ae068e8924a5f41cdb2880","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                      \u0027and one cannot be determined, 127.0.0.1 will be \u0027"},{"line_number":163,"context_line":"                      \u0027used.\u0027)),"},{"line_number":164,"context_line":"    cfg.BoolOpt(\u0027enable_signals\u0027, default\u003dTrue,"},{"line_number":165,"context_line":"                help\u003d_(\u0027If False, neutron will not listen for any Signal \u0027"},{"line_number":166,"context_line":"                       \u0027like SIGINT or SIGTERM. This is useful when running \u0027"},{"line_number":167,"context_line":"                       \u0027behind a wsgi server like apache/mod_wsgi\u0027)),"},{"line_number":168,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3eab151b_db48b20c","line":165,"range":{"start_line":165,"start_character":66,"end_line":165,"end_character":72},"in_reply_to":"2f89a104_3085441b","updated":"2023-06-16 14:08:58.000000000","message":"Done","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"16b8cb1749ddd803b0ae068e8924a5f41cdb2880","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                      \u0027and one cannot be determined, 127.0.0.1 will be \u0027"},{"line_number":163,"context_line":"                      \u0027used.\u0027)),"},{"line_number":164,"context_line":"    cfg.BoolOpt(\u0027enable_signals\u0027, default\u003dTrue,"},{"line_number":165,"context_line":"                help\u003d_(\u0027If False, neutron will not listen for any Signal \u0027"},{"line_number":166,"context_line":"                       \u0027like SIGINT or SIGTERM. This is useful when running \u0027"},{"line_number":167,"context_line":"                       \u0027behind a wsgi server like apache/mod_wsgi\u0027)),"},{"line_number":168,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"cd5c6d70_d18b394c","line":165,"range":{"start_line":165,"start_character":34,"end_line":165,"end_character":41},"in_reply_to":"bde41bf1_36f62bdc","updated":"2023-06-16 14:08:58.000000000","message":"Done","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a0ba28644a65d428d0e01a7b9906a8bca79bf4a0","unresolved":true,"context_lines":[{"line_number":164,"context_line":"    cfg.BoolOpt(\u0027enable_signals\u0027, default\u003dTrue,"},{"line_number":165,"context_line":"                help\u003d_(\u0027If False, neutron will not listen for any Signal \u0027"},{"line_number":166,"context_line":"                       \u0027like SIGINT or SIGTERM. This is useful when running \u0027"},{"line_number":167,"context_line":"                       \u0027behind a wsgi server like apache/mod_wsgi\u0027)),"},{"line_number":168,"context_line":"]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"efd8a36f_c74f5dff","line":167,"range":{"start_line":167,"start_character":33,"end_line":167,"end_character":37},"updated":"2023-06-09 15:08:02.000000000","message":"s/WSGI","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"16b8cb1749ddd803b0ae068e8924a5f41cdb2880","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    cfg.BoolOpt(\u0027enable_signals\u0027, default\u003dTrue,"},{"line_number":165,"context_line":"                help\u003d_(\u0027If False, neutron will not listen for any Signal \u0027"},{"line_number":166,"context_line":"                       \u0027like SIGINT or SIGTERM. This is useful when running \u0027"},{"line_number":167,"context_line":"                       \u0027behind a wsgi server like apache/mod_wsgi\u0027)),"},{"line_number":168,"context_line":"]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"253b8e55_95915922","line":167,"range":{"start_line":167,"start_character":33,"end_line":167,"end_character":37},"in_reply_to":"efd8a36f_c74f5dff","updated":"2023-06-16 14:08:58.000000000","message":"Done","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"de0205295d296a512e3eb14f733f5a56e88149da","unresolved":true,"context_lines":[{"line_number":164,"context_line":"    cfg.BoolOpt(\u0027enable_signals\u0027, default\u003dTrue,"},{"line_number":165,"context_line":"                help\u003d_(\u0027If False, neutron-server will not listen for signals \u0027"},{"line_number":166,"context_line":"                       \u0027like SIGINT or SIGTERM. This is useful when running \u0027"},{"line_number":167,"context_line":"                       \u0027behind a WSGI server like apache/mod_wsgi\u0027)),"},{"line_number":168,"context_line":"]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"922f6245_50b71681","line":167,"updated":"2023-08-04 02:25:23.000000000","message":"Since you have to rebase for the merge conflict, can you put a trailing period on this text?","commit_id":"078e4afb05bebe2503fbd1032389fe9bc2964de7"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"88b39b133855b4a8f952904fceb70c09d9c633da","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    cfg.BoolOpt(\u0027enable_signals\u0027, default\u003dTrue,"},{"line_number":165,"context_line":"                help\u003d_(\u0027If False, neutron-server will not listen for signals \u0027"},{"line_number":166,"context_line":"                       \u0027like SIGINT or SIGTERM. This is useful when running \u0027"},{"line_number":167,"context_line":"                       \u0027behind a WSGI server like apache/mod_wsgi\u0027)),"},{"line_number":168,"context_line":"]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"efc44083_4dca182b","line":167,"in_reply_to":"922f6245_50b71681","updated":"2023-09-06 14:06:47.000000000","message":"Done","commit_id":"078e4afb05bebe2503fbd1032389fe9bc2964de7"}],"neutron/plugins/ml2/ovo_rpc.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"204b37bcc2d3e665a141c3cf77d356d9d90d18c6","unresolved":true,"context_lines":[{"line_number":154,"context_line":"    Generates RPC callback notifications on ML2 object changes."},{"line_number":155,"context_line":"    \"\"\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def __init__(self, enable_signals\u003dTrue):"},{"line_number":158,"context_line":"        self._rpc_pusher \u003d resources_rpc.ResourcesPushRpcApi()"},{"line_number":159,"context_line":"        self._setup_change_handlers()"},{"line_number":160,"context_line":"        # NOTE(arnaud) when running behind wsgi server (like apache2/mod_wsgi)"}],"source_content_type":"text/x-python","patch_set":1,"id":"517410ba_45b7f6bd","line":157,"updated":"2023-05-30 15:03:47.000000000","message":"How is this called with False?","commit_id":"654ca7d05c4b3db85194b770f50135ed18186664"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"91d4ab6eb2747b8e3a350600ee9fbcb830ef5672","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    Generates RPC callback notifications on ML2 object changes."},{"line_number":155,"context_line":"    \"\"\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def __init__(self, enable_signals\u003dTrue):"},{"line_number":158,"context_line":"        self._rpc_pusher \u003d resources_rpc.ResourcesPushRpcApi()"},{"line_number":159,"context_line":"        self._setup_change_handlers()"},{"line_number":160,"context_line":"        # NOTE(arnaud) when running behind wsgi server (like apache2/mod_wsgi)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f8a7607_3dbfad50","line":157,"in_reply_to":"517410ba_45b7f6bd","updated":"2023-05-30 15:36:55.000000000","message":"My bad, forgot one patch in plugin.py","commit_id":"654ca7d05c4b3db85194b770f50135ed18186664"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"de0205295d296a512e3eb14f733f5a56e88149da","unresolved":true,"context_lines":[{"line_number":157,"context_line":"    def __init__(self, enable_signals\u003dTrue):"},{"line_number":158,"context_line":"        self._rpc_pusher \u003d resources_rpc.ResourcesPushRpcApi()"},{"line_number":159,"context_line":"        self._setup_change_handlers()"},{"line_number":160,"context_line":"        # NOTE(arnaud) when running behind wsgi server (like apache2/mod_wsgi)"},{"line_number":161,"context_line":"        # we should not register signals"},{"line_number":162,"context_line":"        if enable_signals:"},{"line_number":163,"context_line":"            _setup_change_handlers_cleanup()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a359cd9_7840f47b","line":160,"range":{"start_line":160,"start_character":10,"end_line":160,"end_character":27},"updated":"2023-08-04 02:25:23.000000000","message":"nit: When\n\nI don\u0027t think you need to put your nick in the comment","commit_id":"078e4afb05bebe2503fbd1032389fe9bc2964de7"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"88b39b133855b4a8f952904fceb70c09d9c633da","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    def __init__(self, enable_signals\u003dTrue):"},{"line_number":158,"context_line":"        self._rpc_pusher \u003d resources_rpc.ResourcesPushRpcApi()"},{"line_number":159,"context_line":"        self._setup_change_handlers()"},{"line_number":160,"context_line":"        # NOTE(arnaud) when running behind wsgi server (like apache2/mod_wsgi)"},{"line_number":161,"context_line":"        # we should not register signals"},{"line_number":162,"context_line":"        if enable_signals:"},{"line_number":163,"context_line":"            _setup_change_handlers_cleanup()"}],"source_content_type":"text/x-python","patch_set":7,"id":"f788524a_f7b36184","line":160,"range":{"start_line":160,"start_character":10,"end_line":160,"end_character":27},"in_reply_to":"1a359cd9_7840f47b","updated":"2023-09-06 14:06:47.000000000","message":"Done","commit_id":"078e4afb05bebe2503fbd1032389fe9bc2964de7"}],"releasenotes/notes/enable_signals-option-706167609c0a5fa7.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a0ba28644a65d428d0e01a7b9906a8bca79bf4a0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new option named \u0027enable_signals\u0027 that force neutron to register (or"},{"line_number":5,"context_line":"    not) handlers on signals (like SIGUSR2, etc.)."},{"line_number":6,"context_line":"    The default value will be True so that neutron will register signals"},{"line_number":7,"context_line":"    handlers (original behavior)."},{"line_number":8,"context_line":"    The recommendation is to set this option to False when neutron server is"},{"line_number":9,"context_line":"    running behind a WSGI server, because in that situation the signals are"},{"line_number":10,"context_line":"    taken over by the WSGI server and neutron will stacktrace letting us know"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b765b5c1_63cc34b3","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":33},"updated":"2023-06-09 15:08:02.000000000","message":"There\u0027s some grammar issues here, and enable_signals should be in bold. I would re-write this first paragraph like this:\n\nA new config option ``enable_signals`` has been added to neutron.conf to control whether neutron-server registers signal handlers or not (like SIGTERM, etc). The default value for this new option is True to mimic the original behavior of registering signal handlers.","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"16b8cb1749ddd803b0ae068e8924a5f41cdb2880","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new option named \u0027enable_signals\u0027 that force neutron to register (or"},{"line_number":5,"context_line":"    not) handlers on signals (like SIGUSR2, etc.)."},{"line_number":6,"context_line":"    The default value will be True so that neutron will register signals"},{"line_number":7,"context_line":"    handlers (original behavior)."},{"line_number":8,"context_line":"    The recommendation is to set this option to False when neutron server is"},{"line_number":9,"context_line":"    running behind a WSGI server, because in that situation the signals are"},{"line_number":10,"context_line":"    taken over by the WSGI server and neutron will stacktrace letting us know"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f339f299_7645b8d2","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":33},"in_reply_to":"b765b5c1_63cc34b3","updated":"2023-06-16 14:08:58.000000000","message":"Done","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a0ba28644a65d428d0e01a7b9906a8bca79bf4a0","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    not) handlers on signals (like SIGUSR2, etc.)."},{"line_number":6,"context_line":"    The default value will be True so that neutron will register signals"},{"line_number":7,"context_line":"    handlers (original behavior)."},{"line_number":8,"context_line":"    The recommendation is to set this option to False when neutron server is"},{"line_number":9,"context_line":"    running behind a WSGI server, because in that situation the signals are"},{"line_number":10,"context_line":"    taken over by the WSGI server and neutron will stacktrace letting us know"},{"line_number":11,"context_line":"    that signals cannot be registered."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6a0674c0_41fb10ab","line":8,"range":{"start_line":8,"start_character":59,"end_line":8,"end_character":73},"updated":"2023-06-09 15:08:02.000000000","message":"s/neutron-server","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"16b8cb1749ddd803b0ae068e8924a5f41cdb2880","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    not) handlers on signals (like SIGUSR2, etc.)."},{"line_number":6,"context_line":"    The default value will be True so that neutron will register signals"},{"line_number":7,"context_line":"    handlers (original behavior)."},{"line_number":8,"context_line":"    The recommendation is to set this option to False when neutron server is"},{"line_number":9,"context_line":"    running behind a WSGI server, because in that situation the signals are"},{"line_number":10,"context_line":"    taken over by the WSGI server and neutron will stacktrace letting us know"},{"line_number":11,"context_line":"    that signals cannot be registered."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bd6187cb_fdeebbab","line":8,"range":{"start_line":8,"start_character":59,"end_line":8,"end_character":73},"in_reply_to":"6a0674c0_41fb10ab","updated":"2023-06-16 14:08:58.000000000","message":"Done","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a0ba28644a65d428d0e01a7b9906a8bca79bf4a0","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    handlers (original behavior)."},{"line_number":8,"context_line":"    The recommendation is to set this option to False when neutron server is"},{"line_number":9,"context_line":"    running behind a WSGI server, because in that situation the signals are"},{"line_number":10,"context_line":"    taken over by the WSGI server and neutron will stacktrace letting us know"},{"line_number":11,"context_line":"    that signals cannot be registered."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cfc43daf_b9691740","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":61},"updated":"2023-06-09 15:08:02.000000000","message":"s/print a stack trace ?","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"16b8cb1749ddd803b0ae068e8924a5f41cdb2880","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    handlers (original behavior)."},{"line_number":8,"context_line":"    The recommendation is to set this option to False when neutron server is"},{"line_number":9,"context_line":"    running behind a WSGI server, because in that situation the signals are"},{"line_number":10,"context_line":"    taken over by the WSGI server and neutron will stacktrace letting us know"},{"line_number":11,"context_line":"    that signals cannot be registered."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f5610fce_3a850fb5","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":61},"in_reply_to":"cfc43daf_b9691740","updated":"2023-06-16 14:08:58.000000000","message":"Done","commit_id":"0336ae7fc3036d5089b8de50bb725b1a9e86f107"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87b26f20178573959e038e81ad2f071645d30d2a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new config option enable_signals has been added to neutron.conf to"},{"line_number":5,"context_line":"    control whether neutron-server registers signal handlers or not (like"},{"line_number":6,"context_line":"    SIGTERM, etc). The default value for this new option is True to mimic the"},{"line_number":7,"context_line":"    original behavior of registering signal handlers."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"6ed391fc_1f0a59be","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":38},"updated":"2023-06-30 21:52:12.000000000","message":"This should be ``enable_signals`` so it\u0027s highlighted in the release note","commit_id":"078e4afb05bebe2503fbd1032389fe9bc2964de7"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"56229e878042073b3b1411b220bbc6095fc2713f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new config option enable_signals has been added to neutron.conf to"},{"line_number":5,"context_line":"    control whether neutron-server registers signal handlers or not (like"},{"line_number":6,"context_line":"    SIGTERM, etc). The default value for this new option is True to mimic the"},{"line_number":7,"context_line":"    original behavior of registering signal handlers."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e8928d8e_d42f4c69","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":38},"in_reply_to":"6ed391fc_1f0a59be","updated":"2023-07-13 15:34:49.000000000","message":"Done","commit_id":"078e4afb05bebe2503fbd1032389fe9bc2964de7"}]}