)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8e24e98261d985ce129e39a06629a56a37327783","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[neutron-api] remove leader_only for sb connection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The maintenance worker from the neutron-api uses a southbound"},{"line_number":10,"context_line":"connection. This task is using the southbound only to get data."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit removes the leader_only flag for the maintenance worker."},{"line_number":13,"context_line":"This should also enable the neutron api to connect to relays instead of only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6b70e725_e4aa1043","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":62},"updated":"2023-06-28 11:14:01.000000000","message":"I don\u0027t think this is true anymore after, this patch does remove duplicated entries from the SB Chassis and Chassis_Private tables.\n\nMaybe it\u0027s OK to do it from a backup instead of the leader db ? @terry perhaps can help us since he knows raft better than I do.\n\nhttps://review.opendev.org/c/openstack/neutron/+/885794","commit_id":"a0ae83097b1d0b76dd1b0af5c76b400f8e5b93ba"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a804c7e5a6d4801fbbacc47d4663825f7f80da8c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[neutron-api] remove leader_only for sb connection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The maintenance worker from the neutron-api uses a southbound"},{"line_number":10,"context_line":"connection. This task is using the southbound only to get data."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit removes the leader_only flag for the maintenance worker."},{"line_number":13,"context_line":"This should also enable the neutron api to connect to relays instead of only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b122689d_a78aeba5","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":62},"in_reply_to":"201bc0e5_65ea8667","updated":"2023-06-28 11:31:05.000000000","message":"If we can\u0027t issue a DB write command from backup DB and the performance improvement is relevant, we can always use the same \"trick\" done in [1]. This chassis/chassis_private deletion should be something very unusual, actually should never happen. It should be OK if we use [1] implementation.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/812805/12/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py","commit_id":"a0ae83097b1d0b76dd1b0af5c76b400f8e5b93ba"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3fdd54a6bcc45272ab3f1e092abf2d0c36d888e1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[neutron-api] remove leader_only for sb connection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The maintenance worker from the neutron-api uses a southbound"},{"line_number":10,"context_line":"connection. This task is using the southbound only to get data."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit removes the leader_only flag for the maintenance worker."},{"line_number":13,"context_line":"This should also enable the neutron api to connect to relays instead of only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"201bc0e5_65ea8667","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":62},"in_reply_to":"6b70e725_e4aa1043","updated":"2023-06-28 11:15:13.000000000","message":"I mean this patch [0] will remove*\n\n[0] https://review.opendev.org/c/openstack/neutron/+/885794/","commit_id":"a0ae83097b1d0b76dd1b0af5c76b400f8e5b93ba"},{"author":{"_account_id":33237,"name":"Maxim Korezkij","email":"maxim.korezkij@mail.schwarz","username":"korezkij"},"change_message_id":"9b33804179fb01ddbf34117f896284d7d57bc556","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[neutron-api] remove leader_only for sb connection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The maintenance worker from the neutron-api uses a southbound"},{"line_number":10,"context_line":"connection. This task is using the southbound only to get data."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit removes the leader_only flag for the maintenance worker."},{"line_number":13,"context_line":"This should also enable the neutron api to connect to relays instead of only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c84f2605_5a070f51","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":62},"in_reply_to":"b122689d_a78aeba5","updated":"2023-07-12 06:18:14.000000000","message":"I adjusted the commit message, i hope thats better now","commit_id":"a0ae83097b1d0b76dd1b0af5c76b400f8e5b93ba"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eb562e486736174a51e9c42a89c689c7777cd3cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8d8be4ce_2358955d","updated":"2023-06-05 09:44:39.000000000","message":"1) Please follow the guidelines for the commit messages: https://wiki.openstack.org/wiki/GitCommitMessages\n2) Open a Launchpad bug to describe the rationale of the issue.\n3) Add a release note. This change is very important.\n4) You should highlight that this is affecting the Neutron API only. The metadata agent modifies the SB DB.","commit_id":"78140825edbcc3f62231fc4366600b96ba071273"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"85bbb59f5f895b1001ce7b9ef9d4c4b4a998a029","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e6e8b9e7_9ad04e25","updated":"2023-07-11 14:46:09.000000000","message":"My main concern when originally setting leader_only\u003dFalse here was that OVSDB locks are per-server, not per-cluster. But as Maxim pointed out to me, we only call set_lock() on the NB DB, which makes sense. We just need *something* to tell us that we are the active maintenance worker, and we return early in methods where we are not. There\u0027s no need to do the lock on both DBs (and we don\u0027t).\n\nRegarding the fact that we now write to the SB, it isn\u0027t necessarily a problem if we don\u0027t write a lot. It\u0027s a bit less efficient to write to a non-leader as the request needs to be routed to the leader, but as long as it isn\u0027t a lot I wouldn\u0027t worry about it. Doing a single transaction in the never-going-to-happen worst case every 5 minutes from a single connection seems to me like it would be fine.","commit_id":"a0ae83097b1d0b76dd1b0af5c76b400f8e5b93ba"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8e24e98261d985ce129e39a06629a56a37327783","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b6b503d_98f7d98a","updated":"2023-06-28 11:14:01.000000000","message":"Soft -1, I want to know what terry thinks because we do write to the SB DB from the maintenance task","commit_id":"a0ae83097b1d0b76dd1b0af5c76b400f8e5b93ba"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a804c7e5a6d4801fbbacc47d4663825f7f80da8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cc2bcf56_d9558df7","updated":"2023-06-28 11:31:05.000000000","message":"Waiting for Terry\u0027s reply","commit_id":"a0ae83097b1d0b76dd1b0af5c76b400f8e5b93ba"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4a3845ec0a5ec3531dc267c19f959f82420e25eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6a14af17_df62b140","in_reply_to":"e6e8b9e7_9ad04e25","updated":"2023-07-11 15:19:13.000000000","message":"Sounds like we should go ahead with this then ?\n\nI agree regarding not needing a lock for both DBs, I can\u0027t think of scenario where that\u0027s needed because we could still use the NB lock to sync the workers even if we write to the SB DB","commit_id":"a0ae83097b1d0b76dd1b0af5c76b400f8e5b93ba"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8e24e98261d985ce129e39a06629a56a37327783","unresolved":true,"context_lines":[{"line_number":661,"context_line":"        helper.register_table(\u0027Encap\u0027)"},{"line_number":662,"context_line":"        helper.register_table(\u0027Port_Binding\u0027)"},{"line_number":663,"context_line":"        helper.register_table(\u0027Datapath_Binding\u0027)"},{"line_number":664,"context_line":"        # Used by MaintenanceWorker which can be a follower connection"},{"line_number":665,"context_line":"        try:"},{"line_number":666,"context_line":"            return cls(connection_string, helper, leader_only\u003dFalse)"},{"line_number":667,"context_line":"        except TypeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa24944_b0cafa12","line":664,"updated":"2023-06-28 11:14:01.000000000","message":"Not sure what \"a follower connection\" means. Maybe just get rid of this comment ?","commit_id":"a0ae83097b1d0b76dd1b0af5c76b400f8e5b93ba"},{"author":{"_account_id":33237,"name":"Maxim Korezkij","email":"maxim.korezkij@mail.schwarz","username":"korezkij"},"change_message_id":"9b33804179fb01ddbf34117f896284d7d57bc556","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        helper.register_table(\u0027Encap\u0027)"},{"line_number":662,"context_line":"        helper.register_table(\u0027Port_Binding\u0027)"},{"line_number":663,"context_line":"        helper.register_table(\u0027Datapath_Binding\u0027)"},{"line_number":664,"context_line":"        # Used by MaintenanceWorker which can be a follower connection"},{"line_number":665,"context_line":"        try:"},{"line_number":666,"context_line":"            return cls(connection_string, helper, leader_only\u003dFalse)"},{"line_number":667,"context_line":"        except TypeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a33ad501_69e791e7","line":664,"in_reply_to":"3fa24944_b0cafa12","updated":"2023-07-12 06:18:14.000000000","message":"got rid of it","commit_id":"a0ae83097b1d0b76dd1b0af5c76b400f8e5b93ba"}],"releasenotes/notes/bug-2022914-edbf1ea3514596b8.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"25c705dcbdfd275fd7353ce756243c71c853e001","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 2022914 \u003chttps://bugs.launchpad.net/neutron/+bug/2022914\u003e`_]"},{"line_number":5,"context_line":"    Neutron-API supports using relays as the southbound connection in a"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"82199183_abe3295e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2023-06-06 02:01:16.000000000","message":"This should be \u0027fixes\u0027","commit_id":"0ce4d9ae5d958899c0e0645372cdd4bcd5be3c6d"},{"author":{"_account_id":33237,"name":"Maxim Korezkij","email":"maxim.korezkij@mail.schwarz","username":"korezkij"},"change_message_id":"8be1d238690dbc78657c98f5e072720534e3493f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 2022914 \u003chttps://bugs.launchpad.net/neutron/+bug/2022914\u003e`_]"},{"line_number":5,"context_line":"    Neutron-API supports using relays as the southbound connection in a"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"881991db_faf5103d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"82199183_abe3295e","updated":"2023-06-06 07:07:58.000000000","message":"Done","commit_id":"0ce4d9ae5d958899c0e0645372cdd4bcd5be3c6d"}]}