)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"47cc455923c080eee01cf23f9c353378316dd7f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68a42f50_513a7fad","updated":"2023-06-15 23:40:53.000000000","message":"-1 just for the question","commit_id":"3ff058f53f7a34b3a3f6db489d9b61fdb25946b3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c6e7265344468c90e4d8c84c1ed803c0fa0b35e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"edd009d2_b4658af9","updated":"2023-06-20 15:29:48.000000000","message":"FT error is reported in other bug.","commit_id":"3ff058f53f7a34b3a3f6db489d9b61fdb25946b3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"49e3ff8c509ceba9681394d659de2174d194d9fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"929aa814_826f7f7e","updated":"2023-06-16 15:58:07.000000000","message":"recheck - functional and dvr scenario job failures don\u0027t seems like be related to this change","commit_id":"3ff058f53f7a34b3a3f6db489d9b61fdb25946b3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"83fd33c6d520878ee14222f995fe73dbf5c0c8e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"52e75bca_4c3388ee","updated":"2023-06-21 14:29:19.000000000","message":"Thanks","commit_id":"6e3525188fdfbe7fabd665e21df2068280471689"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8e69bf02edbe07fcef04b12d8662ce490470d194","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1cf17a5_8807862f","updated":"2023-06-22 07:23:23.000000000","message":"recheck - unrelated timeout in linuxbridge job","commit_id":"6e3525188fdfbe7fabd665e21df2068280471689"}],"neutron/conf/policies/subnet.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"47cc455923c080eee01cf23f9c353378316dd7f4","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":117,"context_line":"        name\u003d\u0027update_subnet\u0027,"},{"line_number":118,"context_line":"        check_str\u003dneutron_policy.policy_or("},{"line_number":119,"context_line":"            base.ADMIN_OR_PROJECT_MEMBER,"},{"line_number":120,"context_line":"            RULE_NET_OWNER_MEMBER),"},{"line_number":121,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":122,"context_line":"        description\u003d\u0027Update a subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ce3d7e9e_aa00f7fa","line":119,"range":{"start_line":119,"start_character":17,"end_line":119,"end_character":40},"updated":"2023-06-15 23:40:53.000000000","message":"I understand that a project member should have access to a project subnet, but now the same user that cannot create the subnet (a project member) can update/delete a subnet from a network that doesn\u0027t belong to him/her. Is that correct? Shouldn\u0027t we keep these check to the admin + the network owner only? Actually the subnet permissions should inherit from the network ones.","commit_id":"3ff058f53f7a34b3a3f6db489d9b61fdb25946b3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9e63d5158da88511444ce6f9a50daeeb915d889c","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":117,"context_line":"        name\u003d\u0027update_subnet\u0027,"},{"line_number":118,"context_line":"        check_str\u003dneutron_policy.policy_or("},{"line_number":119,"context_line":"            base.ADMIN_OR_PROJECT_MEMBER,"},{"line_number":120,"context_line":"            RULE_NET_OWNER_MEMBER),"},{"line_number":121,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":122,"context_line":"        description\u003d\u0027Update a subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7f5cb1e_db08f769","line":119,"range":{"start_line":119,"start_character":17,"end_line":119,"end_character":40},"in_reply_to":"ce3d7e9e_aa00f7fa","updated":"2023-06-16 15:56:29.000000000","message":"not really. In case of subnet create \"member\" means basically any user with member role as part \"project_id:%(project_id)s\" will always be ok and subnet will be created for the project to which that \"member\" belongs.\nIn case of update or delete this part will actually check if member is actual owner of the existing subnet or not. That\u0027s why I left it here.","commit_id":"3ff058f53f7a34b3a3f6db489d9b61fdb25946b3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c6e7265344468c90e4d8c84c1ed803c0fa0b35e3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":117,"context_line":"        name\u003d\u0027update_subnet\u0027,"},{"line_number":118,"context_line":"        check_str\u003dneutron_policy.policy_or("},{"line_number":119,"context_line":"            base.ADMIN_OR_PROJECT_MEMBER,"},{"line_number":120,"context_line":"            RULE_NET_OWNER_MEMBER),"},{"line_number":121,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":122,"context_line":"        description\u003d\u0027Update a subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"98c289da_f2bd1ffc","line":119,"range":{"start_line":119,"start_character":17,"end_line":119,"end_character":40},"in_reply_to":"f7f5cb1e_db08f769","updated":"2023-06-20 15:29:48.000000000","message":"Right, owner of the subnet, not the network (that is the next condition).","commit_id":"3ff058f53f7a34b3a3f6db489d9b61fdb25946b3"}]}