)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"29297aa01f453487e722b133e86a8c947c31d67c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d9107ea4_a36d9a94","updated":"2023-06-28 11:18:58.000000000","message":"I\u0027m fine with this patch but it deserves a release note, at least in the \"other\" section. Please, open a LP bug to document the issue fixed.","commit_id":"081ca4dfd6ef5a5be390bd52b9c927531b33da32"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"72314739342495c342817b25de15848cff72382c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"23741414_24bc68d2","updated":"2023-06-28 11:00:29.000000000","message":"could there be a corner case if the operator changes the DVR config from DVR to non-DVR and the external mac will never get cleared up?\n\nDoes the maintenance task cover this case?","commit_id":"081ca4dfd6ef5a5be390bd52b9c927531b33da32"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"29297aa01f453487e722b133e86a8c947c31d67c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4288a3a7_d4deb000","in_reply_to":"03e4a1f6_8bb7d524","updated":"2023-06-28 11:18:58.000000000","message":"I\u0027m trying to find too any side effect. The traffic will be sent to the chassis previously hosting the port instead of the centralized GW. If the FIP or the port is deleted, the NAT rule will be deleted too. If the port is scheduled in other chassis, the NAT mac will be changed.","commit_id":"081ca4dfd6ef5a5be390bd52b9c927531b33da32"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"10da8955a2874eb964be381375a0b0a10f88dbde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03e4a1f6_8bb7d524","in_reply_to":"23741414_24bc68d2","updated":"2023-06-28 11:12:10.000000000","message":"ops disregard my previous comment, it\u0027d be cleared up in this case.\nSo this patch will leave the external_mac even if it\u0027s down no? I can\u0027t think of any side effects but would be nice to double check","commit_id":"081ca4dfd6ef5a5be390bd52b9c927531b33da32"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b5947c0143e4fce50195bfe2392b0cf71b531788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f25664d_e7f9f605","updated":"2023-06-28 14:38:52.000000000","message":"Soft -1, trying to understand the conditional check","commit_id":"0ff3648858f1395357060eae078577fb40b608ff"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"84c0ad87f1429c9992ddad5112e4bcf920304b5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dcb4d136_0d684abd","updated":"2023-06-29 08:26:19.000000000","message":"recheck neutron-ovn-tempest-ipv6-only-ovs-release test_hotplug_nic","commit_id":"0090572b93d96348778c724194c26a976a9f8757"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"86537e6b31413ebd4a319694bdb911386ac826cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f5e020d0_73b012fe","updated":"2023-06-29 06:29:09.000000000","message":"recheck tempest-integrated-networking test_rebuild_volume_backed_server","commit_id":"0090572b93d96348778c724194c26a976a9f8757"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b5947c0143e4fce50195bfe2392b0cf71b531788","unresolved":true,"context_lines":[{"line_number":1088,"context_line":"                                 nat[\u0027external_mac\u0027]})).execute()"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        if ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":1091,"context_line":"            if up:"},{"line_number":1092,"context_line":"                mac \u003d nat[\u0027external_ids\u0027][ovn_const.OVN_FIP_EXT_MAC_KEY]"},{"line_number":1093,"context_line":"                if nat[\u0027external_mac\u0027] !\u003d mac:"},{"line_number":1094,"context_line":"                    LOG.debug(\"Setting external_mac of port %s to %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3851c05a_d633c463","line":1091,"range":{"start_line":1091,"start_character":12,"end_line":1091,"end_character":18},"updated":"2023-06-28 14:38:52.000000000","message":"Quick q: If we do not care about the port being up or down for external_mac to be set with DVR, why do we need this check; could be removed no ?\n\nOr, are we waiting for up to be true because things like OVN_FIP_EXT_MAC_KEY will only be set then ? But, even if that\u0027s the case I would rather have the following instead:\n\n```\nmac \u003d nat[\u0027external_ids\u0027].get(ovn_const.OVN_FIP_EXT_MAC_KEY)\nif nat[\u0027external_mac\u0027] !\u003d mac:\n    ....\n```","commit_id":"0ff3648858f1395357060eae078577fb40b608ff"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e16fbfdaf5edadbec724fe2a911bee2cbc096a2c","unresolved":true,"context_lines":[{"line_number":1088,"context_line":"                                 nat[\u0027external_mac\u0027]})).execute()"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        if ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":1091,"context_line":"            if up:"},{"line_number":1092,"context_line":"                mac \u003d nat[\u0027external_ids\u0027][ovn_const.OVN_FIP_EXT_MAC_KEY]"},{"line_number":1093,"context_line":"                if nat[\u0027external_mac\u0027] !\u003d mac:"},{"line_number":1094,"context_line":"                    LOG.debug(\"Setting external_mac of port %s to %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9b4b6274_49971fd8","line":1091,"range":{"start_line":1091,"start_character":12,"end_line":1091,"end_character":18},"in_reply_to":"3851c05a_d633c463","updated":"2023-06-28 14:40:48.000000000","message":"Sorry I meant:\n\n```\nif mac and mac !\u003d nat[\u0027external_mac\u0027]:\n\n```\n\nBecause I assume we care about the mac value and not the up value","commit_id":"0ff3648858f1395357060eae078577fb40b608ff"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e94151bfcb35aae7c0d37e9fc2128442ea2da1d9","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"                                 nat[\u0027external_mac\u0027]})).execute()"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        if ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":1091,"context_line":"            if up:"},{"line_number":1092,"context_line":"                mac \u003d nat[\u0027external_ids\u0027][ovn_const.OVN_FIP_EXT_MAC_KEY]"},{"line_number":1093,"context_line":"                if nat[\u0027external_mac\u0027] !\u003d mac:"},{"line_number":1094,"context_line":"                    LOG.debug(\"Setting external_mac of port %s to %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"a730eb21_e6733c5d","line":1091,"range":{"start_line":1091,"start_character":12,"end_line":1091,"end_character":18},"in_reply_to":"9b4b6274_49971fd8","updated":"2023-06-28 14:56:54.000000000","message":"you are right!","commit_id":"0ff3648858f1395357060eae078577fb40b608ff"}]}