)]}'
{"neutron/tests/unit/ml2/drivers/cisco/nexus/test_cisco_config.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"0dc18e2c4b58994c0a9d3895ff5bdaa0072a7468","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FlCQ%3D","line":2,"updated":"2014-04-19 03:36:33.000000000","message":"Drop the above","commit_id":"5b2bfb6400852ada436bc8d31ee00e4b8194d509"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"17b5ef625d15e46121ae606cc01ec960f4bef30d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FeR4%3D","line":2,"in_reply_to":"AAAAXH%2F%2Fh9A%3D","updated":"2014-04-21 14:15:02.000000000","message":"Quite the history. :-)\nAlso from the wiki:\nhttps://wiki.openstack.org/wiki/LegalIssuesFAQ#Copyright_Headers\nbullet item, \"We do not yet have guidance for when to add or remove a copyright header in source files.\" is adding more ambiguity on what should/shouldn\u0027t be added.\n\nI\u0027m still reluctant to remove all together since I find very few files w/ out some Copyright notice.\nI\u0027m going to change to \"Cisco Systems, Inc.\" copyright. My manager is going to check w/ upper management on what is required (if anything) for files created by Cisco employees.","commit_id":"5b2bfb6400852ada436bc8d31ee00e4b8194d509"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"86784bc66d67a8771f734ab9134a90b511cc10a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2Fiqg%3D","line":2,"in_reply_to":"AAAAXH%2F%2Fi5s%3D","updated":"2014-04-19 19:22:15.000000000","message":"Actually I thought I was a part of the \"Openstack Foundation\" -\nhttps://www.openstack.org/join/ :-)\nAlso I don\u0027t see many (virtually no) files that don\u0027t have a Copyright line at the top of the file. \nWe do have other *.py files written by Cisco engineers w/ a \"Copyright .... Cisco Systems, Inc.\" header.\nIs removing the Copyright line something new?","commit_id":"5b2bfb6400852ada436bc8d31ee00e4b8194d509"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"3c311c4db905f4a4798ae8ff99b3a505f0de1ab9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2Fh9A%3D","line":2,"in_reply_to":"AAAAXH%2F%2Fiqg%3D","updated":"2014-04-20 07:50:16.000000000","message":"https://wiki.openstack.org/wiki/LegalIssuesFAQ#OpenStack_Foundation_Copyright_Headers","commit_id":"5b2bfb6400852ada436bc8d31ee00e4b8194d509"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"126943e5a9f5280e920c5e09ceb48780e26399b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2Fi5s%3D","line":2,"in_reply_to":"AAAAXH%2F%2FjmY%3D","updated":"2014-04-19 17:16:44.000000000","message":"Actually I meant that the entire line should be dropped (unless you are an employee of the OpenStack foundation, which is not the case).","commit_id":"5b2bfb6400852ada436bc8d31ee00e4b8194d509"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"d283f33e53f6eebafaec73b723d97b617bbbf5ad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FjmY%3D","line":2,"in_reply_to":"AAAAXH%2F%2FlCQ%3D","updated":"2014-04-19 14:04:46.000000000","message":"Hi Sumit - Do you mean that the \"Copyright (c) ...\" line isn\u0027t required anymore or that the year is wrong? I\u0027m pushing up a new patch w/ the correct year.","commit_id":"5b2bfb6400852ada436bc8d31ee00e4b8194d509"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"0dc18e2c4b58994c0a9d3895ff5bdaa0072a7468","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        # Point neutron config file to: neutron/tests/etc/neutron.conf.test"},{"line_number":29,"context_line":"        args \u003d [\u0027--config-file\u0027, test_api_v2.etcdir(\u0027neutron.conf.test\u0027)]"},{"line_number":30,"context_line":"        neutron_config.parse(args\u003dargs)"},{"line_number":31,"context_line":"#Rac - didn\u0027t work        self.addCleanup(mock.patch.stopall)"},{"line_number":32,"context_line":"        super(TestCiscoNexusPluginConfig, self).setUp()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_config_parse_error(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FlCM%3D","line":31,"updated":"2014-04-19 03:36:33.000000000","message":"I believe the above should not be required","commit_id":"5b2bfb6400852ada436bc8d31ee00e4b8194d509"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"d283f33e53f6eebafaec73b723d97b617bbbf5ad","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        # Point neutron config file to: neutron/tests/etc/neutron.conf.test"},{"line_number":29,"context_line":"        args \u003d [\u0027--config-file\u0027, test_api_v2.etcdir(\u0027neutron.conf.test\u0027)]"},{"line_number":30,"context_line":"        neutron_config.parse(args\u003dargs)"},{"line_number":31,"context_line":"#Rac - didn\u0027t work        self.addCleanup(mock.patch.stopall)"},{"line_number":32,"context_line":"        super(TestCiscoNexusPluginConfig, self).setUp()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_config_parse_error(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2Fjl4%3D","line":31,"in_reply_to":"AAAAXH%2F%2FlCM%3D","updated":"2014-04-19 14:04:46.000000000","message":"Ugh! I wrote this (actually a copy/paste from cisco core plugin UT) back at the end of last year when addCleanup() was still required.\nRemoved comment line. Thanks.","commit_id":"5b2bfb6400852ada436bc8d31ee00e4b8194d509"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"9a011a41fc4eb6d6c8bb52b5d36d8cd393fab060","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            parser.return_value.read.return_value \u003d cfg.CONF.config_file"},{"line_number":71,"context_line":"            parser.return_value.parsed \u003d [test_config]"},{"line_number":72,"context_line":"            cisco_config.ML2MechCiscoConfig()"},{"line_number":73,"context_line":"            self.assertEqual(cisco_config.ML2MechCiscoConfig.nexus_dict,"},{"line_number":74,"context_line":"                             expected_dev_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FfBg%3D","line":73,"updated":"2014-04-21 12:02:50.000000000","message":"Nit: Expected should be first. If fails, it will label the first as \"reference\" and second as \"actual\" in output, so it\u0027ll be less confusing if the args are in that order.","commit_id":"bc9847c921656b3793732bd6faf7ed5d2b9f68ed"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"9ee06e959fe479d97204bef6c9cd14d03e50edc2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            parser.return_value.read.return_value \u003d cfg.CONF.config_file"},{"line_number":71,"context_line":"            parser.return_value.parsed \u003d [test_config]"},{"line_number":72,"context_line":"            cisco_config.ML2MechCiscoConfig()"},{"line_number":73,"context_line":"            self.assertEqual(cisco_config.ML2MechCiscoConfig.nexus_dict,"},{"line_number":74,"context_line":"                             expected_dev_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fee8%3D","line":73,"in_reply_to":"AAAAXH%2F%2FfBg%3D","updated":"2014-04-21 14:15:08.000000000","message":"Done","commit_id":"bc9847c921656b3793732bd6faf7ed5d2b9f68ed"}],"neutron/tests/unit/ml2/drivers/cisco/nexus/test_cisco_mech.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"9a011a41fc4eb6d6c8bb52b5d36d8cd393fab060","unresolved":false,"context_lines":[{"line_number":357,"context_line":"            self.mock_bound_segment.return_value \u003d BOUND_SEGMENT1"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def test_nexus_add_trunk(self):"},{"line_number":360,"context_line":"        \"\"\"Verify the syntax of the command to enable a vlan on an intf but"},{"line_number":361,"context_line":"        do not create the vlan interface."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        Test of the following ml2_conf_cisco_ini config:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FfAQ%3D","line":360,"updated":"2014-04-21 12:02:50.000000000","message":"Nit: PEP257 summary doc-string  line should be one line with period.","commit_id":"bc9847c921656b3793732bd6faf7ed5d2b9f68ed"},{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"9ee06e959fe479d97204bef6c9cd14d03e50edc2","unresolved":false,"context_lines":[{"line_number":357,"context_line":"            self.mock_bound_segment.return_value \u003d BOUND_SEGMENT1"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def test_nexus_add_trunk(self):"},{"line_number":360,"context_line":"        \"\"\"Verify the syntax of the command to enable a vlan on an intf but"},{"line_number":361,"context_line":"        do not create the vlan interface."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        Test of the following ml2_conf_cisco_ini config:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fee4%3D","line":360,"in_reply_to":"AAAAXH%2F%2FfAQ%3D","updated":"2014-04-21 14:15:08.000000000","message":"Done","commit_id":"bc9847c921656b3793732bd6faf7ed5d2b9f68ed"}]}
