)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7b83224724550914e700cb45408d1aad6f28ec4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"598f0767_1dd6b8e1","updated":"2023-06-26 16:54:23.000000000","message":"Add reno!","commit_id":"c032ebcf5a3416e6396c9dcd1bcde9d936dad9c2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"20cb790c3359bed1464c39feab2ea7da74719164","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"27c599dd_d55a381b","updated":"2023-06-26 16:56:59.000000000","message":"Update https://github.com/openstack/neutron/blame/cd66232c2b26cb4141c2e9426ce2dec0f38c364c/doc/source/ovn/faq/index.rst#L16-L29","commit_id":"c032ebcf5a3416e6396c9dcd1bcde9d936dad9c2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8acbd6e765be1ce5d8cce9d48d115362b48e0656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"56218926_f4bac06a","updated":"2023-07-03 20:22:39.000000000","message":"recheck neutron-ovs-grenade-dvr-multinode","commit_id":"32025042c7fdbc777c0aa914d68014fe810da8b4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63c4b8045708b49d820eb40ee1be40f64d4225ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"88df4949_d4ccd44b","updated":"2023-07-04 07:47:38.000000000","message":"recheck neutron-ovs-grenade-dvr-multinode","commit_id":"32025042c7fdbc777c0aa914d68014fe810da8b4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"124b34596b8b6555c7128e768d6c96c2755bed51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9f56624a_778e4a64","updated":"2023-08-28 12:43:43.000000000","message":"ping fellow reviewers","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"54e795fdaccfbe1af79a13f693b738e20b6d4670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2bca962e_3b3b8b5c","updated":"2023-08-18 09:28:49.000000000","message":"recheck\nhttps://review.opendev.org/c/openstack/neutron-tempest-plugin/+/891550 fixed some tempest/devstack issue","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9c4b82757cf5a9a23cd0f8b98176a46bfaa52476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8d6577f7_f4a3d051","updated":"2023-08-25 08:42:27.000000000","message":"recheck openstack-tox-py311","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4d48c162324f23e2f74e6436c92e083487075355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8eba4ff4_d6ff33e8","updated":"2023-08-21 13:08:37.000000000","message":"recheck rally","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"be79fe5dfb6be043bdc942e2cf2b1b5535d5edcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bbc04aeb_a4957463","updated":"2023-09-08 10:00:57.000000000","message":"-W until we have the new stable/2023.2 branch","commit_id":"cd08d695af4e05a27ef3ba330e3d86ab247fbe24"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a52f28f834f4bedba54cdd4c77df2384cb3ef5e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7f670b88_50678aae","updated":"2023-10-05 09:02:19.000000000","message":"recheck n-t-p issue fixed","commit_id":"1a1da2a896c7ec5e3159eeafa5de2a7cdde25b48"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"951a5e4af7be432f8d5c86d1caed22064e18f56a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d1f0a760_31b1d761","updated":"2023-09-29 13:39:49.000000000","message":"recheck neutron-tempest-plugin-openvswitch-iptables_hybrid","commit_id":"1a1da2a896c7ec5e3159eeafa5de2a7cdde25b48"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"91d2940f3600115eb2a72764ab29d6328e4f20b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"70b026e7_851d2c90","updated":"2023-10-13 13:49:17.000000000","message":"recheck neutron-fullstack-with-uwsgi","commit_id":"2066dcaea228c4b872048a486fa3b526d211c178"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"950df61323869969cac2a7dcd11528b27e9bee3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c362bd0d_555c3b69","updated":"2023-10-06 14:26:55.000000000","message":"recheck unrelated error","commit_id":"2066dcaea228c4b872048a486fa3b526d211c178"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9bbab8513deb01639eeae164379de7b8a7e2eb38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5f7c2100_feec6f8a","updated":"2023-10-19 12:52:59.000000000","message":"Hi Rodolfo, this is a very soft -1 to have the has_lock_periodic() decorator in the maintenance task to match the other methods there. Other than that this patch LGTM!","commit_id":"1312248b5b4bdc3a7aaea01829cac07594f4bb31"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"06d7159f146dfa010e64d40fc18cae0038515019","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"95d24eb5_11389d8e","updated":"2023-10-30 09:05:38.000000000","message":"recheck\nfullstack failure is not related","commit_id":"1f1824397dd4e2cfd2327b2d9fec7f57453b45d2"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d38ec723554c9b48e4329fcfbb797b58038a3b9f","unresolved":true,"context_lines":[{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        NOTE: remove this method when the RFE that allows to define the"},{"line_number":1099,"context_line":"        distributed flag per FIP is implemented. At this point, the"},{"line_number":1100,"context_line":"        router.distributed flag will be useless."},{"line_number":1101,"context_line":"        \"\"\""},{"line_number":1102,"context_line":"        if not self.has_lock:"},{"line_number":1103,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"3e6bfebd_56f6f8c3","line":1100,"updated":"2023-07-14 10:18:05.000000000","message":"A link to the LP for this RFE would be useful here I think","commit_id":"32025042c7fdbc777c0aa914d68014fe810da8b4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"01e20e23e89528ac60a6d522962590815c738dde","unresolved":false,"context_lines":[{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        NOTE: remove this method when the RFE that allows to define the"},{"line_number":1099,"context_line":"        distributed flag per FIP is implemented. At this point, the"},{"line_number":1100,"context_line":"        router.distributed flag will be useless."},{"line_number":1101,"context_line":"        \"\"\""},{"line_number":1102,"context_line":"        if not self.has_lock:"},{"line_number":1103,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"8e86c9ad_84bd0a50","line":1100,"in_reply_to":"3e6bfebd_56f6f8c3","updated":"2023-07-14 11:04:15.000000000","message":"Much better, for sure. Just for documentation, the spec has been merged and a n-lib patch, but seems that no other patches are proposed yet.","commit_id":"32025042c7fdbc777c0aa914d68014fe810da8b4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b9be881a30752d9dd9727f5ed4d77e609f354d97","unresolved":true,"context_lines":[{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"        distributed \u003d ovn_conf.is_ovn_distributed_floating_ip()"},{"line_number":1137,"context_line":"        router_obj.RouterExtraAttributes.update_distributed_flag("},{"line_number":1138,"context_line":"            n_context.get_admin_context(), distributed)"},{"line_number":1139,"context_line":"        raise periodics.NeverAgain()"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"10cc48b3_9f7dc9e1","line":1138,"updated":"2023-09-18 18:34:23.000000000","message":"So just question - seems like this will update even if the value hasn\u0027t changed, but assuming we don\u0027t have to check that as the DB code will just treat that as a no-op essentially?","commit_id":"8f70dbab9cec42b3ec908fab6f8b117dd5ce75ef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c6d449acc8ca6e21fe05e688fb149fb907d4009d","unresolved":false,"context_lines":[{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"        distributed \u003d ovn_conf.is_ovn_distributed_floating_ip()"},{"line_number":1137,"context_line":"        router_obj.RouterExtraAttributes.update_distributed_flag("},{"line_number":1138,"context_line":"            n_context.get_admin_context(), distributed)"},{"line_number":1139,"context_line":"        raise periodics.NeverAgain()"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"2fcc9b11_bf17342b","line":1138,"in_reply_to":"10cc48b3_9f7dc9e1","updated":"2023-09-21 14:56:52.000000000","message":"Right, the DB will update only those with the opposite value written in \"distributed\". Actually this method should return how many of them have been changed.\n\nAlthough this query is updating one whole table, it is a quick command.","commit_id":"8f70dbab9cec42b3ec908fab6f8b117dd5ce75ef"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9bbab8513deb01639eeae164379de7b8a7e2eb38","unresolved":true,"context_lines":[{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"        raise periodics.NeverAgain()"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":1099,"context_line":"    def update_router_distributed_flag(self):"},{"line_number":1100,"context_line":"        \"\"\"Set \"enable_distributed_floating_ip\" on the router.distributed flag."},{"line_number":1101,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"e86c39cb_7fad93b2","line":1098,"updated":"2023-10-19 12:52:59.000000000","message":"has_lock_periodic()\n\nTo be consistent with other methods in this class","commit_id":"1312248b5b4bdc3a7aaea01829cac07594f4bb31"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"580d7ddc58df892b656d502d5bfa1a2eb03e13d3","unresolved":false,"context_lines":[{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"        raise periodics.NeverAgain()"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    @periodics.periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":1099,"context_line":"    def update_router_distributed_flag(self):"},{"line_number":1100,"context_line":"        \"\"\"Set \"enable_distributed_floating_ip\" on the router.distributed flag."},{"line_number":1101,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"32ee5c24_da01c5de","line":1098,"in_reply_to":"e86c39cb_7fad93b2","updated":"2023-10-19 15:32:36.000000000","message":"Right, I need to get used to this new decorator.","commit_id":"1312248b5b4bdc3a7aaea01829cac07594f4bb31"}],"neutron/services/ovn_l3/plugin.py":[{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"4ff79c0503f2b63f83f7322a85e1ef62af6d6655","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        # NOTE(ralonsoh): the \"distributed\" flag is a static configuration"},{"line_number":179,"context_line":"        # parameter that needs to be defined only during the router creation."},{"line_number":180,"context_line":"        extra_attr \u003d router_db[\u0027extra_attributes\u0027]"},{"line_number":181,"context_line":"        extra_attr.distributed \u003d ovn_conf.is_ovn_distributed_floating_ip()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        db_rev.create_initial_revision("},{"line_number":184,"context_line":"            context, router_id, ovn_const.TYPE_ROUTERS,"}],"source_content_type":"text/x-python","patch_set":11,"id":"52b7235f_87dd9a45","line":181,"updated":"2023-09-28 11:27:16.000000000","message":"Hi Rodolfo, \nI\u0027m a little confused here since the router_extra_attributes:\u0027distrubuted\u0027 flag has no effect in the OVN world. I mean, no different flow is created when it\u0027s enabled (with or without ovn_distributed_floating_ip param).\n\nConsidering that the BGP protocol (used by n-d-r to advertise FIPs) always sends a prefix with \u0027nexthop\u0027 address, there is no way to make this work in OVN because the nexthop would always be the gateway router port! (which may be on another chassis - cr-lrp). IMO: the distributed FIP with OVN + BGP/n-d-r is not a valid scenario, unless the operator creates an IP on chassis/external provider network and use it to advertise as a netxtop (but I don\u0027t think that\u0027s the case).\n\nSo, in practice, setting the extra_attributes \u0027distributed\u0027 flag when the global ovn_distributed_floating_ip is configured -\u003e disables distributed floating IP in n-d-r (this sounds very strange, doesn\u0027t it?)  double True (distributed + ovn_distributed_floating_ip) becomes a False statement for n-d-r....\n\nDoes it make sense or have I missed something?","commit_id":"1a1da2a896c7ec5e3159eeafa5de2a7cdde25b48"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"5a1046d3179dbf40496fe333a2c11c8d28b30840","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        # NOTE(ralonsoh): the \"distributed\" flag is a static configuration"},{"line_number":179,"context_line":"        # parameter that needs to be defined only during the router creation."},{"line_number":180,"context_line":"        extra_attr \u003d router_db[\u0027extra_attributes\u0027]"},{"line_number":181,"context_line":"        extra_attr.distributed \u003d ovn_conf.is_ovn_distributed_floating_ip()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        db_rev.create_initial_revision("},{"line_number":184,"context_line":"            context, router_id, ovn_const.TYPE_ROUTERS,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1e7957c4_e5962c8b","line":181,"in_reply_to":"10dc07d8_2a401cfb","updated":"2023-10-05 11:37:26.000000000","message":"Thanks for your feedback.\n\nI understand and it makes sense from the exposing config parameter perspective. My only concern is that conditioning the two configurations may not be what is desired in some use cases.\n\nBTW, as the distributed router has a specific configuration parameter in neutron.conf, what would be the desired behavior if the operator enables ovn_distributed_floating_ip and configures \"router_distributed \u003d False\" in neutron.conf?","commit_id":"1a1da2a896c7ec5e3159eeafa5de2a7cdde25b48"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"42ed450f7d3f94a9caea4dfc5f465bd1108310cc","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        # NOTE(ralonsoh): the \"distributed\" flag is a static configuration"},{"line_number":179,"context_line":"        # parameter that needs to be defined only during the router creation."},{"line_number":180,"context_line":"        extra_attr \u003d router_db[\u0027extra_attributes\u0027]"},{"line_number":181,"context_line":"        extra_attr.distributed \u003d ovn_conf.is_ovn_distributed_floating_ip()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        db_rev.create_initial_revision("},{"line_number":184,"context_line":"            context, router_id, ovn_const.TYPE_ROUTERS,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fb3e3e27_0b3599be","line":181,"in_reply_to":"1e7957c4_e5962c8b","updated":"2023-10-06 07:24:54.000000000","message":"The \"dvr\" extension is not enabled in the OVN router thus this parameter cannot be manually set:\n```\nstack@u22ovn:/opt/stack$ openstack router set --distributed router2\nBadRequestException: 400: Client Error for url: http://192.168.10.100:9696/networking/v2.0/routers/54fa874b-ce45-4bee-ad72-586b0d9a5514, Unrecognized attribute(s) \u0027distributed\u0027\n```\n\nThis value is stored in the router information just to be able to be seen by other services, for example n-d-r, that trust in the router object returned. Please check the last sentence of the LP bug description.","commit_id":"1a1da2a896c7ec5e3159eeafa5de2a7cdde25b48"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"884d78884c10650bdb38787b98bd0123f478b88f","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        # NOTE(ralonsoh): the \"distributed\" flag is a static configuration"},{"line_number":179,"context_line":"        # parameter that needs to be defined only during the router creation."},{"line_number":180,"context_line":"        extra_attr \u003d router_db[\u0027extra_attributes\u0027]"},{"line_number":181,"context_line":"        extra_attr.distributed \u003d ovn_conf.is_ovn_distributed_floating_ip()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        db_rev.create_initial_revision("},{"line_number":184,"context_line":"            context, router_id, ovn_const.TYPE_ROUTERS,"}],"source_content_type":"text/x-python","patch_set":11,"id":"10dc07d8_2a401cfb","line":181,"in_reply_to":"52b7235f_87dd9a45","updated":"2023-10-05 09:09:49.000000000","message":"I\u0027ll stick to what I\u0027ve commented in the release note [1] and the bug description: the value set in this flag is exposing the ML2/OVN configuration parameter \"enable_distributed_floating_ip\". That will make easier to read, from the router object, what is the global configured parameter.\n\nUnlike in other mechanism drivers, this router flag in OVN does not have control over the router action (enabling or disabling it won\u0027t move from DVR to centralized). In ML2/OVN, this flag is only exposing a configuration parameter. And if this configuration parameter changes, the router information will be updated too.\n\nEven more, using the CLI it is not possible to change this flag because is not exposed.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/886992/11/releasenotes/notes/ovn-router-distributed-flag-48a8e72c1b258e40.yaml","commit_id":"1a1da2a896c7ec5e3159eeafa5de2a7cdde25b48"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"f08311d54c4bea3417a50b71ebde5c529d27217a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        # NOTE(ralonsoh): the \"distributed\" flag is a static configuration"},{"line_number":179,"context_line":"        # parameter that needs to be defined only during the router creation."},{"line_number":180,"context_line":"        extra_attr \u003d router_db[\u0027extra_attributes\u0027]"},{"line_number":181,"context_line":"        extra_attr.distributed \u003d ovn_conf.is_ovn_distributed_floating_ip()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        db_rev.create_initial_revision("},{"line_number":184,"context_line":"            context, router_id, ovn_const.TYPE_ROUTERS,"}],"source_content_type":"text/x-python","patch_set":11,"id":"387253a2_71b235f8","line":181,"in_reply_to":"fb3e3e27_0b3599be","updated":"2023-10-06 10:41:20.000000000","message":"Ok, thanks. I\u0027m good with this. Please, just verify the FT test_ha_router_lifecycle but the patch looks good.","commit_id":"1a1da2a896c7ec5e3159eeafa5de2a7cdde25b48"}],"releasenotes/notes/ovn-router-distributed-flag-48a8e72c1b258e40.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2dbab2c42be42c462d905d3441756fef55587377","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The OVN routers now expose the \"distributed\" flag depending on the"},{"line_number":5,"context_line":"    configuration option \"enable_distributed_floating_ip\". Because this is a"},{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d853b549_bfc1abe2","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":11},"updated":"2023-08-28 16:47:06.000000000","message":"s/OVN","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee51e60572c4552fbdc3cedf0783fa86fd57e29b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The OVN routers now expose the \"distributed\" flag depending on the"},{"line_number":5,"context_line":"    configuration option \"enable_distributed_floating_ip\". Because this is a"},{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b2630533_758a6371","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":11},"in_reply_to":"d853b549_bfc1abe2","updated":"2023-08-30 10:01:24.000000000","message":"Done","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2dbab2c42be42c462d905d3441756fef55587377","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The OVN routers now expose the \"distributed\" flag depending on the"},{"line_number":5,"context_line":"    configuration option \"enable_distributed_floating_ip\". Because this is a"},{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changed."},{"line_number":9,"context_line":"    NOTE: once the RFE that allows to define the distributed flag per floating"},{"line_number":10,"context_line":"    IP address is implemented in ML2/OVN, this flag will be useless."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b70124ce_4934e0f5","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":21},"updated":"2023-08-28 16:47:06.000000000","message":"s/if","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee51e60572c4552fbdc3cedf0783fa86fd57e29b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The OVN routers now expose the \"distributed\" flag depending on the"},{"line_number":5,"context_line":"    configuration option \"enable_distributed_floating_ip\". Because this is a"},{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changed."},{"line_number":9,"context_line":"    NOTE: once the RFE that allows to define the distributed flag per floating"},{"line_number":10,"context_line":"    IP address is implemented in ML2/OVN, this flag will be useless."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8e5ae3cd_8b98055d","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":21},"in_reply_to":"b70124ce_4934e0f5","updated":"2023-08-30 10:01:24.000000000","message":"Done","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2dbab2c42be42c462d905d3441756fef55587377","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    configuration option \"enable_distributed_floating_ip\". Because this is a"},{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changed."},{"line_number":9,"context_line":"    NOTE: once the RFE that allows to define the distributed flag per floating"},{"line_number":10,"context_line":"    IP address is implemented in ML2/OVN, this flag will be useless."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0d4400d3_512a9ffb","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":11},"updated":"2023-08-28 16:47:06.000000000","message":"s/changes","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee51e60572c4552fbdc3cedf0783fa86fd57e29b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    configuration option \"enable_distributed_floating_ip\". Because this is a"},{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changed."},{"line_number":9,"context_line":"    NOTE: once the RFE that allows to define the distributed flag per floating"},{"line_number":10,"context_line":"    IP address is implemented in ML2/OVN, this flag will be useless."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d3d272f4_bbf8e57d","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":11},"in_reply_to":"0d4400d3_512a9ffb","updated":"2023-08-30 10:01:24.000000000","message":"Done","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2dbab2c42be42c462d905d3441756fef55587377","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changed."},{"line_number":9,"context_line":"    NOTE: once the RFE that allows to define the distributed flag per floating"},{"line_number":10,"context_line":"    IP address is implemented in ML2/OVN, this flag will be useless."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"28d99f79_7115bd07","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":14},"updated":"2023-08-28 16:47:06.000000000","message":"s/Once","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2dbab2c42be42c462d905d3441756fef55587377","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changed."},{"line_number":9,"context_line":"    NOTE: once the RFE that allows to define the distributed flag per floating"},{"line_number":10,"context_line":"    IP address is implemented in ML2/OVN, this flag will be useless."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1c22536d_62240882","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":37},"updated":"2023-08-28 16:47:06.000000000","message":"s/allows us to","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee51e60572c4552fbdc3cedf0783fa86fd57e29b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changed."},{"line_number":9,"context_line":"    NOTE: once the RFE that allows to define the distributed flag per floating"},{"line_number":10,"context_line":"    IP address is implemented in ML2/OVN, this flag will be useless."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"94be32ee_0d850cf0","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":37},"in_reply_to":"1c22536d_62240882","updated":"2023-08-30 10:01:24.000000000","message":"Done","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee51e60572c4552fbdc3cedf0783fa86fd57e29b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changed."},{"line_number":9,"context_line":"    NOTE: once the RFE that allows to define the distributed flag per floating"},{"line_number":10,"context_line":"    IP address is implemented in ML2/OVN, this flag will be useless."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c6535c2d_e7a5f87d","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":14},"in_reply_to":"28d99f79_7115bd07","updated":"2023-08-30 10:01:24.000000000","message":"Done","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2dbab2c42be42c462d905d3441756fef55587377","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changed."},{"line_number":9,"context_line":"    NOTE: once the RFE that allows to define the distributed flag per floating"},{"line_number":10,"context_line":"    IP address is implemented in ML2/OVN, this flag will be useless."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8317171e_92499f6d","line":10,"range":{"start_line":10,"start_character":60,"end_line":10,"end_character":67},"updated":"2023-08-28 16:47:06.000000000","message":"nit: \u0027useless\u0027 is an interesting word choice, does that mean we will no longer return a true/false value?\n\nIt also might be useful to put the RFE url here.","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee51e60572c4552fbdc3cedf0783fa86fd57e29b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    value can flap in the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changed."},{"line_number":9,"context_line":"    NOTE: once the RFE that allows to define the distributed flag per floating"},{"line_number":10,"context_line":"    IP address is implemented in ML2/OVN, this flag will be useless."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"34908703_b22794a0","line":10,"range":{"start_line":10,"start_character":60,"end_line":10,"end_character":67},"in_reply_to":"8317171e_92499f6d","updated":"2023-08-30 10:01:24.000000000","message":"The value returned won\u0027t be considered by the Neutron server. This RFE is just an idea considered in several PTGs but there is no LP bug nor blueprint defined yet.","commit_id":"4c2b857884c59425bf45c07fafd1eef7be8f08e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b9be881a30752d9dd9727f5ed4d77e609f354d97","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OVN routers now expose the \"distributed\" flag depending on the"},{"line_number":5,"context_line":"    configuration option \"enable_distributed_floating_ip\". Because this is a"},{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap if the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changes."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"955a5f62_915b3f22","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":57},"updated":"2023-09-18 18:34:23.000000000","message":"nit: should be ``enable_distributed_floating_ip`` as it\u0027s a config option.","commit_id":"8f70dbab9cec42b3ec908fab6f8b117dd5ce75ef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c6d449acc8ca6e21fe05e688fb149fb907d4009d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OVN routers now expose the \"distributed\" flag depending on the"},{"line_number":5,"context_line":"    configuration option \"enable_distributed_floating_ip\". Because this is a"},{"line_number":6,"context_line":"    common configuration option, all routers will expose the same value. This"},{"line_number":7,"context_line":"    value can flap if the Neutron API is restarted and the configuration option"},{"line_number":8,"context_line":"    changes."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"820b1db9_562e4b81","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":57},"in_reply_to":"955a5f62_915b3f22","updated":"2023-09-21 14:56:52.000000000","message":"Done","commit_id":"8f70dbab9cec42b3ec908fab6f8b117dd5ce75ef"}]}