)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b5cd1263aa3e5388406dbc363a649a53d210d5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[OVN] Disable the mcast_flood_reports option for LSPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The mcast_flood_reports option was being enabled on LSPs as a workaround"},{"line_number":10,"context_line":"for a problem in core OVN. The issue in core OVN has been fixed for"},{"line_number":11,"context_line":"awhile and this workaround is now causing an increase in the number of"},{"line_number":12,"context_line":"actions on the table 38 of OVN (at the risk of hitting a size limit)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e537c463_6da722b3","line":10,"range":{"start_line":10,"start_character":58,"end_line":10,"end_character":63},"updated":"2023-07-11 17:01:03.000000000","message":"this should probably link to the exact patch that rendered this workaround unnecessary.","commit_id":"dc26feaf614a085b2aacb6607caf24d54087f0a8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c4737d7193a7412313b85123f51f943088ba5768","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[OVN] Disable the mcast_flood_reports option for LSPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The mcast_flood_reports option was being enabled on LSPs as a workaround"},{"line_number":10,"context_line":"for a problem in core OVN. The issue in core OVN has been fixed for"},{"line_number":11,"context_line":"awhile and this workaround is now causing an increase in the number of"},{"line_number":12,"context_line":"actions on the table 38 of OVN (at the risk of hitting a size limit)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4a56d1dc_ac1c3ff1","line":10,"range":{"start_line":10,"start_character":58,"end_line":10,"end_character":63},"in_reply_to":"0d10df1b_fcb30282","updated":"2023-07-13 09:20:38.000000000","message":"If this Neutron patch depends on a specific OVN version, we should make an upgrade check. Because we are still testing with older versions that are supported, we should have a conditional check (same as with \"Chassis_Private\" table) to disable or not the \"mcast_flood_reports\". Is it possible to make some kind of realtime check?","commit_id":"dc26feaf614a085b2aacb6607caf24d54087f0a8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0b521b440d3da3fb8c49f903e23711828836e3aa","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[OVN] Disable the mcast_flood_reports option for LSPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The mcast_flood_reports option was being enabled on LSPs as a workaround"},{"line_number":10,"context_line":"for a problem in core OVN. The issue in core OVN has been fixed for"},{"line_number":11,"context_line":"awhile and this workaround is now causing an increase in the number of"},{"line_number":12,"context_line":"actions on the table 38 of OVN (at the risk of hitting a size limit)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba42af42_5e3725ac","line":10,"range":{"start_line":10,"start_character":58,"end_line":10,"end_character":63},"in_reply_to":"4a56d1dc_ac1c3ff1","updated":"2023-07-13 09:32:48.000000000","message":"I will check, but, I don\u0027t know if it\u0027s possible because the fix [0] does not seem to include any change in the schema for us to detect it like the Chassis_Private one. So I am not sure if we can set the value of it on-the-fly :-/\n\n[0] https://github.com/ovn-org/ovn/commit/6aeeccdf272bc60630581e46aa42d97f4f56d4fa","commit_id":"dc26feaf614a085b2aacb6607caf24d54087f0a8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a5f96c8722992012e64a918b0692cd5bc2b85784","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[OVN] Disable the mcast_flood_reports option for LSPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The mcast_flood_reports option was being enabled on LSPs as a workaround"},{"line_number":10,"context_line":"for a problem in core OVN. The issue in core OVN has been fixed for"},{"line_number":11,"context_line":"awhile and this workaround is now causing an increase in the number of"},{"line_number":12,"context_line":"actions on the table 38 of OVN (at the risk of hitting a size limit)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f4f680cd_783a8fa4","line":10,"range":{"start_line":10,"start_character":58,"end_line":10,"end_character":63},"in_reply_to":"ba42af42_5e3725ac","updated":"2023-07-13 10:40:00.000000000","message":"The schema version for OVN 22.09 is:\n\n    \"name\": \"OVN_Northbound\",\n    \"version\": \"6.3.0\",\n\nMaybe checking if it\u0027s \u003e\u003d6.3.0 and set it accordingly ?","commit_id":"dc26feaf614a085b2aacb6607caf24d54087f0a8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7cfce8520474ff1f40021768f1b32a1c0bee9541","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[OVN] Disable the mcast_flood_reports option for LSPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The mcast_flood_reports option was being enabled on LSPs as a workaround"},{"line_number":10,"context_line":"for a problem in core OVN. The issue in core OVN has been fixed for"},{"line_number":11,"context_line":"awhile and this workaround is now causing an increase in the number of"},{"line_number":12,"context_line":"actions on the table 38 of OVN (at the risk of hitting a size limit)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0d10df1b_fcb30282","line":10,"range":{"start_line":10,"start_character":58,"end_line":10,"end_character":63},"in_reply_to":"e537c463_6da722b3","updated":"2023-07-11 17:03:39.000000000","message":"Also consider that we currently test against ovn LTS (22.03) and I believe the fix in core OVN was in 22.09+, so the gate doesn\u0027t include it. I suspect we don\u0027t test IGMP messages in any of our test scenarios and that\u0027s why Zuul passes, but that may be a problem if someone pulls LTS OVN with the latest neutron. Thoughts?","commit_id":"dc26feaf614a085b2aacb6607caf24d54087f0a8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"40ffb3dff99fea002550f160bb231a4e71d1fd6a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[OVN] Disable the mcast_flood_reports option for LSPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The mcast_flood_reports option was being enabled on LSPs as a workaround"},{"line_number":10,"context_line":"for a problem in core OVN. The issue in core OVN has been fixed for"},{"line_number":11,"context_line":"awhile and this workaround is now causing an increase in the number of"},{"line_number":12,"context_line":"actions on the table 38 of OVN (at the risk of hitting a size limit)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ad00184e_6271fe4d","line":10,"range":{"start_line":10,"start_character":58,"end_line":10,"end_character":63},"in_reply_to":"f4f680cd_783a8fa4","updated":"2023-07-20 09:09:33.000000000","message":"Done","commit_id":"dc26feaf614a085b2aacb6607caf24d54087f0a8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4e0f5ce6b6f96d4da8b7871ae9c933741f3c11ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f9ad7ac_d0008e0e","updated":"2023-07-11 10:40:35.000000000","message":"Doing some final tests","commit_id":"dc26feaf614a085b2aacb6607caf24d54087f0a8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00b5cd1263aa3e5388406dbc363a649a53d210d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa7f3733_04ed05e4","updated":"2023-07-11 17:01:03.000000000","message":"Thanks. I\u0027d suggest to include the link to ovn core fix somewhere (in commit message I guess).","commit_id":"dc26feaf614a085b2aacb6607caf24d54087f0a8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c672f1a6f3e9a373e13ff84ce4c5e4ce93b52db5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"02c0d075_20ef3548","updated":"2023-07-11 11:08:21.000000000","message":"Works","commit_id":"dc26feaf614a085b2aacb6607caf24d54087f0a8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"852c3f458b1b7f421d55e01f06890892d7be2d8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4de1c8cc_33ac8744","updated":"2023-07-21 09:01:29.000000000","message":"recheck","commit_id":"fbccbb1cd1cf497055cce3ee7ff2a66a29dabd41"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a7c95903f4684e2a98aa7351488996880fd3767a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6865a930_91e07a0a","updated":"2023-08-10 09:38:27.000000000","message":"Just wondering if we need a release note for this ?","commit_id":"c1ef7ff047bd37be9730f0e0e3f78ffdf9a9f6ad"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"de498340a6e4b8ad49fc69117cee0b1ff331228b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4f4819f2_aa0af13b","in_reply_to":"6865a930_91e07a0a","updated":"2023-08-10 12:25:43.000000000","message":"Sure, will add one","commit_id":"c1ef7ff047bd37be9730f0e0e3f78ffdf9a9f6ad"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c21b1049178b8ff0a867de9852d2da42a37d82a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4dcf956e_92dcf957","updated":"2023-08-17 08:37:10.000000000","message":"Last patch just fixes a merge conflict in fake_resources.py","commit_id":"06dbc5227b9208887bab9bc6623098c80156f36d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f6cef0a1b29a4682f6677a93a923a0fd53e39241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1985b3a8_4501082f","updated":"2023-08-20 21:01:09.000000000","message":"recheck","commit_id":"06dbc5227b9208887bab9bc6623098c80156f36d"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8d69c1f77cf8ddb004e34323cef9938e57c61984","unresolved":true,"context_lines":[{"line_number":634,"context_line":""},{"line_number":635,"context_line":"                if port_type \u003d\u003d ovn_const.LSP_TYPE_LOCALNET:"},{"line_number":636,"context_line":"                    mcast_flood_value \u003d options.get("},{"line_number":637,"context_line":"                        ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS)"},{"line_number":638,"context_line":"                    if mcast_flood_value \u003d\u003d \u0027false\u0027:"},{"line_number":639,"context_line":"                        continue"},{"line_number":640,"context_line":"                    options.update("}],"source_content_type":"text/x-python","patch_set":2,"id":"cc27519b_69ab8efe","line":637,"updated":"2023-07-19 17:29:19.000000000","message":"Looks like this is re-doing L627 so not necessary","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"40ffb3dff99fea002550f160bb231a4e71d1fd6a","unresolved":false,"context_lines":[{"line_number":634,"context_line":""},{"line_number":635,"context_line":"                if port_type \u003d\u003d ovn_const.LSP_TYPE_LOCALNET:"},{"line_number":636,"context_line":"                    mcast_flood_value \u003d options.get("},{"line_number":637,"context_line":"                        ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS)"},{"line_number":638,"context_line":"                    if mcast_flood_value \u003d\u003d \u0027false\u0027:"},{"line_number":639,"context_line":"                        continue"},{"line_number":640,"context_line":"                    options.update("}],"source_content_type":"text/x-python","patch_set":2,"id":"efd92711_9b0d3a45","line":637,"in_reply_to":"cc27519b_69ab8efe","updated":"2023-07-20 09:09:33.000000000","message":"Done","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8d69c1f77cf8ddb004e34323cef9938e57c61984","unresolved":true,"context_lines":[{"line_number":640,"context_line":"                    options.update("},{"line_number":641,"context_line":"                        {ovn_const.LSP_OPTIONS_MCAST_FLOOD: \u0027false\u0027})"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"                elif ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS in options:"},{"line_number":644,"context_line":"                    continue"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"                options.update("}],"source_content_type":"text/x-python","patch_set":2,"id":"314edbbc_9a92da39","line":643,"updated":"2023-07-19 17:29:19.000000000","message":"mcast_flood_value would have been set on L627 to None/\u0027true\u0027/\u0027false\u0027 I think, so seems this line can change slightly to \u0027not mcast_flood_value\u0027 ?","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"40ffb3dff99fea002550f160bb231a4e71d1fd6a","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                    options.update("},{"line_number":641,"context_line":"                        {ovn_const.LSP_OPTIONS_MCAST_FLOOD: \u0027false\u0027})"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"                elif ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS in options:"},{"line_number":644,"context_line":"                    continue"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"                options.update("}],"source_content_type":"text/x-python","patch_set":2,"id":"c7892e43_34becc2e","line":643,"in_reply_to":"314edbbc_9a92da39","updated":"2023-07-20 09:09:33.000000000","message":"Done","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fb5ff6b481a8f4e5d5e6f8a4f6402a83b115d77","unresolved":true,"context_lines":[{"line_number":648,"context_line":"                cmds.append(self._nb_idl.lsp_set_options(port.name, **options))"},{"line_number":649,"context_line":"            else:"},{"line_number":650,"context_line":"                if (not mcast_flood_value or port_type \u003d\u003d"},{"line_number":651,"context_line":"                        ovn_const.LSP_TYPE_LOCALNET):"},{"line_number":652,"context_line":"                    continue"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"                cmds.append(self._nb_idl.db_remove("}],"source_content_type":"text/x-python","patch_set":2,"id":"49740944_19af0f2b","line":651,"updated":"2023-07-19 15:51:38.000000000","message":"so 1) for regular ports, we\u0027ll db_remove the option (which makes it behave like \u003dfalse); but 2) for LOCALNET ports, we\u0027ll leave \u003dfalse (which has the same effect). While I believe the effect of the discrepancy will be the same in both cases, I wonder if we should be consistent - by db_removing the option for all ports?","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"40ffb3dff99fea002550f160bb231a4e71d1fd6a","unresolved":true,"context_lines":[{"line_number":648,"context_line":"                cmds.append(self._nb_idl.lsp_set_options(port.name, **options))"},{"line_number":649,"context_line":"            else:"},{"line_number":650,"context_line":"                if (not mcast_flood_value or port_type \u003d\u003d"},{"line_number":651,"context_line":"                        ovn_const.LSP_TYPE_LOCALNET):"},{"line_number":652,"context_line":"                    continue"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"                cmds.append(self._nb_idl.db_remove("}],"source_content_type":"text/x-python","patch_set":2,"id":"a5d4d0e5_a738cc15","line":651,"in_reply_to":"49740944_19af0f2b","updated":"2023-07-20 09:09:33.000000000","message":"I will take a look at the logic there, but indeed should be consistent","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"26fd5e7d8483caef35992aa38822dca1656600ae","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                cmds.append(self._nb_idl.lsp_set_options(port.name, **options))"},{"line_number":649,"context_line":"            else:"},{"line_number":650,"context_line":"                if (not mcast_flood_value or port_type \u003d\u003d"},{"line_number":651,"context_line":"                        ovn_const.LSP_TYPE_LOCALNET):"},{"line_number":652,"context_line":"                    continue"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"                cmds.append(self._nb_idl.db_remove("}],"source_content_type":"text/x-python","patch_set":2,"id":"3e0b9da9_a65f80a5","line":651,"in_reply_to":"7057b80a_c1f20334","updated":"2023-08-01 09:00:17.000000000","message":"That would work too","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e115bd2c603c90ce259aed146951b4cdfa183cac","unresolved":true,"context_lines":[{"line_number":648,"context_line":"                cmds.append(self._nb_idl.lsp_set_options(port.name, **options))"},{"line_number":649,"context_line":"            else:"},{"line_number":650,"context_line":"                if (not mcast_flood_value or port_type \u003d\u003d"},{"line_number":651,"context_line":"                        ovn_const.LSP_TYPE_LOCALNET):"},{"line_number":652,"context_line":"                    continue"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"                cmds.append(self._nb_idl.db_remove("}],"source_content_type":"text/x-python","patch_set":2,"id":"dc1a4dcf_cf47b834","line":651,"in_reply_to":"a5d4d0e5_a738cc15","updated":"2023-07-20 13:30:02.000000000","message":"Just a note, what we are setting to false is LSP_OPTIONS_MCAST_FLOOD and not LSP_OPTIONS_MCAST_FLOOD_REPORTS.\n\nAt the end, what we want to achieve is having LSP_OPTIONS_MCAST_FLOOD\u003dfalse and LSP_OPTIONS_MCAST_FLOOD_REPORTS\u003dtrue for the LOCALNET ports.\n\nI will change this logic to remove LSP_OPTIONS_MCAST_FLOOD (so it will be false by default)","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"881c1e8f27f618603341268de3cafee87d3463b0","unresolved":true,"context_lines":[{"line_number":648,"context_line":"                cmds.append(self._nb_idl.lsp_set_options(port.name, **options))"},{"line_number":649,"context_line":"            else:"},{"line_number":650,"context_line":"                if (not mcast_flood_value or port_type \u003d\u003d"},{"line_number":651,"context_line":"                        ovn_const.LSP_TYPE_LOCALNET):"},{"line_number":652,"context_line":"                    continue"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"                cmds.append(self._nb_idl.db_remove("}],"source_content_type":"text/x-python","patch_set":2,"id":"7057b80a_c1f20334","line":651,"in_reply_to":"dc1a4dcf_cf47b834","updated":"2023-07-31 20:25:24.000000000","message":"nit: seems a little strange to use an if() to continue, could have put the cmds.append() in here and let the continue happen at end of block.\n\nelif (mcast_flood_reports_value or\n      port_type !\u003d ovn_const.LSP_TYPE_LOCALNET):\n    cmds.append(...)","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3916f77ec44af3cc0a07c1caf377668cd41c4c6d","unresolved":true,"context_lines":[{"line_number":273,"context_line":"        if self._is_mcast_flood_broken is None:"},{"line_number":274,"context_line":"            schema_version \u003d self._nb_idl.get_schema_version()"},{"line_number":275,"context_line":"            self._is_mcast_flood_broken \u003d ("},{"line_number":276,"context_line":"                version.parse(schema_version) \u003c version.parse(\u00276.3.0\u0027))"},{"line_number":277,"context_line":"        return self._is_mcast_flood_broken"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def _get_port_options(self, port):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2dd1b82e_516ed1af","line":276,"range":{"start_line":276,"start_character":16,"end_line":276,"end_character":71},"updated":"2023-07-14 11:25:36.000000000","message":"nit: in Neutron we use oslo_utils.versionutils.convert_version_to_tuple\n```\n    versionutils.convert_version_to_tuple(schema_version) \u003c (6, 3, 0)\n```","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"26fd5e7d8483caef35992aa38822dca1656600ae","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        if self._is_mcast_flood_broken is None:"},{"line_number":274,"context_line":"            schema_version \u003d self._nb_idl.get_schema_version()"},{"line_number":275,"context_line":"            self._is_mcast_flood_broken \u003d ("},{"line_number":276,"context_line":"                version.parse(schema_version) \u003c version.parse(\u00276.3.0\u0027))"},{"line_number":277,"context_line":"        return self._is_mcast_flood_broken"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def _get_port_options(self, port):"}],"source_content_type":"text/x-python","patch_set":2,"id":"347c431d_7a15784e","line":276,"range":{"start_line":276,"start_character":16,"end_line":276,"end_character":71},"in_reply_to":"1f5a8b8c_be5799e0","updated":"2023-08-01 09:00:17.000000000","message":"Right on, will do","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"008e8c7b36e39cc7c5713f2430c52649cf65bcda","unresolved":true,"context_lines":[{"line_number":273,"context_line":"        if self._is_mcast_flood_broken is None:"},{"line_number":274,"context_line":"            schema_version \u003d self._nb_idl.get_schema_version()"},{"line_number":275,"context_line":"            self._is_mcast_flood_broken \u003d ("},{"line_number":276,"context_line":"                version.parse(schema_version) \u003c version.parse(\u00276.3.0\u0027))"},{"line_number":277,"context_line":"        return self._is_mcast_flood_broken"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def _get_port_options(self, port):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7029039_49596b60","line":276,"range":{"start_line":276,"start_character":16,"end_line":276,"end_character":71},"in_reply_to":"2dd1b82e_516ed1af","updated":"2023-07-14 12:17:44.000000000","message":"I actually saw this packaging.version being used in other places in Neutron, that was actually where I got it from:\n\nhttps://github.com/openstack/neutron/blob/ce5c60640c8c4ad1cf099eb3f3802d3f49475e9a/neutron/tests/common/helpers.py#L226-L227\n\nhttps://github.com/openstack/neutron/blob/ce5c60640c8c4ad1cf099eb3f3802d3f49475e9a/neutron/cmd/runtime_checks.py#L49\n\nLet me know. If needed I can change to the versionutils.","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"881c1e8f27f618603341268de3cafee87d3463b0","unresolved":true,"context_lines":[{"line_number":273,"context_line":"        if self._is_mcast_flood_broken is None:"},{"line_number":274,"context_line":"            schema_version \u003d self._nb_idl.get_schema_version()"},{"line_number":275,"context_line":"            self._is_mcast_flood_broken \u003d ("},{"line_number":276,"context_line":"                version.parse(schema_version) \u003c version.parse(\u00276.3.0\u0027))"},{"line_number":277,"context_line":"        return self._is_mcast_flood_broken"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def _get_port_options(self, port):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f5a8b8c_be5799e0","line":276,"range":{"start_line":276,"start_character":16,"end_line":276,"end_character":71},"in_reply_to":"c7029039_49596b60","updated":"2023-07-31 20:25:24.000000000","message":"I would recommend changing to use the code Rodolfo mentioned, as it is used in multiple places. I\u0027ll send up a quick patch to remove the packaging library from the two you mentioned.","commit_id":"ead224e2e0d4f7a1bc7a558463db8fa94d721073"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0ca63e3de71c84fe48dbda939e5300e0d15d7096","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        self._transaction(cmd)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    # TODO(lucasagomes): Remove this method and the logic around the broken"},{"line_number":303,"context_line":"    # mcast_flood_reports configuration option on any other port that is not"},{"line_number":304,"context_line":"    # type \"localnet\" when the fixed version of OVN becomes the norm."},{"line_number":305,"context_line":"    # The commit in core OVN fixing this issue is the"}],"source_content_type":"text/x-python","patch_set":6,"id":"be1bf9f7_d4c3fcc0","line":302,"range":{"start_line":302,"start_character":4,"end_line":302,"end_character":75},"updated":"2023-08-24 16:28:44.000000000","message":"+1\n\nThanks!","commit_id":"06dbc5227b9208887bab9bc6623098c80156f36d"}]}