)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"2f4af1b33df3dad14c91b54b36bc97227662a807","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31629924_5a93a3d2","updated":"2023-07-19 11:04:16.000000000","message":"Good patch, let\u0027s see how CI reacts to it! Thanks","commit_id":"ebe3f6b7e2d49ec5fb0f5b9e66ff9f0850f914b2"}],"neutron/services/trunk/drivers/ovn/trunk_driver.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"47013a02c3a8795fec9f4824339c9583d6121741","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        db_parent_port \u003d port_obj.Port.get_object(context, id\u003dparent_port)"},{"line_number":54,"context_line":"        parent_port_status \u003d db_parent_port.status"},{"line_number":55,"context_line":"        parent_port_bindings \u003d None"},{"line_number":56,"context_line":"        for pb in (pb for pb in db_parent_port.bindings if"},{"line_number":57,"context_line":"                   pb.status \u003d\u003d n_const.ACTIVE):"},{"line_number":58,"context_line":"            parent_port_bindings \u003d pb"},{"line_number":59,"context_line":"        for subport in subports:"},{"line_number":60,"context_line":"            with db_api.CONTEXT_WRITER.using(context), ("},{"line_number":61,"context_line":"                    txn(check_error\u003dTrue)) as ovn_txn:"}],"source_content_type":"text/x-python","patch_set":3,"id":"b8b2bd8a_b4c59fbe","line":58,"range":{"start_line":56,"start_character":0,"end_line":58,"end_character":37},"updated":"2023-07-20 17:47:59.000000000","message":"Sorry, maybe I am not understanding the scope of the change completely. But stricly only judging the code, isn\u0027t this going to set just the last pb that is ACTIVE? Is that what we want?","commit_id":"ba07706efc091df3d25660df1c28ed5f0e960ce0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a75993979612b56c9ff5ebf0f5c821eb3ff4c3f0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        db_parent_port \u003d port_obj.Port.get_object(context, id\u003dparent_port)"},{"line_number":54,"context_line":"        parent_port_status \u003d db_parent_port.status"},{"line_number":55,"context_line":"        parent_port_bindings \u003d None"},{"line_number":56,"context_line":"        for pb in (pb for pb in db_parent_port.bindings if"},{"line_number":57,"context_line":"                   pb.status \u003d\u003d n_const.ACTIVE):"},{"line_number":58,"context_line":"            parent_port_bindings \u003d pb"},{"line_number":59,"context_line":"        for subport in subports:"},{"line_number":60,"context_line":"            with db_api.CONTEXT_WRITER.using(context), ("},{"line_number":61,"context_line":"                    txn(check_error\u003dTrue)) as ovn_txn:"}],"source_content_type":"text/x-python","patch_set":3,"id":"c6cd3e67_78c8408e","line":58,"range":{"start_line":56,"start_character":0,"end_line":58,"end_character":37},"in_reply_to":"b8b2bd8a_b4c59fbe","updated":"2023-07-21 09:06:03.000000000","message":"In this section, from the multiple PB registers that we can find, we need the active one. I\u0027m just extracting this from a generator instead of making a \"if\" check inside the loop.\n\nIn \"_set_binding_profile\", from the PB provided, if we are in a live migration, we are extracting the destination host from the PB.options. In other case, the PB.host will be used.","commit_id":"ba07706efc091df3d25660df1c28ed5f0e960ce0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9b7991a0a5f7617261756de287fefec8320bc3b7","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        db_parent_port \u003d port_obj.Port.get_object(context, id\u003dparent_port)"},{"line_number":54,"context_line":"        parent_port_status \u003d db_parent_port.status"},{"line_number":55,"context_line":"        parent_port_bindings \u003d None"},{"line_number":56,"context_line":"        for pb in (pb for pb in db_parent_port.bindings if"},{"line_number":57,"context_line":"                   pb.status \u003d\u003d n_const.ACTIVE):"},{"line_number":58,"context_line":"            parent_port_bindings \u003d pb"},{"line_number":59,"context_line":"        for subport in subports:"},{"line_number":60,"context_line":"            with db_api.CONTEXT_WRITER.using(context), ("},{"line_number":61,"context_line":"                    txn(check_error\u003dTrue)) as ovn_txn:"}],"source_content_type":"text/x-python","patch_set":5,"id":"99fdc1cf_161f522a","line":58,"range":{"start_line":56,"start_character":0,"end_line":58,"end_character":37},"updated":"2023-08-22 12:44:39.000000000","message":"nit:\n\nWe don\u0027t need the second for loop\n\n```\ntry:\n    parent_port_bindings \u003d [pb for pb in db_parent_port.bindings \n                            if pb.status \u003d\u003d n_const.ACTIVE][-1]\nexcept IndexError:\n    parent_port_bindings \u003d None\n```","commit_id":"172424868fbe12013908a3b377cace6525f72127"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d6ced5fc3cc71edf1e0b926a37892e95091ded91","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        db_parent_port \u003d port_obj.Port.get_object(context, id\u003dparent_port)"},{"line_number":54,"context_line":"        parent_port_status \u003d db_parent_port.status"},{"line_number":55,"context_line":"        parent_port_bindings \u003d None"},{"line_number":56,"context_line":"        for pb in (pb for pb in db_parent_port.bindings if"},{"line_number":57,"context_line":"                   pb.status \u003d\u003d n_const.ACTIVE):"},{"line_number":58,"context_line":"            parent_port_bindings \u003d pb"},{"line_number":59,"context_line":"        for subport in subports:"},{"line_number":60,"context_line":"            with db_api.CONTEXT_WRITER.using(context), ("},{"line_number":61,"context_line":"                    txn(check_error\u003dTrue)) as ovn_txn:"}],"source_content_type":"text/x-python","patch_set":5,"id":"6846d72b_6b0f11e0","line":58,"range":{"start_line":56,"start_character":0,"end_line":58,"end_character":37},"in_reply_to":"99fdc1cf_161f522a","updated":"2023-08-24 09:11:08.000000000","message":"Done","commit_id":"172424868fbe12013908a3b377cace6525f72127"}]}