)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f367e47b2cd86537759f5f59eb6e89e50e52bd5e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, agents in DVR mode requesting a router update fetch all the"},{"line_number":10,"context_line":"FIPs on a network from the DB rather than just the FIPs that are"},{"line_number":11,"context_line":"relevant to the specific host requesting tte update."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"While not noticable in smaller networks with a limited number of"},{"line_number":14,"context_line":"floating IPs, this can add significant overhead in larger networks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"94342f20_33f8f249","line":11,"range":{"start_line":11,"start_character":41,"end_line":11,"end_character":44},"updated":"2023-07-19 16:24:58.000000000","message":"nit: the","commit_id":"80f46e823dfeb71ffe54f93d940667dcf6163096"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"403f71ee3c05405976199ee5697409f0dc853d3f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, agents in DVR mode requesting a router update fetch all the"},{"line_number":10,"context_line":"FIPs on a network from the DB rather than just the FIPs that are"},{"line_number":11,"context_line":"relevant to the specific host requesting tte update."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"While not noticable in smaller networks with a limited number of"},{"line_number":14,"context_line":"floating IPs, this can add significant overhead in larger networks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a46e9d67_30d73bfc","line":11,"range":{"start_line":11,"start_character":41,"end_line":11,"end_character":44},"in_reply_to":"94342f20_33f8f249","updated":"2023-07-19 16:42:05.000000000","message":"Done","commit_id":"80f46e823dfeb71ffe54f93d940667dcf6163096"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"d71215f44b1e65cf94920453c6198e93ae4e7b62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"024cb416_1e9718f1","updated":"2023-07-19 12:14:56.000000000","message":"In our environment, we have a network with x000s of FIPs and x00s of hosts. After applying this change, we\u0027ve seen the response time for the sync_routers call drop from around 40s to approximately 6s.","commit_id":"8cc8a594d15b2939f512404f24dd7f68078a5160"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f367e47b2cd86537759f5f59eb6e89e50e52bd5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"254206f3_1680e1e9","updated":"2023-07-19 16:24:58.000000000","message":"Is there a bug associated with this?\n\nAlso, are there unit tests for the changed methods that need adding to to test the host\u003d case now?","commit_id":"80f46e823dfeb71ffe54f93d940667dcf6163096"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"403f71ee3c05405976199ee5697409f0dc853d3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"331e2740_479a7de1","in_reply_to":"254206f3_1680e1e9","updated":"2023-07-19 16:42:05.000000000","message":"I didn\u0027t create a bug in this instance but can create one now if it\u0027s helpful.\n\nNone of the other unit tests were changed as I don\u0027t think any of them actually make a valid call to get_scoped_floating_ips.\n\nThere\u0027s only one case where this is called and [] is used as the value for router_ids so it won\u0027t return anything anyway.","commit_id":"80f46e823dfeb71ffe54f93d940667dcf6163096"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"92369d68fae88a99de64636842476260d49ecde0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bf8c8492_675458f6","updated":"2023-07-19 16:46:26.000000000","message":"I mentioned the bug since without it we can\u0027t backport. If it\u0027s related to the other bug you filed can add a \"Related-bug: #xxx\"","commit_id":"4527c5bcf196157bacca572e0edbb6a3a3dbf242"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"77fad9aa155eeb5a628b68e74002da005feedcff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f168a75_4eb6edc4","in_reply_to":"bf8c8492_675458f6","updated":"2023-07-19 17:01:21.000000000","message":"Got it. Created #2028185 and updated the commit message.\n\nIt isn\u0027t incredibly detailed (as I\u0027m hoping the patch kind of explains it anyway) but I can add more info the bug report if needed.","commit_id":"4527c5bcf196157bacca572e0edbb6a3a3dbf242"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"90000cb1b4b9ddf8447a7681015402fad10c518a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e3056c30_5449de8e","updated":"2023-08-10 00:44:13.000000000","message":"Looks good to me.","commit_id":"96fd203a1461a74318af0e89b3d049f618c32fde"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"72574ad9ec96c45533de9d33ff1228e9d887651a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4ed424cc_894d3937","updated":"2023-07-25 13:41:50.000000000","message":"Looks ok, and seems something that can be backported.","commit_id":"96fd203a1461a74318af0e89b3d049f618c32fde"}],"neutron/tests/unit/objects/test_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f367e47b2cd86537759f5f59eb6e89e50e52bd5e","unresolved":true,"context_lines":[{"line_number":355,"context_line":"            for j in range(3):"},{"line_number":356,"context_line":"                self._create_test_subnet_id(network_id\u003dnet_id,"},{"line_number":357,"context_line":"                                            subnet_pool_id\u003dsubnet_pool_id)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"                fip \u003d router.FloatingIP("},{"line_number":360,"context_line":"                    self.context,"},{"line_number":361,"context_line":"                    floating_ip_address\u003dnetaddr.IPAddress(f\u002710.{i}.{j}.3\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"d7444191_c942f6a7","line":358,"updated":"2023-07-19 16:24:58.000000000","message":"nit: unrelated change","commit_id":"80f46e823dfeb71ffe54f93d940667dcf6163096"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"403f71ee3c05405976199ee5697409f0dc853d3f","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            for j in range(3):"},{"line_number":356,"context_line":"                self._create_test_subnet_id(network_id\u003dnet_id,"},{"line_number":357,"context_line":"                                            subnet_pool_id\u003dsubnet_pool_id)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"                fip \u003d router.FloatingIP("},{"line_number":360,"context_line":"                    self.context,"},{"line_number":361,"context_line":"                    floating_ip_address\u003dnetaddr.IPAddress(f\u002710.{i}.{j}.3\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"42415244_ef940bd7","line":358,"in_reply_to":"d7444191_c942f6a7","updated":"2023-07-19 16:42:05.000000000","message":"Oops. Not sure how that got on there. Fixed","commit_id":"80f46e823dfeb71ffe54f93d940667dcf6163096"}]}