)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"07a3e78a5ac6f6c8adc06c9115411cde674b97c7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Lewis Denny \u003clewisdenny@me.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-25 16:00:42 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add max limit to agent_down_time"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The agent_down_time ends up being passed to an eventlet green-thread; under the hood, this uses a CPython C-types interface with a limitation of (2^32 / 2 - 1) MAXINT"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"19383058_8a1be128","line":7,"updated":"2023-07-25 17:59:37.000000000","message":"The commit message should explain what will happen with setups that have this setting currently set to values out of the new range. (They will fail to start neutron-server.)\n\nAnd since this is a change that may potentially break existing setups that (kinda) work, I think it\u0027s worth adding a release note to document this change in behavior. (See docs on `reno` - the tool openstack uses to maintain release notes - at: https://docs.openstack.org/reno/latest/user/usage.html)","commit_id":"2f29781412031feafea84a413a556025bcc8ce04"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"22a307bc6e70cdb457732b1b44dc8493c5975efa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lewis Denny \u003clewisdenny@me.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-25 16:00:42 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add max limit to agent_down_time"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The agent_down_time ends up being passed to an eventlet green-thread; under the hood, this uses a CPython C-types interface with a limitation of (2^32 / 2 - 1) MAXINT"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"010398df_e9d38312","line":7,"in_reply_to":"19383058_8a1be128","updated":"2023-07-26 01:44:31.000000000","message":"Done","commit_id":"2f29781412031feafea84a413a556025bcc8ce04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"07a3e78a5ac6f6c8adc06c9115411cde674b97c7","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"I have set the max value to (2^32 / 2 - 1)/1000 as agent_down_time configured in seconds."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is required as passing a larger number causes this traceback: OverflowError: timeout is too large"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib5b943344cddbd468c00768461ba1ee00a2b4c58"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ad0d9d54_bd72009f","line":13,"updated":"2023-07-25 17:59:37.000000000","message":"(nit) technically, it\u0027s not traceback (which implies a stack of calls), it\u0027s an error.","commit_id":"2f29781412031feafea84a413a556025bcc8ce04"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b023763e7603eda14ae970f48ef566d379751c95","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"I have set the max value to (2^32 / 2 - 1)/1000 as agent_down_time configured in seconds."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is required as passing a larger number causes this traceback: OverflowError: timeout is too large"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib5b943344cddbd468c00768461ba1ee00a2b4c58"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bb5a6ab4_5c533425","line":13,"in_reply_to":"ad0d9d54_bd72009f","updated":"2023-07-26 01:23:15.000000000","message":"Done","commit_id":"2f29781412031feafea84a413a556025bcc8ce04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"07a3e78a5ac6f6c8adc06c9115411cde674b97c7","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is required as passing a larger number causes this traceback: OverflowError: timeout is too large"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib5b943344cddbd468c00768461ba1ee00a2b4c58"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a555fa2c_1e02ce77","line":15,"updated":"2023-07-25 17:59:37.000000000","message":"Please report LP bug that you are trying to tackle in `bugs.launchpad.net` (you may copy paste details from rhbz for this issue - as long as it\u0027s tracked in Launchpad). Then link it here via `Closes-Bug: #...` tag.\n\nThis is helpful to track bug fixes for backports etc. This bug report could also be useful to track a potential fix in `oslo.service` for the same scenario - I think the library shouldn\u0027t allow passing `interval` values to `FixedIntervalWithTimeoutLoopingCall` that are (now) known to us as problematic. We should add `oslo.service` as another component that is affected by the issue.","commit_id":"2f29781412031feafea84a413a556025bcc8ce04"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b023763e7603eda14ae970f48ef566d379751c95","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is required as passing a larger number causes this traceback: OverflowError: timeout is too large"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib5b943344cddbd468c00768461ba1ee00a2b4c58"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"866b4959_4bf93b8e","line":15,"in_reply_to":"a555fa2c_1e02ce77","updated":"2023-07-26 01:23:15.000000000","message":"Done","commit_id":"2f29781412031feafea84a413a556025bcc8ce04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf3d91265d8c3a9b459714db376dc4a3ceb5af7a","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"I have set the max value to (2^32 / 2 - 1)/1000 as agent_down_time configured in seconds."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is required as passing a larger number causes this erorr: OverflowError: timeout is too large"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If a user currently has a value larger than (2^32 / 2 - 1)/1000 set, Neutron Server will fail to start and will print out a very helpful error message."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"8b992c96_5154d055","line":13,"updated":"2023-07-26 15:38:12.000000000","message":"s/erorr/error","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b1522ae478029eb088e5a24bb3e9439f5081c041","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"I have set the max value to (2^32 / 2 - 1)/1000 as agent_down_time configured in seconds."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is required as passing a larger number causes this erorr: OverflowError: timeout is too large"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If a user currently has a value larger than (2^32 / 2 - 1)/1000 set, Neutron Server will fail to start and will print out a very helpful error message."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"876df528_50f3b955","line":13,"in_reply_to":"8b992c96_5154d055","updated":"2023-07-27 03:03:50.000000000","message":"Done","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf3d91265d8c3a9b459714db376dc4a3ceb5af7a","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is required as passing a larger number causes this erorr: OverflowError: timeout is too large"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If a user currently has a value larger than (2^32 / 2 - 1)/1000 set, Neutron Server will fail to start and will print out a very helpful error message."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #2028724"},{"line_number":18,"context_line":"Change-Id: Ib5b943344cddbd468c00768461ba1ee00a2b4c58"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"efd8c145_59b067cc","line":15,"updated":"2023-07-26 15:38:12.000000000","message":"this line should be wrapped to fit in standard terminal.","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b1522ae478029eb088e5a24bb3e9439f5081c041","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is required as passing a larger number causes this erorr: OverflowError: timeout is too large"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If a user currently has a value larger than (2^32 / 2 - 1)/1000 set, Neutron Server will fail to start and will print out a very helpful error message."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #2028724"},{"line_number":18,"context_line":"Change-Id: Ib5b943344cddbd468c00768461ba1ee00a2b4c58"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c5a33356_fa701d98","line":15,"in_reply_to":"36f4c37e_e5ffa299","updated":"2023-07-27 03:03:50.000000000","message":"Done","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59ae770992b15828464e045528793643807c2617","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is required as passing a larger number causes this erorr: OverflowError: timeout is too large"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If a user currently has a value larger than (2^32 / 2 - 1)/1000 set, Neutron Server will fail to start and will print out a very helpful error message."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #2028724"},{"line_number":18,"context_line":"Change-Id: Ib5b943344cddbd468c00768461ba1ee00a2b4c58"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"36f4c37e_e5ffa299","line":15,"in_reply_to":"efd8c145_59b067cc","updated":"2023-07-26 20:28:25.000000000","message":"other lines should also be re-wrapped","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"07a3e78a5ac6f6c8adc06c9115411cde674b97c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8bc581d7_5cf8136a","updated":"2023-07-25 17:59:37.000000000","message":"Lewis, thanks for the patch. The direction of the change is correct; but I think we may have to catch some tails here - report a bug in Launchpad, add a comment, add a release note...","commit_id":"2f29781412031feafea84a413a556025bcc8ce04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf3d91265d8c3a9b459714db376dc4a3ceb5af7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"98e33e77_167aa8e2","updated":"2023-07-26 15:38:12.000000000","message":"Thanks for the new version! I think there\u0027s some adjustments needed in the release note and the help message (perhaps the latter shouldn\u0027t be touched).","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e4794d030ff9b94abcb952a15cfe8aabc4f9073d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"59a56e8f_a0523571","updated":"2023-07-27 21:19:10.000000000","message":"Happy to see this. Thanks!\n\nI wonder if in another patch whether we should find a way to allow disabling of this. I know the interval for the periodic worker ends up getting set to a minimum of 1, and the other methods in `neutron/db/agentschedulers_db.py` look like they\u0027d happily accept zero or negative numbers and pass them to time.sleep() or the PeriodicWorker loopingcall. Until then, should this have a minimum value as well?","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"85d5d661310353eba0117a2c13d27f31b6aea850","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c4f8dc4d_292dcfea","updated":"2023-07-27 20:03:28.000000000","message":"Thank you.","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"126c01c74a634a0925e38178ca8ed36af4527ce6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"faaa49ac_452e1da6","in_reply_to":"59a56e8f_a0523571","updated":"2023-07-28 19:47:59.000000000","message":"It may be, but it would be a different LP and a different patch.","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5f5702bba64e7408dbb7f8370a795925b22d0009","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b7196f5e_f4eb3462","updated":"2023-08-01 17:35:49.000000000","message":"-1 just for the relnote","commit_id":"db4c733dfc15ebde94f3960d4402c9c71612d8c3"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"832d8bc9ef0d8f4ece30292178914c4ae92d84f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"da10b0b4_a33f453a","updated":"2023-08-09 23:19:29.000000000","message":"recheck\npy310 timed out but passed in previous run","commit_id":"6fef1e65250dbda057206e1c2ee64f59b21d490f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d1d9e9324085ff94d9fd1e6e446adb55545fe650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d062c5e5_a8817362","updated":"2023-08-08 13:48:43.000000000","message":"recheck\ntest_unshelve_to_specific_host failure is unrelated","commit_id":"6fef1e65250dbda057206e1c2ee64f59b21d490f"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"0dfbc8618fc8ce9ca773b54ea392ab3f006c40e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"019da45e_d4774ddd","updated":"2023-08-14 23:53:29.000000000","message":"recheck \nneutron-functional-with-uwsgi failed but was successful in the last run.","commit_id":"6fef1e65250dbda057206e1c2ee64f59b21d490f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"fe4f373870ab263eeef8c489744fe990f93577c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"03e9885b_a3df782e","updated":"2023-08-16 14:07:41.000000000","message":"recheck unrelated timeouts","commit_id":"6fef1e65250dbda057206e1c2ee64f59b21d490f"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"764e26a463bee1679693cd9c6762ee5c809fc7ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"11607567_2fac1cb1","updated":"2023-08-22 05:46:29.000000000","message":"recheck unrelated timeouts","commit_id":"6fef1e65250dbda057206e1c2ee64f59b21d490f"}],"neutron/conf/agent/database/agents_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"07a3e78a5ac6f6c8adc06c9115411cde674b97c7","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from neutron.common import _constants"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"AGENT_OPTS \u003d ["},{"line_number":19,"context_line":"    cfg.IntOpt(\u0027agent_down_time\u0027, default\u003d75, max\u003d2147483,"},{"line_number":20,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":21,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":22,"context_line":"                      \"agent is down for good.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"d576bcf3_1cfa5c8e","line":19,"updated":"2023-07-25 17:59:37.000000000","message":"You should explain here in the comment why you use this upper limit. (A brief description and a link to Launchpad bug report should be sufficient.)\n\nAlso, I think it may be better to be slightly more explicit and replace the magic number with the formula you used to calculate it, e.g.\n\n`..., max\u003d(2 ** 32) / 2 - 1, ...`","commit_id":"2f29781412031feafea84a413a556025bcc8ce04"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b023763e7603eda14ae970f48ef566d379751c95","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from neutron.common import _constants"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"AGENT_OPTS \u003d ["},{"line_number":19,"context_line":"    cfg.IntOpt(\u0027agent_down_time\u0027, default\u003d75, max\u003d2147483,"},{"line_number":20,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":21,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":22,"context_line":"                      \"agent is down for good.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"e294caed_10592d80","line":19,"in_reply_to":"d576bcf3_1cfa5c8e","updated":"2023-07-26 01:23:15.000000000","message":"I adjusted your example to int(((2 ** 32) / 2 - 1)/1000)\n\nI believe it needs to be divided by 1000 as the value entered will be converted to milliseconds. \n\nI also cast the calculation to int as that\u0027s what max\u003d expects.\n\nPlease let me know what you think :)","commit_id":"2f29781412031feafea84a413a556025bcc8ce04"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"c15774802279d47acb562ab48600e343ab019e91","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron.common import _constants"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"AGENT_OPTS \u003d ["},{"line_number":19,"context_line":"    cfg.IntOpt(\u0027agent_down_time\u0027, default\u003d75, max\u003d2147483,"},{"line_number":20,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":21,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":22,"context_line":"                      \"agent is down for good.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7d88f934_e73ff893","line":19,"in_reply_to":"e294caed_10592d80","updated":"2023-07-27 03:05:23.000000000","message":"Done","commit_id":"2f29781412031feafea84a413a556025bcc8ce04"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf3d91265d8c3a9b459714db376dc4a3ceb5af7a","unresolved":true,"context_lines":[{"line_number":20,"context_line":"               max\u003d(int(((2 ** 32) / 2 - 1) / 1000)),"},{"line_number":21,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":22,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":23,"context_line":"                      \"agent is down for good. This value can only be a max \""},{"line_number":24,"context_line":"                      \"of ((2 ** 32) / 2 - 1)/1000 as it will be passed to \""},{"line_number":25,"context_line":"                      \"eventlet in milliseconds and any number higher \""},{"line_number":26,"context_line":"                      \"will produce an OverFlow error. More details here: \""}],"source_content_type":"text/x-python","patch_set":5,"id":"909724a9_334893f7","line":23,"updated":"2023-07-26 15:38:12.000000000","message":"Wait. :) This is help message as seen by users. I don\u0027t think we should document the \"reasons\" for the limit for users. It is of interest to developers only. That\u0027s why I suggested to add a comment before, not touch help message. I don\u0027t think it\u0027s needed / desirable to link to project bugs from help message. Nor the fact that the service uses eventlet is of interest to users.","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b1522ae478029eb088e5a24bb3e9439f5081c041","unresolved":false,"context_lines":[{"line_number":20,"context_line":"               max\u003d(int(((2 ** 32) / 2 - 1) / 1000)),"},{"line_number":21,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":22,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":23,"context_line":"                      \"agent is down for good. This value can only be a max \""},{"line_number":24,"context_line":"                      \"of ((2 ** 32) / 2 - 1)/1000 as it will be passed to \""},{"line_number":25,"context_line":"                      \"eventlet in milliseconds and any number higher \""},{"line_number":26,"context_line":"                      \"will produce an OverFlow error. More details here: \""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f916344_7544e1e6","line":23,"in_reply_to":"909724a9_334893f7","updated":"2023-07-27 03:03:50.000000000","message":"Done","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf3d91265d8c3a9b459714db376dc4a3ceb5af7a","unresolved":true,"context_lines":[{"line_number":21,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":22,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":23,"context_line":"                      \"agent is down for good. This value can only be a max \""},{"line_number":24,"context_line":"                      \"of ((2 ** 32) / 2 - 1)/1000 as it will be passed to \""},{"line_number":25,"context_line":"                      \"eventlet in milliseconds and any number higher \""},{"line_number":26,"context_line":"                      \"will produce an OverFlow error. More details here: \""},{"line_number":27,"context_line":"                      \"https://bugs.launchpad.net/neutron/+bug/2028724\")),"}],"source_content_type":"text/x-python","patch_set":5,"id":"4cb3e7ee_21ab851d","line":24,"range":{"start_line":24,"start_character":26,"end_line":24,"end_character":50},"updated":"2023-07-26 15:38:12.000000000","message":"I\u0027d suggest to not repeat the magic formula here or in a comment, instead just say it\u0027s MAX_INT (as defined in C), where int is - usually - 32 bits.","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d7beb08a4541669a3ff5d2ead904c2087c6bc2cf","unresolved":true,"context_lines":[{"line_number":21,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":22,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":23,"context_line":"                      \"agent is down for good. This value can only be a max \""},{"line_number":24,"context_line":"                      \"of ((2 ** 32) / 2 - 1)/1000 as it will be passed to \""},{"line_number":25,"context_line":"                      \"eventlet in milliseconds and any number higher \""},{"line_number":26,"context_line":"                      \"will produce an OverFlow error. More details here: \""},{"line_number":27,"context_line":"                      \"https://bugs.launchpad.net/neutron/+bug/2028724\")),"}],"source_content_type":"text/x-python","patch_set":5,"id":"c0871414_26759fb5","line":24,"range":{"start_line":24,"start_character":26,"end_line":24,"end_character":50},"in_reply_to":"4cb3e7ee_21ab851d","updated":"2023-07-26 15:39:19.000000000","message":"Sorry, it\u0027s `INT_MAX`, not `MAX_INT`.","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b1522ae478029eb088e5a24bb3e9439f5081c041","unresolved":false,"context_lines":[{"line_number":21,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":22,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":23,"context_line":"                      \"agent is down for good. This value can only be a max \""},{"line_number":24,"context_line":"                      \"of ((2 ** 32) / 2 - 1)/1000 as it will be passed to \""},{"line_number":25,"context_line":"                      \"eventlet in milliseconds and any number higher \""},{"line_number":26,"context_line":"                      \"will produce an OverFlow error. More details here: \""},{"line_number":27,"context_line":"                      \"https://bugs.launchpad.net/neutron/+bug/2028724\")),"}],"source_content_type":"text/x-python","patch_set":5,"id":"dce63188_7e93ee3a","line":24,"range":{"start_line":24,"start_character":26,"end_line":24,"end_character":50},"in_reply_to":"c0871414_26759fb5","updated":"2023-07-27 03:03:50.000000000","message":"Done","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e4794d030ff9b94abcb952a15cfe8aabc4f9073d","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    # eventlet in milliseconds and any number higher will produce an OverFlow"},{"line_number":22,"context_line":"    # error. More details here: https://bugs.launchpad.net/neutron/+bug/2028724"},{"line_number":23,"context_line":"    cfg.IntOpt(\u0027agent_down_time\u0027, default\u003d75,"},{"line_number":24,"context_line":"               max\u003d(int(((2 ** 32) / 2 - 1) / 1000)),"},{"line_number":25,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":26,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":27,"context_line":"                      \"agent is down for good.\")),"}],"source_content_type":"text/x-python","patch_set":8,"id":"0dc62dfd_fc147b09","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":52},"updated":"2023-07-27 21:19:10.000000000","message":"super-duper-nit: Extra parentheses here. The outside ones are superfluous.\n\nThe rest is just opinion very close to the importance of bike shed colors, so feel free to ignore. PEP8 gives a lot of leeway on whitespace around operators, but does suggest that when using operators with different priorities to add spaces around the ones with the *lowest* priority. I\u0027d remove the parens and spaces around the exponent as well. `max\u003dint((2**32 / 2 - 1) / 1000)` is a lot easier for me to read. YMMV, though, and not worth a respin.","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e99b4b09efc527726bf80b358e7cb80f38eae761","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    # eventlet in milliseconds and any number higher will produce an OverFlow"},{"line_number":22,"context_line":"    # error. More details here: https://bugs.launchpad.net/neutron/+bug/2028724"},{"line_number":23,"context_line":"    cfg.IntOpt(\u0027agent_down_time\u0027, default\u003d75,"},{"line_number":24,"context_line":"               max\u003d(int(((2 ** 32) / 2 - 1) / 1000)),"},{"line_number":25,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":26,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":27,"context_line":"                      \"agent is down for good.\")),"}],"source_content_type":"text/x-python","patch_set":8,"id":"4474db33_12da6dc3","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":52},"in_reply_to":"0dc62dfd_fc147b09","updated":"2023-07-28 06:43:37.000000000","message":"Too me it doesn\u0027t look good to read, may be we better just do (2\\**31 -1)//1000 ?\nNot clear why we do 2\\**32 and then divide by 2 instead of 2**31, also can use integer division instead of additional type cast to int, is there some reason for that and /me missing something?","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"126c01c74a634a0925e38178ca8ed36af4527ce6","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    # eventlet in milliseconds and any number higher will produce an OverFlow"},{"line_number":22,"context_line":"    # error. More details here: https://bugs.launchpad.net/neutron/+bug/2028724"},{"line_number":23,"context_line":"    cfg.IntOpt(\u0027agent_down_time\u0027, default\u003d75,"},{"line_number":24,"context_line":"               max\u003d(int(((2 ** 32) / 2 - 1) / 1000)),"},{"line_number":25,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":26,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":27,"context_line":"                      \"agent is down for good.\")),"}],"source_content_type":"text/x-python","patch_set":8,"id":"d234dda2_7f8db41a","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":52},"in_reply_to":"4474db33_12da6dc3","updated":"2023-07-28 19:47:59.000000000","message":"2**32 is just to indicate that it\u0027s 32 bits. Arguably, it\u0027s a matter of taste? (For example, if I were the author, I would go full explicit, so I would introduce the following globals at the top:\n\n```\nINT_BITS \u003d 32\nINT_MAX \u003d (2 ** INT_BITS / 2 - 1)\nAGENT_DOWN_TIME_MAX_SECS \u003d int(INT_MAX / 1000)\n```\n\nThen use it below in option definition, as in\n\n`..., max\u003dAGENT_DOWN_TIME_MAX_SECS, ...`\n\nBut that\u0027s a matter of taste.","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"69e4148ba837892b76aece1836e36c5219bf9eb1","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    # eventlet in milliseconds and any number higher will produce an OverFlow"},{"line_number":22,"context_line":"    # error. More details here: https://bugs.launchpad.net/neutron/+bug/2028724"},{"line_number":23,"context_line":"    cfg.IntOpt(\u0027agent_down_time\u0027, default\u003d75,"},{"line_number":24,"context_line":"               max\u003d(int(((2 ** 32) / 2 - 1) / 1000)),"},{"line_number":25,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":26,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":27,"context_line":"                      \"agent is down for good.\")),"}],"source_content_type":"text/x-python","patch_set":8,"id":"65546c3d_43de595f","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":52},"in_reply_to":"49016810_cd1feff5","updated":"2023-07-31 05:43:31.000000000","message":"Thanks Ihar for sharing the perspective, may be Lewis too thought the same way.\nAnd it\u0027s just me who thought it differently, Anyway i was not objecting the change itself, just wanted to avoid any unnecessary computation if possible.\n\nPersonally I would also have prefered private globals at the top, but would have avoided unnecessary computation and make it simple as we are hard coding it to 32 bits. To explain 32 bit part it could be just a simple comment.","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cedb4b08cd0fcfccee839d6ef55b5cfd956697c5","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    # eventlet in milliseconds and any number higher will produce an OverFlow"},{"line_number":22,"context_line":"    # error. More details here: https://bugs.launchpad.net/neutron/+bug/2028724"},{"line_number":23,"context_line":"    cfg.IntOpt(\u0027agent_down_time\u0027, default\u003d75,"},{"line_number":24,"context_line":"               max\u003d(int(((2 ** 32) / 2 - 1) / 1000)),"},{"line_number":25,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":26,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":27,"context_line":"                      \"agent is down for good.\")),"}],"source_content_type":"text/x-python","patch_set":8,"id":"49016810_cd1feff5","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":52},"in_reply_to":"d234dda2_7f8db41a","updated":"2023-07-28 19:49:10.000000000","message":"(though I would probably also make the globals \"private\", adding underscores at the start of each name)","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"61cc9b28f0787b9be114af555fe042edf58da58b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    # eventlet in milliseconds and any number higher will produce an OverFlow"},{"line_number":22,"context_line":"    # error. More details here: https://bugs.launchpad.net/neutron/+bug/2028724"},{"line_number":23,"context_line":"    cfg.IntOpt(\u0027agent_down_time\u0027, default\u003d75,"},{"line_number":24,"context_line":"               max\u003d((2**32 / 2 - 1) // 1000),"},{"line_number":25,"context_line":"               help\u003d_(\"Seconds to regard the agent as down; should be at \""},{"line_number":26,"context_line":"                      \"least twice report_interval, to be sure the \""},{"line_number":27,"context_line":"                      \"agent is down for good.\")),"}],"source_content_type":"text/x-python","patch_set":12,"id":"53c7d7b3_0bab2743","line":24,"updated":"2023-08-11 08:38:38.000000000","message":"This results into 2147483.0 but should be fine with oslo_config int max option.","commit_id":"6fef1e65250dbda057206e1c2ee64f59b21d490f"}],"releasenotes/notes/agent_down_time_max-af3b62763aaa2fe5.yaml":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf3d91265d8c3a9b459714db376dc4a3ceb5af7a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where agent_down_time can be configured to a value so high "},{"line_number":5,"context_line":"    it can crash due to CPython epoll limitation. If the agent_down_time is "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"64732541_9bae1590","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2023-07-26 15:38:12.000000000","message":"I am not sure this bug is worth being mentioned in `fixes` section (though that\u0027s ok), but I\u0027m sure that some info on upgrade impact should be added into `upgrade` section (that you don\u0027t have here). The section would explain to admins reading the release notes that, before upgrade, they should make sure that their `agent_down_time is \u003c\u003d \u003cvalue\u003e`.","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b1522ae478029eb088e5a24bb3e9439f5081c041","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where agent_down_time can be configured to a value so high "},{"line_number":5,"context_line":"    it can crash due to CPython epoll limitation. If the agent_down_time is "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"23dbbdcb_3791e3cb","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"64732541_9bae1590","updated":"2023-07-27 03:03:50.000000000","message":"Done","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf3d91265d8c3a9b459714db376dc4a3ceb5af7a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where agent_down_time can be configured to a value so high "},{"line_number":5,"context_line":"    it can crash due to CPython epoll limitation. If the agent_down_time is "},{"line_number":6,"context_line":"    already configured larger than ((2 ** 32) / 2 - 1)/1000), after this "},{"line_number":7,"context_line":"    patch neutron server will fail to start with a error explaining the "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8ddc2eb3_ec7bf6e1","line":4,"range":{"start_line":4,"start_character":25,"end_line":4,"end_character":40},"updated":"2023-07-26 15:38:12.000000000","message":"It\u0027s markdown format, you can use back-ticks like in: `agent_down_time`.","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf3d91265d8c3a9b459714db376dc4a3ceb5af7a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where agent_down_time can be configured to a value so high "},{"line_number":5,"context_line":"    it can crash due to CPython epoll limitation. If the agent_down_time is "},{"line_number":6,"context_line":"    already configured larger than ((2 ** 32) / 2 - 1)/1000), after this "},{"line_number":7,"context_line":"    patch neutron server will fail to start with a error explaining the "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d66c01d0_ff06b0d3","line":4,"range":{"start_line":4,"start_character":77,"end_line":4,"end_character":78},"updated":"2023-07-26 15:38:12.000000000","message":"these spaces should probably be cleaned up","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b1522ae478029eb088e5a24bb3e9439f5081c041","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where agent_down_time can be configured to a value so high "},{"line_number":5,"context_line":"    it can crash due to CPython epoll limitation. If the agent_down_time is "},{"line_number":6,"context_line":"    already configured larger than ((2 ** 32) / 2 - 1)/1000), after this "},{"line_number":7,"context_line":"    patch neutron server will fail to start with a error explaining the "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7318cf81_c5858e51","line":4,"range":{"start_line":4,"start_character":25,"end_line":4,"end_character":40},"in_reply_to":"8ddc2eb3_ec7bf6e1","updated":"2023-07-27 03:03:50.000000000","message":"Done","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b1522ae478029eb088e5a24bb3e9439f5081c041","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where agent_down_time can be configured to a value so high "},{"line_number":5,"context_line":"    it can crash due to CPython epoll limitation. If the agent_down_time is "},{"line_number":6,"context_line":"    already configured larger than ((2 ** 32) / 2 - 1)/1000), after this "},{"line_number":7,"context_line":"    patch neutron server will fail to start with a error explaining the "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f3e9b50c_c1556e5b","line":4,"range":{"start_line":4,"start_character":77,"end_line":4,"end_character":78},"in_reply_to":"d66c01d0_ff06b0d3","updated":"2023-07-27 03:03:50.000000000","message":"Done","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf3d91265d8c3a9b459714db376dc4a3ceb5af7a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where agent_down_time can be configured to a value so high "},{"line_number":5,"context_line":"    it can crash due to CPython epoll limitation. If the agent_down_time is "},{"line_number":6,"context_line":"    already configured larger than ((2 ** 32) / 2 - 1)/1000), after this "},{"line_number":7,"context_line":"    patch neutron server will fail to start with a error explaining the "},{"line_number":8,"context_line":"    agent_down_time is too large. For more information see bug: "},{"line_number":9,"context_line":"    https://bugs.launchpad.net/oslo.service/+bug/2028724"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a1dde5d_2a31040e","line":6,"updated":"2023-07-26 15:38:12.000000000","message":"This seems to go too deep into the woods. It would be sufficient to say that:\n\n- agent_down_time is now limited to maximum value of X.\n- neutron-server will fail to start if agent_down_time is more than X.\n\nIf you\u0027d like to be more specific, you may say that e.g. the bug scenario is when neutron-server worker threads may die when a `agent_down_time` value that is too high is configured, which may affect functionality of the service. (I don\u0027t think users care - or should care - that we use cpython epoll, or eventlet, or that the max limit is derived from a particular formula etc. All they care is how the bug manifests and what they should do prior to upgrade, if at all.)","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"b1522ae478029eb088e5a24bb3e9439f5081c041","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue where agent_down_time can be configured to a value so high "},{"line_number":5,"context_line":"    it can crash due to CPython epoll limitation. If the agent_down_time is "},{"line_number":6,"context_line":"    already configured larger than ((2 ** 32) / 2 - 1)/1000), after this "},{"line_number":7,"context_line":"    patch neutron server will fail to start with a error explaining the "},{"line_number":8,"context_line":"    agent_down_time is too large. For more information see bug: "},{"line_number":9,"context_line":"    https://bugs.launchpad.net/oslo.service/+bug/2028724"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"66b7fa3a_27591aee","line":6,"in_reply_to":"5a1dde5d_2a31040e","updated":"2023-07-27 03:03:50.000000000","message":"Done","commit_id":"d9dee3023e01fa8e7067a830489ee60cbcb29c31"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e99b4b09efc527726bf80b358e7cb80f38eae761","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `agent_down_time` is now limited to a maximum value of `2147483`"},{"line_number":5,"context_line":"    Neutron server will fail to start if the `agent_down_time` is configured higher than `2147483`"},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die when a"},{"line_number":7,"context_line":"    `agent_down_time` value that is too high is configured, which may affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"249f79be_c45f22eb","line":4,"updated":"2023-07-28 06:43:37.000000000","message":"missing fullstop","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e99b4b09efc527726bf80b358e7cb80f38eae761","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `agent_down_time` is now limited to a maximum value of `2147483`"},{"line_number":5,"context_line":"    Neutron server will fail to start if the `agent_down_time` is configured higher than `2147483`"},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die when a"},{"line_number":7,"context_line":"    `agent_down_time` value that is too high is configured, which may affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"92e8b26d_a8fe0604","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":24},"updated":"2023-07-28 06:43:37.000000000","message":"would be better to highlight config option as bold using double back quote.","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"515b4bf9624e92caa7911e84be704277ff9b678a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `agent_down_time` is now limited to a maximum value of `2147483`"},{"line_number":5,"context_line":"    Neutron server will fail to start if the `agent_down_time` is configured higher than `2147483`"},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die when a"},{"line_number":7,"context_line":"    `agent_down_time` value that is too high is configured, which may affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"03bf93b1_06235045","line":4,"in_reply_to":"249f79be_c45f22eb","updated":"2023-07-31 03:20:51.000000000","message":"Done","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"515b4bf9624e92caa7911e84be704277ff9b678a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `agent_down_time` is now limited to a maximum value of `2147483`"},{"line_number":5,"context_line":"    Neutron server will fail to start if the `agent_down_time` is configured higher than `2147483`"},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die when a"},{"line_number":7,"context_line":"    `agent_down_time` value that is too high is configured, which may affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2b6afd45_e9311fbf","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":24},"in_reply_to":"92e8b26d_a8fe0604","updated":"2023-07-31 03:20:51.000000000","message":"Done","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e99b4b09efc527726bf80b358e7cb80f38eae761","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `agent_down_time` is now limited to a maximum value of `2147483`"},{"line_number":5,"context_line":"    Neutron server will fail to start if the `agent_down_time` is configured higher than `2147483`"},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die when a"},{"line_number":7,"context_line":"    `agent_down_time` value that is too high is configured, which may affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"efd93d4c_6b283ac6","line":5,"updated":"2023-07-28 06:43:37.000000000","message":"fullstop","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"515b4bf9624e92caa7911e84be704277ff9b678a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `agent_down_time` is now limited to a maximum value of `2147483`"},{"line_number":5,"context_line":"    Neutron server will fail to start if the `agent_down_time` is configured higher than `2147483`"},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die when a"},{"line_number":7,"context_line":"    `agent_down_time` value that is too high is configured, which may affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"26d5dec0_0f3b6b52","line":5,"in_reply_to":"efd93d4c_6b283ac6","updated":"2023-07-31 03:20:51.000000000","message":"Done","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e99b4b09efc527726bf80b358e7cb80f38eae761","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The `agent_down_time` is now limited to a maximum value of `2147483`"},{"line_number":5,"context_line":"    Neutron server will fail to start if the `agent_down_time` is configured higher than `2147483`"},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die when a"},{"line_number":7,"context_line":"    `agent_down_time` value that is too high is configured, which may affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"051c6a38_8b2bdc7d","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":21},"updated":"2023-07-28 06:43:37.000000000","message":"can avoid repeating config name here again by modifying like:-\n    This limit has been implemented due to a bug scenario where neutron-server worker threads may die when a higher value is configured for it, which may also affect functionality of the service.","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"515b4bf9624e92caa7911e84be704277ff9b678a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The `agent_down_time` is now limited to a maximum value of `2147483`"},{"line_number":5,"context_line":"    Neutron server will fail to start if the `agent_down_time` is configured higher than `2147483`"},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die when a"},{"line_number":7,"context_line":"    `agent_down_time` value that is too high is configured, which may affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c8d152e4_38ff3e94","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":21},"in_reply_to":"051c6a38_8b2bdc7d","updated":"2023-07-31 03:20:51.000000000","message":"Done","commit_id":"6442b310676d89a1bba62c22766dd20666cbda3f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5f5702bba64e7408dbb7f8370a795925b22d0009","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``agent_down_time`` is now limited to a maximum value of `2147483`."},{"line_number":5,"context_line":"    Neutron server will fail to start if the ``agent_down_time`` is configured higher than `2147483`."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6d1667cf_f46b3e4d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2023-08-01 17:35:49.000000000","message":"s/fixes","commit_id":"db4c733dfc15ebde94f3960d4402c9c71612d8c3"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"dedfef2f4349bcf6dc7c9d2920ee6b9ee3b2b8f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``agent_down_time`` is now limited to a maximum value of `2147483`."},{"line_number":5,"context_line":"    Neutron server will fail to start if the ``agent_down_time`` is configured higher than `2147483`."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"829523b4_a5c6db96","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"0e9f400c_309f420e","updated":"2023-08-08 00:08:34.000000000","message":"Ah right, good point Brian. Done.","commit_id":"db4c733dfc15ebde94f3960d4402c9c71612d8c3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"077ec3de1f086bb9c92266bc697725e2a4c1a703","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``agent_down_time`` is now limited to a maximum value of `2147483`."},{"line_number":5,"context_line":"    Neutron server will fail to start if the ``agent_down_time`` is configured higher than `2147483`."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0e9f400c_309f420e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"613f815d_198d4563","updated":"2023-08-07 21:07:36.000000000","message":"Hi Lewis,\n\nI guess I was basing my comment on this line in the bug:\n\n\u003e This bug is applicable to all current versions of Neutron and can be reproduced on master devstack\n\nSo if someone had already configured this invalid it would be broken regardless if an upgrade was involved, i.e. they wouldn\u0027t be surprised by an upgrade it would just be failing in a different way - config versus code.","commit_id":"db4c733dfc15ebde94f3960d4402c9c71612d8c3"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"aedf815936c607d53b26cb47abea6cd57a5d9d79","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``agent_down_time`` is now limited to a maximum value of `2147483`."},{"line_number":5,"context_line":"    Neutron server will fail to start if the ``agent_down_time`` is configured higher than `2147483`."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"613f815d_198d4563","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"6d1667cf_f46b3e4d","updated":"2023-08-03 00:56:07.000000000","message":"Hi Brian, Thanks for the review. Upgrade was chosen because this is somewhat a change in behaviour that could affect a user when upgrading Neutron. I would like this release note to be read before the user upgrades. Please let me know if you would still like me to update this to `fixes`","commit_id":"db4c733dfc15ebde94f3960d4402c9c71612d8c3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5f5702bba64e7408dbb7f8370a795925b22d0009","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``agent_down_time`` is now limited to a maximum value of `2147483`."},{"line_number":5,"context_line":"    Neutron server will fail to start if the ``agent_down_time`` is configured higher than `2147483`."},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die"},{"line_number":7,"context_line":"    when a higher value is configured for it, which may also affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"10c65def_8bc940d1","line":5,"updated":"2023-08-01 17:35:49.000000000","message":"I would just combine these into one sentence:\n\n    The config option ``agent_down_time`` is now limited to a maximum value of\n    `2147483`, as neutron-server will fail to start if it is configured higher.","commit_id":"db4c733dfc15ebde94f3960d4402c9c71612d8c3"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"aedf815936c607d53b26cb47abea6cd57a5d9d79","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``agent_down_time`` is now limited to a maximum value of `2147483`."},{"line_number":5,"context_line":"    Neutron server will fail to start if the ``agent_down_time`` is configured higher than `2147483`."},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die"},{"line_number":7,"context_line":"    when a higher value is configured for it, which may also affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"8c0b7530_12cf470e","line":5,"in_reply_to":"10c65def_8bc940d1","updated":"2023-08-03 00:56:07.000000000","message":"Done","commit_id":"db4c733dfc15ebde94f3960d4402c9c71612d8c3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5f5702bba64e7408dbb7f8370a795925b22d0009","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The ``agent_down_time`` is now limited to a maximum value of `2147483`."},{"line_number":5,"context_line":"    Neutron server will fail to start if the ``agent_down_time`` is configured higher than `2147483`."},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die"},{"line_number":7,"context_line":"    when a higher value is configured for it, which may also affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c0760b2b_4d1b63b7","line":7,"updated":"2023-08-01 17:35:49.000000000","message":"This sentence is just re-describing the first, should replace with something like:\n\nSee `bug 2028724 \u003chttps://bugs.launchpad.net/neutron/+bug/2028724\u003e`_ for more information.\n\nI\u0027m also not sure why you\u0027re getting the \"No newline at end of right file.\" complaint below.","commit_id":"db4c733dfc15ebde94f3960d4402c9c71612d8c3"},{"author":{"_account_id":32114,"name":"Lewis Denny","email":"ldenny@redhat.com","username":"ldenny"},"change_message_id":"aedf815936c607d53b26cb47abea6cd57a5d9d79","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The ``agent_down_time`` is now limited to a maximum value of `2147483`."},{"line_number":5,"context_line":"    Neutron server will fail to start if the ``agent_down_time`` is configured higher than `2147483`."},{"line_number":6,"context_line":"    This limit has been implemented due to a bug scenario where neutron-server worker threads may die"},{"line_number":7,"context_line":"    when a higher value is configured for it, which may also affect functionality of the service."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"91a11f03_3d840086","line":7,"in_reply_to":"c0760b2b_4d1b63b7","updated":"2023-08-03 00:56:07.000000000","message":"Done","commit_id":"db4c733dfc15ebde94f3960d4402c9c71612d8c3"}]}