)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4352a59f4ea570b4a260889e0e7d25ef7e84679e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Terry Wilson \u003ctwilson@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-26 14:13:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add  note to avoid version checks in sanity checks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I71be7929a3ed9c0bcec350a35f054b8faddbeea7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"05d4f080_ffdf1832","line":7,"updated":"2023-10-09 22:00:08.000000000","message":"double space character, call the police!","commit_id":"0f6e24c4eef48fe5d9bf882d7c1597dda1c1ba82"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4352a59f4ea570b4a260889e0e7d25ef7e84679e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb1d7e0c_0c1594db","updated":"2023-10-09 22:00:08.000000000","message":"-1 to clarify the status of existing version checks, not for the double-space.","commit_id":"0f6e24c4eef48fe5d9bf882d7c1597dda1c1ba82"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e16b3fca5f28bf743355d42b63eac830fd1fc2b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04819d73_46720ba3","updated":"2023-07-26 14:23:55.000000000","message":"As in interesting historical note, here is the original commit message for adding sanity checks:\n```\ncommit ab4dc5261eea8662adabd0c326ab6297e6556b32\nAuthor: Terry Wilson \u003ctwilson@redhat.com\u003e\nDate:   Wed Apr 16 21:48:04 2014 -0400\n\n    Remove run-time version checking for openvswitch features\n    \n    The current method of checking openvswitch and kernel versions for\n    specific feature support is brittle, distro-specific and unsupportable.\n    \n    This patch removes the runtime version checks and implements a test\n    script which allows testing specific neutron features or can test\n    that all features required by a specific configuration are available.\n    \n    For example, to test VXLAN support in openvswitch, either:\n    \n      neutron-sanity-check --ovs_vxlan\n    \n    or pass in the deployed configuration files with AGENT/tunnel_types\n    containing \u0027vxlan\u0027, like:\n    \n      neutron-sanity-check --config-file /etc/neutron/plugins/ml2.conf.ini\n    \n    Deployment tools can then test that the required features exist without\n    relying on version numbers and without incurring a penalty every time\n    the agent is started.\n    \n    Implements: blueprint remove-openvswitch-version-check\n    DocImpact\n    Change-Id: I5e822d97b9bece9242ba5ac8901aa0ca4f090cfe\n```\nwhich makes the ensuing use of the system for checking version numbers especially amusing to its author. 😄","commit_id":"0f6e24c4eef48fe5d9bf882d7c1597dda1c1ba82"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cc3f5f25dba2b867c2702be04d4151ba7be5eae7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9b2f0416_76b2847c","updated":"2023-07-28 05:44:07.000000000","message":"ohkk i too recently added a warning for dnsmasq 2.86 in sanity check, the reasoning in the shared commit message makes sense but now i wonder how would have tested for the random segfault dnsmasq issue without a version check. For features and consistent issue not using version check would work though.","commit_id":"0f6e24c4eef48fe5d9bf882d7c1597dda1c1ba82"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"555f2af381900ad910b5b8fcdaa1496a230e6a43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d478c631_8b02dc9a","updated":"2023-07-26 18:02:20.000000000","message":"recheck timeout","commit_id":"0f6e24c4eef48fe5d9bf882d7c1597dda1c1ba82"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c96973a25652924ceb053b238f0233aaa7666f8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"439c8ada_2e3ba731","in_reply_to":"9b2f0416_76b2847c","updated":"2023-07-28 13:25:25.000000000","message":"Yeah, there may be things that are hard/impossible to test with sanity checks. But those things may also be hard to do in a cross-distro way with version numbers as well. I guess some things are just hard. 😄","commit_id":"0f6e24c4eef48fe5d9bf882d7c1597dda1c1ba82"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"4e1c6c36429a47d67024137f33f2a433e88f1a39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e6580ea4_1593a117","in_reply_to":"fb1d7e0c_0c1594db","updated":"2023-10-18 01:26:48.000000000","message":"The existing version checks should eventually be converted into better tests or removed, imho. But when that will happen, I have no idea. I just want to stop it continuing to get worse.","commit_id":"0f6e24c4eef48fe5d9bf882d7c1597dda1c1ba82"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"157e307fe66e4765e8c7f4262968d643181a3b69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"155072cb_224c6261","updated":"2023-10-19 04:58:42.000000000","message":"recheck neutron fullstack timeout","commit_id":"f18c5426b090c6bcc3f46f8969eaaa7acf956203"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0121ad859f638b62acac5603f549b0cb545ab47f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6d7e4f1c_b9f0080c","updated":"2023-10-19 14:38:47.000000000","message":"recheck neutron-fullstack-with-uwsgi","commit_id":"f18c5426b090c6bcc3f46f8969eaaa7acf956203"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59fde0f1c4b871086acef4d98a9d09d1ab5c287f","unresolved":true,"context_lines":[{"line_number":48,"context_line":"# may backport fixes/features to different versioned releases and they are"},{"line_number":49,"context_line":"# not a reliable way to test for features/bugs. Please write sanity checks that"},{"line_number":50,"context_line":"# actually test for the usage of the feature in combination with it actually"},{"line_number":51,"context_line":"# being configured to use on the running system (e.g. via a config option)."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"MINIMUM_DNSMASQ_VERSION \u003d \u00272.67\u0027"},{"line_number":54,"context_line":"DNSMASQ_VERSION_DHCP_RELEASE6 \u003d \u00272.76\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"e11c83b7_4cec1612","line":51,"updated":"2023-10-09 21:58:46.000000000","message":"It would make sense to then also explain why I - a coder that was about to add a version check - still see a long list of versions documented just below.\n\nMaybe the text should say \"PLEASE DON\u0027T ADD *NEW* VERSION CHECK TESTS.\" and explain that the existing ones are obsolete / to be re-written.","commit_id":"0f6e24c4eef48fe5d9bf882d7c1597dda1c1ba82"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"4e1c6c36429a47d67024137f33f2a433e88f1a39","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# may backport fixes/features to different versioned releases and they are"},{"line_number":49,"context_line":"# not a reliable way to test for features/bugs. Please write sanity checks that"},{"line_number":50,"context_line":"# actually test for the usage of the feature in combination with it actually"},{"line_number":51,"context_line":"# being configured to use on the running system (e.g. via a config option)."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"MINIMUM_DNSMASQ_VERSION \u003d \u00272.67\u0027"},{"line_number":54,"context_line":"DNSMASQ_VERSION_DHCP_RELEASE6 \u003d \u00272.76\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"f93981f1_b4d03d18","line":51,"in_reply_to":"e11c83b7_4cec1612","updated":"2023-10-18 01:26:48.000000000","message":"Done","commit_id":"0f6e24c4eef48fe5d9bf882d7c1597dda1c1ba82"}]}