)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9968ddf3969dc44d84d985d271a5d879897890bb","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     liushy \u003cliuxie_11@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-28 18:29:22 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent internal ip change for floatingip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Raise an error when deleting/changing the fixed IP"},{"line_number":10,"context_line":"which is linked to a FIP in ml2/plugin."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"f8413e81_f0888f28","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":19},"updated":"2023-08-24 16:22:37.000000000","message":"IP","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9968ddf3969dc44d84d985d271a5d879897890bb","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     liushy \u003cliuxie_11@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-28 18:29:22 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent internal ip change for floatingip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Raise an error when deleting/changing the fixed IP"},{"line_number":10,"context_line":"which is linked to a FIP in ml2/plugin."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"cfcf0b67_5f2ac98b","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":41},"updated":"2023-08-24 16:22:37.000000000","message":"floating IP","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"1b8efac772cfc59a9410784ebb6c0da630a40c4f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liushy \u003cliuxie_11@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-28 18:29:22 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent internal ip change for floatingip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Raise an error when deleting/changing the fixed IP"},{"line_number":10,"context_line":"which is linked to a FIP in ml2/plugin."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"39b04f58_57cb8342","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":41},"in_reply_to":"cfcf0b67_5f2ac98b","updated":"2023-08-25 03:21:25.000000000","message":"Done","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"1b8efac772cfc59a9410784ebb6c0da630a40c4f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liushy \u003cliuxie_11@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-28 18:29:22 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent internal ip change for floatingip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Raise an error when deleting/changing the fixed IP"},{"line_number":10,"context_line":"which is linked to a FIP in ml2/plugin."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"a49504b2_23030697","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":19},"in_reply_to":"f8413e81_f0888f28","updated":"2023-08-25 03:21:25.000000000","message":"Done","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9968ddf3969dc44d84d985d271a5d879897890bb","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Prevent internal ip change for floatingip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Raise an error when deleting/changing the fixed IP"},{"line_number":10,"context_line":"which is linked to a FIP in ml2/plugin."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1999209"},{"line_number":13,"context_line":"Change-Id: I83a5b6c30d54435426f75f4cd1f80bf41822eec5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"6027084d_14cb22d8","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":39},"updated":"2023-08-24 16:22:37.000000000","message":"to a floating IP.\n\nThe FIP belongs to the router extension, not the ML2 plugin.","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"1b8efac772cfc59a9410784ebb6c0da630a40c4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Prevent internal ip change for floatingip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Raise an error when deleting/changing the fixed IP"},{"line_number":10,"context_line":"which is linked to a FIP in ml2/plugin."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1999209"},{"line_number":13,"context_line":"Change-Id: I83a5b6c30d54435426f75f4cd1f80bf41822eec5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"45195d3b_6e207c4a","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":39},"in_reply_to":"6027084d_14cb22d8","updated":"2023-08-25 03:21:25.000000000","message":"Done","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"5ddb74903bd4e740af9e0ffab66657c5276ca16d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fcc557aa_d3922e68","updated":"2023-07-27 07:22:20.000000000","message":"recheck","commit_id":"865c33f581f08c1e41c787d88d1ebb989e88fcc4"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"2aa8fae9752af80c3e857655cb7531709086e9e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"037d002e_d61cfdf6","updated":"2023-07-28 03:20:38.000000000","message":"recheck","commit_id":"c29a1ba9b8580079c221cf38ef6ddab14acf0367"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9968ddf3969dc44d84d985d271a5d879897890bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c3597296_c69bbd6b","updated":"2023-08-24 16:22:37.000000000","message":"Some nits, code looks almost good.\n\nNOTE: you need a release note for this patch. That will change the API (we are now preventing an update operation), so please add a release note.\n\nNice patch, thanks!","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"bae1cc78c172d27526b6c31fc280e19aa97bcb05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a60f2cdd_17a8e769","updated":"2023-07-31 02:40:31.000000000","message":"recheck","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"41907b1466462dc282490a1052d16a07abfc5576","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d9c6aa4e_22de1b1e","updated":"2023-07-29 10:25:59.000000000","message":"recheck","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"9013ac9113576954b4d85a3f452c4f2dd5530af3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f23f926a_8183f064","updated":"2023-07-31 06:18:56.000000000","message":"recheck","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"}],"neutron/db/l3_db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9968ddf3969dc44d84d985d271a5d879897890bb","unresolved":true,"context_lines":[{"line_number":128,"context_line":"                                            trigger, payload\u003dNone):"},{"line_number":129,"context_line":"        l3plugin \u003d directory.get_plugin(plugin_constants.L3)"},{"line_number":130,"context_line":"        new_port \u003d payload.states[1]"},{"line_number":131,"context_line":"        if l3plugin and payload.metadata.get(\u0027fixed_ips_updated\u0027, False):"},{"line_number":132,"context_line":"            l3plugin.prevent_internal_ip_change_for_fip("},{"line_number":133,"context_line":"                payload.context, payload.resource_id,"},{"line_number":134,"context_line":"                new_port[\u0027fixed_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"c3a62db1_b6c61215","line":131,"range":{"start_line":131,"start_character":8,"end_line":131,"end_character":73},"updated":"2023-08-24 16:22:37.000000000","message":"You also need to check that payload.metadata is present:\n``\n    if (l3plugin and payload.metadata and \n        payload.metadata.get(\u0027fixed_ips_updated\u0027))\n``","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"1b8efac772cfc59a9410784ebb6c0da630a40c4f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                                            trigger, payload\u003dNone):"},{"line_number":129,"context_line":"        l3plugin \u003d directory.get_plugin(plugin_constants.L3)"},{"line_number":130,"context_line":"        new_port \u003d payload.states[1]"},{"line_number":131,"context_line":"        if l3plugin and payload.metadata.get(\u0027fixed_ips_updated\u0027, False):"},{"line_number":132,"context_line":"            l3plugin.prevent_internal_ip_change_for_fip("},{"line_number":133,"context_line":"                payload.context, payload.resource_id,"},{"line_number":134,"context_line":"                new_port[\u0027fixed_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5585fd8d_9d679c9c","line":131,"range":{"start_line":131,"start_character":8,"end_line":131,"end_character":73},"in_reply_to":"c3a62db1_b6c61215","updated":"2023-08-25 03:21:25.000000000","message":"Done","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9968ddf3969dc44d84d985d271a5d879897890bb","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"                return"},{"line_number":1752,"context_line":"        msg \u003d (_(\u0027Cannot update the fixed_ips of the port %s, because \u0027"},{"line_number":1753,"context_line":"                 \u0027its original fixed_ip has been associated to a \u0027"},{"line_number":1754,"context_line":"                 \u0027floating ip.\u0027) %"},{"line_number":1755,"context_line":"               port_id)"},{"line_number":1756,"context_line":"        raise n_exc.BadRequest(resource\u003d\u0027port\u0027, msg\u003dmsg)"},{"line_number":1757,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"2b290dfc_0a81258c","line":1754,"range":{"start_line":1754,"start_character":29,"end_line":1754,"end_character":30},"updated":"2023-08-24 16:22:37.000000000","message":"nit: please remove the period. It is duplicated in the CLI error:\n\nBadRequestException: 400: Client Error for url: http://192.168.10.100:9696/networking/v2.0/ports/b9a1a101-9db0-44a8-b09f-0af9d3092a09, Bad port request: Cannot update the fixed_ips of the port b9a1a101-9db0-44a8-b09f-0af9d3092a09, because its original fixed_ip has been associated to a floating ip..","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"1b8efac772cfc59a9410784ebb6c0da630a40c4f","unresolved":false,"context_lines":[{"line_number":1751,"context_line":"                return"},{"line_number":1752,"context_line":"        msg \u003d (_(\u0027Cannot update the fixed_ips of the port %s, because \u0027"},{"line_number":1753,"context_line":"                 \u0027its original fixed_ip has been associated to a \u0027"},{"line_number":1754,"context_line":"                 \u0027floating ip.\u0027) %"},{"line_number":1755,"context_line":"               port_id)"},{"line_number":1756,"context_line":"        raise n_exc.BadRequest(resource\u003d\u0027port\u0027, msg\u003dmsg)"},{"line_number":1757,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"e7aab063_61f23c51","line":1754,"range":{"start_line":1754,"start_character":29,"end_line":1754,"end_character":30},"in_reply_to":"2b290dfc_0a81258c","updated":"2023-08-25 03:21:25.000000000","message":"Done","commit_id":"94a73c9149d3d1a8c3066e9f6e5c154d83384e3f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2b01fb1284e82e5f5cf806e98baef16477d093a2","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        l3plugin \u003d directory.get_plugin(plugin_constants.L3)"},{"line_number":130,"context_line":"        new_port \u003d payload.states[1]"},{"line_number":131,"context_line":"        if (l3plugin and payload.metadata and"},{"line_number":132,"context_line":"                payload.metadata.get(\u0027fixed_ips_updated\u0027, False)):"},{"line_number":133,"context_line":"            l3plugin.prevent_internal_ip_change_for_fip("},{"line_number":134,"context_line":"                payload.context, payload.resource_id,"},{"line_number":135,"context_line":"                new_port[\u0027fixed_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"b4275d4d_933cc906","line":132,"range":{"start_line":132,"start_character":56,"end_line":132,"end_character":63},"updated":"2023-09-12 13:42:20.000000000","message":"nit: unnecessary","commit_id":"aad82233eb4fa7a6354f58cd9f8fda869f77db80"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3cd1d4cce1f951225c272e9195698ce0ce4087d","unresolved":true,"context_lines":[{"line_number":1752,"context_line":"                return"},{"line_number":1753,"context_line":"        msg \u003d (_(\u0027Cannot update the fixed_ips of the port %s, because \u0027"},{"line_number":1754,"context_line":"                 \u0027its original fixed_ip has been associated to a \u0027"},{"line_number":1755,"context_line":"                 \u0027floating ip\u0027) %"},{"line_number":1756,"context_line":"               port_id)"},{"line_number":1757,"context_line":"        raise n_exc.BadRequest(resource\u003d\u0027port\u0027, msg\u003dmsg)"},{"line_number":1758,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dc09845b_71711425","line":1755,"range":{"start_line":1755,"start_character":27,"end_line":1755,"end_character":29},"updated":"2023-09-12 15:56:52.000000000","message":"nit: s/IP","commit_id":"aad82233eb4fa7a6354f58cd9f8fda869f77db80"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3cd1d4cce1f951225c272e9195698ce0ce4087d","unresolved":true,"context_lines":[{"line_number":1754,"context_line":"                 \u0027its original fixed_ip has been associated to a \u0027"},{"line_number":1755,"context_line":"                 \u0027floating ip\u0027) %"},{"line_number":1756,"context_line":"               port_id)"},{"line_number":1757,"context_line":"        raise n_exc.BadRequest(resource\u003d\u0027port\u0027, msg\u003dmsg)"},{"line_number":1758,"context_line":""},{"line_number":1759,"context_line":"    def prevent_l3_port_deletion(self, context, port_id, port\u003dNone):"},{"line_number":1760,"context_line":"        \"\"\"Checks to make sure a port is allowed to be deleted."}],"source_content_type":"text/x-python","patch_set":12,"id":"d2c16346_c2eef91a","line":1757,"updated":"2023-09-12 15:56:52.000000000","message":"So is this a bad request failure or a conflict? I guess we raise a BadRequest if the port doesn\u0027t have a fixed ip so this is similar?","commit_id":"aad82233eb4fa7a6354f58cd9f8fda869f77db80"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2fbf98e08a01074d50c60ad7e67927067fb50325","unresolved":true,"context_lines":[{"line_number":1754,"context_line":"                 \u0027its original fixed_ip has been associated to a \u0027"},{"line_number":1755,"context_line":"                 \u0027floating ip\u0027) %"},{"line_number":1756,"context_line":"               port_id)"},{"line_number":1757,"context_line":"        raise n_exc.BadRequest(resource\u003d\u0027port\u0027, msg\u003dmsg)"},{"line_number":1758,"context_line":""},{"line_number":1759,"context_line":"    def prevent_l3_port_deletion(self, context, port_id, port\u003dNone):"},{"line_number":1760,"context_line":"        \"\"\"Checks to make sure a port is allowed to be deleted."}],"source_content_type":"text/x-python","patch_set":12,"id":"0a00cc6d_e5a22b09","line":1757,"in_reply_to":"d2c16346_c2eef91a","updated":"2023-09-13 11:42:23.000000000","message":"My understanding is the same","commit_id":"aad82233eb4fa7a6354f58cd9f8fda869f77db80"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"1b8efac772cfc59a9410784ebb6c0da630a40c4f","unresolved":false,"context_lines":[{"line_number":1856,"context_line":"        need_port_update_notify \u003d False"},{"line_number":1857,"context_line":"        bound_mech_contexts \u003d []"},{"line_number":1858,"context_line":"        original_port \u003d self.get_port(context, id)"},{"line_number":1859,"context_line":"        metadata \u003d {\u0027fixed_ips_updated\u0027: True"},{"line_number":1860,"context_line":"                    if \u0027fixed_ips\u0027 in attrs else False}"},{"line_number":1861,"context_line":"        registry.publish(resources.PORT, events.BEFORE_UPDATE, self,"},{"line_number":1862,"context_line":"                         payload\u003devents.DBEventPayload("}],"source_content_type":"text/x-python","patch_set":6,"id":"f88ccb74_d540ce64","line":1859,"in_reply_to":"3b98034c_87e630b5","updated":"2023-08-25 03:21:25.000000000","message":"Done","commit_id":"c29a1ba9b8580079c221cf38ef6ddab14acf0367"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"2aa8fae9752af80c3e857655cb7531709086e9e1","unresolved":true,"context_lines":[{"line_number":1856,"context_line":"        need_port_update_notify \u003d False"},{"line_number":1857,"context_line":"        bound_mech_contexts \u003d []"},{"line_number":1858,"context_line":"        original_port \u003d self.get_port(context, id)"},{"line_number":1859,"context_line":"        metadata \u003d {\u0027fixed_ips_updated\u0027: True"},{"line_number":1860,"context_line":"                    if \u0027fixed_ips\u0027 in attrs else False}"},{"line_number":1861,"context_line":"        registry.publish(resources.PORT, events.BEFORE_UPDATE, self,"},{"line_number":1862,"context_line":"                         payload\u003devents.DBEventPayload("}],"source_content_type":"text/x-python","patch_set":6,"id":"3b98034c_87e630b5","line":1859,"in_reply_to":"e0f7faa8_0cdf688d","updated":"2023-07-28 03:20:38.000000000","message":"\u003e pep8: R1719: The if expression can be replaced with \u0027test\u0027 (simplifiable-if-expression)\n\nPlease fix.","commit_id":"c29a1ba9b8580079c221cf38ef6ddab14acf0367"}]}