)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ce183514de150cbb0040305ecf7d4b45472277be","unresolved":true,"context_lines":[{"line_number":10,"context_line":"oslo_utils.versionutils to determine minimum version"},{"line_number":11,"context_line":"numbers, but there were two places that used the"},{"line_number":12,"context_line":"packaging.version class instead. Change to always"},{"line_number":13,"context_line":"use the same code throughout the tree."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Trivialfix"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dc432895_a59992ad","line":13,"updated":"2023-10-09 21:48:32.000000000","message":"I don\u0027t know the exact reason why versionutils is better, but assuming it is - should there be a pep8 enforcement check to make sure the tree doesn\u0027t diverge?","commit_id":"45ae80c64f80b33e1eac29eb61dddca3d9198616"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f58e8359b4ffcd585bcd9baad348101302c29c39","unresolved":true,"context_lines":[{"line_number":10,"context_line":"oslo_utils.versionutils to determine minimum version"},{"line_number":11,"context_line":"numbers, but there were two places that used the"},{"line_number":12,"context_line":"packaging.version class instead. Change to always"},{"line_number":13,"context_line":"use the same code throughout the tree."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Trivialfix"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"de0fb862_971ce619","line":13,"in_reply_to":"dc432895_a59992ad","updated":"2023-10-11 01:39:54.000000000","message":"I did this as a follow-on to a patch Lucas did where he was asking which is correct? The reason we should use oslo_utils is because we should prefer using that common one instead of rolling our own. I\u0027ll add an enforcement check and remove packaging from requirements.txt too.","commit_id":"45ae80c64f80b33e1eac29eb61dddca3d9198616"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3d836a336ed33a43348d262fc91e7cff3e765b9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"oslo_utils.versionutils to determine minimum version"},{"line_number":11,"context_line":"numbers, but there were two places that used the"},{"line_number":12,"context_line":"packaging.version class instead. Change to always"},{"line_number":13,"context_line":"use the same code throughout the tree."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Trivialfix"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"128852c0_06b5b9aa","line":13,"in_reply_to":"de0fb862_971ce619","updated":"2023-10-13 18:14:45.000000000","message":"Done","commit_id":"45ae80c64f80b33e1eac29eb61dddca3d9198616"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1af2054ca49549915188520c367d93ab9b95b352","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c07ce45c_cfd570ea","updated":"2023-08-17 20:36:14.000000000","message":"recheck neutron-tempest-plugin patch merged","commit_id":"45ae80c64f80b33e1eac29eb61dddca3d9198616"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"593e4d47075e490bc6615464197e6851fb4f1e26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7c2f548_aa76ec12","updated":"2023-08-22 19:09:18.000000000","message":"recheck rally job fixed","commit_id":"45ae80c64f80b33e1eac29eb61dddca3d9198616"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eedb809c2f6204e3c5311984ec50243b2eb5a738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad5cd425_fd28cc3c","updated":"2023-08-14 13:49:11.000000000","message":"recheck tempest timeouts","commit_id":"45ae80c64f80b33e1eac29eb61dddca3d9198616"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5fc1a041e1db723edb9de48313408841d5c104f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba2e9ff0_4e0f21b4","updated":"2023-08-18 15:01:49.000000000","message":"recheck unrelated failure","commit_id":"45ae80c64f80b33e1eac29eb61dddca3d9198616"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"556fb1cd276492744f034bc925ccdcfe3bb2276d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"55c61b9b_f077e751","updated":"2023-10-11 14:02:21.000000000","message":"recheck unrelated fullstack timeout","commit_id":"cd83758f9582beacb3d071ae94ae376ebe5616f2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c91b1b251856042e4be551b0cf0a9234abbe6e00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"033f95dd_03e2a45a","updated":"2023-10-13 21:56:39.000000000","message":"recheck unrelated fullstack timeout","commit_id":"171305f70629237190742628f82f34681df9cc5d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fd17187118946631ba88d42262117c54c7a3362d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9e10c16e_cddfe99c","updated":"2023-10-16 16:32:06.000000000","message":"recheck unrelated fullstack timeout","commit_id":"171305f70629237190742628f82f34681df9cc5d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4dfd5843147449afb21452db7117e09213315870","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6db60d4a_31f66d26","updated":"2023-10-21 17:40:58.000000000","message":"recheck unrelated failure","commit_id":"bd0fec95fae1f5a52e662fc0e09500ccd9be3caa"}],"neutron/cmd/runtime_checks.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"762805555bd5d0597b77d1cf1a4ab7b02caccf94","unresolved":true,"context_lines":[{"line_number":45,"context_line":"                                  return_stderr\u003dTrue)"},{"line_number":46,"context_line":"        # First line is the interesting one here from stderr"},{"line_number":47,"context_line":"        version_line \u003d res[1].split(\u0027\\n\u0027)[0]"},{"line_number":48,"context_line":"        # Version string is of form \u0027v2.0.19\u0027"},{"line_number":49,"context_line":"        keepalived_version \u003d versionutils.convert_version_to_tuple("},{"line_number":50,"context_line":"            version_line.split()[1].lstrip(\u0027v\u0027))"},{"line_number":51,"context_line":"        return keepalived_version"}],"source_content_type":"text/x-python","patch_set":3,"id":"123ad813_2aa579ab","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":45},"updated":"2023-10-12 20:33:22.000000000","message":"Are you saying that `version_line` could be a `\u0027v2.0.19\u0027`? If thats what you mean then how is the `split()[1]` not going to be out of range?\n```\n\u003e\u003e\u003e version_line\u003d\u0027v2.0.19\u0027\n\u003e\u003e\u003e version_line.split()\n[\u0027v2.0.19\u0027]\n\u003e\u003e\u003e version_line.split()[1]\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nIndexError: list index out of range\n```","commit_id":"cd83758f9582beacb3d071ae94ae376ebe5616f2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3d836a336ed33a43348d262fc91e7cff3e765b9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                                  return_stderr\u003dTrue)"},{"line_number":46,"context_line":"        # First line is the interesting one here from stderr"},{"line_number":47,"context_line":"        version_line \u003d res[1].split(\u0027\\n\u0027)[0]"},{"line_number":48,"context_line":"        # Version string is of form \u0027v2.0.19\u0027"},{"line_number":49,"context_line":"        keepalived_version \u003d versionutils.convert_version_to_tuple("},{"line_number":50,"context_line":"            version_line.split()[1].lstrip(\u0027v\u0027))"},{"line_number":51,"context_line":"        return keepalived_version"}],"source_content_type":"text/x-python","patch_set":3,"id":"2f021fc7_9bd18c15","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":45},"in_reply_to":"123ad813_2aa579ab","updated":"2023-10-13 18:14:45.000000000","message":"Should have changed to 0 when I updated, will fix.\n\n\u003e\u003e\u003e version_line.split()[0].lstrip(\u0027v\u0027)\n\u00272.0.19\u0027","commit_id":"cd83758f9582beacb3d071ae94ae376ebe5616f2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"35ea195e427092c70b4372ea897b3163965e5f05","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        version_line \u003d res[1].split(\u0027\\n\u0027)[0]"},{"line_number":48,"context_line":"        # Version string is of form \u0027v2.0.19\u0027, must remove \u0027v\u0027"},{"line_number":49,"context_line":"        keepalived_version \u003d versionutils.convert_version_to_tuple("},{"line_number":50,"context_line":"            version_line.split()[0].lstrip(\u0027v\u0027))"},{"line_number":51,"context_line":"        return keepalived_version"},{"line_number":52,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":53,"context_line":"        LOG.exception(\"Failed to get keepalived version\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"57528da6_b55c6d66","line":50,"updated":"2023-10-18 13:58:35.000000000","message":"this is breaking. why do you switch from [1] to [0]? The full string has the name of the daemon as the first item:\n\n```\n[vagrant@fedora38 ~]$ keepalived --version\nKeepalived v2.2.8 (04/04,2023), git commit v2.2.7-154-g292b299e+\n```","commit_id":"171305f70629237190742628f82f34681df9cc5d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"92f82745d5314133c6e78e2789c5bfaaeab8189b","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        version_line \u003d res[1].split(\u0027\\n\u0027)[0]"},{"line_number":48,"context_line":"        # Version string is of form \u0027v2.0.19\u0027, must remove \u0027v\u0027"},{"line_number":49,"context_line":"        keepalived_version \u003d versionutils.convert_version_to_tuple("},{"line_number":50,"context_line":"            version_line.split()[0].lstrip(\u0027v\u0027))"},{"line_number":51,"context_line":"        return keepalived_version"},{"line_number":52,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":53,"context_line":"        LOG.exception(\"Failed to get keepalived version\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f03c93d_42b1af55","line":50,"in_reply_to":"57528da6_b55c6d66","updated":"2023-10-18 14:14:14.000000000","message":"this also reveals no test coverage for this function. and it should probably be easy to cover it, just mock out execute().","commit_id":"171305f70629237190742628f82f34681df9cc5d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae17c450102fd57a6c532b8c6779bc9c03230eb3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        version_line \u003d res[1].split(\u0027\\n\u0027)[0]"},{"line_number":48,"context_line":"        # Version string is of form \u0027v2.0.19\u0027, must remove \u0027v\u0027"},{"line_number":49,"context_line":"        keepalived_version \u003d versionutils.convert_version_to_tuple("},{"line_number":50,"context_line":"            version_line.split()[0].lstrip(\u0027v\u0027))"},{"line_number":51,"context_line":"        return keepalived_version"},{"line_number":52,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":53,"context_line":"        LOG.exception(\"Failed to get keepalived version\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"daf3ec58_d4eb0c6a","line":50,"in_reply_to":"5f03c93d_42b1af55","updated":"2023-10-20 22:04:01.000000000","message":"Done","commit_id":"171305f70629237190742628f82f34681df9cc5d"}],"requirements.txt":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7b3bdc0d43d06baeb0c026c0ecfeef2a03c5406b","unresolved":true,"context_lines":[{"line_number":51,"context_line":"os-resource-classes\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":52,"context_line":"ovs\u003e\u003d2.10.0 # Apache-2.0"},{"line_number":53,"context_line":"ovsdbapp\u003e\u003d2.2.1 # Apache-2.0"},{"line_number":54,"context_line":"packaging\u003e\u003d20.4  # Apache-2.0"},{"line_number":55,"context_line":"psutil\u003e\u003d5.3.0 # BSD"},{"line_number":56,"context_line":"pyroute2\u003e\u003d0.7.3;sys_platform!\u003d\u0027win32\u0027 # Apache-2.0 (+ dual licensed GPL2)"},{"line_number":57,"context_line":"pyOpenSSL\u003e\u003d17.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":5,"id":"afcd3b4a_571bc35a","side":"PARENT","line":54,"updated":"2023-10-30 09:11:45.000000000","message":"+1 for not forgetting to remove it","commit_id":"3930b9f5c54971db3c7c30094baf6c128bc60043"}]}