)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"03cdd8fe1d27413d75f0cbaf153e9f679b3b79c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76f87da5_29e6ee72","updated":"2023-08-04 14:18:10.000000000","message":"Is there a bug filed for this?","commit_id":"e3b85f497ff0edcf154650b93a0e959010afb81f"},{"author":{"_account_id":32921,"name":"Reason li","email":"liyou01@inspur.com","username":"liyou01"},"change_message_id":"9b36f088ec8a2d82408bb8ce92665d87265236f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a04fbc9d_df737e3c","updated":"2023-08-04 06:06:42.000000000","message":"recheck","commit_id":"e3b85f497ff0edcf154650b93a0e959010afb81f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5edb5c733f6da14997335fc7a73f6ad5d54d7bfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d43923da_11b1ac0f","updated":"2023-08-10 09:27:59.000000000","message":"The unit test failures seems to be related, please check\n(https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e85/890476/4/check/openstack-tox-py310/e851ef1/testr_results.html )\n\nYou can execute them like tox -epy310 -- neutron.tests.unit.services.ovn_l3.test_plugin.TestOVNL3RouterPlugin","commit_id":"f97d5a6ae9b5776008d39b6d1f7bcb52582f930b"}],"neutron/db/extraroute_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"03cdd8fe1d27413d75f0cbaf153e9f679b3b79c6","unresolved":true,"context_lines":[{"line_number":116,"context_line":"                    subnet_ids.append(ip[\u0027subnet_id\u0027])"},{"line_number":117,"context_line":"                    ip_addresses.append(ip[\u0027ip_address\u0027])"},{"line_number":118,"context_line":"            for cidr in context.session.query(models_v2.Subnet.cidr).filter("},{"line_number":119,"context_line":"                    models_v2.Subnet.id.in_(subnet_ids)).all():"},{"line_number":120,"context_line":"                cidrs.append(cidr[0])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        for route in routes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b3f594ee_904d6164","line":119,"updated":"2023-08-04 14:18:10.000000000","message":"This doesn\u0027t look right either. Can you call self._core_plugin.get_subnets() with all the ids as a filter?\n\nfilters\u003d{\u0027id\u0027: list(subnet_ids)}","commit_id":"e3b85f497ff0edcf154650b93a0e959010afb81f"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"03cdd8fe1d27413d75f0cbaf153e9f679b3b79c6","unresolved":true,"context_lines":[{"line_number":1258,"context_line":"        ports \u003d ports or self._get_router_ports(context, router_id)"},{"line_number":1259,"context_line":"        for port in ports:"},{"line_number":1260,"context_line":"            for fixed_ip in port[\u0027fixed_ips\u0027]:"},{"line_number":1261,"context_line":"                subnet_ids.append(fixed_ip[\u0027subnet_id\u0027])"},{"line_number":1262,"context_line":"        for cidr in context.session.query(models_v2.Subnet.cidr).filter("},{"line_number":1263,"context_line":"                models_v2.Subnet.id.in_(subnet_ids)).all():"},{"line_number":1264,"context_line":"            networks.append(cidr[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7055ad4b_73e894d4","line":1261,"updated":"2023-08-04 14:18:10.000000000","message":"The original code filtered subnets by ip_version, but it looks like this is no longer the case. I think you could do that below in the query, or possibly by checking the version of the fixed_ip with something like this?\n\nnetaddr.IPAddress(fixed_ip[\u0027ip_address\u0027]).version \u003d\u003d const.IP_VERSION_4\n\nOr you can use a filter when looking up the subnets.","commit_id":"e3b85f497ff0edcf154650b93a0e959010afb81f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"03cdd8fe1d27413d75f0cbaf153e9f679b3b79c6","unresolved":true,"context_lines":[{"line_number":1260,"context_line":"            for fixed_ip in port[\u0027fixed_ips\u0027]:"},{"line_number":1261,"context_line":"                subnet_ids.append(fixed_ip[\u0027subnet_id\u0027])"},{"line_number":1262,"context_line":"        for cidr in context.session.query(models_v2.Subnet.cidr).filter("},{"line_number":1263,"context_line":"                models_v2.Subnet.id.in_(subnet_ids)).all():"},{"line_number":1264,"context_line":"            networks.append(cidr[0])"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"        return networks"}],"source_content_type":"text/x-python","patch_set":1,"id":"d915d27c_ffccf5e8","line":1263,"updated":"2023-08-04 14:18:10.000000000","message":"Actually, I don\u0027t think you can do this here as you are not in a DB read context session. That is why the original code was calling self._plugin.get_subnet() since it is.","commit_id":"e3b85f497ff0edcf154650b93a0e959010afb81f"}]}