)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3f3494c4392b9e97c0252463d0c3022ba74a3b29","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://github.com/ovn-org/ovn/commit/c5fd51bd154147a567097eaf61fbebc0b5b39e28"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Close-Bug: #2030520"},{"line_number":17,"context_line":"Change-Id: Iaa3ff8e97021e44f352e5a9a370714bf5f1d77b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"92340cdd_9d744aad","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":9},"updated":"2023-09-12 14:25:24.000000000","message":"s/Closes-bug (although the hyperlink still seems to work)","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"16c539af8081a8b4591235e740c79cb8b1a27901","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://github.com/ovn-org/ovn/commit/c5fd51bd154147a567097eaf61fbebc0b5b39e28"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Close-Bug: #2030520"},{"line_number":17,"context_line":"Change-Id: Iaa3ff8e97021e44f352e5a9a370714bf5f1d77b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3b2caa21_2f692436","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":9},"in_reply_to":"09c9fdef_83f006c8","updated":"2023-11-07 13:12:28.000000000","message":"Done","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9156891f6c4846a73e6430cfe9fd559c8c7adcd5","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://github.com/ovn-org/ovn/commit/c5fd51bd154147a567097eaf61fbebc0b5b39e28"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Close-Bug: #2030520"},{"line_number":17,"context_line":"Change-Id: Iaa3ff8e97021e44f352e5a9a370714bf5f1d77b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"09c9fdef_83f006c8","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":9},"in_reply_to":"92340cdd_9d744aad","updated":"2023-10-11 14:12:50.000000000","message":"If memory serves, the LP string matching is just for closes-bug, so it might miss an automated launchpad entry update without being fixed.","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d4d99d005c85a291928512bdcae89e93457ed5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"755f49b0_9b470c27","updated":"2023-08-07 16:00:39.000000000","message":"Mostly text nits.","commit_id":"de6dcc3fd1d0ecf6bd449ed51e15b58a73869121"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a243142ce3e82db94fb413dedff4dd29d91ad6cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2392009_ba03be35","updated":"2023-08-08 08:29:46.000000000","message":"recheck - nova related failure (rebuild instance)","commit_id":"de6dcc3fd1d0ecf6bd449ed51e15b58a73869121"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0492e93d265ad6019d19f43655054c264fa0c940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"02357944_60c3874c","updated":"2023-08-09 06:49:34.000000000","message":"recheck - unrelated ssh failure in ovs job","commit_id":"db1e1dfcd544be20264b29a24755c1804445a55d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"da3b87491b5625cfd749daacddbd03a3966caecb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5ee5e130_bf38a4fa","updated":"2023-08-24 21:00:07.000000000","message":"-1 more to suggest a release note should be added, but otherwise LGTM.","commit_id":"5cf09b86cc715e3bf192b61580378726ad7e713e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"00b460ccdce0840fa7538e2a44c89339458963c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ee7f31ab_6a4b1a27","updated":"2023-08-11 14:26:37.000000000","message":"Looks good, should we add a release note?","commit_id":"5cf09b86cc715e3bf192b61580378726ad7e713e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d4ee25782a1f3afa3c12afe61a9636528ddf7c6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"78def6ba_4ea6c76b","in_reply_to":"5ee5e130_bf38a4fa","updated":"2023-08-28 13:23:24.000000000","message":"Done","commit_id":"5cf09b86cc715e3bf192b61580378726ad7e713e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"da3b87491b5625cfd749daacddbd03a3966caecb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"736dd5f5_3726d928","in_reply_to":"ee7f31ab_6a4b1a27","updated":"2023-08-24 21:00:07.000000000","message":"+1 to adding one! It is the best way to inform folks of what has changed/evolved!","commit_id":"5cf09b86cc715e3bf192b61580378726ad7e713e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cfcb5b37acf07e070e8d792620fe43df47a40eaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6e94a69d_08fa1fe6","updated":"2023-09-04 13:56:47.000000000","message":"-W until we open C cycle and create 2023.2 stable branch","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f4a66c552a70e8874301005c8869fbe36203b3c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2c953a3b_97614283","updated":"2023-09-11 13:15:20.000000000","message":"Hold on, now I realize, you need to add an upgrade check to inform about the needed version. This feature is very new (v23.06.0) and not all deployments will have this OVN version.","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e6f09fe7579dc5f210e1682c993e297365396f5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dc34044e_67b157f8","updated":"2023-09-04 11:22:14.000000000","message":"I think this is good.\n\nHave not been fully succesful in attempt to verify on devstack, but comparing pcap\u0027s and output from edk2/ovmf indicate the DHCPv6 options are set correct, i.e this patch is good and something else is not quite working in my devstack config.\n\n```\n\u003e\u003eStart PXE over IPv6..\n  Station IP address is FC01:0:0:0:0:0:0:206\n  Server IP address is FC00:0:0:0:0:0:0:1\n  NBP filename is snponly.efi\n  NBP filesize is 0 Bytes\n  PXE-E53: No boot filename received.\n```\n\nBoot File URL 59 from pcap file:\n```\n0000   00 3b 00 1c 74 66 74 70 3a 2f 2f 5b 66 63 30 30   .;..tftp://[fc00\n0010   3a 3a 31 5d 2f 73 6e 70 6f 6e 6c 79 2e 65 66 69   ::1]/snponly.efi\n```","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9548b909868cc2903ee8ad2fe532fc75a20a09d8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"26f919cd_7f6667e7","in_reply_to":"25795304_07afe1da","updated":"2023-11-07 13:12:11.000000000","message":"I agree that relying on the version check isn\u0027t great but in this case I think it should be enough. It\u0027s just to display potential warning during upgrade. It will not disable anything really. And I was trying to wrote that warning message in the way that it should be clear what MAY be missing and what operator should check to make sure that all will work fine for them.","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"12ca0a07257420e4c4f8f3b71927f19c2dcf8dbd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ee0e6763_e89fd11d","in_reply_to":"2c953a3b_97614283","updated":"2023-09-25 09:03:32.000000000","message":"I\u0027m thinking about this upgrade check and TBH I\u0027m not sure what should I exactly check here. I can of course check ovn-nbctl --version but then what? Warn users about baremetal over IPv6? If they have already set \"disable_ovn_dhcp_for_baremetal_ports\" to True, this means they are using Neutron DHCP agent so they aren\u0027t at any risk after upgrade. If they have \"disable_ovn_dhcp_for_baremetal_ports\" set to False it means that either they already didn\u0027t use BM provisioning (False is default value for this config option) or they use it with IPv4 so far so they will also be not impacted at all.\n\nThis patch will not make it any worst for users IMO so I\u0027m not sure if there\u0027s any point to make upgrade check about it.","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"351a4ec3944c445afdf0630081ee7f9708e5d696","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"25795304_07afe1da","in_reply_to":"716042dc_5ee6b8bd","updated":"2023-10-30 21:44:32.000000000","message":"Version checks are in general a bad idea (due to potential backports). Is it possible to handle it with SB database check where we would confirm that DHCP_Options with the corresponding type/code is populated? AFAIU northd should populate the table on startup.","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9156891f6c4846a73e6430cfe9fd559c8c7adcd5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"716042dc_5ee6b8bd","in_reply_to":"810e015c_d84438dc","updated":"2023-10-11 14:12:50.000000000","message":"That seems quite reasonable to me because I expect some operators might try to upgrade and put it in place immediately where as some will just continue to use dnsmasq... especially should Ironic add HTTPBoot support this cycle.","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4a1c70b47c93562997e855fa1397be03e4a7e677","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"810e015c_d84438dc","in_reply_to":"ee0e6763_e89fd11d","updated":"2023-09-27 07:34:18.000000000","message":"As you said, that\u0027s exactly what I was expecting: a NB version check and a warning message in the case of not meeting the requirements for this feature. The upgrade checks are reading the configuration so you can also check if the \"disable_ovn_dhcp_for_baremetal_ports\" is disabled and the user is trying to use the internal DHCP server for baremetal.","commit_id":"6025b2c5da800e15d3bc4808740a04e866c74d0b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"60f987eb3144b9224014da3f201ca1e1d2962569","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"189c8b75_60ea4718","updated":"2023-11-27 19:14:49.000000000","message":"Really just typos","commit_id":"9888d3dc446774985ba962d6f3f4037d7bc00de0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e59ee297a608df716ada91eeb5efa056c095c65f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7db8b959_fea99240","updated":"2023-12-06 12:36:10.000000000","message":"Looks ok","commit_id":"034fcb0f6d9fa3851ce960fd130ea33dc78e2b06"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a420d5e0754fe57dbbff528b5a1407dccd981b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"91cff2f4_6c7a51b2","updated":"2023-12-06 12:42:02.000000000","message":"Wondering if it could be tested in some ironic jobs too just like ipv4 is being tested, may be @Harald already made progress since his last comment.","commit_id":"034fcb0f6d9fa3851ce960fd130ea33dc78e2b06"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d999c3de07dbb31b87ea88448a3666e8f64fe50d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"49d87f99_7fa9284d","updated":"2023-11-30 07:38:52.000000000","message":"recheck - unrelated designate integration issue","commit_id":"034fcb0f6d9fa3851ce960fd130ea33dc78e2b06"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37667b530126ec7557a97e3ddbdbabe8089c8c37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0b87306e_0a899465","updated":"2023-12-04 16:26:08.000000000","message":"recheck - unrelated ssh failure","commit_id":"034fcb0f6d9fa3851ce960fd130ea33dc78e2b06"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ab74994cb29c38ad10aa209225335beceb059587","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"20b318fb_95dc77d4","updated":"2023-12-11 23:15:10.000000000","message":"recheck unrelated failure","commit_id":"034fcb0f6d9fa3851ce960fd130ea33dc78e2b06"}],"neutron/cmd/upgrade_checks/checks.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"60f987eb3144b9224014da3f201ca1e1d2962569","unresolved":true,"context_lines":[{"line_number":609,"context_line":"        if cfg.CONF.ovn.disable_ovn_dhcp_for_baremetal_ports:"},{"line_number":610,"context_line":"            return upgradecheck.Result("},{"line_number":611,"context_line":"                upgradecheck.Code.SUCCESS,"},{"line_number":612,"context_line":"                _(\"Native OVN DHCP is disabed for baremetal pors.\"))"},{"line_number":613,"context_line":"        try:"},{"line_number":614,"context_line":"            ovn_client \u003d get_ovn_client()"},{"line_number":615,"context_line":"        except RuntimeError:"}],"source_content_type":"text/x-python","patch_set":9,"id":"f01c4689_eaf248a5","line":612,"range":{"start_line":612,"start_character":60,"end_line":612,"end_character":64},"updated":"2023-11-27 19:14:49.000000000","message":"s/ports","commit_id":"9888d3dc446774985ba962d6f3f4037d7bc00de0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8ef4c7de07bb0dbd4a524a6bc4adbcb2b0741b9f","unresolved":false,"context_lines":[{"line_number":609,"context_line":"        if cfg.CONF.ovn.disable_ovn_dhcp_for_baremetal_ports:"},{"line_number":610,"context_line":"            return upgradecheck.Result("},{"line_number":611,"context_line":"                upgradecheck.Code.SUCCESS,"},{"line_number":612,"context_line":"                _(\"Native OVN DHCP is disabed for baremetal pors.\"))"},{"line_number":613,"context_line":"        try:"},{"line_number":614,"context_line":"            ovn_client \u003d get_ovn_client()"},{"line_number":615,"context_line":"        except RuntimeError:"}],"source_content_type":"text/x-python","patch_set":9,"id":"e0bf5b3e_d468841d","line":612,"range":{"start_line":612,"start_character":60,"end_line":612,"end_character":64},"in_reply_to":"f01c4689_eaf248a5","updated":"2023-11-28 10:07:15.000000000","message":"Done","commit_id":"9888d3dc446774985ba962d6f3f4037d7bc00de0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"60f987eb3144b9224014da3f201ca1e1d2962569","unresolved":true,"context_lines":[{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            return upgradecheck.Result("},{"line_number":631,"context_line":"                upgradecheck.Code.WARNING,"},{"line_number":632,"context_line":"                _(\u0027Version of OVN do not support iPXE over IPv6 but \u0027"},{"line_number":633,"context_line":"                  \u0027``disable_ovn_dhcp_for_baremetal_ports`` is set to \u0027"},{"line_number":634,"context_line":"                  \u0027``False``. In case if provisioning of baremetal nodes \u0027"},{"line_number":635,"context_line":"                  \u0027is required, please make sure that either \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"018e846c_86c74337","line":632,"range":{"start_line":632,"start_character":34,"end_line":632,"end_character":36},"updated":"2023-11-27 19:14:49.000000000","message":"s/does","commit_id":"9888d3dc446774985ba962d6f3f4037d7bc00de0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8ef4c7de07bb0dbd4a524a6bc4adbcb2b0741b9f","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            return upgradecheck.Result("},{"line_number":631,"context_line":"                upgradecheck.Code.WARNING,"},{"line_number":632,"context_line":"                _(\u0027Version of OVN do not support iPXE over IPv6 but \u0027"},{"line_number":633,"context_line":"                  \u0027``disable_ovn_dhcp_for_baremetal_ports`` is set to \u0027"},{"line_number":634,"context_line":"                  \u0027``False``. In case if provisioning of baremetal nodes \u0027"},{"line_number":635,"context_line":"                  \u0027is required, please make sure that either \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"1c4ddfa6_dc323a48","line":632,"range":{"start_line":632,"start_character":34,"end_line":632,"end_character":36},"in_reply_to":"018e846c_86c74337","updated":"2023-11-28 10:07:15.000000000","message":"Done","commit_id":"9888d3dc446774985ba962d6f3f4037d7bc00de0"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a420d5e0754fe57dbbff528b5a1407dccd981b3a","unresolved":true,"context_lines":[{"line_number":602,"context_line":"        Support for the required DHCPv6 options was recently added in core"},{"line_number":603,"context_line":"        OVN with c5fd51bd154147a567097eaf61fbebc0b5b39e28 in OVN."},{"line_number":604,"context_line":"        This check function will raise warning if user is using older OVN"},{"line_number":605,"context_line":"        version, withouth this patch and will have"},{"line_number":606,"context_line":"        ``disable_ovn_dhcp_for_baremetal_ports`` option set to False."},{"line_number":607,"context_line":"        \"\"\""},{"line_number":608,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"4c5b46e5_8c8f22e6","line":605,"range":{"start_line":605,"start_character":17,"end_line":605,"end_character":25},"updated":"2023-12-06 12:42:02.000000000","message":"nit: without","commit_id":"034fcb0f6d9fa3851ce960fd130ea33dc78e2b06"}],"neutron/common/ovn/constants.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d4d99d005c85a291928512bdcae89e93457ed5f","unresolved":true,"context_lines":[{"line_number":201,"context_line":"    \u0027tag:ipxe,bootfile-name\u0027: \u0027bootfile_name\u0027,"},{"line_number":202,"context_line":"    \u0027tag:ipxe,59\u0027: \u0027bootfile_name\u0027,"},{"line_number":203,"context_line":"    \u0027tag:!ipxe,bootfile-name\u0027: \u0027bootfile_name_alt\u0027,"},{"line_number":204,"context_line":"    \u0027tag:!ipxe,59\u0027: \u0027bootfile_name_alt\u0027})"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# OVN string type DHCP options"}],"source_content_type":"text/x-python","patch_set":1,"id":"105bf0c7_1a5479a0","line":204,"updated":"2023-08-07 16:00:39.000000000","message":"So is this similar to IPv4? From https://github.com/ovn-org/ovn/commit/c5fd51bd154147a567097eaf61fbebc0b5b39e28#diff-96b62f5cce3c8f4dff290adb9a10998cf7952c3514998eb16b5cb2e77acd0e67R134\n\n/* Use unused 254 option for iPXE bootfile_name_alt userdata DHCP option.\n * This option code is replaced by 67 when sending the DHCP reply.\n */\n \n I just didn\u0027t see a similar comment in the code for IPv6.","commit_id":"de6dcc3fd1d0ecf6bd449ed51e15b58a73869121"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bef770989457be6791fee3a6cee0cf066cdcd288","unresolved":true,"context_lines":[{"line_number":201,"context_line":"    \u0027tag:ipxe,bootfile-name\u0027: \u0027bootfile_name\u0027,"},{"line_number":202,"context_line":"    \u0027tag:ipxe,59\u0027: \u0027bootfile_name\u0027,"},{"line_number":203,"context_line":"    \u0027tag:!ipxe,bootfile-name\u0027: \u0027bootfile_name_alt\u0027,"},{"line_number":204,"context_line":"    \u0027tag:!ipxe,59\u0027: \u0027bootfile_name_alt\u0027})"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# OVN string type DHCP options"}],"source_content_type":"text/x-python","patch_set":1,"id":"83393cbd_12bac684","line":204,"in_reply_to":"105bf0c7_1a5479a0","updated":"2023-08-08 10:07:41.000000000","message":"yes, there\u0027s no comment but that\u0027s what I understood reading that patch and code in https://github.com/ovn-org/ovn/blob/c5fd51bd154147a567097eaf61fbebc0b5b39e28/controller/pinctrl.c#L2561","commit_id":"de6dcc3fd1d0ecf6bd449ed51e15b58a73869121"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"00b460ccdce0840fa7538e2a44c89339458963c2","unresolved":true,"context_lines":[{"line_number":201,"context_line":"    \u0027tag:ipxe,bootfile-name\u0027: \u0027bootfile_name\u0027,"},{"line_number":202,"context_line":"    \u0027tag:ipxe,59\u0027: \u0027bootfile_name\u0027,"},{"line_number":203,"context_line":"    \u0027tag:!ipxe,bootfile-name\u0027: \u0027bootfile_name_alt\u0027,"},{"line_number":204,"context_line":"    \u0027tag:!ipxe,59\u0027: \u0027bootfile_name_alt\u0027})"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# OVN string type DHCP options"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd32daa9_4663b12c","line":204,"in_reply_to":"83393cbd_12bac684","updated":"2023-08-11 14:26:37.000000000","message":"Yes, that makes sense now, thanks.","commit_id":"de6dcc3fd1d0ecf6bd449ed51e15b58a73869121"}],"neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d4d99d005c85a291928512bdcae89e93457ed5f","unresolved":true,"context_lines":[{"line_number":207,"context_line":"                help\u003d_(\u0027Disable OVN\\\u0027s built-in DHCP for baremetal ports \u0027"},{"line_number":208,"context_line":"                       \u0027(VNIC type \"baremetal\"). This alllow operators to \u0027"},{"line_number":209,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":210,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer supports \u0027"},{"line_number":211,"context_line":"                       \u0027also baremetal provisioning over IPv6. If older OVN \u0027"},{"line_number":212,"context_line":"                       \u0027is used, for baremetal provisioning over IPv6 this \u0027"},{"line_number":213,"context_line":"                       \u0027option should be set to \"True\" and neutron-dhcp-agent \u0027"},{"line_number":214,"context_line":"                       \u0027should be used. Defaults to False.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb35fa0d_0fc49d2a","line":211,"range":{"start_line":210,"start_character":63,"end_line":211,"end_character":28},"updated":"2023-08-07 16:00:39.000000000","message":"s/also supports","commit_id":"de6dcc3fd1d0ecf6bd449ed51e15b58a73869121"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bef770989457be6791fee3a6cee0cf066cdcd288","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                help\u003d_(\u0027Disable OVN\\\u0027s built-in DHCP for baremetal ports \u0027"},{"line_number":208,"context_line":"                       \u0027(VNIC type \"baremetal\"). This alllow operators to \u0027"},{"line_number":209,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":210,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer supports \u0027"},{"line_number":211,"context_line":"                       \u0027also baremetal provisioning over IPv6. If older OVN \u0027"},{"line_number":212,"context_line":"                       \u0027is used, for baremetal provisioning over IPv6 this \u0027"},{"line_number":213,"context_line":"                       \u0027option should be set to \"True\" and neutron-dhcp-agent \u0027"},{"line_number":214,"context_line":"                       \u0027should be used. Defaults to False.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"065dfc67_0b8e1225","line":211,"range":{"start_line":210,"start_character":63,"end_line":211,"end_character":28},"in_reply_to":"fb35fa0d_0fc49d2a","updated":"2023-08-08 10:07:41.000000000","message":"Done","commit_id":"de6dcc3fd1d0ecf6bd449ed51e15b58a73869121"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d4d99d005c85a291928512bdcae89e93457ed5f","unresolved":true,"context_lines":[{"line_number":208,"context_line":"                       \u0027(VNIC type \"baremetal\"). This alllow operators to \u0027"},{"line_number":209,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":210,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer supports \u0027"},{"line_number":211,"context_line":"                       \u0027also baremetal provisioning over IPv6. If older OVN \u0027"},{"line_number":212,"context_line":"                       \u0027is used, for baremetal provisioning over IPv6 this \u0027"},{"line_number":213,"context_line":"                       \u0027option should be set to \"True\" and neutron-dhcp-agent \u0027"},{"line_number":214,"context_line":"                       \u0027should be used. Defaults to False.\u0027)),"},{"line_number":215,"context_line":"    cfg.BoolOpt(\u0027allow_stateless_action_supported\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"364198ec_e9ed1a54","line":212,"range":{"start_line":211,"start_character":63,"end_line":212,"end_character":46},"updated":"2023-08-07 16:00:39.000000000","message":"s/If an older OVN is used for baremetal","commit_id":"de6dcc3fd1d0ecf6bd449ed51e15b58a73869121"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bef770989457be6791fee3a6cee0cf066cdcd288","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                       \u0027(VNIC type \"baremetal\"). This alllow operators to \u0027"},{"line_number":209,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":210,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer supports \u0027"},{"line_number":211,"context_line":"                       \u0027also baremetal provisioning over IPv6. If older OVN \u0027"},{"line_number":212,"context_line":"                       \u0027is used, for baremetal provisioning over IPv6 this \u0027"},{"line_number":213,"context_line":"                       \u0027option should be set to \"True\" and neutron-dhcp-agent \u0027"},{"line_number":214,"context_line":"                       \u0027should be used. Defaults to False.\u0027)),"},{"line_number":215,"context_line":"    cfg.BoolOpt(\u0027allow_stateless_action_supported\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb4a7d0c_4d97b02a","line":212,"range":{"start_line":211,"start_character":63,"end_line":212,"end_character":46},"in_reply_to":"364198ec_e9ed1a54","updated":"2023-08-08 10:07:41.000000000","message":"Done","commit_id":"de6dcc3fd1d0ecf6bd449ed51e15b58a73869121"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"da3b87491b5625cfd749daacddbd03a3966caecb","unresolved":true,"context_lines":[{"line_number":208,"context_line":"                       \u0027(VNIC type \"baremetal\"). This alllow operators to \u0027"},{"line_number":209,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":210,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":211,"context_line":"                       \u0027baremetal provisioning over IPv6. If an older OVN \u0027"},{"line_number":212,"context_line":"                       \u0027is used for baremetal provisioning over IPv6 this \u0027"},{"line_number":213,"context_line":"                       \u0027option should be set to \"True\" and neutron-dhcp-agent \u0027"},{"line_number":214,"context_line":"                       \u0027should be used. Defaults to False.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f2a2f4d_2e0b620a","line":211,"updated":"2023-08-24 21:00:07.000000000","message":"So when we say provisioning, we should be explicit by what we mean. This is *only* PXE based provisioning. If Ironic were to add HTTP URL Booting (likely for next cycle), the OVN dhcp sever *and* neutron would likely need to receieve updates, otherwise the operator would be forced into using the neutron-dhcp-agent.\n\nDefinitely something to also explain in a release note.","commit_id":"5cf09b86cc715e3bf192b61580378726ad7e713e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d4ee25782a1f3afa3c12afe61a9636528ddf7c6d","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                       \u0027(VNIC type \"baremetal\"). This alllow operators to \u0027"},{"line_number":209,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":210,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":211,"context_line":"                       \u0027baremetal provisioning over IPv6. If an older OVN \u0027"},{"line_number":212,"context_line":"                       \u0027is used for baremetal provisioning over IPv6 this \u0027"},{"line_number":213,"context_line":"                       \u0027option should be set to \"True\" and neutron-dhcp-agent \u0027"},{"line_number":214,"context_line":"                       \u0027should be used. Defaults to False.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3d949d4_f7548f86","line":211,"in_reply_to":"7f2a2f4d_2e0b620a","updated":"2023-08-28 13:23:24.000000000","message":"Done","commit_id":"5cf09b86cc715e3bf192b61580378726ad7e713e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1d89afece5d04be8e7483ee20d933166970afd05","unresolved":true,"context_lines":[{"line_number":205,"context_line":"    cfg.BoolOpt(\u0027disable_ovn_dhcp_for_baremetal_ports\u0027,"},{"line_number":206,"context_line":"                default\u003dFalse,"},{"line_number":207,"context_line":"                help\u003d_(\u0027Disable OVN\\\u0027s built-in DHCP for baremetal ports \u0027"},{"line_number":208,"context_line":"                       \u0027(VNIC type \"baremetal\"). This alllow operators to \u0027"},{"line_number":209,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":210,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":211,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5b4aad01_24340db6","line":208,"range":{"start_line":208,"start_character":54,"end_line":208,"end_character":60},"updated":"2023-10-30 21:34:59.000000000","message":"(no action required) (allllllllow)","commit_id":"181a3a588d84f3f24a7b63155fba9a5f63bd6062"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9548b909868cc2903ee8ad2fe532fc75a20a09d8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    cfg.BoolOpt(\u0027disable_ovn_dhcp_for_baremetal_ports\u0027,"},{"line_number":206,"context_line":"                default\u003dFalse,"},{"line_number":207,"context_line":"                help\u003d_(\u0027Disable OVN\\\u0027s built-in DHCP for baremetal ports \u0027"},{"line_number":208,"context_line":"                       \u0027(VNIC type \"baremetal\"). This alllow operators to \u0027"},{"line_number":209,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":210,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":211,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"56326965_b8d37f97","line":208,"range":{"start_line":208,"start_character":54,"end_line":208,"end_character":60},"in_reply_to":"5b4aad01_24340db6","updated":"2023-11-07 13:12:11.000000000","message":"Done","commit_id":"181a3a588d84f3f24a7b63155fba9a5f63bd6062"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1d89afece5d04be8e7483ee20d933166970afd05","unresolved":true,"context_lines":[{"line_number":210,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":211,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"},{"line_number":212,"context_line":"                       \u0027If an older OVN is used for baremetal provisioning \u0027"},{"line_number":213,"context_line":"                       \u0027over IPv6 this option should be set to \"True\" and \u0027"},{"line_number":214,"context_line":"                       \u0027neutron-dhcp-agent should be used. Defaults to \u0027"},{"line_number":215,"context_line":"                       \u0027False.\u0027)),"},{"line_number":216,"context_line":"    cfg.BoolOpt(\u0027allow_stateless_action_supported\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f236fcb2_c700fb3c","line":213,"range":{"start_line":213,"start_character":63,"end_line":213,"end_character":64},"updated":"2023-10-30 21:34:59.000000000","message":"Here you use double-quotes, but later, with `False`, you don\u0027t.","commit_id":"181a3a588d84f3f24a7b63155fba9a5f63bd6062"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9548b909868cc2903ee8ad2fe532fc75a20a09d8","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":211,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"},{"line_number":212,"context_line":"                       \u0027If an older OVN is used for baremetal provisioning \u0027"},{"line_number":213,"context_line":"                       \u0027over IPv6 this option should be set to \"True\" and \u0027"},{"line_number":214,"context_line":"                       \u0027neutron-dhcp-agent should be used. Defaults to \u0027"},{"line_number":215,"context_line":"                       \u0027False.\u0027)),"},{"line_number":216,"context_line":"    cfg.BoolOpt(\u0027allow_stateless_action_supported\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3de4dddb_a320c37a","line":213,"range":{"start_line":213,"start_character":63,"end_line":213,"end_character":64},"in_reply_to":"f236fcb2_c700fb3c","updated":"2023-11-07 13:12:11.000000000","message":"Done","commit_id":"181a3a588d84f3f24a7b63155fba9a5f63bd6062"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1d89afece5d04be8e7483ee20d933166970afd05","unresolved":true,"context_lines":[{"line_number":211,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"},{"line_number":212,"context_line":"                       \u0027If an older OVN is used for baremetal provisioning \u0027"},{"line_number":213,"context_line":"                       \u0027over IPv6 this option should be set to \"True\" and \u0027"},{"line_number":214,"context_line":"                       \u0027neutron-dhcp-agent should be used. Defaults to \u0027"},{"line_number":215,"context_line":"                       \u0027False.\u0027)),"},{"line_number":216,"context_line":"    cfg.BoolOpt(\u0027allow_stateless_action_supported\u0027,"},{"line_number":217,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3eaf8ec2_d3e9ae0f","line":214,"range":{"start_line":214,"start_character":43,"end_line":214,"end_character":57},"updated":"2023-10-30 21:34:59.000000000","message":"(no action required) maybe: \"should be used instead\".","commit_id":"181a3a588d84f3f24a7b63155fba9a5f63bd6062"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9548b909868cc2903ee8ad2fe532fc75a20a09d8","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"},{"line_number":212,"context_line":"                       \u0027If an older OVN is used for baremetal provisioning \u0027"},{"line_number":213,"context_line":"                       \u0027over IPv6 this option should be set to \"True\" and \u0027"},{"line_number":214,"context_line":"                       \u0027neutron-dhcp-agent should be used. Defaults to \u0027"},{"line_number":215,"context_line":"                       \u0027False.\u0027)),"},{"line_number":216,"context_line":"    cfg.BoolOpt(\u0027allow_stateless_action_supported\u0027,"},{"line_number":217,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"860d1f33_500683a3","line":214,"range":{"start_line":214,"start_character":43,"end_line":214,"end_character":57},"in_reply_to":"3eaf8ec2_d3e9ae0f","updated":"2023-11-07 13:12:11.000000000","message":"Done","commit_id":"181a3a588d84f3f24a7b63155fba9a5f63bd6062"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c232a8f870208f98c38e8a10d0269bcd6b1cf9df","unresolved":true,"context_lines":[{"line_number":207,"context_line":"    cfg.BoolOpt(\u0027disable_ovn_dhcp_for_baremetal_ports\u0027,"},{"line_number":208,"context_line":"                default\u003dFalse,"},{"line_number":209,"context_line":"                help\u003d_(\u0027Disable OVN\\\u0027s built-in DHCP for baremetal ports \u0027"},{"line_number":210,"context_line":"                       \u0027(VNIC type \"baremetal\"). This allow operators to \u0027"},{"line_number":211,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":212,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":213,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7c638f2c_7fd2e870","line":210,"range":{"start_line":210,"start_character":54,"end_line":210,"end_character":59},"updated":"2023-12-11 14:52:47.000000000","message":"\"allows\" sorry for not spotting it before","commit_id":"302533739371602ae17d34d922e028435549eee1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"60f987eb3144b9224014da3f201ca1e1d2962569","unresolved":true,"context_lines":[{"line_number":207,"context_line":"    cfg.BoolOpt(\u0027disable_ovn_dhcp_for_baremetal_ports\u0027,"},{"line_number":208,"context_line":"                default\u003dFalse,"},{"line_number":209,"context_line":"                help\u003d_(\u0027Disable OVN\\\u0027s built-in DHCP for baremetal ports \u0027"},{"line_number":210,"context_line":"                       \u0027(VNIC type \"baremetal\"). This allow operators to \u0027"},{"line_number":211,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":212,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":213,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ccadab3_a67dc85c","line":210,"range":{"start_line":210,"start_character":54,"end_line":210,"end_character":59},"updated":"2023-11-27 19:14:49.000000000","message":"s/allows","commit_id":"9888d3dc446774985ba962d6f3f4037d7bc00de0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8ef4c7de07bb0dbd4a524a6bc4adbcb2b0741b9f","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    cfg.BoolOpt(\u0027disable_ovn_dhcp_for_baremetal_ports\u0027,"},{"line_number":208,"context_line":"                default\u003dFalse,"},{"line_number":209,"context_line":"                help\u003d_(\u0027Disable OVN\\\u0027s built-in DHCP for baremetal ports \u0027"},{"line_number":210,"context_line":"                       \u0027(VNIC type \"baremetal\"). This allow operators to \u0027"},{"line_number":211,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":212,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":213,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"a61e588c_26029cca","line":210,"range":{"start_line":210,"start_character":54,"end_line":210,"end_character":59},"in_reply_to":"9ccadab3_a67dc85c","updated":"2023-11-28 10:07:15.000000000","message":"Done","commit_id":"9888d3dc446774985ba962d6f3f4037d7bc00de0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"60f987eb3144b9224014da3f201ca1e1d2962569","unresolved":true,"context_lines":[{"line_number":211,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":212,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":213,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"},{"line_number":214,"context_line":"                       \u0027If an older OVN is used for baremetal provisioning \u0027"},{"line_number":215,"context_line":"                       \u0027over IPv6 this option should be set to \"True\" and \u0027"},{"line_number":216,"context_line":"                       \u0027neutron-dhcp-agent should be used instead. \u0027"},{"line_number":217,"context_line":"                       \u0027Defaults to \"False\".\u0027)),"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ca3a6b2_b47a9aac","line":214,"range":{"start_line":214,"start_character":36,"end_line":214,"end_character":39},"updated":"2023-11-27 19:14:49.000000000","message":"nit: version of OVN","commit_id":"9888d3dc446774985ba962d6f3f4037d7bc00de0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8ef4c7de07bb0dbd4a524a6bc4adbcb2b0741b9f","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                       \u0027plug their own DHCP server of choice for PXE booting \u0027"},{"line_number":212,"context_line":"                       \u0027baremetal nodes. OVN 23.06.0 and newer also supports \u0027"},{"line_number":213,"context_line":"                       \u0027baremetal ``PXE`` based provisioning over IPv6. \u0027"},{"line_number":214,"context_line":"                       \u0027If an older OVN is used for baremetal provisioning \u0027"},{"line_number":215,"context_line":"                       \u0027over IPv6 this option should be set to \"True\" and \u0027"},{"line_number":216,"context_line":"                       \u0027neutron-dhcp-agent should be used instead. \u0027"},{"line_number":217,"context_line":"                       \u0027Defaults to \"False\".\u0027)),"}],"source_content_type":"text/x-python","patch_set":9,"id":"c148c204_5f637858","line":214,"range":{"start_line":214,"start_character":36,"end_line":214,"end_character":39},"in_reply_to":"7ca3a6b2_b47a9aac","updated":"2023-11-28 10:07:15.000000000","message":"Done","commit_id":"9888d3dc446774985ba962d6f3f4037d7bc00de0"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c232a8f870208f98c38e8a10d0269bcd6b1cf9df","unresolved":true,"context_lines":[{"line_number":315,"context_line":"        return self._is_mcast_flood_broken"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    # TODO(slaweq): Remove this method when min supported OVN version will be"},{"line_number":318,"context_line":"    # \u003e\u003d v23.06.0 which is the one which have support for IPv6 iPXE booting"},{"line_number":319,"context_line":"    # added:"},{"line_number":320,"context_line":"    # https://github.com/ovn-org/ovn/commit/c5fd51bd154147a567097eaf61fbebc0b5b39e28"},{"line_number":321,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":7,"id":"e537f90a_cce2da59","line":318,"range":{"start_line":318,"start_character":41,"end_line":318,"end_character":45},"updated":"2023-12-11 14:52:47.000000000","message":"has","commit_id":"302533739371602ae17d34d922e028435549eee1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4e4ab483aaa1f461c56399ac23a23aefa7021dc0","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    def is_ipxe_over_ipv6_supported(self):"},{"line_number":323,"context_line":"        if self._is_ipxe_over_ipv6_supported is None:"},{"line_number":324,"context_line":"            schema_version \u003d self._nb_idl.get_schema_version()"},{"line_number":325,"context_line":"            self._is_ipxe_over_ipv6_supported \u003d ("},{"line_number":326,"context_line":"                versionutils.convert_version_to_tuple(schema_version) \u003e\u003d"},{"line_number":327,"context_line":"                (7, 0, 4))"},{"line_number":328,"context_line":"        return self._is_ipxe_over_ipv6_supported"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _get_port_options(self, port):"}],"source_content_type":"text/x-python","patch_set":13,"id":"c0094c18_7c277509","line":327,"range":{"start_line":325,"start_character":12,"end_line":327,"end_character":26},"updated":"2023-12-11 12:12:00.000000000","message":"I think Terry is against this feature check and I\u0027m with him. This feature can be backported in other private D/S releases and supported regardless of this version check.\n\nBut unless we have an API method, provided by OVN, to check the feature support, that should be the only way.","commit_id":"034fcb0f6d9fa3851ce960fd130ea33dc78e2b06"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c232a8f870208f98c38e8a10d0269bcd6b1cf9df","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    def is_ipxe_over_ipv6_supported(self):"},{"line_number":323,"context_line":"        if self._is_ipxe_over_ipv6_supported is None:"},{"line_number":324,"context_line":"            schema_version \u003d self._nb_idl.get_schema_version()"},{"line_number":325,"context_line":"            self._is_ipxe_over_ipv6_supported \u003d ("},{"line_number":326,"context_line":"                versionutils.convert_version_to_tuple(schema_version) \u003e\u003d"},{"line_number":327,"context_line":"                (7, 0, 4))"},{"line_number":328,"context_line":"        return self._is_ipxe_over_ipv6_supported"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _get_port_options(self, port):"}],"source_content_type":"text/x-python","patch_set":13,"id":"d0a28ae4_2018c2ee","line":327,"range":{"start_line":325,"start_character":12,"end_line":327,"end_character":26},"in_reply_to":"bb7bdb88_c1562a2f","updated":"2023-12-11 14:52:47.000000000","message":"there is no \"feature check\" feature in core ovn, and I advocated for one to ovn team. that said, it doesn\u0027t seem like a critical thing for them to work on, so unless we spend our cycles, it\u0027s probably not going to happen.","commit_id":"034fcb0f6d9fa3851ce960fd130ea33dc78e2b06"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0835c67a23ac658d14e1bdedb7cdd728507974cb","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    def is_ipxe_over_ipv6_supported(self):"},{"line_number":323,"context_line":"        if self._is_ipxe_over_ipv6_supported is None:"},{"line_number":324,"context_line":"            schema_version \u003d self._nb_idl.get_schema_version()"},{"line_number":325,"context_line":"            self._is_ipxe_over_ipv6_supported \u003d ("},{"line_number":326,"context_line":"                versionutils.convert_version_to_tuple(schema_version) \u003e\u003d"},{"line_number":327,"context_line":"                (7, 0, 4))"},{"line_number":328,"context_line":"        return self._is_ipxe_over_ipv6_supported"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _get_port_options(self, port):"}],"source_content_type":"text/x-python","patch_set":13,"id":"bb7bdb88_c1562a2f","line":327,"range":{"start_line":325,"start_character":12,"end_line":327,"end_character":26},"in_reply_to":"c0094c18_7c277509","updated":"2023-12-11 13:24:57.000000000","message":"Belive me, I was looking for other possibility to check it but I didn\u0027t found any. But as this is used only in the upgrade check and may display warning message, it shouldn\u0027t be a big deal really 😊","commit_id":"034fcb0f6d9fa3851ce960fd130ea33dc78e2b06"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee322d6fc7bf5b97203d5d96120202e9d5a81edc","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    def is_ipxe_over_ipv6_supported(self):"},{"line_number":323,"context_line":"        if self._is_ipxe_over_ipv6_supported is None:"},{"line_number":324,"context_line":"            schema_version \u003d self._nb_idl.get_schema_version()"},{"line_number":325,"context_line":"            self._is_ipxe_over_ipv6_supported \u003d ("},{"line_number":326,"context_line":"                versionutils.convert_version_to_tuple(schema_version) \u003e\u003d"},{"line_number":327,"context_line":"                (7, 0, 4))"},{"line_number":328,"context_line":"        return self._is_ipxe_over_ipv6_supported"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _get_port_options(self, port):"}],"source_content_type":"text/x-python","patch_set":13,"id":"60d53818_194de6e2","line":327,"range":{"start_line":325,"start_character":12,"end_line":327,"end_character":26},"in_reply_to":"d0a28ae4_2018c2ee","updated":"2023-12-13 12:19:53.000000000","message":"Yeah, I think I was not clear enough in my comment. I know you Ihar and Terry were trying to propose this kind of \"feature check\" for OVN. That will help us in future Neutron patches to avoid the DB version check.","commit_id":"034fcb0f6d9fa3851ce960fd130ea33dc78e2b06"}]}