)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"359d17463a9a48506fbab9c17d836005aa22c31b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c87be803_ebfe4384","updated":"2023-08-11 21:19:44.000000000","message":"I submitted an alternative to this at https://review.opendev.org/c/openstack/neutron/+/891236 since I found a few other cases where the code did not catch non-existent entries on delete exceptions.","commit_id":"bde6f77f2fb9f8c457d688014f9b8feeb04b8e51"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"42bbd02513d070b293c4a7c5e85d1f3d465676b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"502c4685_a9fc1609","in_reply_to":"c87be803_ebfe4384","updated":"2023-08-11 22:32:15.000000000","message":"Sorry for the delayed reply on this. Your change looks like the better option so I\u0027ll abandon this one. Thanks for your help with this!","commit_id":"bde6f77f2fb9f8c457d688014f9b8feeb04b8e51"}],"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59cf4fda09754caad180771b4a4c6d1eb4e5c763","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                                      priority\u003dint(str(rule_pr)))"},{"line_number":223,"context_line":"            except pyroute2_exc.NetlinkError:"},{"line_number":224,"context_line":"                LOG.warning(\u0027Floating IP %s did not appear to have \u0027"},{"line_number":225,"context_line":"                            \u0027an ip rule configured:\u0027, floating_ip)"},{"line_number":226,"context_line":"            self.fip_ns.deallocate_rule_priority(floating_ip)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            LOG.error(\u0027Floating IP %s not stored in this agent. Because of \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"542554e5_04647a36","line":225,"updated":"2023-08-08 21:33:44.000000000","message":"I have two thoughts on this:\n\n1) change to \u0027pass\u0027 or LOG.debug, since there\u0027s really nothing for the admin to do\n\n2) Fix this in the neutron/privileged/agent/linux/ip_lib.py code, for example, make it somewhat similar to the add_ip_rule code right above it:\n\n    except netlink_exceptions.NetlinkError as e:\n        if e.code \u003d\u003d errno.ENOENT:\n            return\n        raise\n\nI\u0027m assuming that\u0027s the correct errno in this case.\n\nAnd is this related to your other change? If so should it have been called in the first place? Just something to think about since no other callers catch exceptions.","commit_id":"abff16f7e3ccc7e6086b395af6ff8351d317b2c0"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"42bbd02513d070b293c4a7c5e85d1f3d465676b6","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                                      priority\u003dint(str(rule_pr)))"},{"line_number":223,"context_line":"            except pyroute2_exc.NetlinkError:"},{"line_number":224,"context_line":"                LOG.warning(\u0027Floating IP %s did not appear to have \u0027"},{"line_number":225,"context_line":"                            \u0027an ip rule configured:\u0027, floating_ip)"},{"line_number":226,"context_line":"            self.fip_ns.deallocate_rule_priority(floating_ip)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            LOG.error(\u0027Floating IP %s not stored in this agent. Because of \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"866f379f_4352bc1c","line":225,"in_reply_to":"1acb12d6_ba9b098a","updated":"2023-08-11 22:32:15.000000000","message":"I\u0027m not sure about a missing add elsewhere as I\u0027ve struggled to pin down exactly what circumstances this issue occurs under. However in my opinion, I think that as the ip rules are outside of Neutron, it shouldn\u0027t completely error in cases where those external resources (ip rules) are changed.\n\nAlso, I believe we were seeing this error long before the other patch was created. Therefore, I don\u0027t think this is an issue that was a result of that previous change, even if that change didn\u0027t fully address the problem.","commit_id":"abff16f7e3ccc7e6086b395af6ff8351d317b2c0"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"79d85d88fb3ee99910d1ea50b9a3c62e11982d10","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                                      priority\u003dint(str(rule_pr)))"},{"line_number":223,"context_line":"            except pyroute2_exc.NetlinkError:"},{"line_number":224,"context_line":"                LOG.warning(\u0027Floating IP %s did not appear to have \u0027"},{"line_number":225,"context_line":"                            \u0027an ip rule configured:\u0027, floating_ip)"},{"line_number":226,"context_line":"            self.fip_ns.deallocate_rule_priority(floating_ip)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            LOG.error(\u0027Floating IP %s not stored in this agent. Because of \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeef4cd_2cb8a6aa","line":225,"in_reply_to":"542554e5_04647a36","updated":"2023-08-09 13:11:01.000000000","message":"1) This makes sense. I\u0027ve updated the patch to use debug instead.\n\n2) My worry was that errno.ENOENT also applies if the network namespace doesn\u0027t exist and so if any other callers rely on this in cases where the netns has been deleted, no longer returning that exception could have weird side effects. However, if you think this makes more sense then I can update the patch to drop all the changes to dvr_local_router.py and just update ip_lib.py instead.\n\n3) Assuming you\u0027re referring to 887036, I think this bug could be remnants of the issue that patch addressed. We may need to reassociate all the FIPs for this to stop happening however, given this is a very small patch, it still seems worthwhile.","commit_id":"abff16f7e3ccc7e6086b395af6ff8351d317b2c0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1dbf67ccca2d2ce02a18ec52c8f6186c9541ec74","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                                      priority\u003dint(str(rule_pr)))"},{"line_number":223,"context_line":"            except pyroute2_exc.NetlinkError:"},{"line_number":224,"context_line":"                LOG.warning(\u0027Floating IP %s did not appear to have \u0027"},{"line_number":225,"context_line":"                            \u0027an ip rule configured:\u0027, floating_ip)"},{"line_number":226,"context_line":"            self.fip_ns.deallocate_rule_priority(floating_ip)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            LOG.error(\u0027Floating IP %s not stored in this agent. Because of \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1acb12d6_ba9b098a","line":225,"in_reply_to":"dfeef4cd_2cb8a6aa","updated":"2023-08-09 17:55:40.000000000","message":"I think a missing namespace would throw an OSError from looking at delete_ip_rule() in the privileged code, which raises a sub-class of RuntimeError. I guess you would have to test putting the code there helps, just not sure it should live here.\n\nAnd regarding the other change, if it\u0027s triggering this my worry is there is a missing add somewhere.","commit_id":"abff16f7e3ccc7e6086b395af6ff8351d317b2c0"}]}