)]}'
{"neutron/agent/ovn/metadata/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5be5f3d2474725f16ac0605897f8f5bf6f405912","unresolved":true,"context_lines":[{"line_number":430,"context_line":"    def _vif_ports(self, ports):"},{"line_number":431,"context_line":"        return (p for p in ports if p.type in OVN_VIF_PORT_TYPES)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def teardown_namespace(self, net_name):"},{"line_number":434,"context_line":"        \"\"\"Unprovision this datapath to stop serving metadata."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        This function will shutdown metadata proxy if it\u0027s running and delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"fcfe1aac_12fe35fb","line":433,"range":{"start_line":433,"start_character":17,"end_line":433,"end_character":26},"updated":"2023-08-11 20:28:50.000000000","message":"There are so many things in this class that use datapath I would just leave this alone","commit_id":"5ed1970bc432b6fbd76c71c9b7bc4e1e42147d7d"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"d1dddc72f37f100dbca6c774b68c7be12b6e2843","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    def _vif_ports(self, ports):"},{"line_number":431,"context_line":"        return (p for p in ports if p.type in OVN_VIF_PORT_TYPES)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def teardown_namespace(self, net_name):"},{"line_number":434,"context_line":"        \"\"\"Unprovision this datapath to stop serving metadata."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        This function will shutdown metadata proxy if it\u0027s running and delete"}],"source_content_type":"text/x-python","patch_set":1,"id":"8624ea85_3005140c","line":433,"range":{"start_line":433,"start_character":17,"end_line":433,"end_character":26},"in_reply_to":"fcfe1aac_12fe35fb","updated":"2023-08-15 19:01:04.000000000","message":"After we change from using datapath id to neutron network id, the naming got little confusing. Maybe it would be better to just revist renaming in a separate patch.","commit_id":"5ed1970bc432b6fbd76c71c9b7bc4e1e42147d7d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"08aaf23ae43b6f26b1ce33055ee9bcfe82c9e336","unresolved":true,"context_lines":[{"line_number":394,"context_line":"            ns.decode(\u0027utf-8\u0027) if isinstance(ns, bytes) else ns"},{"line_number":395,"context_line":"            for ns in ip_lib.list_network_namespaces())"},{"line_number":396,"context_line":"        net_datapaths \u003d self.get_networks_datapaths()"},{"line_number":397,"context_line":"        metadata_namespaces_names \u003d ["},{"line_number":398,"context_line":"            self._add_ovn_prefix("},{"line_number":399,"context_line":"                ovn_utils.get_network_name_from_datapath(datapath))"},{"line_number":400,"context_line":"            for datapath in net_datapaths"}],"source_content_type":"text/x-python","patch_set":2,"id":"09b19686_0cca6a5f","line":397,"range":{"start_line":397,"start_character":8,"end_line":397,"end_character":33},"updated":"2023-08-15 19:56:50.000000000","message":"nit: metadata_namespace_names","commit_id":"ad1dd72927f346206022fb183882538518d19c94"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"d043d5a8ec9c60959d4e9bc30c0aaae249d222b7","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            ns.decode(\u0027utf-8\u0027) if isinstance(ns, bytes) else ns"},{"line_number":395,"context_line":"            for ns in ip_lib.list_network_namespaces())"},{"line_number":396,"context_line":"        net_datapaths \u003d self.get_networks_datapaths()"},{"line_number":397,"context_line":"        metadata_namespaces_names \u003d ["},{"line_number":398,"context_line":"            self._add_ovn_prefix("},{"line_number":399,"context_line":"                ovn_utils.get_network_name_from_datapath(datapath))"},{"line_number":400,"context_line":"            for datapath in net_datapaths"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6d611e_68891362","line":397,"range":{"start_line":397,"start_character":8,"end_line":397,"end_character":33},"in_reply_to":"09b19686_0cca6a5f","updated":"2023-08-17 15:17:13.000000000","message":"Done","commit_id":"ad1dd72927f346206022fb183882538518d19c94"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"08aaf23ae43b6f26b1ce33055ee9bcfe82c9e336","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        net_datapaths \u003d self.get_networks_datapaths()"},{"line_number":397,"context_line":"        metadata_namespaces_names \u003d ["},{"line_number":398,"context_line":"            self._add_ovn_prefix("},{"line_number":399,"context_line":"                ovn_utils.get_network_name_from_datapath(datapath))"},{"line_number":400,"context_line":"            for datapath in net_datapaths"},{"line_number":401,"context_line":"        ]"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c48b1ce6_75f6a304","line":399,"updated":"2023-08-15 19:56:50.000000000","message":"This seems to be the only change required to fix this, I don\u0027t think any of the rest is necessary, right? If so I would just leave it all alone.","commit_id":"ad1dd72927f346206022fb183882538518d19c94"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"d043d5a8ec9c60959d4e9bc30c0aaae249d222b7","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        net_datapaths \u003d self.get_networks_datapaths()"},{"line_number":397,"context_line":"        metadata_namespaces_names \u003d ["},{"line_number":398,"context_line":"            self._add_ovn_prefix("},{"line_number":399,"context_line":"                ovn_utils.get_network_name_from_datapath(datapath))"},{"line_number":400,"context_line":"            for datapath in net_datapaths"},{"line_number":401,"context_line":"        ]"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e11cc9fc_eee32d90","line":399,"in_reply_to":"4094f317_e9f2d250","updated":"2023-08-17 15:17:13.000000000","message":"Done","commit_id":"ad1dd72927f346206022fb183882538518d19c94"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"046c4b461848a378211c79586f8db086892d5923","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        net_datapaths \u003d self.get_networks_datapaths()"},{"line_number":397,"context_line":"        metadata_namespaces_names \u003d ["},{"line_number":398,"context_line":"            self._add_ovn_prefix("},{"line_number":399,"context_line":"                ovn_utils.get_network_name_from_datapath(datapath))"},{"line_number":400,"context_line":"            for datapath in net_datapaths"},{"line_number":401,"context_line":"        ]"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4094f317_e9f2d250","line":399,"in_reply_to":"c48b1ce6_75f6a304","updated":"2023-08-16 12:16:21.000000000","message":"Correct, this is the minimum to fix the issue. Rest was just little clean up","commit_id":"ad1dd72927f346206022fb183882538518d19c94"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"08aaf23ae43b6f26b1ce33055ee9bcfe82c9e336","unresolved":true,"context_lines":[{"line_number":406,"context_line":"            if (namespace.startswith(NS_PREFIX) and"},{"line_number":407,"context_line":"                namespace not in metadata_namespaces_names):"},{"line_number":408,"context_line":"                self.teardown_datapath("},{"line_number":409,"context_line":"                    self._get_id_from_ovn_namespace(namespace))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # resync all network namespaces based on the associated datapaths,"},{"line_number":412,"context_line":"        # even those that are already running. This is to make sure"}],"source_content_type":"text/x-python","patch_set":2,"id":"6f47151f_8b728580","line":409,"updated":"2023-08-15 19:56:50.000000000","message":"This is pretty much doing what the original code did, just without list comprehension. Can you just change the two necessary variables/calls (metadata_namespace_names/self._get_id_from_ovn_namespace()) ?","commit_id":"ad1dd72927f346206022fb183882538518d19c94"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"40c774cc16f66258fddcb16477902bb58e6952a3","unresolved":true,"context_lines":[{"line_number":406,"context_line":"            if (namespace.startswith(NS_PREFIX) and"},{"line_number":407,"context_line":"                namespace not in metadata_namespaces_names):"},{"line_number":408,"context_line":"                self.teardown_datapath("},{"line_number":409,"context_line":"                    self._get_id_from_ovn_namespace(namespace))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # resync all network namespaces based on the associated datapaths,"},{"line_number":412,"context_line":"        # even those that are already running. This is to make sure"}],"source_content_type":"text/x-python","patch_set":2,"id":"efc710ee_3a337cb2","line":409,"in_reply_to":"6f47151f_8b728580","updated":"2023-08-16 12:20:42.000000000","message":"Correct, I found it uneccesary to have two for loops where one for loop can accomplish the same thing. IMO I think its ok to have small clean ups like this. But I can put it back to original form if it goes against some guidelines. Thank you","commit_id":"ad1dd72927f346206022fb183882538518d19c94"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"d043d5a8ec9c60959d4e9bc30c0aaae249d222b7","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            if (namespace.startswith(NS_PREFIX) and"},{"line_number":407,"context_line":"                namespace not in metadata_namespaces_names):"},{"line_number":408,"context_line":"                self.teardown_datapath("},{"line_number":409,"context_line":"                    self._get_id_from_ovn_namespace(namespace))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # resync all network namespaces based on the associated datapaths,"},{"line_number":412,"context_line":"        # even those that are already running. This is to make sure"}],"source_content_type":"text/x-python","patch_set":2,"id":"0886ac41_e5e61053","line":409,"in_reply_to":"7691fd18_c8a15840","updated":"2023-08-17 15:17:13.000000000","message":"thanks for the feedback guys. I\u0027ll revert the name changes and just keep the actual fix.","commit_id":"ad1dd72927f346206022fb183882538518d19c94"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"60227ce746d1a204a5fa744536ec23fd4c6e87b2","unresolved":true,"context_lines":[{"line_number":406,"context_line":"            if (namespace.startswith(NS_PREFIX) and"},{"line_number":407,"context_line":"                namespace not in metadata_namespaces_names):"},{"line_number":408,"context_line":"                self.teardown_datapath("},{"line_number":409,"context_line":"                    self._get_id_from_ovn_namespace(namespace))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # resync all network namespaces based on the associated datapaths,"},{"line_number":412,"context_line":"        # even those that are already running. This is to make sure"}],"source_content_type":"text/x-python","patch_set":2,"id":"7691fd18_c8a15840","line":409,"in_reply_to":"b461c95a_5d4b9c50","updated":"2023-08-17 12:22:23.000000000","message":"I agree with Brian here, for backports it\u0027s always best to keep it as simple as possible. Nothing wrong in splitting this part into another patch just cleaning things up","commit_id":"ad1dd72927f346206022fb183882538518d19c94"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7a303ddc1467fdb1dc16d5f2b1f9633ae09b3168","unresolved":true,"context_lines":[{"line_number":406,"context_line":"            if (namespace.startswith(NS_PREFIX) and"},{"line_number":407,"context_line":"                namespace not in metadata_namespaces_names):"},{"line_number":408,"context_line":"                self.teardown_datapath("},{"line_number":409,"context_line":"                    self._get_id_from_ovn_namespace(namespace))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # resync all network namespaces based on the associated datapaths,"},{"line_number":412,"context_line":"        # even those that are already running. This is to make sure"}],"source_content_type":"text/x-python","patch_set":2,"id":"b461c95a_5d4b9c50","line":409,"in_reply_to":"efc710ee_3a337cb2","updated":"2023-08-16 19:41:17.000000000","message":"I would make the change as small as possible and do the clean-ups in a follow in since this will most likely be backported.","commit_id":"ad1dd72927f346206022fb183882538518d19c94"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"abbe348db4df78425700aa8bf1ad3e4849544ce2","unresolved":true,"context_lines":[{"line_number":397,"context_line":"        net_datapaths \u003d self.get_networks_datapaths()"},{"line_number":398,"context_line":"        metadata_namespaces \u003d ["},{"line_number":399,"context_line":"            self._get_namespace_name("},{"line_number":400,"context_line":"                ovn_utils.get_network_name_from_datapath(datapath))"},{"line_number":401,"context_line":"            for datapath in net_datapaths"},{"line_number":402,"context_line":"        ]"},{"line_number":403,"context_line":"        unused_namespaces \u003d [ns for ns in system_namespaces if"}],"source_content_type":"text/x-python","patch_set":4,"id":"5029deef_ddc906e6","line":400,"updated":"2023-08-17 20:53:37.000000000","message":"Ok, thanks for the smaller change.\n\nBut I think the other reason this was never caught was the unit test needs to change slightly as well - it was using the same value for the datapath uuid as it was for the network uuid, which from the description should be different. In the setUp() method in test_agent.py we should make them distinct by using a real uuid for the datapath. I mention this since the unit test should have failed otherwise.","commit_id":"8177004401d88b1d8e198e2e474187ec54e64d50"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"850f196032dcae2359e12958c7284e90971027ec","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        net_datapaths \u003d self.get_networks_datapaths()"},{"line_number":398,"context_line":"        metadata_namespaces \u003d ["},{"line_number":399,"context_line":"            self._get_namespace_name("},{"line_number":400,"context_line":"                ovn_utils.get_network_name_from_datapath(datapath))"},{"line_number":401,"context_line":"            for datapath in net_datapaths"},{"line_number":402,"context_line":"        ]"},{"line_number":403,"context_line":"        unused_namespaces \u003d [ns for ns in system_namespaces if"}],"source_content_type":"text/x-python","patch_set":4,"id":"fb06b701_40ae5f0d","line":400,"in_reply_to":"5029deef_ddc906e6","updated":"2023-08-24 19:19:42.000000000","message":"Done","commit_id":"8177004401d88b1d8e198e2e474187ec54e64d50"}]}