)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6ca90805ec79fb952f4089bca6b17680d9b7d427","unresolved":true,"context_lines":[{"line_number":11,"context_line":"entries, and most of the callers were not catching it either,"},{"line_number":12,"context_line":"which could lead to random failures."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Add code in the IP route, rule and bridge dfb code to catch"},{"line_number":15,"context_line":"these errors and not raise on them, other exceptions will"},{"line_number":16,"context_line":"still be raised."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f5059256_9c187762","line":14,"range":{"start_line":14,"start_character":42,"end_line":14,"end_character":45},"updated":"2023-08-13 18:40:09.000000000","message":"should be fdb, guess i can fix since noone is probably voting on this today","commit_id":"a23dbf304ebad580e282152f3f9d42ab2ab8550b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"412ac7aa87c47302176d7ccb03461af7c2703293","unresolved":false,"context_lines":[{"line_number":11,"context_line":"entries, and most of the callers were not catching it either,"},{"line_number":12,"context_line":"which could lead to random failures."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Add code in the IP route, rule and bridge dfb code to catch"},{"line_number":15,"context_line":"these errors and not raise on them, other exceptions will"},{"line_number":16,"context_line":"still be raised."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"101fcec9_bc982657","line":14,"range":{"start_line":14,"start_character":42,"end_line":14,"end_character":45},"in_reply_to":"f5059256_9c187762","updated":"2023-08-13 23:04:17.000000000","message":"Done","commit_id":"a23dbf304ebad580e282152f3f9d42ab2ab8550b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b5922f589b6d5478b79379847214a23153fa1e27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ad34115_bf12ed37","updated":"2023-08-13 16:31:55.000000000","message":"recheck rally command not found","commit_id":"a23dbf304ebad580e282152f3f9d42ab2ab8550b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9e37f36325c148134dbc1c14b1a3976b490e7039","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"50e53abc_d3c56251","updated":"2023-08-16 13:08:14.000000000","message":"Please don\u0027t re-check the tempest timeouts until https://bugs.launchpad.net/neutron/+bug/2031526 is fixed","commit_id":"2e86418a534acfb25d8a342f47219b4899ac348a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7ef5809365bcd6e79672a268cad644700b09277a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7ddb0038_03308e79","updated":"2023-08-13 21:24:08.000000000","message":"Seems the job timeouts are happening for all the neutron changes, so not specific to this change.","commit_id":"2e86418a534acfb25d8a342f47219b4899ac348a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c08278fc862a47913e650aea7c43fe3465863b99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d7989774_f3fd48d4","updated":"2023-08-16 14:58:35.000000000","message":"We should also have functional tests testing the new exception catches, at least for ip-route, ip-rule and bridge fdb commands.","commit_id":"2e86418a534acfb25d8a342f47219b4899ac348a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"90448f7f909637b2b8f8e2c38b5e4cb1f4c5c158","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c2312d5_577c8445","updated":"2023-08-14 13:48:15.000000000","message":"recheck tempest timeouts","commit_id":"2e86418a534acfb25d8a342f47219b4899ac348a"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"104bdd329dc2019305d4999536977a187f1408ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"75ba8695_7a7b8846","updated":"2023-08-15 10:43:22.000000000","message":"recheck tempest timeouts","commit_id":"2e86418a534acfb25d8a342f47219b4899ac348a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"5b5ac86c00a77afff69d8af95b35c0c124476a79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e897174b_abe29904","updated":"2023-11-15 12:23:29.000000000","message":"recheck refresh results","commit_id":"16875b5f92731a9cf2d7e819d406bfcc442339f3"}],"neutron/privileged/agent/linux/ip_lib.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"20329d76de656053113108d78dda420d3421a286","unresolved":true,"context_lines":[{"line_number":828,"context_line":"            ip.route(\u0027del\u0027, **kwargs)"},{"line_number":829,"context_line":"    except netlink_exceptions.NetlinkError as e:"},{"line_number":830,"context_line":"        # trying to delete a non-existent entry shouldn\u0027t raise an error"},{"line_number":831,"context_line":"        if e.code \u003d\u003d errno.ESRCH:"},{"line_number":832,"context_line":"            return"},{"line_number":833,"context_line":"        raise"},{"line_number":834,"context_line":"    except OSError as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"2ada2145_5e5d775a","line":831,"updated":"2023-10-09 21:46:49.000000000","message":"which line is supposed to trigger ESRCH? Just line 827?\n\nif so, should you not also handle ENOENT from line 828?","commit_id":"16875b5f92731a9cf2d7e819d406bfcc442339f3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"15c5434adee65c4b01558c47378b772386eda12b","unresolved":true,"context_lines":[{"line_number":828,"context_line":"            ip.route(\u0027del\u0027, **kwargs)"},{"line_number":829,"context_line":"    except netlink_exceptions.NetlinkError as e:"},{"line_number":830,"context_line":"        # trying to delete a non-existent entry shouldn\u0027t raise an error"},{"line_number":831,"context_line":"        if e.code \u003d\u003d errno.ESRCH:"},{"line_number":832,"context_line":"            return"},{"line_number":833,"context_line":"        raise"},{"line_number":834,"context_line":"    except OSError as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"cc9b2521_e762255b","line":831,"in_reply_to":"2ada2145_5e5d775a","updated":"2023-10-11 01:12:57.000000000","message":"So if I\u0027m remembering from PS4 correctly, the functional test failed because I had the wrong errno here, but I pushed a new patch before the results got logged. And when I looked at the pyroute2 sources shows ESRCH as the error it will generate.\n\nndb/objects/__init__.py\n    errno.ESRCH: None,  # routes\n\nI can switch it back and see what happens, but running by hand in python:\n\nwith pyroute2.NetNS(\u0027foo\u0027, flags\u003d0) as ip:\n    link_id \u003d ip.link_lookup(ifname\u003d\u0027lo\u0027)\n    dev \u003d link_id[0]\n    ip.route(\"delete\", oif\u003ddev, dst\u003d\u00279.9.9.9\u0027, family\u003dsocket.AF_INET)\n\npyroute2.netlink.exceptions.NetlinkError: (3, \u0027No such process\u0027)","commit_id":"16875b5f92731a9cf2d7e819d406bfcc442339f3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5a9b6e2c678cac17063e5f4b625b51fca8887a0b","unresolved":false,"context_lines":[{"line_number":828,"context_line":"            ip.route(\u0027del\u0027, **kwargs)"},{"line_number":829,"context_line":"    except netlink_exceptions.NetlinkError as e:"},{"line_number":830,"context_line":"        # trying to delete a non-existent entry shouldn\u0027t raise an error"},{"line_number":831,"context_line":"        if e.code \u003d\u003d errno.ESRCH:"},{"line_number":832,"context_line":"            return"},{"line_number":833,"context_line":"        raise"},{"line_number":834,"context_line":"    except OSError as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"a7cf69b6_1ffc04d2","line":831,"in_reply_to":"72bc22bb_552b2d81","updated":"2023-10-18 19:47:30.000000000","message":"Ack","commit_id":"16875b5f92731a9cf2d7e819d406bfcc442339f3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79070ef6790d346c586256a134f52b7b2a628ef7","unresolved":true,"context_lines":[{"line_number":828,"context_line":"            ip.route(\u0027del\u0027, **kwargs)"},{"line_number":829,"context_line":"    except netlink_exceptions.NetlinkError as e:"},{"line_number":830,"context_line":"        # trying to delete a non-existent entry shouldn\u0027t raise an error"},{"line_number":831,"context_line":"        if e.code \u003d\u003d errno.ESRCH:"},{"line_number":832,"context_line":"            return"},{"line_number":833,"context_line":"        raise"},{"line_number":834,"context_line":"    except OSError as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"72bc22bb_552b2d81","line":831,"in_reply_to":"cc9b2521_e762255b","updated":"2023-10-17 13:44:00.000000000","message":"+1, this is the correct error number for routes.","commit_id":"16875b5f92731a9cf2d7e819d406bfcc442339f3"}],"neutron/tests/unit/privileged/agent/linux/test_ip_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d913e4ae8243ef852d5e111adc0619f8a512e801","unresolved":true,"context_lines":[{"line_number":166,"context_line":"            try:"},{"line_number":167,"context_line":"                priv_lib._run_iproute_neigh("},{"line_number":168,"context_line":"                    \"test_cmd\", \"eth0\", None, test_param\u003d\"test_value\")"},{"line_number":169,"context_line":"                self.fail(\"OSError exception not raised\")"},{"line_number":170,"context_line":"            except netlink_exceptions.NetlinkError as e:"},{"line_number":171,"context_line":"                self.assertEqual(errno.ENOENT, e.code)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f4378136_7c5ff70d","line":169,"range":{"start_line":169,"start_character":27,"end_line":169,"end_character":34},"updated":"2023-08-13 18:48:27.000000000","message":"This should be NetlinkError as well, copy/paste issue","commit_id":"a23dbf304ebad580e282152f3f9d42ab2ab8550b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"412ac7aa87c47302176d7ccb03461af7c2703293","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            try:"},{"line_number":167,"context_line":"                priv_lib._run_iproute_neigh("},{"line_number":168,"context_line":"                    \"test_cmd\", \"eth0\", None, test_param\u003d\"test_value\")"},{"line_number":169,"context_line":"                self.fail(\"OSError exception not raised\")"},{"line_number":170,"context_line":"            except netlink_exceptions.NetlinkError as e:"},{"line_number":171,"context_line":"                self.assertEqual(errno.ENOENT, e.code)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6e3b85f8_a3169c38","line":169,"range":{"start_line":169,"start_character":27,"end_line":169,"end_character":34},"in_reply_to":"f4378136_7c5ff70d","updated":"2023-08-13 23:04:17.000000000","message":"Done","commit_id":"a23dbf304ebad580e282152f3f9d42ab2ab8550b"}]}