)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"256e4d4bb80f0862e538ce93484d5e3b6c02cf67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a8c444cc_bda14055","updated":"2023-10-20 20:16:41.000000000","message":"recheck due to stale test results","commit_id":"28059598d2230c588b99074bfd7f914c86c35b5a"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"256e4d4bb80f0862e538ce93484d5e3b6c02cf67","unresolved":true,"context_lines":[{"line_number":1055,"context_line":"                db_network \u003d db_networks[lswitch[\u0027name\u0027]]"},{"line_number":1056,"context_line":"                db_segments \u003d self.segments_plugin.get_segments("},{"line_number":1057,"context_line":"                    ctx, filters\u003d{\u0027network_id\u0027: [db_network[\u0027id\u0027]],"},{"line_number":1058,"context_line":"                                  \u0027is_dynamic\u0027: False})"},{"line_number":1059,"context_line":"                segments_provnet_port_names \u003d []"},{"line_number":1060,"context_line":"                for db_segment in db_segments:"},{"line_number":1061,"context_line":"                    physnet \u003d db_segment.get(segment_def.PHYSICAL_NETWORK)"}],"source_content_type":"text/x-python","patch_set":1,"id":"365789b7_730a64fe","line":1058,"updated":"2023-10-20 20:16:41.000000000","message":"Does seem correct after looking through the code a bit. I\u0027ll add Rodolfo for his opinion as well.","commit_id":"28059598d2230c588b99074bfd7f914c86c35b5a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"079414dbb56bc8a45399008bafbcd959b9a774e6","unresolved":true,"context_lines":[{"line_number":1055,"context_line":"                db_network \u003d db_networks[lswitch[\u0027name\u0027]]"},{"line_number":1056,"context_line":"                db_segments \u003d self.segments_plugin.get_segments("},{"line_number":1057,"context_line":"                    ctx, filters\u003d{\u0027network_id\u0027: [db_network[\u0027id\u0027]],"},{"line_number":1058,"context_line":"                                  \u0027is_dynamic\u0027: False})"},{"line_number":1059,"context_line":"                segments_provnet_port_names \u003d []"},{"line_number":1060,"context_line":"                for db_segment in db_segments:"},{"line_number":1061,"context_line":"                    physnet \u003d db_segment.get(segment_def.PHYSICAL_NETWORK)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc58ce16_42ab5640","line":1058,"in_reply_to":"365789b7_730a64fe","updated":"2023-10-31 21:04:26.000000000","message":"This is technically correct. +1.\n\nBTW I tried to understand what the \"dynamic\" segments even are, and it seems to be some remnant from ~2013 when Bob Kukura worked on hierarchical port binding. I don\u0027t see allocate_dynamic_segment used anywhere for years. I suspect it\u0027s a dead weight and could be cleaned up with no risk (though it\u0027s part of ML2 driver API - e.g. defined in neutron-lib, so technically it\u0027s breaking change.)\n\nAnyone aware is \"dynamic segment allocation\" a thing?","commit_id":"28059598d2230c588b99074bfd7f914c86c35b5a"}]}