)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"9875ac6d2f29c3ea7a456c4c68ff9531a6736bb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"59d8d0e5_94f4120a","updated":"2023-10-30 09:54:45.000000000","message":"Sorry to nudge this but is there anything else I can do from my side to try to get some reviews on this? Would love to get some feedback on this change if possible.","commit_id":"002c50e5b00737359d1a8156cd54866a4c360100"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"b3407d9c4b2e1314b62742440e78a49dc16060ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5362ca94_c6bcdec8","updated":"2023-08-23 13:26:45.000000000","message":"The _routers_to_sync function usually makes up most of the processing time when agents make the sync_routers call.\n\nIf we only call it once, it seems to roughly halve the response time from the perspective of the L3 agent.","commit_id":"002c50e5b00737359d1a8156cd54866a4c360100"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"14db22b2f1f43aa056836627de11a8421a2515d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d56457d5_5d6d3b79","updated":"2023-09-01 16:06:20.000000000","message":"lgtm! Just wondering, shouldn\u0027t we have a launchpad attached to this commit?","commit_id":"002c50e5b00737359d1a8156cd54866a4c360100"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"20cbf2128c50da374053826749ed32c7ee5f744e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"555f90a3_aca1d693","in_reply_to":"59d8d0e5_94f4120a","updated":"2023-10-30 09:59:39.000000000","message":"Feel free to ask for reviews from core reviewers on IRC. You can do it at any time, we also have a weekly meeting: https://meetings.opendev.org/#Neutron_Team_Meeting","commit_id":"002c50e5b00737359d1a8156cd54866a4c360100"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"20cbf2128c50da374053826749ed32c7ee5f744e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ea960e1_249b1e27","in_reply_to":"d46d8901_ec530c75","updated":"2023-10-30 09:59:39.000000000","message":"Yes, I meant that. If it\u0027s a trivial fix I guess there is no need.","commit_id":"002c50e5b00737359d1a8156cd54866a4c360100"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"ead1ee75d48cb4d667893301b51e990a36df8ee8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d46d8901_ec530c75","in_reply_to":"d56457d5_5d6d3b79","updated":"2023-09-18 12:19:34.000000000","message":"Sorry for the slow reply here. It looks like I missed this!\n\nJust checking but when you say Launchpad, I guess you mean a bug report right?\n\nIf so, then I didn\u0027t bother in this case as I didn\u0027t think this was backport worthy and the current code seems to work okay.\n\nI can create one if needed though.","commit_id":"002c50e5b00737359d1a8156cd54866a4c360100"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"53122e6ea3112f561d41d3ca14fe484331880065","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0a7544b_fd3f5835","updated":"2024-03-28 22:14:42.000000000","message":"Can you add a test for this please?","commit_id":"4b1b22463cc32c2630aa0d2d7ea3c8313816027f"}],"neutron/api/rpc/handlers/l3_rpc.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a374d910f4a32d889422753a9fc7575f28ed2700","unresolved":true,"context_lines":[{"line_number":210,"context_line":"                        context,"},{"line_number":211,"context_line":"                        port[\u0027id\u0027],"},{"line_number":212,"context_line":"                        {\u0027port\u0027: {portbindings.HOST_ID: host}})"},{"line_number":213,"context_line":"                    # updating port\u0027s host to pass actual info to l3 agent"},{"line_number":214,"context_line":"                except exceptions.PortNotFound:"},{"line_number":215,"context_line":"                    LOG.debug(\"Port %(port)s not found while updating \""},{"line_number":216,"context_line":"                              \"agent binding for router %(router)s.\","}],"source_content_type":"text/x-python","patch_set":1,"id":"28d0ac9b_753b8fea","line":213,"updated":"2023-12-01 17:38:30.000000000","message":"Comment no longer applies","commit_id":"002c50e5b00737359d1a8156cd54866a4c360100"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"a8ec03a590e50bdedb836eb5ef5824279034d3e6","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                        context,"},{"line_number":211,"context_line":"                        port[\u0027id\u0027],"},{"line_number":212,"context_line":"                        {\u0027port\u0027: {portbindings.HOST_ID: host}})"},{"line_number":213,"context_line":"                    # updating port\u0027s host to pass actual info to l3 agent"},{"line_number":214,"context_line":"                except exceptions.PortNotFound:"},{"line_number":215,"context_line":"                    LOG.debug(\"Port %(port)s not found while updating \""},{"line_number":216,"context_line":"                              \"agent binding for router %(router)s.\","}],"source_content_type":"text/x-python","patch_set":1,"id":"2bef41d1_ed58cea9","line":213,"in_reply_to":"28d0ac9b_753b8fea","updated":"2024-01-03 11:56:31.000000000","message":"Done","commit_id":"002c50e5b00737359d1a8156cd54866a4c360100"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a374d910f4a32d889422753a9fc7575f28ed2700","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                portbindings.VIF_DETAILS,"},{"line_number":264,"context_line":"                portbindings.HOST_ID,"},{"line_number":265,"context_line":"                portbindings.PROFILE,"},{"line_number":266,"context_line":"                portbindings_extended.STATUS,"},{"line_number":267,"context_line":"            ]:"},{"line_number":268,"context_line":"                port[attr] \u003d updated_port[attr]"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2bfcf30e_077db4ad","line":266,"updated":"2023-12-01 17:38:30.000000000","message":"So I only see the above code updating HOST_ID, why do we need to update all these other fields? I must be missing something.","commit_id":"002c50e5b00737359d1a8156cd54866a4c360100"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"a8ec03a590e50bdedb836eb5ef5824279034d3e6","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                portbindings.VIF_DETAILS,"},{"line_number":264,"context_line":"                portbindings.HOST_ID,"},{"line_number":265,"context_line":"                portbindings.PROFILE,"},{"line_number":266,"context_line":"                portbindings_extended.STATUS,"},{"line_number":267,"context_line":"            ]:"},{"line_number":268,"context_line":"                port[attr] \u003d updated_port[attr]"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"359d178a_2087d4cc","line":266,"in_reply_to":"2bfcf30e_077db4ad","updated":"2024-01-03 11:56:31.000000000","message":"As far as I can tell, the code above updating HOST_ID doesn\u0027t seem very useful because the resulting data isn\u0027t actually used. This is because the second call to _routers_to_sync() returns completely new router information to pick up any changes that are made here. \n\nWhen that happens, all the port binding info is recreated from scratch and so some of these other fields may also change. As we want to stop making that second _routers_to_sync() call (because it\u0027s really expensive), we need to update various other portbinding fields as a part of this code.","commit_id":"002c50e5b00737359d1a8156cd54866a4c360100"}]}