)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"491609dd371847c99390a8153f75186321fe8e80","unresolved":true,"context_lines":[{"line_number":12,"context_line":"centralized and distributed traffic."},{"line_number":13,"context_line":"FIP port forwarding in ovn backend are implemented as OVN Load balancers"},{"line_number":14,"context_line":"thus are always centralized but if \"enable_distributed_floating_ip\" is"},{"line_number":15,"context_line":"set to True, FIPs are distributed. And in such case it won\u0027t works as"},{"line_number":16,"context_line":"expected as either it tries to send FIP PF\u0027s traffic as distributed when"},{"line_number":17,"context_line":"\"reside-on-redirect-chassis\" for LRP is set to \"false\" or"},{"line_number":18,"context_line":"tries to centralized everything (even FIP which should be distributed)"},{"line_number":19,"context_line":"when \"reside-on-redirect-chassis\" is ste to \"true\"."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f7172f5e_c1d1ddd1","line":17,"range":{"start_line":15,"start_character":35,"end_line":17,"end_character":54},"updated":"2023-08-23 16:08:49.000000000","message":"are you sure this is not a side effect of \"redirect-type\u003dbridge\"on the gateway port instead? the reside-on-redirect-chassis was removed long ago and that would mean PF are broken for quite some time","commit_id":"f2ed316c8547aeec245aba4986a36393ce46e541"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"491609dd371847c99390a8153f75186321fe8e80","unresolved":true,"context_lines":[{"line_number":21,"context_line":"To avoid that issue and to avoid switching FIPs from being"},{"line_number":22,"context_line":"centralized/distributed when PF is created/deleted this patch adds some"},{"line_number":23,"context_line":"kind of workaround and, in case when port_forwarding service plugin is"},{"line_number":24,"context_line":"enabled and vlan or flat networks are configured as tenant network type,"},{"line_number":25,"context_line":"all FIPs will be centralized."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #2028846"},{"line_number":28,"context_line":"Change-Id: I398f3f676c59dc794cf03320fa45efc7b22fc003"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b5943cb0_b4c31212","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":29},"updated":"2023-08-23 16:08:49.000000000","message":"is there an option of only centralizing the traffic for FIPs when the associated port is on a vlan/flat network, as the geneve ones are supposed to work fine, right?","commit_id":"f2ed316c8547aeec245aba4986a36393ce46e541"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"930d7b7abb841a5ef6435cda0d643d4c544c94e5","unresolved":true,"context_lines":[{"line_number":16,"context_line":"expected as either it tries to send FIP PF\u0027s traffic as distributed when"},{"line_number":17,"context_line":"\"reside-on-redirect-chassis\" for LRP is set to \"false\" or"},{"line_number":18,"context_line":"tries to centralized everything (even FIP which should be distributed)"},{"line_number":19,"context_line":"when \"reside-on-redirect-chassis\" is ste to \"true\"."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To avoid that issue and to avoid switching FIPs from being"},{"line_number":22,"context_line":"centralized/distributed when PF is created/deleted this patch adds"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"29392ea8_c10d0634","line":19,"range":{"start_line":19,"start_character":37,"end_line":19,"end_character":40},"updated":"2023-12-13 08:54:27.000000000","message":"nit: set","commit_id":"fd1e4b95cbcade5298fea54a3d72592506895e87"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6eafbb13a9c08c8c065615832fd131fe1b045ae0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d1321e7f_7eb943b0","updated":"2023-09-12 13:13:09.000000000","message":"-W until we have 2024.1 master branch open","commit_id":"e1656d013666caa1300044c5e2ca5668421e1a7a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3cb12d5a7d241306cd09e8ccc06e59334ee16af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1899e0dc_8f26a575","updated":"2023-09-12 13:10:12.000000000","message":"Some nits, code looks ok","commit_id":"e1656d013666caa1300044c5e2ca5668421e1a7a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8014082edc68ea203c4e3757f11a0745dc43b8ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f03a633b_c09af785","updated":"2023-09-12 15:56:11.000000000","message":"-W until 2024.1 master branch is open.","commit_id":"29dfe5a66f99f3685cc4ff5b1a7301b437454548"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"87fe5bfe25ffd761fda5cd4b3303970f3157cfd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0dac83a_70f2a2a5","updated":"2023-09-19 12:15:03.000000000","message":"As 2023.2 branch is already cut we can push this forward","commit_id":"29dfe5a66f99f3685cc4ff5b1a7301b437454548"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3cdb9797a1d2573cfaf2ffd7ce1d6ad3dfd625e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e13f53ec_fd738cb8","updated":"2023-12-11 12:35:11.000000000","message":"@slawek: should we backport this patch?","commit_id":"d67b571a5faa667cb36dd844060a760e81dfcd81"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f0eb8479680167c4192c66f4cc48a676c034268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"78a1169a_166aef87","updated":"2023-12-04 09:45:56.000000000","message":"recheck - unrelated SG issue","commit_id":"d67b571a5faa667cb36dd844060a760e81dfcd81"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"04937a51a31a0f2e342e6c5e173c702bc059dcc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cc4fd927_585f736d","updated":"2023-12-01 15:16:50.000000000","message":"recheck - unrelated customize_image error in devstack","commit_id":"d67b571a5faa667cb36dd844060a760e81dfcd81"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ed26ad5026ea10ccd811692d7fe288e9aa30ec80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5419d71a_dac08162","in_reply_to":"e13f53ec_fd738cb8","updated":"2023-12-11 13:21:49.000000000","message":"I don\u0027t think so. This changed behaviour of Neutron so it may e.g. break updates","commit_id":"d67b571a5faa667cb36dd844060a760e81dfcd81"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"29e715bc60cff13a3cc3adfa6e9dfde60e25c82e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"80e0e28d_87b7193f","updated":"2024-02-01 12:38:11.000000000","message":"Please fix the nits from ralonsoh and haleyb.\nOtherwise looks ok","commit_id":"91a0df1e8fb9468ad2e3a990f00e05f692c8b217"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1a3e432ccfa1e6a04e59a61aaaf5ec2a98e7f36c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"897b8eed_2c4e5997","updated":"2024-02-06 14:47:19.000000000","message":"I just updated grammar in release note, otherwise looked good","commit_id":"ce53fb55ade372431af634638ff90d41ffa88ea3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"193c249c94289f77e7088eb007f167fd5d221385","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1230fe42_d6bc434d","updated":"2024-02-09 12:16:38.000000000","message":"recheck\nfullstack failure is not related","commit_id":"ce53fb55ade372431af634638ff90d41ffa88ea3"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9be5a3efd6d63d6d4a3e716e8f177590181e9af0","unresolved":true,"context_lines":[{"line_number":832,"context_line":"        # TODO(mjozefcz): Remove this workaround when OVN LB"},{"line_number":833,"context_line":"        # will support both decentralized FIPs on LB and member."},{"line_number":834,"context_line":"        lb_member_fip \u003d self._is_lb_member_fip(admin_context, floatingip)"},{"line_number":835,"context_line":"        if (utils.distributed_floating_ip_enabled() and"},{"line_number":836,"context_line":"                lb_member_fip):"},{"line_number":837,"context_line":"            LOG.warning(\"Port %s is configured as a member \""},{"line_number":838,"context_line":"                        \"of one of OVN Load_Balancers and \""}],"source_content_type":"text/x-python","patch_set":1,"id":"af968f08_7dc6363f","line":835,"range":{"start_line":835,"start_character":7,"end_line":835,"end_character":55},"updated":"2023-08-23 16:10:42.000000000","message":"I think this is wrong, as in this case we need to centralize the traffic even if there is no vlan/flat tenant networks involved","commit_id":"f2ed316c8547aeec245aba4986a36393ce46e541"}],"neutron/services/portforwarding/drivers/ovn/driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3cb12d5a7d241306cd09e8ccc06e59334ee16af","unresolved":true,"context_lines":[{"line_number":209,"context_line":"            ovn_utils.validate_port_forwarding_configuration()"},{"line_number":210,"context_line":"        except ovn_exc.InvalidPortForwardingConfiguration as err:"},{"line_number":211,"context_line":"            LOG.critical(err)"},{"line_number":212,"context_line":"            sys.exit(1)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @property"},{"line_number":215,"context_line":"    def _pf_plugin(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ac79850b_46e99ec8","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":23},"updated":"2023-09-12 13:10:12.000000000","message":"We usually use:\n```\n    raise SystemExit(str(err))\n```","commit_id":"e1656d013666caa1300044c5e2ca5668421e1a7a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52d3b84bae5ade863befc3bd9a2757ea7862a21b","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            ovn_utils.validate_port_forwarding_configuration()"},{"line_number":210,"context_line":"        except ovn_exc.InvalidPortForwardingConfiguration as err:"},{"line_number":211,"context_line":"            LOG.critical(err)"},{"line_number":212,"context_line":"            sys.exit(1)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @property"},{"line_number":215,"context_line":"    def _pf_plugin(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"961640e0_cffb010e","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":23},"in_reply_to":"ac79850b_46e99ec8","updated":"2023-09-12 13:50:02.000000000","message":"Done","commit_id":"e1656d013666caa1300044c5e2ca5668421e1a7a"}],"releasenotes/notes/OVN-L3-with-FIP-PF-require-centralized-FIPs-65864dfeb3edc9b1.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3cb12d5a7d241306cd09e8ccc06e59334ee16af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When OVN with its L3 service plugin (``ovn-router``) is enabled and when"},{"line_number":5,"context_line":"    ``port_forwarding`` service plugin is enabled, ``vlan`` or ``flat`` network"},{"line_number":6,"context_line":"    types are configured as ``tenant_network_types`` in the ML2 config and"},{"line_number":7,"context_line":"    floating IP traffic is set to be distributed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0f498e80_00ea7565","line":4,"updated":"2023-09-12 13:10:12.000000000","message":"nit: I would rewrite this as a list to make it more readable. Something like\n```\nWhen the following configuration is enabled at the same time:\n* OVN L3 service plugin (``ovn-router``)\n* Port forwarding service plugin (``port_forwarding``)\n* \"vlan\" or \"flat\" network types configured in the ML2 configuration variable ``tenant_network_types``\n* The OVN floating IP traffic is distributed (``enable_distributed_floating_ip`` \u003d ``True``)\nthe Neutron server will fail to start because this is an invalid configuration matrix. Floating IPs needs to be centralized in such case always.\nFor more details see `bug report \u003chttps://bugs.launchpad.net/neutron/+bug/2028846\u003e`\n```","commit_id":"e1656d013666caa1300044c5e2ca5668421e1a7a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52d3b84bae5ade863befc3bd9a2757ea7862a21b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When OVN with its L3 service plugin (``ovn-router``) is enabled and when"},{"line_number":5,"context_line":"    ``port_forwarding`` service plugin is enabled, ``vlan`` or ``flat`` network"},{"line_number":6,"context_line":"    types are configured as ``tenant_network_types`` in the ML2 config and"},{"line_number":7,"context_line":"    floating IP traffic is set to be distributed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a671af53_c6a522df","line":4,"in_reply_to":"0f498e80_00ea7565","updated":"2023-09-12 13:50:02.000000000","message":"Done","commit_id":"e1656d013666caa1300044c5e2ca5668421e1a7a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52d3b84bae5ade863befc3bd9a2757ea7862a21b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When OVN with its L3 service plugin (``ovn-router``) is enabled and when"},{"line_number":5,"context_line":"    ``port_forwarding`` service plugin is enabled, ``vlan`` or ``flat`` network"},{"line_number":6,"context_line":"    types are configured as ``tenant_network_types`` in the ML2 config and"},{"line_number":7,"context_line":"    floating IP traffic is set to be distributed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cf010cbc_89d07db8","line":4,"in_reply_to":"0f498e80_00ea7565","updated":"2023-09-12 13:50:02.000000000","message":"Done","commit_id":"e1656d013666caa1300044c5e2ca5668421e1a7a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4e78dc0cbdd8196b60c720e8489c5d2982629f9a","unresolved":true,"context_lines":[{"line_number":11,"context_line":"      (``enable_distributed_floating_ip`` \u003d ``True``)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    the Neutron server will fail to start because this is an invalid"},{"line_number":14,"context_line":"    configuration matrix. Floating IPs needs to be centralized in such case"},{"line_number":15,"context_line":"    always."},{"line_number":16,"context_line":"    For more details see `bug report"},{"line_number":17,"context_line":"    \u003chttps://bugs.launchpad.net/neutron/+bug/2028846\u003e`."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b0eb87fb_d9506090","line":15,"range":{"start_line":14,"start_character":26,"end_line":15,"end_character":11},"updated":"2023-12-16 23:40:53.000000000","message":"s/Floating IPs need to always be centralized in such a case.\n\nIt was good enough, but since I had the other comment below figured I\u0027d mention it.","commit_id":"fd1e4b95cbcade5298fea54a3d72592506895e87"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4e78dc0cbdd8196b60c720e8489c5d2982629f9a","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    configuration matrix. Floating IPs needs to be centralized in such case"},{"line_number":15,"context_line":"    always."},{"line_number":16,"context_line":"    For more details see `bug report"},{"line_number":17,"context_line":"    \u003chttps://bugs.launchpad.net/neutron/+bug/2028846\u003e`."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"041ba186_79f9fddf","line":17,"range":{"start_line":17,"start_character":54,"end_line":17,"end_character":55},"updated":"2023-12-16 23:40:53.000000000","message":"s/_.\n\nThe rendered note from the job is not creating a hyperlink because of the missing _ I believe.","commit_id":"fd1e4b95cbcade5298fea54a3d72592506895e87"}]}